[issue9628] runtests.sh -x doesn't work with more than two args (sed error)
R. David Murray rdmur...@bitdance.com added the comment: Fixed in py3k r85078, 3.1 r85079. Note that the only fix required was to the 'PAT' line, the other sed expressions are operating only on single filenames-per-line and so don't need the 'g' added. I don't see runtests.sh in 2.7 (or 2.6), yet the history goes back quite a few years... -- nosy: +r.david.murray resolution: - fixed stage: patch review - committed/rejected status: open - closed type: - behavior versions: -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9628 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9628] runtests.sh -x doesn't work with more than two args (sed error)
Sandro Tosi sandro.t...@gmail.com added the comment: Hello, the patch applies cleanly against up-to-date py3k branch: is there anything else to do before committing it? Regards, Sandro -- nosy: +sandro.tosi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9628 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9628] runtests.sh -x doesn't work with more than two args (sed error)
New submission from Dave Malcolm dmalc...@redhat.com: runtests.sh -x fails to work with more than two tests; for example, running: $ ./runtests.sh -x test_httplib test_http_cookies test_dl erroneously runs test_dl By default, sed -e s only substitutes the first match - the invocations within runtests.sh need to add the trailing g flag to substitute all matches. From info sed: The `s' command can be followed by zero or more of the following FLAGS: `g' Apply the replacement to _all_ matches to the REGEXP, not just the first. Am attaching a patch. (Seen with sed-4.2.1 on Fedora 13) -- components: Tests files: fix-sed-invocations-in-runtests.sh.patch keywords: easy, needs review, patch, patch messages: 114134 nosy: dmalcolm priority: normal severity: normal stage: patch review status: open title: runtests.sh -x doesn't work with more than two args (sed error) versions: Python 3.1, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file18554/fix-sed-invocations-in-runtests.sh.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9628 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9628] runtests.sh -x doesn't work with more than two args (sed error)
Dave Malcolm dmalc...@redhat.com added the comment: FWIW it works with two args, but adding the third fails; echoing PAT indicates the generated regex is missing the | separator: ^(test_httplib|test_http_cookies test_dl)$ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9628 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
