[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[SpaceOne]

Changes by SpaceOne pyt...@florianbest.de:


--
nosy: +spaceone

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Demian Brecht]

Changes by Demian Brecht demianbre...@gmail.com:


--
nosy: +demian.brecht

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Demian Brecht]

Changes by Demian Brecht demianbre...@gmail.com:


--
nosy:  -demian.brecht

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Erick Jones]

Erick Jones added the comment:

This ended up biting me also.  I had a list of URLs to fetch with 
authentication.  One of the URLs was bad (returning 401 even with 
authentication), and that was causing all of the subsequent URLs to fail as 
well since the reset count wasn't getting reset.

I also don't like that the retry count is stored in the handler -- that's 
mutable global state, which wreaks havoc if I use this with Eventlet coroutines 
for concurrent page fetches.  (If I just add the authentication headers myself, 
then urllib2 works just fine under Eventlet.)

Couldn't the retry count be stored in the request object itself?

And why do we even need a retry count?  If it fails without authentication, 
then try it with authentication.  If it fails again, just return to the 
application.  It makes no sense to retry four more times.

--
nosy: +Erick.Jones

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Mark Lawrence]

Mark Lawrence added the comment:

Could we have a response to this please as a way to reproduce the problem is 
given in the attached patch and a suggested solution is inline.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Luci Stanescu]

New submission from Luci Stanescu luci.stane...@gmail.com:

Hi,

The HTTPDigestAuthHandler's code looks like this:

def http_error_401(self, req, fp, code, msg, headers):
host = urlparse(req.full_url)[1]
retry = self.http_error_auth_reqed('www-authenticate',
   host, req, headers)
self.reset_retry_count()
return retry

After successful authentication, the HTTP server might still return an error 
code, such as 404 or 304. In that case, self.http_error_auth_reqed raises the 
appropriate HTTPError and self.reset_retry_count is not called. I think that 
the code should be something along the lines of:

try:
  retry = self.http_error_auth_reqed('www-authenticate', host, req, headers)
except HTTPError, e:
  if e.code != 401:
self.reset_retry_counter()
  raise
else:
  self.reset_retry_counter()
  return retry

Ways to reproduce the problem: try to access a resource for which an HTTP 
server requires authentication but for which after successful authentication 
returns a negative reply. I've attached an example script to demonstrate it 
(for python 2.X; bug also resent in 3.X, just replace import urllib2 with from 
urllib import request as urllib2 ;-) ).

The same problem applies to ProxyDigestAuthHandler.

--
components: Library (Lib)
files: test_urllib2.py
messages: 115054
nosy: Luci.Stanescu
priority: normal
severity: normal
status: open
title: When reusing an handler, urllib(2)'s digest authentication fails after 
multiple regative replies
type: behavior
versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file18656/test_urllib2.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[R. David Murray]

Changes by R. David Murray rdmur...@bitdance.com:


--
nosy: +orsenthil
versions:  -Python 2.5, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9698] When reusing an handler, urllib(2)'s digest authentication fails after multiple regative replies

[Mads Kiilerich]

Changes by Mads Kiilerich m...@kiilerich.com:


--
nosy: +kiilerix

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9698
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com