[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[s-ball]

Change by s-ball :


--
pull_requests: +10113
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[A.M. Kuchling]

A.M. Kuchling added the comment:

Éric: do you still want to apply this patch?

(I don't think any of the 'global MESSAGES' statements in msgfmt.py are 
necessary; none of those functions is doing 'MESSAGES = ', just 
calling methods or setting keys in the dictionary.)

--
nosy: +akuchling

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Ezio Melotti]

Ezio Melotti added the comment:

FWIW now we have Lib/test/test_tools.py.

--
nosy: +ezio.melotti
versions: +Python 3.4 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Éric Araujo]

Éric Araujo  added the comment:

Thanks!  In my latest message, I had forgotten that msgfmt was in Tools, not in 
the standard library, and as such has no automated regression tests.  Features 
get added and bugs get fixed after manual testing only, so I will commit your 
patch (modulo the unneeded global statement) without tests (but after manual 
testing) unless someone objects.

--
assignee:  -> eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Timothy Lee]

Changes by Timothy Lee :


Added file: http://bugs.python.org/file22370/test2.po

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Timothy Lee]

Changes by Timothy Lee :


Added file: http://bugs.python.org/file22369/test1.po

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Timothy Lee]

Changes by Timothy Lee :


Added file: http://bugs.python.org/file22368/test_msgfmt.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Éric Araujo]

Éric Araujo  added the comment:

Thanks for the report and patch.  Can you write a test?

--
nosy: +eric.araujo
stage: patch review -> test needed
versions: +Python 3.3 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[R. David Murray]

Changes by R. David Murray :


--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Brian Curtin]

Changes by Brian Curtin :


--
keywords: +needs review
stage:  -> patch review
versions:  -Python 2.5, Python 2.6, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9741] msgfmt.py generates invalid mo because msgfmt.make() does not clear dictionary

[Timothy Lee]

New submission from Timothy Lee :

This bug can potentially lead to generation of invalid mo files when 
msgfmt.make() is invoked more than once.

The bug has always been present in the source code.  The included patch should 
be applied to all maintained branches.

--
components: Demos and Tools
files: msgfmt-clear.diff
keywords: patch
messages: 115378
nosy: timothy.ty.lee
priority: normal
severity: normal
status: open
title: msgfmt.py generates invalid mo because msgfmt.make() does not clear 
dictionary
type: behavior
versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file18710/msgfmt-clear.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com