[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

New submission from Marko Kohtala :

Sqlite3 fails to dump a database with column names that are keywords.

--
components: Extension Modules
files: sqlite3bug.py
messages: 115420
nosy: Marko.Kohtala
priority: normal
severity: normal
status: open
title: sqlite3 iterdump fails on column with reserved name
type: behavior
versions: Python 2.7, Python 3.1
Added file: http://bugs.python.org/file18720/sqlite3bug.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Marko Kohtala  added the comment:

Here is a patch that may resolve the bug.

--
keywords: +patch
Added file: http://bugs.python.org/file18721/sqlite3bug.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Ned Deily]

Changes by Ned Deily :


--
nosy: +ghaering
versions: +Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Gerhard Häring]

Changes by Gerhard Häring :


--
assignee:  -> ghaering

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Marko Kohtala  added the comment:

The second patch contains also fixes for some places where the rules described 
in http://www.sqlite.org/lang_keywords.html are not followed.

--
Added file: http://bugs.python.org/file18722/sqlite3ident.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Marko Kohtala  added the comment:

It also fails if table or column names contain double quote.

--
Added file: http://bugs.python.org/file18725/sqlite3bug2.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Added file: http://bugs.python.org/file18726/sqlite3dump.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Éric Araujo]

Éric Araujo  added the comment:

Thank you for the report and patch.  Some bug tracker tips:

1) It’s possible to replace a file, so that there is always one bug.py and one 
diff, which is easier for reviewers to understand than a long list of files 
(possibly all with the same name).  It’s also possible to remove obsolete files 
so that nobody loses time commenting on them.

2) Can you turn your bug reproducer into a patch for Lib/test/test_sqlite.py?

3) Please follow guidelines on http://www.python.org/dev/patches/ to make 
patches.

Regarding the code itself:

a) I don’t understand why you added quotes around names that seemed fine 
without them (for example in “SELECT name”).

b) I find the master line difficult to read: “q += ",".join(["'||quote(\"" + 
col.replace('"', '""') + "\")||'" for col in column_names])”.  You’re using 
backslashes since there are both single and double quotes, but I would use 
triple-quoted strings here.  I also find string formatting more readable than 
string concatenation: 'blah blah "{}" blah'.format(thing.replace('"', '""')).

c) Minor style thing: A generator expression works as fine as a list 
comprehension in str.join (that is, ",".join(i for i in source) == ";".join([i 
for i in source])).

Thanks again!

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Removed file: http://bugs.python.org/file18721/sqlite3bug.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Removed file: http://bugs.python.org/file18722/sqlite3ident.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Marko Kohtala  added the comment:

Thank you for the review.

I have very limited time to use on this. So even when I'd like to make 
everything easy for you, have the time you give to python be as productive as 
possible, I can not.

But I'll respond to your comments on the patch.

a) I added the quotes to every identifier based on a comment in sqlite 
documentation "SQLite adds new keywords from time to time when it takes on new 
features. So to prevent your code from being broken by future enhancements, you 
should normally quote any identifier that is an English language word, even if 
you do not have to." While fixing one place, I fixed it to follow this 
recommendation in other places as well.

b) I added quotes using backslashes because it was consistent. The table name 
was already quoted like that. I agree it could be clearer.

c) I know. I only tried to make minimal changes targeted only to the issues at 
hand. I did not want to hide the fixes in middlde of changes to style.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Éric Araujo]

Éric Araujo  added the comment:

> I have very limited time to use on this.
This is a perfectly reasonable stance, and we’re grateful for the work you’re 
doing.  When you say that you don’t have time, someone else will take up the 
patch and update it to address reviews, and you will get credited.

a) Thanks for the explanation.  This would be a useful comment in the source.

b) It’s not uncommon to make cosmetic changes in the same commit as a bugfix.  
Readability is valued.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Petri Lehtinen]

Changes by Petri Lehtinen :


--
nosy: +petri.lehtinen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Marko Kohtala  added the comment:

Here is finally an update to my patch modified according to comments received. 
It should apply on 2.7 and 3.3 branches.

--
Added file: http://bugs.python.org/file24429/sqlite3dump.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Removed file: http://bugs.python.org/file18726/sqlite3dump.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Removed file: http://bugs.python.org/file18725/sqlite3bug2.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Marko Kohtala]

Changes by Marko Kohtala :


Removed file: http://bugs.python.org/file18720/sqlite3bug.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Petri Lehtinen]

Petri Lehtinen  added the comment:

Marko's last patch looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Éric Araujo]

Éric Araujo  added the comment:

Petri, I think you can go ahead.

Lucas, thanks for your help, even though your patch is not used.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Roundup Robot]

Roundup Robot  added the comment:

New changeset 60aa7dacb605 by Petri Lehtinen in branch '2.7':
Fix sqlite3.Connection.iterdump on tables/fields with reserved names or quotes
http://hg.python.org/cpython/rev/60aa7dacb605

New changeset 4b105d328fe7 by Petri Lehtinen in branch '3.2':
Fix sqlite3.Connection.iterdump on tables/fields with reserved names or quotes
http://hg.python.org/cpython/rev/4b105d328fe7

New changeset 5d0f7b275fe9 by Petri Lehtinen in branch 'default':
Merge branch '3.2'
http://hg.python.org/cpython/rev/5d0f7b275fe9

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[R. David Murray]

R. David Murray  added the comment:

Note that the use of 'format' in the 2.7 patch caused a regression (% causes an 
implicit promotion to unicode, .format does not).  See issue 15109.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Lucas Sinclair]

Lucas Sinclair  added the comment:

I just encountered this issue today.

So, it's been several months, will the patch be merged into the master branch ? 
Or will this never be fixed ?

--
nosy: +xapple

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Éric Araujo]

Éric Araujo  added the comment:

Hi Lucas.  Have you read my previous message?  The patch needs to be updated.  
Would you like to do it?

--
versions: +Python 3.3 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Lucas Sinclair]

Lucas Sinclair  added the comment:

Sure, I can have a try at it and address the issues you pointed out.

The URL to the guidelines you provided gives a 404. In what form exactly would 
you like the patch to be ?

I wouldn't mind either adding to the test suite, but I'm not sure how to do 
that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Éric Araujo]

Éric Araujo  added the comment:

> Sure, I can have a try at it and address the issues you pointed out.
Nice!

> The URL to the guidelines you provided gives a 404.
They’ve moved to http://docs.python.org/devguide meanwhile.

> I wouldn't mind either adding to the test suite, but I'm not sure how to do 
> that.
Edit Lib/sqlite3/test/dump.py

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Lucas Sinclair]

Lucas Sinclair  added the comment:

My patch contains two new dump tests which originally fail, and the fixes to 
the code that makes them pass.

--
Added file: http://bugs.python.org/file23629/issue9750.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Ezio Melotti]

Changes by Ezio Melotti :


--
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[R. David Murray]

R. David Murray added the comment:

For the record, this patch also introduced another regression (issue 15545).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9750] sqlite3 iterdump fails on column with reserved name

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2cdb599172ab by R David Murray in branch '3.2':
#15545: fix sqlite3.iterdump regression on unsortable row_factory objects.
http://hg.python.org/cpython/rev/2cdb599172ab

New changeset 6a85894c428f by R David Murray in branch '3.3':
merge #15545: fix sqlite3.iterdump regression on unsortable row_factory objects.
http://hg.python.org/cpython/rev/6a85894c428f

New changeset 7a62b5ee32ec by R David Murray in branch 'default':
merge #15545: fix sqlite3.iterdump regression on unsortable row_factory objects.
http://hg.python.org/cpython/rev/7a62b5ee32ec

New changeset bb4e4f0cec2e by R David Murray in branch '2.7':
#15545: sort iterdump via SQL instead of in python code
http://hg.python.org/cpython/rev/bb4e4f0cec2e

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com