[issue9937] _winreg.EnumValue causes MemoryError

[Eryk Sun]

Eryk Sun  added the comment:

> Did anyone reproduce on python3.X? 

In principle, winreg should not have a problem in 3.x because it only uses the 
UTF-16 wide-character API.

--
nosy: +eryksun
stage:  -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Irit Katriel]

Irit Katriel  added the comment:

> I can reproduce the issue on python2.x. I cannot on python3.x.

Did anyone reproduce on python3.X? Why are versions 3.4/3.5 selected?

--
nosy: +iritkatriel
resolution:  -> out of date
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Mark Lawrence]

Mark Lawrence added the comment:

Does anyone wish to follow this up as I no longer run 2.7?

--
nosy: +BreamoreBoy
versions: +Python 3.4, Python 3.5 -Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:


Removed file: http://bugs.python.org/file18999/py27_winreg_EnumValue.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:


Removed file: 
http://bugs.python.org/file19021/py27_fix_winreg_EnumValue_op1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

I've withdrew my patch... It has still problem, and
I cannot fix it yet. I suppose option 2 is easy.
ANSI API's limitation makes it harder to implement
correctly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[STINNER Victor]

STINNER Victor victor.stin...@haypocalc.com added the comment:

Can't we use RegEnumValueW and RegQueryInfoKeyW?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

Sorry, my patch didn't pass test_dynamic_key(test_winreg).
(Apologize for not testing on unit test)

RegEnumValueA and RegQueryInfoKeyA always returned 0 for 
required data size if target is HKEY_PERFORMANCE_DATA.

The possible fixes I can imagine are...

1. Use GetCPInfo() to get MaxCharSize.
http://msdn.microsoft.com/en-us/library/dd317780%28v=VS.85%29.aspx
We can get a large value enough to store the key name in ANSI by
The length in Unicode * MaxCharSize.

2. Use RegEnumValueW and convert result via WideCharToMultiByte

I'll attach the patch with option 1.

--
Added file: http://bugs.python.org/file19021/py27_fix_winreg_EnumValue_op1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

I shall create unit test later.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Iwasa Kazmi]

Iwasa Kazmi kzmi...@gmail.com added the comment:

Added sample registory data file.

--
Added file: http://bugs.python.org/file18993/fonts.reg

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Iwasa Kazmi]

Iwasa Kazmi kzmi...@gmail.com added the comment:

Added py file to reproduce.

--
Added file: http://bugs.python.org/file18994/test.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +brian.curtin, haypo, tim.golden
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

I'm not able to reproduce any MemoryError on 2.6, 2.7, or 3.2 on Windows 7 
using your registry data and test script.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

I can reproduce the issue on python2.x. I cannot on
python3.x.

--
nosy: +ocean-city

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

This happens because RegQueryInfoKeyA returns maximum value
name length in *Unicode* characters. Strange API.

lpcMaxValueNameLen [out, optional]

A pointer to a variable that receives the size of the key's longest value 
name, in Unicode characters. The size does not include the terminating null 
character. This parameter can be NULL.

http://msdn.microsoft.com/en-us/library/ms724902%28VS.85%29.aspx

The Unicode length equals to Ansi length in ascii locale,
so this may not happen where people live in ascii locale.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp:


--
Removed message: http://bugs.python.org/msg117293

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

This happens because RegQueryInfoKeyA returns maximum value
name length not in *Ansi* characters but in *Unicode characters.
I don't know clue why.

http://msdn.microsoft.com/en-us/library/ms724902%28VS.85%29.aspx

In multibyte environment, 2 or 3 bytes characters are
mapped to one size unicode. So usually, the length of *Ansi*
characters are larger than or equals to the length of *Unicode*
characters. If every Ansi characters are mapped to one size
Unicode, lengthes are equal, so probably this issue won't happen.

I'll attach the patch to fix this issue. But be care, this is not 
tested so densely. At least, the script to reproduce this issue
ran fine.

--
keywords: +patch
Added file: http://bugs.python.org/file18999/py27_winreg_EnumValue.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9937] _winreg.EnumValue causes MemoryError

[Hirokazu Yamamoto]

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

Again, I'm not sure this is right fix.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com