[issue9950] socket.sendall() crash when receiving a signal
Changes by Ned Deily n...@acm.org: Removed file: http://bugs.python.org/file19042/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment: Patch committed in r85032. I'm gonna watch the buildbots a bit, in case the test fails on some platforms. -- assignee: - pitrou resolution: - fixed stage: - committed/rejected ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment: The patch passes at least on Linux, OS X and Solaris buildbots. Backported to 3.1 (r85034) and 2.7 (r85035). -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Gregory P. Smith g...@krypto.org added the comment: thanks Antoine! -- Added file: http://bugs.python.org/file19042/unnamed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___thanks Antoine! ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
New submission from Antoine Pitrou pit...@free.fr: This was introduced by r74426 which addressed issue1628205. socket.sendall() calls PyErr_CheckSignals() (and potentially returns to the caller) without having the GIL. import socket c, s = socket.socketpair() s.sendall(bx*(100 * 1024**2)) ^C^CFatal Python error: PyThreadState_Get: no current thread -- components: Library (Lib) messages: 117385 nosy: gregory.p.smith, pitrou priority: normal severity: normal status: open title: socket.sendall() crash when receiving a signal type: crash versions: Python 2.7, Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment:
The fix is very simple, but perhaps a test should be added.
diff -r af0d7b32d6ce Modules/socketmodule.c
--- a/Modules/socketmodule.cFri Sep 24 20:03:12 2010 +0200
+++ b/Modules/socketmodule.cSat Sep 25 21:09:58 2010 +0200
@@ -2581,8 +2581,8 @@ sock_sendall(PySocketSockObject *s, PyOb
return select_error();
}
-Py_BEGIN_ALLOW_THREADS
do {
+Py_BEGIN_ALLOW_THREADS
timeout = internal_select(s, 1);
n = -1;
if (timeout)
@@ -2592,6 +2592,7 @@ sock_sendall(PySocketSockObject *s, PyOb
#else
n = send(s-sock_fd, buf, len, flags);
#endif
+Py_END_ALLOW_THREADS
if (n 0) {
#ifdef EINTR
/* We must handle EINTR here as there is no way for
@@ -2610,7 +2611,6 @@ sock_sendall(PySocketSockObject *s, PyOb
buf += n;
len -= n;
} while (len 0);
-Py_END_ALLOW_THREADS
PyBuffer_Release(pbuf);
if (timeout == 1) {
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9950
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment: Actually, the patch is enough to suppress the crash, but sendall() behaviour is buggy in another way: EINTR may be received as part of the select() call (on sockets with a timeout), in which case the loop will be exited early instead of retrying, losing track of the number of bytes written (something which the original patch aimed to avoid). For example: def handler(*args): print (args) ... signal.signal(signal.SIGALRM, handler) 0 c, s = socket.socketpair() s.settimeout(60.0) signal.alarm(1); s.sendall(bx * (100 * 1024**2)) 0 (14, frame object at 0x2b8f220) Traceback (most recent call last): File stdin, line 1, in module socket.error: [Errno 4] Interrupted system call -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment: Oh, and an additional bug is that send() can return a successful partial write when it was actually interrupted by a signal. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9950] socket.sendall() crash when receiving a signal
Antoine Pitrou pit...@free.fr added the comment: Here is a patch fixing the aforementioned issues, and with tests. -- keywords: +patch nosy: +exarkun Added file: http://bugs.python.org/file19015/sendallinterrupt.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9950 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
