[python-committers] Discussions on PRs

2017-02-13 Thread M.-A. Lemburg 
With the move to Github, I'm seeing a move away from
discussions on the issue tracker towards discussions on
pull requests.

Example: https://github.com/python/cpython/pull/4

Is this something we should encourage or better ask the OPs
to open a ticket on the tracker first and reference the PR
there ?

Discussion on the PRs would then only be for code review
aspects.

Thanks,
-- 
Marc-Andre Lemburg
eGenix.com

Professional Python Services directly from the Experts (#1, Feb 13 2017)
>>> Python Projects, Coaching and Consulting ...  http://www.egenix.com/
>>> Python Database Interfaces ...   http://products.egenix.com/
>>> Plone/Zope Database Interfaces ...   http://zope.egenix.com/


::: We implement business ideas - efficiently in both time and costs :::

   eGenix.com Software, Skills and Services GmbH  Pastor-Loeh-Str.48
D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg
   Registered at Amtsgericht Duesseldorf: HRB 46611
   http://www.egenix.com/company/contact/
  http://www.malemburg.com/

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner 
I prefer to discuss on the review rather than on the bug tracker. In
the extreme case, if we had to choose, I had rather prefer to drop the
bug tracker. It is not going to appear since people still have to
report bugs without patch :-)

Victor

2017-02-13 10:33 GMT+01:00 M.-A. Lemburg :
> With the move to Github, I'm seeing a move away from
> discussions on the issue tracker towards discussions on
> pull requests.
>
> Example: https://github.com/python/cpython/pull/4
>
> Is this something we should encourage or better ask the OPs
> to open a ticket on the tracker first and reference the PR
> there ?
>
> Discussion on the PRs would then only be for code review
> aspects.
>
> Thanks,
> --
> Marc-Andre Lemburg
> eGenix.com
>
> Professional Python Services directly from the Experts (#1, Feb 13 2017)
 Python Projects, Coaching and Consulting ...  http://www.egenix.com/
 Python Database Interfaces ...   http://products.egenix.com/
 Plone/Zope Database Interfaces ...   http://zope.egenix.com/
> 
>
> ::: We implement business ideas - efficiently in both time and costs :::
>
>eGenix.com Software, Skills and Services GmbH  Pastor-Loeh-Str.48
> D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg
>Registered at Amtsgericht Duesseldorf: HRB 46611
>http://www.egenix.com/company/contact/
>   http://www.malemburg.com/
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah 

On Mon, Feb 13, 2017 at 10:33:58AM +0100, M.-A. Lemburg wrote:
> With the move to Github, I'm seeing a move away from
> discussions on the issue tracker towards discussions on
> pull requests.
> 
> Example: https://github.com/python/cpython/pull/4
> 
> Is this something we should encourage or better ask the OPs
> to open a ticket on the tracker first and reference the PR
> there ?
> 
> Discussion on the PRs would then only be for code review
> aspects.

I agree completely.  I find the whole workflow very distracting.  What I
see now is that patches without comments emerge really fast:

https://github.com/python/cpython/pull/65


Actually I expected this competitive atmosphere, because that's what
GitHub encourages.

Realistically, my workload tripled for this one particular issue
compared to our previous workflow.



Stefan Krah




___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Donald Stufft 

> On Feb 13, 2017, at 5:49 AM, Stefan Krah  wrote:
> 
> What I
> see now is that patches without comments emerge really fast:
> 
>https://github.com/python/cpython/pull/65 
> 


It looks like the person in question is commenting on the issue tracker.

—
Donald Stufft



___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah 


On Mon, Feb 13, 2017 at 08:48:08AM -0500, Donald Stufft wrote:
> It looks like the person in question is commenting on the issue tracker.

Is *now* commenting on the issue tracker as opposed to when I wrote the
mail.  But hey, it sounds much more impressive the way you phrased it ...


Stefan



___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Barry Warsaw 
On Feb 13, 2017, at 10:33 AM, M.-A. Lemburg wrote:

>Discussion on the PRs would then only be for code review
>aspects.

+1

On Feb 13, 2017, at 11:49 AM, Stefan Krah wrote:

>Realistically, my workload tripled for this one particular issue
>compared to our previous workflow.

Not to mention the size of my inbox. :(

Cheers,
-Barry
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Serhiy Storchaka 
понеділок, 13 лютого 2017 р. 10:33:58 EET M.-A. Lemburg написано:
> With the move to Github, I'm seeing a move away from
> discussions on the issue tracker towards discussions on
> pull requests.
> 
> Example: https://github.com/python/cpython/pull/4
> 
> Is this something we should encourage or better ask the OPs
> to open a ticket on the tracker first and reference the PR
> there ?
> 
> Discussion on the PRs would then only be for code review
> aspects.

I prefer discussions on the issue tracker. First, it is better to have all 
discussion in one place. Second, I got hundreds of email messages last day and 
discussions interesting by me just are lost in a flame. I'm going to 
unsubscribe from getting emails for all pull requests and subscribe to only 
selected ones.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner 
2017-02-13 19:30 GMT+01:00 Serhiy Storchaka :
> I'm going to
> unsubscribe from getting emails for all pull requests and subscribe to only
> selected ones.

I did exactly that, very early :-)

https://github.com/python/cpython/ : "Watch: *not watching*. Be
notified when participating or @mention".

I never tried to follow *everything* on bugs.python.org, there is too
much trafic ;-)

Victor
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Ezio Melotti 
On Mon, Feb 13, 2017 at 11:33 AM, M.-A. Lemburg  wrote:
> With the move to Github, I'm seeing a move away from
> discussions on the issue tracker towards discussions on
> pull requests.
>
> Example: https://github.com/python/cpython/pull/4
>
> Is this something we should encourage or better ask the OPs
> to open a ticket on the tracker first and reference the PR
> there ?
>

Unless it's a trivial PR (e.g. typo fix), then there should be a
discussion on bpo.  The devguide has been/is being update to be more
clear about this aspect.

> Discussion on the PRs would then only be for code review
> aspects.
>

Yes, discussions on the PRs replace the discussions we had on Rietveld
-- they should only be about the code review.

Best Regards,
Ezio Melotti

> Thanks,
> --
> Marc-Andre Lemburg
> eGenix.com
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Discussions on PRs

2017-02-14 Thread M.-A. Lemburg 
On 13.02.2017 23:49, Victor Stinner wrote:
> 2017-02-13 19:30 GMT+01:00 Serhiy Storchaka :
>> I'm going to
>> unsubscribe from getting emails for all pull requests and subscribe to only
>> selected ones.
> 
> I did exactly that, very early :-)
> 
> https://github.com/python/cpython/ : "Watch: *not watching*. Be
> notified when participating or @mention".
> 
> I never tried to follow *everything* on bugs.python.org, there is too
> much trafic ;-)

That's a great idea to focus on bpo discussions again. My Inbox was
exploding in the last few days, even with filters on.

-- 
Marc-Andre Lemburg
eGenix.com

Professional Python Services directly from the Experts (#1, Feb 14 2017)
>>> Python Projects, Coaching and Consulting ...  http://www.egenix.com/
>>> Python Database Interfaces ...   http://products.egenix.com/
>>> Plone/Zope Database Interfaces ...   http://zope.egenix.com/


::: We implement business ideas - efficiently in both time and costs :::

   eGenix.com Software, Skills and Services GmbH  Pastor-Loeh-Str.48
D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg
   Registered at Amtsgericht Duesseldorf: HRB 46611
   http://www.egenix.com/company/contact/
  http://www.malemburg.com/

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/