Re: [python-committers] Orphaned backports

[Brett Cannon]

On Mon, 14 May 2018 at 14:22 Mariatta Wijaya 
wrote:

> To help with this, miss-islington will now assign the PR where backport
> had failed to the core dev who merged the original PR.
>

Great feature!

-Brett


>
>
> Mariatta
>
> On Tue, Apr 24, 2018 at 8:57 AM, Brett Cannon  wrote:
>
>>
>>
>> On Tue, 24 Apr 2018 at 02:59 Serhiy Storchaka 
>> wrote:
>>
>>> 23.04.18 19:47, Brett Cannon пише:
>>>
>>> On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:
>>>
 Does github allow repository owners to send email directly to people
 who
 have submitted PRs or at least, people with commit privileges (in this
 case, those whose have done particular merges)?

>>>
>>> No. People have to provide explicit permission to expose their email
>>> address. Otherwise the best we have are @ mentions in a comment.
>>>
>>>
>>> Aren't all active committer subscribed to this mailing list?
>>>
>>
>> They should be. Doesn't mean they pay attention to it. ;)
>>
>> -Brett
>>
>>
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>>
> ᐧ
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Mariatta Wijaya]

To help with this, miss-islington will now assign the PR where backport had
failed to the core dev who merged the original PR.


Mariatta

On Tue, Apr 24, 2018 at 8:57 AM, Brett Cannon  wrote:

>
>
> On Tue, 24 Apr 2018 at 02:59 Serhiy Storchaka  wrote:
>
>> 23.04.18 19:47, Brett Cannon пише:
>>
>> On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:
>>
>>> Does github allow repository owners to send email directly to people who
>>> have submitted PRs or at least, people with commit privileges (in this
>>> case, those whose have done particular merges)?
>>>
>>
>> No. People have to provide explicit permission to expose their email
>> address. Otherwise the best we have are @ mentions in a comment.
>>
>>
>> Aren't all active committer subscribed to this mailing list?
>>
>
> They should be. Doesn't mean they pay attention to it. ;)
>
> -Brett
>
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
>
ᐧ
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Brett Cannon]

On Tue, 24 Apr 2018 at 02:59 Serhiy Storchaka  wrote:

> 23.04.18 19:47, Brett Cannon пише:
>
> On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:
>
>> Does github allow repository owners to send email directly to people who
>> have submitted PRs or at least, people with commit privileges (in this
>> case, those whose have done particular merges)?
>>
>
> No. People have to provide explicit permission to expose their email
> address. Otherwise the best we have are @ mentions in a comment.
>
>
> Aren't all active committer subscribed to this mailing list?
>

They should be. Doesn't mean they pay attention to it. ;)

-Brett
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Serhiy Storchaka]

23.04.18 19:47, Brett Cannon пише:
On Sun, 22 Apr 2018 at 11:27 Terry Reedy > wrote:


Does github allow repository owners to send email directly to
people who
have submitted PRs or at least, people with commit privileges (in
this
case, those whose have done particular merges)?


No. People have to provide explicit permission to expose their email 
address. Otherwise the best we have are @ mentions in a comment.


Aren't all active committer subscribed to this mailing list?

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Brett Cannon]

On Sun, 22 Apr 2018 at 11:27 Terry Reedy  wrote:

> On 4/22/2018 12:16 PM, Serhiy Storchaka wrote:
> > miss-islington is an awesome bot! It makes fixing bugs in multiple
> > versions much simpler. You need just accept automatically created
> > backporting PRs.
> >
> > But there is a downside. miss-islington makes the life so easier, that
> > sometimes you forgot about not finished backports. miss-islington can
> > fail to backport some changes for different reasons. Currently on GitHub
> > there are tens merged PRs labeled for backporting, but backports were
> > not finished. Please take attention if your PRs in one of the following
> > lists:
>
> Does github allow repository owners to send email directly to people who
> have submitted PRs or at least, people with commit privileges (in this
> case, those whose have done particular merges)?
>

No. People have to provide explicit permission to expose their email
address. Otherwise the best we have are @ mentions in a comment.

-Brett


>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed
>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed
>
> Several of these were closed without merging and should not and cannot
> be backported.  For instance, you closed
> https://github.com/python/cpython/pull/4225
> after you submitted and merged a replacement.
> https://github.com/python/cpython/pull/6259
>
> Stripping backport labels off of rejected PRs could be considered.  But
> this would toss information needed for a new PR if the bpo issue is
> open.  Expecting either the submitter or merged of a replacement to go
> back and clean up the original seems a bit much.  The submitter might
> not be able to, and the merger might not know or forget that the PR is a
> replacement.  Perhaps rejected PRs should just be ignored.
>
> Replacing 'closed' with 'merged' excludes rejected PRs.
>
>
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged
>
> >
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed
>
>
> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged
>
> The 2.7 backport of https://github.com/python/cpython/pull/3639
> is yours.
>
> tjr
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Serhiy Storchaka]

22.04.18 21:27, Terry Reedy пише:

Replacing 'closed' with 'merged' excludes rejected PRs.


Thank you, this gives cleaner result.


The 2.7 backport of https://github.com/python/cpython/pull/3639
is yours.


I thought you taken it.

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Orphaned backports

[Terry Reedy]

On 4/22/2018 12:16 PM, Serhiy Storchaka wrote:
miss-islington is an awesome bot! It makes fixing bugs in multiple 
versions much simpler. You need just accept automatically created 
backporting PRs.


But there is a downside. miss-islington makes the life so easier, that 
sometimes you forgot about not finished backports. miss-islington can 
fail to backport some changes for different reasons. Currently on GitHub 
there are tens merged PRs labeled for backporting, but backports were 
not finished. Please take attention if your PRs in one of the following 
lists:


Does github allow repository owners to send email directly to people who 
have submitted PRs or at least, people with commit privileges (in this 
case, those whose have done particular merges)?


https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed 


https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed 


Several of these were closed without merging and should not and cannot 
be backported.  For instance, you closed

https://github.com/python/cpython/pull/4225
after you submitted and merged a replacement.
https://github.com/python/cpython/pull/6259

Stripping backport labels off of rejected PRs could be considered.  But 
this would toss information needed for a new PR if the bpo issue is 
open.  Expecting either the submitter or merged of a replacement to go 
back and clean up the original seems a bit much.  The submitter might 
not be able to, and the merger might not know or forget that the PR is a 
replacement.  Perhaps rejected PRs should just be ignored.


Replacing 'closed' with 'merged' excludes rejected PRs.

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed 


https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged

The 2.7 backport of https://github.com/python/cpython/pull/3639
is yours.

tjr

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Orphaned backports

[Serhiy Storchaka]

miss-islington is an awesome bot! It makes fixing bugs in multiple 
versions much simpler. You need just accept automatically created 
backporting PRs.


But there is a downside. miss-islington makes the life so easier, that 
sometimes you forgot about not finished backports. miss-islington can 
fail to backport some changes for different reasons. Currently on GitHub 
there are tens merged PRs labeled for backporting, but backports were 
not finished. Please take attention if your PRs in one of the following 
lists:


https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed

___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/