Re: [python-committers] Merge with spurious CI failures?

[Gregory P. Smith]

fwiw a future way to avoid this mess is in
https://bugs.python.org/issue36855: have the tests support multiple
certificates so we can stage the new ones into our repo before updating the
server.

-gps

On Wed, May 8, 2019 at 11:15 AM Gregory P. Smith  wrote:

> If this cert change is impacting CI checks for everyone's PRs, I suspect
> all PRs will need to merge this change into their branch before they can
> pass CI.
>
> Having CI depend on external network resources does not seem like a good
> idea.
>
> -gps
>
> On Wed, May 8, 2019 at 11:04 AM Antoine Pitrou  wrote:
>
>>
>> Ah, there's already a PR at
>> https://github.com/python/cpython/pull/13192, thanks to Gregory.
>>
>> Regards
>>
>> Antoine.
>>
>>
>> Le 08/05/2019 à 17:58, Antoine Pitrou a écrit :
>> >
>> > Ok, apparently the SSL cert on self-signed.pythontest.net was changed
>> > but it wasn't updated in our source tree, hence the failure.
>> >
>> > Regards
>> >
>> > Antoine.
>> >
>> >
>> > Le 08/05/2019 à 17:49, Mariatta a écrit :
>> >> If you can't merge from GitHub UI then you won't be able to do it from
>> >> GitHub command line (it respects the same branch protection policy)
>> >>
>> >> I don't think we should merge if tests are still failing. Perhaps the
>> >> test should be adjusted to handle this spurious errors? Can it be
>> marked
>> >> as "allowed failure" or something like that?
>> >>
>> >>
>> >> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou > >> > wrote:
>> >>
>> >>
>> >> Hello,
>> >>
>> >> There are spurious CI failures (SSL certificate issue in
>> test_httplib).
>> >> Therefore the "Squash and merge" button is greyed out.
>> >>
>> >> How should I merge? Using the command-line instructions from
>> Github?
>> >>
>> >> Regards
>> >>
>> >> Antoine.
>> >> ___
>> >> python-committers mailing list
>> >> python-committers@python.org 
>> >> https://mail.python.org/mailman/listinfo/python-committers
>> >> Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >>
>> > ___
>> > python-committers mailing list
>> > python-committers@python.org
>> > https://mail.python.org/mailman/listinfo/python-committers
>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Gregory P. Smith]

If this cert change is impacting CI checks for everyone's PRs, I suspect
all PRs will need to merge this change into their branch before they can
pass CI.

Having CI depend on external network resources does not seem like a good
idea.

-gps

On Wed, May 8, 2019 at 11:04 AM Antoine Pitrou  wrote:

>
> Ah, there's already a PR at
> https://github.com/python/cpython/pull/13192, thanks to Gregory.
>
> Regards
>
> Antoine.
>
>
> Le 08/05/2019 à 17:58, Antoine Pitrou a écrit :
> >
> > Ok, apparently the SSL cert on self-signed.pythontest.net was changed
> > but it wasn't updated in our source tree, hence the failure.
> >
> > Regards
> >
> > Antoine.
> >
> >
> > Le 08/05/2019 à 17:49, Mariatta a écrit :
> >> If you can't merge from GitHub UI then you won't be able to do it from
> >> GitHub command line (it respects the same branch protection policy)
> >>
> >> I don't think we should merge if tests are still failing. Perhaps the
> >> test should be adjusted to handle this spurious errors? Can it be marked
> >> as "allowed failure" or something like that?
> >>
> >>
> >> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  >> > wrote:
> >>
> >>
> >> Hello,
> >>
> >> There are spurious CI failures (SSL certificate issue in
> test_httplib).
> >> Therefore the "Squash and merge" button is greyed out.
> >>
> >> How should I merge? Using the command-line instructions from Github?
> >>
> >> Regards
> >>
> >> Antoine.
> >> ___
> >> python-committers mailing list
> >> python-committers@python.org 
> >> https://mail.python.org/mailman/listinfo/python-committers
> >> Code of Conduct: https://www.python.org/psf/codeofconduct/
> >>
> > ___
> > python-committers mailing list
> > python-committers@python.org
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Gregory P. Smith]

Our pythontestdotnet repo is different than the cpython repo and the
certificate gets pushed to the server after being committed by hand so it's
a synchronization problem,.

https://github.com/python/cpython/pull/13192 should clear it up.  It's
awaiting the slow CI queuing gods.  It is marked automerge, so if a core
dev could go do a github review and Approve it, it'll go in immediately
after Travis and AppVeyor come back green.

-gps

On Wed, May 8, 2019 at 10:58 AM Antoine Pitrou  wrote:

>
> Ok, apparently the SSL cert on self-signed.pythontest.net was changed
> but it wasn't updated in our source tree, hence the failure.
>
> Regards
>
> Antoine.
>
>
> Le 08/05/2019 à 17:49, Mariatta a écrit :
> > If you can't merge from GitHub UI then you won't be able to do it from
> > GitHub command line (it respects the same branch protection policy)
> >
> > I don't think we should merge if tests are still failing. Perhaps the
> > test should be adjusted to handle this spurious errors? Can it be marked
> > as "allowed failure" or something like that?
> >
> >
> > On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  > > wrote:
> >
> >
> > Hello,
> >
> > There are spurious CI failures (SSL certificate issue in
> test_httplib).
> > Therefore the "Squash and merge" button is greyed out.
> >
> > How should I merge? Using the command-line instructions from Github?
> >
> > Regards
> >
> > Antoine.
> > ___
> > python-committers mailing list
> > python-committers@python.org 
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Antoine Pitrou]

Ah, there's already a PR at
https://github.com/python/cpython/pull/13192, thanks to Gregory.

Regards

Antoine.


Le 08/05/2019 à 17:58, Antoine Pitrou a écrit :
> 
> Ok, apparently the SSL cert on self-signed.pythontest.net was changed
> but it wasn't updated in our source tree, hence the failure.
> 
> Regards
> 
> Antoine.
> 
> 
> Le 08/05/2019 à 17:49, Mariatta a écrit :
>> If you can't merge from GitHub UI then you won't be able to do it from
>> GitHub command line (it respects the same branch protection policy)
>>
>> I don't think we should merge if tests are still failing. Perhaps the
>> test should be adjusted to handle this spurious errors? Can it be marked
>> as "allowed failure" or something like that?
>>
>>
>> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou > > wrote:
>>
>>
>> Hello,
>>
>> There are spurious CI failures (SSL certificate issue in test_httplib).
>> Therefore the "Squash and merge" button is greyed out.
>>
>> How should I merge? Using the command-line instructions from Github?
>>
>> Regards
>>
>> Antoine.
>> ___
>> python-committers mailing list
>> python-committers@python.org 
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Alex Gaynor]

https://github.com/python/cpython/pull/13192

Thanks gps!

Alex

On Wed, May 8, 2019 at 11:58 AM Antoine Pitrou  wrote:

>
> Ok, apparently the SSL cert on self-signed.pythontest.net was changed
> but it wasn't updated in our source tree, hence the failure.
>
> Regards
>
> Antoine.
>
>
> Le 08/05/2019 à 17:49, Mariatta a écrit :
> > If you can't merge from GitHub UI then you won't be able to do it from
> > GitHub command line (it respects the same branch protection policy)
> >
> > I don't think we should merge if tests are still failing. Perhaps the
> > test should be adjusted to handle this spurious errors? Can it be marked
> > as "allowed failure" or something like that?
> >
> >
> > On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  > > wrote:
> >
> >
> > Hello,
> >
> > There are spurious CI failures (SSL certificate issue in
> test_httplib).
> > Therefore the "Squash and merge" button is greyed out.
> >
> > How should I merge? Using the command-line instructions from Github?
> >
> > Regards
> >
> > Antoine.
> > ___
> > python-committers mailing list
> > python-committers@python.org 
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>


-- 
All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Antoine Pitrou]

Ok, apparently the SSL cert on self-signed.pythontest.net was changed
but it wasn't updated in our source tree, hence the failure.

Regards

Antoine.


Le 08/05/2019 à 17:49, Mariatta a écrit :
> If you can't merge from GitHub UI then you won't be able to do it from
> GitHub command line (it respects the same branch protection policy)
> 
> I don't think we should merge if tests are still failing. Perhaps the
> test should be adjusted to handle this spurious errors? Can it be marked
> as "allowed failure" or something like that?
> 
> 
> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  > wrote:
> 
> 
> Hello,
> 
> There are spurious CI failures (SSL certificate issue in test_httplib).
> Therefore the "Squash and merge" button is greyed out.
> 
> How should I merge? Using the command-line instructions from Github?
> 
> Regards
> 
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org 
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Eric V. Smith]

D’oh! Good point!

Eric

> On May 8, 2019, at 11:52 AM, Alex Gaynor  wrote:
> 
> Tests for that PR would presumably be green :-)
> 
> Alex
> 
>> On Wed, May 8, 2019 at 11:51 AM Eric V. Smith  wrote:
>> Surely there must be some way around it. After all, how would you merge a PR 
>> to fix this test?
>> 
>> --
>> Eric V. Smith
>> True Blade Systems, Inc
>> (301) 859-4544
>> 
>>> On May 8, 2019, at 11:49 AM, Mariatta  wrote:
>>> 
>>> If you can't merge from GitHub UI then you won't be able to do it from 
>>> GitHub command line (it respects the same branch protection policy)
>>> 
>>> I don't think we should merge if tests are still failing. Perhaps the test 
>>> should be adjusted to handle this spurious errors? Can it be marked as 
>>> "allowed failure" or something like that?
>>> 
>>> 
 On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  wrote:
 
 Hello,
 
 There are spurious CI failures (SSL certificate issue in test_httplib).
 Therefore the "Squash and merge" button is greyed out.
 
 How should I merge? Using the command-line instructions from Github?
 
 Regards
 
 Antoine.
 ___
 python-committers mailing list
 python-committers@python.org
 https://mail.python.org/mailman/listinfo/python-committers
 Code of Conduct: https://www.python.org/psf/codeofconduct/
>>> ___
>>> python-committers mailing list
>>> python-committers@python.org
>>> https://mail.python.org/mailman/listinfo/python-committers
>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
> 
> -- 
> All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Alex Gaynor]

Tests for that PR would presumably be green :-)

Alex

On Wed, May 8, 2019 at 11:51 AM Eric V. Smith  wrote:

> Surely there must be some way around it. After all, how would you merge a
> PR to fix this test?
>
> --
> Eric V. Smith
> True Blade Systems, Inc
> (301) 859-4544
>
> On May 8, 2019, at 11:49 AM, Mariatta  wrote:
>
> If you can't merge from GitHub UI then you won't be able to do it from
> GitHub command line (it respects the same branch protection policy)
>
> I don't think we should merge if tests are still failing. Perhaps the test
> should be adjusted to handle this spurious errors? Can it be marked as
> "allowed failure" or something like that?
>
>
> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  wrote:
>
>>
>> Hello,
>>
>> There are spurious CI failures (SSL certificate issue in test_httplib).
>> Therefore the "Squash and merge" button is greyed out.
>>
>> How should I merge? Using the command-line instructions from Github?
>>
>> Regards
>>
>> Antoine.
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>


-- 
All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Alex Gaynor]

I don't know if CPython has a specific policy about this -- other projects
I work on generally have a "we need to get master's tests passing again
before anything can merge" policy.

Alex

On Wed, May 8, 2019 at 11:44 AM Antoine Pitrou  wrote:

>
> They're deterministic.  Apparently the test which connects to
> "self-signed.pythontest.net" always fails now with a "self-signed
> certificate" error...
>
> Le 08/05/2019 à 17:37, Alex Gaynor a écrit :
> > Are these intermittent failures, or is there bustage on master right now?
> >
> > My usual habit on other projects (I'm not very active on CPython these
> > days) is to restart the build on travis so that is a nice green
> checkmark.
> >
> > Alex
> >
> > On Wed, May 8, 2019 at 11:32 AM Antoine Pitrou  > > wrote:
> >
> >
> > Hello,
> >
> > There are spurious CI failures (SSL certificate issue in
> test_httplib).
> > Therefore the "Squash and merge" button is greyed out.
> >
> > How should I merge? Using the command-line instructions from Github?
> >
> > Regards
> >
> > Antoine.
> > ___
> > python-committers mailing list
> > python-committers@python.org 
> > https://mail.python.org/mailman/listinfo/python-committers
> > Code of Conduct: https://www.python.org/psf/codeofconduct/
> >
> >
> >
> > --
> > All that is necessary for evil to succeed is for good people to do
> nothing.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>


-- 
All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Eric V. Smith]

Surely there must be some way around it. After all, how would you merge a PR to 
fix this test?

--
Eric V. Smith
True Blade Systems, Inc
(301) 859-4544

> On May 8, 2019, at 11:49 AM, Mariatta  wrote:
> 
> If you can't merge from GitHub UI then you won't be able to do it from GitHub 
> command line (it respects the same branch protection policy)
> 
> I don't think we should merge if tests are still failing. Perhaps the test 
> should be adjusted to handle this spurious errors? Can it be marked as 
> "allowed failure" or something like that?
> 
> 
>> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  wrote:
>> 
>> Hello,
>> 
>> There are spurious CI failures (SSL certificate issue in test_httplib).
>> Therefore the "Squash and merge" button is greyed out.
>> 
>> How should I merge? Using the command-line instructions from Github?
>> 
>> Regards
>> 
>> Antoine.
>> ___
>> python-committers mailing list
>> python-committers@python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Mariatta]

If you can't merge from GitHub UI then you won't be able to do it from
GitHub command line (it respects the same branch protection policy)

I don't think we should merge if tests are still failing. Perhaps the test
should be adjusted to handle this spurious errors? Can it be marked as
"allowed failure" or something like that?


On Wed, May 8, 2019, 8:32 AM Antoine Pitrou  wrote:

>
> Hello,
>
> There are spurious CI failures (SSL certificate issue in test_httplib).
> Therefore the "Squash and merge" button is greyed out.
>
> How should I merge? Using the command-line instructions from Github?
>
> Regards
>
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Antoine Pitrou]

They're deterministic.  Apparently the test which connects to
"self-signed.pythontest.net" always fails now with a "self-signed
certificate" error...

Le 08/05/2019 à 17:37, Alex Gaynor a écrit :
> Are these intermittent failures, or is there bustage on master right now?
> 
> My usual habit on other projects (I'm not very active on CPython these
> days) is to restart the build on travis so that is a nice green checkmark.
> 
> Alex
> 
> On Wed, May 8, 2019 at 11:32 AM Antoine Pitrou  > wrote:
> 
> 
> Hello,
> 
> There are spurious CI failures (SSL certificate issue in test_httplib).
> Therefore the "Squash and merge" button is greyed out.
> 
> How should I merge? Using the command-line instructions from Github?
> 
> Regards
> 
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org 
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
> 
> 
> -- 
> All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Merge with spurious CI failures?

[Alex Gaynor]

Are these intermittent failures, or is there bustage on master right now?

My usual habit on other projects (I'm not very active on CPython these
days) is to restart the build on travis so that is a nice green checkmark.

Alex

On Wed, May 8, 2019 at 11:32 AM Antoine Pitrou  wrote:

>
> Hello,
>
> There are spurious CI failures (SSL certificate issue in test_httplib).
> Therefore the "Squash and merge" button is greyed out.
>
> How should I merge? Using the command-line instructions from Github?
>
> Regards
>
> Antoine.
> ___
> python-committers mailing list
> python-committers@python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>


-- 
All that is necessary for evil to succeed is for good people to do nothing.
___
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/