[python-committers] New workflow - some questions

2017-07-28 Thread Paul Moore
I'm just looking at doing some work for the first time under the new
workflow. Most things look fine - I'm familiar with git/github, so
there's nothing startling in there, but I do have a few small
questions:

1. Section 32.2 in the Git bootcamp section - is there any reason to
use git@github URLs for the clones? I normally always use
https://github.com URLs, as they work with my proxy at work.

2. Section 32.10, I generally use "Compare and create pull request"
from my clone's github page, as that seems simpler. Is there any
reason for starting from the cpython repo - the process working that
way (which I wasn't even aware of!) seems more complex. I can't see
that it matters much, but I wouldn't want to mess up a PR if there
*is* a difference in the results.

3. The new blurb tool - I presume I'll need to set that up
somewhere/somehow, and use it to create a news entry. But I can't find
any docs on it at all :-(

There may be other stuff - I've been watching the core-workflow list,
and it feels like there's some awfully complex stuff being discussed.
But so far it looks pretty straightforward and "as expected" - which
is a credit to Brett and the others who've set all this up!

Thanks,
Paul
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] New workflow - some questions

2017-07-28 Thread Mariatta Wijaya
>
> 1. Section 32.2 in the Git bootcamp section - is there any reason to
> use git@github URLs for the clones? I normally always use
> https://github.com URLs, as they work with my proxy at work.


I don't have any explanation other than Git bootcamp was initially written
based on my personal setup.
I cloned CPython using SSH, and that's what I wrote in the devguide :)
You can use HTTPS if that works for you.
Perhaps someone else can explain better the difference between cloning via
HTTPS and SSH.


I generally use "Compare and create pull request"
> from my clone's github page, as that seems simpler.


Note that the link is only visible within 30 minutes (or so) after you
pushed your branch to remote.
If you did not create the PR immediately after pushing, the link
disappears. In this case, the instructions in 32.10 will help (maybe?).
Can we assume that people will create their PR immediately?
Maybe an improvement is to mention the "Compare and create pull request",
and to do this immediately after pushing the branch.

side-topic: Does anyone have some sort of script/git
alias/program/whatchamacallit that will open the PR page once we push to
remote? (similar to what cherry_picker does)  That could be a time saver :)


3. The new blurb tool - I presume I'll need to set that up
> somewhere/somehow, and use it to create a news entry. But I can't find
> any docs on it at all :-(



pip install blurb

Some write-up here: https://devguide.python.org/committing/#what-s-new-
and-news-entries
blurb readme: https://github.com/python/core-workflow/blob/
master/blurb/README.rst



Mariatta Wijaya
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] New workflow - some questions

2017-07-28 Thread INADA Naoki
On Sat, Jul 29, 2017 at 7:30 AM, Mariatta Wijaya
 wrote:
>> 1. Section 32.2 in the Git bootcamp section - is there any reason to
>> use git@github URLs for the clones? I normally always use
>> https://github.com URLs, as they work with my proxy at work.
>
>
> I don't have any explanation other than Git bootcamp was initially written
> based on my personal setup.
> I cloned CPython using SSH, and that's what I wrote in the devguide :)
> You can use HTTPS if that works for you.
> Perhaps someone else can explain better the difference between cloning via
> HTTPS and SSH.
>

I usually uses https for "read-only" remote.
Sometimes, even I have commit rights, I use pull request from personal fork and
I don't want to push directly.
Of course, I can use https to push.  But it requires some additional
steps.  So it
prevent accidental push to "origin".

I think there are no downside to use HTTPS for "read only" remotes.

>
>> I generally use "Compare and create pull request"
>> from my clone's github page, as that seems simpler.
>
>
> Note that the link is only visible within 30 minutes (or so) after you
> pushed your branch to remote.
> If you did not create the PR immediately after pushing, the link disappears.
> In this case, the instructions in 32.10 will help (maybe?).
> Can we assume that people will create their PR immediately?
> Maybe an improvement is to mention the "Compare and create pull request",
> and to do this immediately after pushing the branch.
>
> side-topic: Does anyone have some sort of script/git
> alias/program/whatchamacallit that will open the PR page once we push to
> remote? (similar to what cherry_picker does)  That could be a time saver :)
>

I use Github's "hub" CLI.
https://github.com/github/hub

"hub pull-request" can be used to create pull request from terminal.
"hub browse" can be used to open browser for current branch.


Regards,
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/