[Python-Dev] Re: PEP 614: Relaxing Grammar Restrictions On Decorators

2020-02-22 Thread Brandt Bucher
Happy to help.

Since it doesn't seem like anybody has issues with the PEP, and the PR looks 
solid, I think I'll contact the Steering Council about moving this forward.

Brandt
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/4WVJPAG5PCWFF3JWC54LA2QSR2NANZBF/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-22 Thread Steven D'Aprano
On Tue, Feb 18, 2020 at 05:35:38PM -, Brandt Bucher wrote:
> > I am accepting this PEP. Congratulations Steven and Brandt!
> 
> Thank you for your guidance, especially the suggestions late last 
> year. And thanks Steven for taking me on as a co-author and shaping 
> the bulk of the proposal.

Thank you Guido, and thank you Brandt for volunteering to do the heavy 
lifting with the proof of concept code etc. I never could have done this 
without you.

[...]
> I feel that I've adequately responded to the other points you've 
> raised here in this email (please let me know if I missed anything, 
> and perhaps Steven may want to chime in as well).

No, I'm good. Thank you to everyone for your constructive criticism and 
suggestions.


-- 
Steven
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/PSLPPSYPDOJSN3WU2UURLWN5XZ22ZFTC/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-22 Thread Brandt Bucher
> we'll also want to look at collections.UserDict, collections.ChainMap, and 
> types.MappingProxyType.

UserDict has already been updated in the PR (it has tests that fail if it 
doesn't have all of dict's methods). I'll look into the others... thanks for 
reminding me!

> collections.Mapping and collections.MutableMapping could provide concrete 
> method implementations that make subclasses behave in a way that's similar to 
> built-in dicts

Hm, haven't thought too much about this (I don't have much experience with the 
ABCs). Would they return dicts, or call the self.copy and self.update methods?

Those are just hypothetical questions for now; I don't necessarily want to dig 
too far into that discussion again. But I agree that it's definitely worth 
considering. ;)
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/QRX3NQPWTHFQFSQR6NJ54N2IKRGL3VET/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: PEP 614: Relaxing Grammar Restrictions On Decorators

2020-02-22 Thread Nick Coghlan
On Wed., 19 Feb. 2020, 5:07 pm Brandt Bucher, 
wrote:

> PEP 614 has recently completed a round of review on Python-Ideas:
>
> https://www.python.org/dev/peps/pep-0614/
>
> It proposes that the current decorator syntax restrictions be relaxed to
> allow any valid expression. Nobody has raised any objections, but I wanted
> to gather more feedback here prior to bringing it before the Steering
> Council.
>

I couldn't point you to a specific thread reference, but I think we came to
consensus years ago that this was a good idea that was just in need of
someone with the time and inclination to do the work :)

Thank you!

Cheers,
Nick.


>
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/FUAFZKRXJJHBGBRGUW2QRCCWV6CWDPU4/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: PEP 585: Type Hinting Generics In Standard Collections

2020-02-22 Thread Nick Coghlan
This looks like a nice usability improvement to me.

My only suggestion would be that types.MappingProxyType be included on the
list of types to be updated.

Cheers,
Nick.
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/EYU3VDK7T4OVT7MXM5OWOPFA4YKWXVDE/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-22 Thread Nick Coghlan
On Sun., 23 Feb. 2020, 5:32 am Brandt Bucher, 
wrote:

> Just to follow up on this, here are the subclasses I've found.
>
> Should be updated:
> - collections.OrderedDict
> - collections.defaultdict
> - http.cookies.BaseCookie
> - http.cookies.Morsel
> - http.cookies.SimpleCookie
>

They're not dict subclasses, but we'll also want to look at
collections.UserDict, collections.ChainMap, and types.MappingProxyType.

Finally, while the PEP quite reasonably doesn't propose making __or__ a
*required* part of the mutable mapping API, collections.Mapping and
collections.MutableMapping *could* provide concrete method implementations
that make subclasses behave in a way that's similar to built-in dicts by
default.

Cheers,
Nick.


>
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/YFC32QSDG7JH2AOUY5X5JUPP6P6REEUN/
Code of Conduct: http://python.org/psf/codeofconduct/


[Python-Dev] Re: Accepting PEP 584: Add Union Operators To dict

2020-02-22 Thread Brandt Bucher
Just to follow up on this, here are the subclasses I've found.

Should be updated:
- collections.OrderedDict
- collections.defaultdict
- http.cookies.BaseCookie
- http.cookies.Morsel
- http.cookies.SimpleCookie

Don’t think so:
- typing.TypedDict

Already defines the operator:
- collections.Counter

Not Public (or at least not documented):
- _strptime.TimeRE
- builtins.StgDict (this one's only available internally in _ctypes).
- email._encoded_words._QByteMap
- enum._EnumDict
- logging.config.ConvertingDict
- multiprocessing.pool._PoolCache
- urllib.parse.Quoter
___
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at 
https://mail.python.org/archives/list/python-dev@python.org/message/BRNLVR4G7TDG7Z2BQMURCSYSTFHDXYW5/
Code of Conduct: http://python.org/psf/codeofconduct/