Re: [Python-Dev] [Python-3000] Introduction and request for commit access to the sandbox.
On 5/23/07, Neal Norwitz [EMAIL PROTECTED] wrote: On 5/22/07, Alexandre Vassalotti [EMAIL PROTECTED] wrote: As you see, cStringIO's code also needs a good cleanup to make it, at least, conforms to PEP-7. Alexandre, It would be great if you could break up unrelated changes into separate patches. Some of these can go in sooner rather than later. I don't know all the things that need to be done, but I could imagine a separate patch for each of: * whitespace normalization * function name modification * other formatting changes * bug fixes * changes to make consistent with StringIO I don't know if all those items in the list need to change, but that's the general idea. Separate patches will make it much easier to review and get benefits from your work earlier. I totally agree, and that was already my current idea. I look forward to seeing your work! Thanks! -- Alexandre ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] [Python-3000] Introduction and request for commit access to the sandbox.
On 5/22/07, Alexandre Vassalotti [EMAIL PROTECTED] wrote: As you see, cStringIO's code also needs a good cleanup to make it, at least, conforms to PEP-7. Alexandre, It would be great if you could break up unrelated changes into separate patches. Some of these can go in sooner rather than later. I don't know all the things that need to be done, but I could imagine a separate patch for each of: * whitespace normalization * function name modification * other formatting changes * bug fixes * changes to make consistent with StringIO I don't know if all those items in the list need to change, but that's the general idea. Separate patches will make it much easier to review and get benefits from your work earlier. I look forward to seeing your work! n ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
