Re: [Python-Dev] Stop automerging
Oh yes, one issue of missing bpo-xxx is that bots don't report merged commits into the bpo. I like using the bpo issue to track backports: https://bugs.python.org/issue31902 It was just a general remark, it's fine for these commits. Someone can add them manually to the bpo if you want. Victor Le mer. 12 sept. 2018 à 17:56, Victor Stinner a écrit : > > Hi Benjamin, > > https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 > > Le mer. 12 sept. 2018 à 17:19, Benjamin Peterson a > écrit : > > (Just checking) Is there something wrong with this message besides the <-- > > comment? > > Since the commit is described as a follow-up of > 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b, maybe it could also include > "bpo-31902: " prefix in it's title. Just to ease following where the > change comes from. > > IMHO the main complain of Serhiy was the giant comment > ;-) I agree that this one has to go, and hopefully it's already fixed. > We are now good! > > Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Stop automerging
Hi Benjamin, https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 Le mer. 12 sept. 2018 à 17:19, Benjamin Peterson a écrit : > (Just checking) Is there something wrong with this message besides the <-- > comment? Since the commit is described as a follow-up of 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b, maybe it could also include "bpo-31902: " prefix in it's title. Just to ease following where the change comes from. IMHO the main complain of Serhiy was the giant comment ;-) I agree that this one has to go, and hopefully it's already fixed. We are now good! Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Stop automerging
On Wed, Sep 12, 2018, at 01:33, Serhiy Storchaka wrote: > 12.09.18 01:34, Miss Islington (bot) пише: > > https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 > > commit: d13e59c1b512069d90efe7ee9b613d3913e79c56 > > branch: master > > author: Benjamin Peterson > > committer: Miss Islington (bot) > > <31488909+miss-isling...@users.noreply.github.com> > > date: 2018-09-11T15:29:57-07:00 > > summary: > > > > Make sure the line comes from the same node as the col offset. (GH-9189) > > > > Followup to 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b. > > > > > > This commit message looks awful (and it is duplicated in maintained > branches). Please stop automerging to master by bots. The reason of > automating merging before is that the core dev that performs merging is > responsible for editing the commit message. There were mistakes from > time to time, but usually regular commiters did care of this. (Just checking) Is there something wrong with this message besides the <-- comment? ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Stop automerging
Thanks Zach for fixing it quickly. Even if that bug has been fixed, per my instructions to python-committers, core devs should still edit the PR title and PR description *before* adding the '烙 automerge' label. The YouTube video (link in python-committers email) shows to edit those. The PR title and body will be used as the squashed commit message. And remember, you can still merge the PR manually. Just don't apply the '烙 automerge' label. On Wed, Sep 12, 2018, 2:09 AM Zachary Ware wrote: > It is still up to the core dev to set the message properly, but the HTML > comments are invisible on GitHub until you edit the message. That bug is > now fixed, though; HTML comments are stripped from the message before > creating the commit. > > ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Stop automerging
It is still up to the core dev to set the message properly, but the HTML comments are invisible on GitHub until you edit the message. That bug is now fixed, though; HTML comments are stripped from the message before creating the commit. -- Zach (Top-posted in HTML from a phone) On Wed, Sep 12, 2018, 01:34 Serhiy Storchaka wrote: > 12.09.18 01:34, Miss Islington (bot) пише: > > > https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 > > commit: d13e59c1b512069d90efe7ee9b613d3913e79c56 > > branch: master > > author: Benjamin Peterson > > committer: Miss Islington (bot) < > 31488909+miss-isling...@users.noreply.github.com> > > date: 2018-09-11T15:29:57-07:00 > > summary: > > > > Make sure the line comes from the same node as the col offset. (GH-9189) > > > > Followup to 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b. > > > > > > This commit message looks awful (and it is duplicated in maintained > branches). Please stop automerging to master by bots. The reason of > automating merging before is that the core dev that performs merging is > responsible for editing the commit message. There were mistakes from > time to time, but usually regular commiters did care of this. > > I often use "git log", and such commit messages spoil the history. > > ___ > Python-Dev mailing list > Python-Dev@python.org > https://mail.python.org/mailman/listinfo/python-dev > Unsubscribe: > https://mail.python.org/mailman/options/python-dev/zachary.ware%2Bpydev%40gmail.com > ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Stop automerging
12.09.18 01:34, Miss Islington (bot) пише: https://github.com/python/cpython/commit/d13e59c1b512069d90efe7ee9b613d3913e79c56 commit: d13e59c1b512069d90efe7ee9b613d3913e79c56 branch: master author: Benjamin Peterson committer: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com> date: 2018-09-11T15:29:57-07:00 summary: Make sure the line comes from the same node as the col offset. (GH-9189) Followup to 90fc8980bbcc5c7dcced3627fe172b0bfd193a3b. This commit message looks awful (and it is duplicated in maintained branches). Please stop automerging to master by bots. The reason of automating merging before is that the core dev that performs merging is responsible for editing the commit message. There were mistakes from time to time, but usually regular commiters did care of this. I often use "git log", and such commit messages spoil the history. ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
