Re: [Python-Dev] cpython (3.1): #11515: fix several typos. Patch by Piotr Kasprzyk.

2011-03-15 Thread Antoine Pitrou
On Tue, 15 Mar 2011 04:19:24 +0100
ezio.melotti python-check...@python.org wrote:
   Modules/_ctypes/libffi/src/powerpc/ffi_darwin.c
   Modules/_ctypes/libffi_osx/powerpc/ppc-ffi_darwin.c

libffi is a third-party library and you should probably not introduce
gratuitous changes in these files. It will make tracking changes with
upstream more tedious.

Regards

Antoine.


___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] cpython (3.1): #11515: fix several typos. Patch by Piotr Kasprzyk.

2011-03-15 Thread Terry Reedy

On 3/15/2011 1:00 PM, Antoine Pitrou wrote:

On Tue, 15 Mar 2011 04:19:24 +0100
ezio.melottipython-check...@python.org  wrote:

   Modules/_ctypes/libffi/src/powerpc/ffi_darwin.c
   Modules/_ctypes/libffi_osx/powerpc/ppc-ffi_darwin.c


libffi is a third-party library and you should probably not introduce
gratuitous changes in these files. It will make tracking changes with
upstream more tedious.


This answers my question elsewhere of why revert real fixes. Perhaps the 
fixes could be submitted upstream.


Is that status and the restriction on changes indicated in the file?

--
Terry Jan Reedy

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] cpython (3.1): #11515: fix several typos. Patch by Piotr Kasprzyk.

2011-03-15 Thread Benjamin Peterson
2011/3/15 Terry Reedy tjre...@udel.edu:
 On 3/15/2011 1:00 PM, Antoine Pitrou wrote:

 On Tue, 15 Mar 2011 04:19:24 +0100
 ezio.melottipython-check...@python.org  wrote:

   Modules/_ctypes/libffi/src/powerpc/ffi_darwin.c
   Modules/_ctypes/libffi_osx/powerpc/ppc-ffi_darwin.c

 libffi is a third-party library and you should probably not introduce
 gratuitous changes in these files. It will make tracking changes with
 upstream more tedious.

 This answers my question elsewhere of why revert real fixes. Perhaps the
 fixes could be submitted upstream.

It really doesn't matter if there's typos in 3rd party libraries which
we distribute.


 Is that status and the restriction on changes indicated in the file?

No, because that would make updating it annoying, too. :)



-- 
Regards,
Benjamin
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com