Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread Anthony Baxter
On Friday 18 August 2006 06:06, Martin v. Löwis wrote:
> Georg Brandl schrieb:
> >> Can somebody please fix that? If not, should we remove the uuid module
> >> as being immature?
> >
> > Patch #1541863 supposedly solves this.
>
> Ah, good. I think it should go in.

Sounds fine to me. Making buildbot less red == goodness.


-- 
Anthony Baxter <[EMAIL PROTECTED]>
It's never too late to have a happy childhood.
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread glyph
On Thu, 17 Aug 2006 23:58:27 +0200, "\"Martin v. Löwis\"" <[EMAIL PROTECTED]> 
wrote:

>You misunderstand indeed: the chunk reads (...)

>it currently calls uuid1, and will call uuid4 when patched.
>test_uuid4 should have never failed, except that it uses uuid1
>as the uniqueness test.

Whooops.  I must have hit the "reverse diff" button in Emacs before reading it.

Thanks for the correction.
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread Martin v. Löwis
[EMAIL PROTECTED] schrieb:
>>> Patch #1541863 supposedly solves this.
>> Ah, good. I think it should go in.
> 
> Uh, I may be misunderstanding here, but that patch looks like it
> changes that part of the test for test_uuid4 to stop calling uuid4
> and call uuid1 instead?

You misunderstand indeed: the chunk reads

-for u in [uuid.uuid1() for i in range(1000)]:
+for u in [uuid.uuid4() for i in range(1000)]:

so it currently calls uuid1, and will call uuid4 when patched.
test_uuid4 should have never failed, except that it uses uuid1
as the uniqueness test.

Regards,
Martin
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread glyph
On Thu, 17 Aug 2006 22:06:24 +0200, "\"Martin v. Löwis\"" <[EMAIL PROTECTED]> 
wrote:
>Georg Brandl schrieb:
>>> Can somebody please fix that? If not, should we remove the uuid module
>>> as being immature?
>>
>> Patch #1541863 supposedly solves this.
>
>Ah, good. I think it should go in.

Uh, I may be misunderstanding here, but that patch looks like it changes that 
part of the test for test_uuid4 to stop calling uuid4 and call uuid1 instead?
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread Martin v. Löwis
Georg Brandl schrieb:
>> Can somebody please fix that? If not, should we remove the uuid module
>> as being immature?
> 
> Patch #1541863 supposedly solves this.

Ah, good. I think it should go in.

Regards,
Martin
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


Re: [Python-Dev] uuid tests failing on Windows

2006-08-17 Thread Georg Brandl
Martin v. Löwis wrote:
> test_uuid1 and test_uuid4 fail consistently on Windows; apparently,
> the generated universally-unique identifiers aren't even unique within
> a set of 1000 identifiers.
> 
> Can somebody please fix that? If not, should we remove the uuid module
> as being immature?

Patch #1541863 supposedly solves this.

Georg

___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] uuid tests failing on Windows

2006-08-17 Thread Martin v. Löwis
test_uuid1 and test_uuid4 fail consistently on Windows; apparently,
the generated universally-unique identifiers aren't even unique within
a set of 1000 identifiers.

Can somebody please fix that? If not, should we remove the uuid module
as being immature?

Regards,
Martin
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com