Re: [Python-Dev] Update on labels to be used on GitHub
2017-02-13 21:08 GMT+01:00 Brett Cannon : > We now have two sets of labels for representing cherry-picking statuses: > "backport to N.M" and "cherry-pick for N.M". The former are to help keep > track of what branches a PR should be cherry-picked to and can be removed > once the PR for a cherry-pick has been created (you can add a comment like > "cherry-picked from GH-NN" to make the link between the PRs). The first time I looked at the "backport to 3.6" flag, I understood that the change was written on the 3.6 branch and asked to rebase the change on 3.6. If I was confused, I'm sure that someone else will be confused as well :-) What do you think of renaming the label to "need 3.6 backport" (or "need backport to 3.6")? Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Update on labels to be used on GitHub
On Mon, 13 Feb 2017 at 14:43 Victor Stinner wrote: > 2017-02-13 21:08 GMT+01:00 Brett Cannon : > > We now have two sets of labels for representing cherry-picking statuses: > > "backport to N.M" and "cherry-pick for N.M". The former are to help keep > > track of what branches a PR should be cherry-picked to and can be removed > > once the PR for a cherry-pick has been created (you can add a comment > like > > "cherry-picked from GH-NN" to make the link between the PRs). > > The first time I looked at the "backport to 3.6" flag, I understood > that the change was written on the 3.6 branch and asked to rebase the > change on 3.6. If I was confused, I'm sure that someone else will be > confused as well :-) > > What do you think of renaming the label to "need 3.6 backport" (or > "need backport to 3.6")? > That's fine by me. Anyone else have an opinion? ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Update on labels to be used on GitHub
On Tue, Feb 14, 2017 at 11:32 AM, Brett Cannon wrote: > On Mon, 13 Feb 2017 at 14:43 Victor Stinner > wrote: >> >> 2017-02-13 21:08 GMT+01:00 Brett Cannon : >> > We now have two sets of labels for representing cherry-picking statuses: >> > "backport to N.M" and "cherry-pick for N.M". The former are to help keep >> > track of what branches a PR should be cherry-picked to and can be >> > removed >> > once the PR for a cherry-pick has been created (you can add a comment >> > like >> > "cherry-picked from GH-NN" to make the link between the PRs). >> >> The first time I looked at the "backport to 3.6" flag, I understood >> that the change was written on the 3.6 branch and asked to rebase the >> change on 3.6. If I was confused, I'm sure that someone else will be >> confused as well :-) >> >> What do you think of renaming the label to "need 3.6 backport" (or >> "need backport to 3.6")? > > > That's fine by me. Anyone else have an opinion? To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels? PRs that should be backported get "needs backport" and each branch that should get the patch, and cherry-pick PRs get exactly one branch label and the "cherry-pick" label. I think this would make it easier to see which branch a particular PR is against from the PR list. -- Zach ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Update on labels to be used on GitHub
2017-02-14 18:43 GMT+01:00 Zachary Ware : > To propose another color for the bikeshed, what about having labels > for each branch along with "needs backport" and "cherry-pick" labels? Oh right, labels have colors. I propose pink for "needs backport" and yellow for "cherry-pick"! Just kidding, sorry ;-) Victor ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Update on labels to be used on GitHub
On 2017-02-14 17:58, Victor Stinner wrote: 2017-02-14 18:43 GMT+01:00 Zachary Ware : To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels? Oh right, labels have colors. I propose pink for "needs backport" and yellow for "cherry-pick"! Just kidding, sorry ;-) Surely the colour for "cherry-pick" should be the colour of cherries! :-) ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Update on labels to be used on GitHub
On Tue, 14 Feb 2017 at 10:13 MRAB wrote: > On 2017-02-14 17:58, Victor Stinner wrote: > > 2017-02-14 18:43 GMT+01:00 Zachary Ware : > >> To propose another color for the bikeshed, what about having labels > >> for each branch along with "needs backport" and "cherry-pick" labels? > > > > Oh right, labels have colors. I propose pink for "needs backport" and > > yellow for "cherry-pick"! > > > > Just kidding, sorry ;-) > > > Surely the colour for "cherry-pick" should be the colour of cherries! :-) > Since the wording keeps throwing people I have renamed "backport to N.M" to "needs backport to N.M". I left the "cherry-pick for N.M" labels but made them a shade of pink (I associate cherry red with "bug" too much to switch over to red entirely :) . ___ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
