Re: Packages FTBFS with Python 3.6

2017-01-17 Thread Zbigniew Jędrzejewski-Szmek
On Tue, Jan 17, 2017 at 08:29:16AM -0700, Jerry James wrote:
> On Tue, Jan 17, 2017 at 7:08 AM, Zbigniew Jędrzejewski-Szmek
>  wrote:
> > On Mon, Jan 16, 2017 at 10:27:19PM -0800, Adam Williamson wrote:
> >> On Tue, 2017-01-17 at 05:33 +, Zbigniew Jędrzejewski-Szmek wrote:
> >> > Oh, Jerry beat me to it by taking a different route and disabling most
> >> > test. That should work too, but I think it hides real problems with
> >> > the python3 code...
> >>
> >> Yeah. Please don't just disable tests. Tests exist for a reason.
> >
> > We need to disable *some* tests, at least if we hope to build this
> > quickly.  It's just a question whether to disable more or less of
> > them.
> >
> > Most tests fail because of sympy/pyglet/xvfb/opengl interaction
> > (#904851), not from sympy error per se — the same tests run fine on a
> > "real" display.
> 
> Oh, sorry if I stepped on somebody's toes.  i didn't realize others
> were trying to fix sympy, too.  I guess I should join the python SIG
> mailing list, but I'm already on far too many mailing lists...
No, no, there were no toes to step on. I didn't announce anywhere
that I'm working on this. And anyway, I think our work is complementary:
I didn't know about the patch you pulled in,
but otoh, I managed to fix some of the tests by passing options to xvfb.

I'll try to push some of my changes too, let's see if that builds.

> But I don't understand what you mean about me disabling tests.  I
> haven't disabled any tests, much less "most tests".  i did add a BR on
> pyglets, then discovered that that CAUSES test failures due to missing
> GLX support, and so I removed the pyglets BR again.  Maybe a BR on
> mesa is needed as well as pyglets?  I don't know.
> 
> Anyway, I checked in an experimental patch in an attempt at fixing the
> test failures, and now there is a different test failure. :-(  So
> either my experimental patch isn't good enough, or it works perfectly
> and has unmasked another problem.  I probably won't have time to
> figure that out for a couple of days, so if somebody else is
> interested in looking at it, here is the latest build failure:
> 
> https://koji.fedoraproject.org/koji/buildinfo?buildID=828867

Zbyszek
___
python-devel mailing list -- python-devel@lists.fedoraproject.org
To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org


Re: Packages FTBFS with Python 3.6

2017-01-17 Thread Zbigniew Jędrzejewski-Szmek
On Mon, Jan 16, 2017 at 10:27:19PM -0800, Adam Williamson wrote:
> On Tue, 2017-01-17 at 05:33 +, Zbigniew Jędrzejewski-Szmek wrote:
> > On Tue, Jan 17, 2017 at 05:29:35AM +, Zbigniew Jędrzejewski-Szmek wrote:
> > > On Wed, Jan 11, 2017 at 04:28:18AM +, Zbigniew Jędrzejewski-Szmek 
> > > wrote:
> > > > > python3-sympy-0:1.0-3.fc25.noarch
> > > > 
> > > > Pfff, it still fails in the test suite :(
> > > 
> > > I'm chipping away at this one. There are some failing python2 tests
> > > which I had to disable, but it seems that things are mostly with python2.
> > > But it seems that the python3 code is plain broken (bad non-absolute
> > > imports).
> > 
> > Oh, Jerry beat me to it by taking a different route and disabling most
> > test. That should work too, but I think it hides real problems with
> > the python3 code...
> 
> Yeah. Please don't just disable tests. Tests exist for a reason.

We need to disable *some* tests, at least if we hope to build this
quickly.  It's just a question whether to disable more or less of
them.

Most tests fail because of sympy/pyglet/xvfb/opengl interaction
(#904851), not from sympy error per se — the same tests run fine on a
"real" display.

Zbyszek
___
python-devel mailing list -- python-devel@lists.fedoraproject.org
To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org