Re: Philosophical question regarding setuptools dependency
On Tuesday, 16 April 2019 10.04.15 WEST Miro Hrončok wrote: > On 15. 04. 19 19:11, José Abílio Matos wrote: > > > Hi, > > > >recently I got a bug report regarding doit (packaged in python3-doit): > > > > "setuptools is required at runtime" > > https://bugzilla.redhat.com/show_bug.cgi?id=1695045 > > > > The obvious fix is to add python3-setuptools as a BR for python3-doit. > > > I suppose you meant: As runtime requires. Yes, I meant that. I even had to double check to ensure that the fix was correct. (BTW it was :-) ) > > My question here is if I should report this upstream? > > > Not needed. Upstream installs via pip. You already get pkg_resourcess > (setuptools) and no upstream has setuptools in their requires. I suspected so but I was not sure and thus this thread. > > If this requirement were in the dependencies of the package the auto > > generator would had picked initially. > > > If the auto generator is capable of seeing an console_script entry point > (hint, yes it is) they should add setuptools to the required packages. > > We should open a RFE bug for this (on it). I saw that already sent a fix for this issue. Thanks. :-) > -- > Miro Hrončok Regards, -- José Abílio ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
Re: Philosophical question regarding setuptools dependency
On 16. 04. 19 11:04, Miro Hrončok wrote: On 15. 04. 19 19:11, José Abílio Matos wrote: Hi, recently I got a bug report regarding doit (packaged in python3-doit): "setuptools is required at runtime" https://bugzilla.redhat.com/show_bug.cgi?id=1695045 The obvious fix is to add python3-setuptools as a BR for python3-doit. I suppose you meant: As runtime requires. My question here is if I should report this upstream? Not needed. Upstream installs via pip. You already get pkg_resourcess (setuptools) and no upstream has setuptools in their requires. If this requirement were in the dependencies of the package the auto generator would had picked initially. If the auto generator is capable of seeing an console_script entry point (hint, yes it is) they should add setuptools to the required packages. We should open a RFE bug for this (on it). https://github.com/rpm-software-management/rpm/issues/664 -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
Re: Philosophical question regarding setuptools dependency
On 15. 04. 19 19:11, José Abílio Matos wrote: Hi, recently I got a bug report regarding doit (packaged in python3-doit): "setuptools is required at runtime" https://bugzilla.redhat.com/show_bug.cgi?id=1695045 The obvious fix is to add python3-setuptools as a BR for python3-doit. I suppose you meant: As runtime requires. My question here is if I should report this upstream? Not needed. Upstream installs via pip. You already get pkg_resourcess (setuptools) and no upstream has setuptools in their requires. If this requirement were in the dependencies of the package the auto generator would had picked initially. If the auto generator is capable of seeing an console_script entry point (hint, yes it is) they should add setuptools to the required packages. We should open a RFE bug for this (on it). -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
Philosophical question regarding setuptools dependency
Hi, recently I got a bug report regarding doit (packaged in python3-doit): "setuptools is required at runtime" https://bugzilla.redhat.com/show_bug.cgi?id=1695045 The obvious fix is to add python3-setuptools as a BR for python3-doit. My question here is if I should report this upstream? If this requirement were in the dependencies of the package the auto generator would had picked initially. What do you think? Regards, -- José Abílio ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org
