Re: HEADS UP: Slightly more robust Python Requires generated by RPM
On 30. 10. 21 21:42, Gordon Messmer wrote: On 10/29/21 05:49, Miro Hrončok wrote: For some of them (e.g. mako), this seems to be a mistake even. There are a lot of "dev0" versions in that set, so I took a look for the cause. It looks like all of the "dev0" packages use github source rather than PyPI sources, which means that none of the release process defined in setup.py/cfg is being used for those packages; they're just tarballs of the git repo. https://src.fedoraproject.org/rpms/python-mako/blob/rawhide/f/python-mako.spec#_11 "dev0" doesn't appear to be a bug in the scripts. Builds from github are intentionally marked dev releases: https://github.com/sqlalchemy/mako/blob/main/setup.cfg#L72 That pattern also appears in the updated policy document: https://fedoraproject.org/wiki/Changes/PythonPackagingGuidelines202x I'd suggest that we should instead strongly encourage the use of PyPI URLs. That is however not always possible, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi I think we need to enhance that section with tips for when using a git tarball wrt setuptools_scm and tag_build = dev See for example https://src.fedoraproject.org/rpms/python-mako/pull-request/13 (it doesn't even use git snapshot, but upstream release tarball). -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: HEADS UP: Slightly more robust Python Requires generated by RPM
On 10/31/21 02:45, Miro Hrončok wrote: See for example https://src.fedoraproject.org/rpms/python-mako/pull-request/13 Would we upstream that? I think that the "staying close to upstream projects" policy suggests that we should. And, personally, I don't think we should patch source without at least asking the upstream project if that is the best solution. In the case of mako, specifically, it probably isn't, since the PyPI tarball does include the test suite (and the generated documentation that's missing from the git tarball.) (it doesn't even use git snapshot, but upstream release tarball). In my opinion, calling it an "upstream release tarball" implies intent that is not in evidence. GitHub's release tarballs are a side-effect of declaring a release for a project that can't be disabled (last time I looked). For any project whose release process is more complex than simply tarring up the git repo (for example, any project that includes sub-modules in their intentional release archive), GitHub's automatic archive isn't a suitable substitute for the archive that developers intentionally publish. ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: HEADS UP: Slightly more robust Python Requires generated by RPM
On 31. 10. 21 19:21, Gordon Messmer wrote: (it doesn't even use git snapshot, but upstream release tarball). In my opinion, calling it an "upstream release tarball" implies intent that is not in evidence. GitHub's release tarballs are a side-effect of declaring a release for a project that can't be disabled (last time I looked). For any project whose release process is more complex than simply tarring up the git repo (for example, any project that includes sub-modules in their intentional release archive), GitHub's automatic archive isn't a suitable substitute for the archive that developers intentionally publish. I've made a mistake when mentioning "upstream release tarball" because I've mistaken it with another package (sqlalchemy). It is not relevant here. -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ python-devel mailing list -- python-devel@lists.fedoraproject.org To unsubscribe send an email to python-devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
