[issue47138] Bump Sphinx or pin Jinja2 to fix docs build
Maciej Olko added the comment: I've update both PRs to contain the pin only. -- ___ Python tracker <https://bugs.python.org/issue47138> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47138] Bump Sphinx or pin Jinja2 to fix docs build
Change by Maciej Olko : -- pull_requests: +30232 pull_request: https://github.com/python/cpython/pull/32109 ___ Python tracker <https://bugs.python.org/issue47138> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue47138] Bump Sphinx or pin Jinja2 to fix docs build
Change by Maciej Olko : -- keywords: +patch nosy: +Maciej Olko nosy_count: 2.0 -> 3.0 pull_requests: +30231 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32111 ___ Python tracker <https://bugs.python.org/issue47138> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: > This really should be handled in a new issue since the original fixes for all > affected releases are already in the field. Sorry, I got suggested too much with expected fix which is common for both of those issues. Shall I create a new issue? > Moreover, we should be a bit careful about bumping the required Sphinx > version for older releases as this has caused problems for downstream > distributors of Python in the past. Can't we just pin the Jinja2 version for > current releases? Didn't know about the problems for distributors. Definitely just pinning Jinja2 is enough. -- ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- pull_requests: +30194 pull_request: https://github.com/python/cpython/pull/32111 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- pull_requests: +30186 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/32109 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: After the Jinja version 3.1.0 release today [1], documentation builds fail for all stable branches. Sphinx in versions pinned on those branches fails with ImportError. [2] Backporting 14a4fce457033412278ca9a056787db424310dc3 to 3.10 and 3.9 fixes the problem for them (build is successful with 4.2.0). For 3.8 and 3.7 pinning down Jinja is required (docs don't build smoothly with 4.2.0 for those branches). Could some core developer help with the backports? I am starting to work on PRs with pins for 3.8 and 3.7. [1] https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0 [2] % sphinx-build --version Traceback (most recent call last): File "…/cpython/Doc/./venv/bin/sphinx-build", line 5, in from sphinx.cmd.build import main File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/cmd/build.py", line 25, in from sphinx.application import Sphinx File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/application.py", line 42, in from sphinx.registry import SphinxComponentRegistry File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/registry.py", line 24, in from sphinx.builders import Builder File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/builders/__init__.py", line 26, in from sphinx.util import import_object, logging, rst, progress_message, status_iterator File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/util/rst.py", line 22, in from jinja2 import environmentfilter ImportError: cannot import name 'environmentfilter' from 'jinja2' (…/cpython/Doc/venv/lib/python3.9/site-packages/jinja2/__init__.py) -- resolution: fixed -> status: closed -> open versions: -Python 3.11, Python 3.6 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- pull_requests: +27520 pull_request: https://github.com/python/cpython/pull/29256 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: It occurs that the documentation builds without warnings on most recent Sphinx -- version 4.2.0. Probably we should bump the version in 3.11, 3.10 and 3.9 to 4.2.0. That would enable us to remove the pin on docutils. -- ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: I'm sorry for the confusion. I might have make more checking on my side before proposing a fix. -- ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: For what it's worth I have just successfully built documentation on 3.7 and 3.6 branches locally. It looks like Sphinx 2.3.1 used there doesn't use this part of docutils API that have changed recently. Sphinx 2.3.1 has requirement of "docutils>=0.12", just like 3.2.1. We can pin docutils version to current (0.18) "just in case" to prevent a breakage in the future or do nothing – maybe it won't break – maybe the docutils API used is narrow enough. -- ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- keywords: +patch pull_requests: +27493 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29230 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Maciej Olko added the comment: The pin can be removed after bumping Sphinx to at least 3.5.4, which introduced upper limit for docutils version. https://github.com/sphinx-doc/sphinx/commit/9263eea38379822e053c67ad1d17036d724c5e41 -- ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- versions: +Python 3.11 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
Change by Maciej Olko : -- versions: -Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45618] Documentation builds fail with Sphinx 3.2.1
New submission from Maciej Olko : Since the release of Docutils 0.18 today building Python documentation fails. In CPython repository we have Sphinx pinned to 3.2.1, which has too loose requirement for Docutils version in install_requires – docutils>=0.12. Example of failing build: https://github.com/python/python-docs-pl/runs/4009459257. My suggestion is to pin down docutils in docs requirements. -- assignee: docs@python components: Documentation messages: 405060 nosy: Maciej Olko, docs@python priority: normal severity: normal status: open title: Documentation builds fail with Sphinx 3.2.1 type: crash versions: Python 3.10, Python 3.11, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42481] Add to pathlib function to check permission similar to os.access
Change by Maciej Olko : -- nosy: +Maciej Olko ___ Python tracker <https://bugs.python.org/issue42481> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41510] Mentions of pdb.set_trace() in library/functions and library/sys incorrectly states that set_trace expects no arguments
Change by Maciej Olko : -- title: Mentions of pdb.set_trace() in library/functions and library/sys uncorrectly states that set_trace expects no arguments -> Mentions of pdb.set_trace() in library/functions and library/sys incorrectly states that set_trace expects no arguments ___ Python tracker <https://bugs.python.org/issue41510> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41510] Mentions of pdb.set_trace() in library/functions and library/sys uncorrectly states that set_trace expects no arguments
New submission from Maciej Olko : An argument was added to pdb.set_trace() in Python 3.7 and those fragments of documentation should have been updated: library/functions.rst:120 > By default, sys.breakpointhook() calls pdb.set_trace() expecting no arguments. library/sys.rst > For example, the default binding (e.g. pdb.set_trace()) expects no arguments, > but you might bind it to a function that expects additional arguments > (positional and/or keyword). -- assignee: docs@python components: Documentation messages: 375064 nosy: Maciej Olko, docs@python priority: normal severity: normal status: open title: Mentions of pdb.set_trace() in library/functions and library/sys uncorrectly states that set_trace expects no arguments versions: Python 3.10, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41510> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40204] Docs build error with Sphinx 3.0 due to invalid C declaration
Change by Maciej Olko : -- nosy: +Maciej Olko ___ Python tracker <https://bugs.python.org/issue40204> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
