[issue41105] Add some extra content check in configure process for some empty header file who has been deprecated by glibc
Change by Manjusaka : -- title: Add some extra content check for some who has been deprecated by glibc -> Add some extra content check in configure process for some empty header file who has been deprecated by glibc ___ Python tracker <https://bugs.python.org/issue41105> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41105] Add some extra content check for some who has been deprecated by glibc
Manjusaka added the comment: Here's the reference https://sourceware.org/legacy-ml/libc-alpha/2019-08/msg00029.html -- ___ Python tracker <https://bugs.python.org/issue41105> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41105] Add some extra content check for some who has been deprecated by glibc
New submission from Manjusaka : Hello everyone When I try to compile the code from the master branch on my Manjaro, one of the Linux system based on the Arch and based on the glibc-2.31 && gcc-10.1.0 . the compiler show me that the fcntl module has been failed to be compiled Here's the message /home/manjusaka/Documents/project/cpython/Modules/fcntlmodule.c:618:33: error: ‘I_PUSH’ undeclared (first use in this function) 618 | if (PyModule_AddIntMacro(m, I_PUSH)) return -1; | ^~ ./Include/modsupport.h:146:67: note: in definition of macro ‘PyModule_AddIntMacro’ 146 | #define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant(m, #c, c) | ^ /home/manjusaka/Documents/project/cpython/Modules/fcntlmodule.c:618:33: note: each undeclared identifier is reported only once for each function it appears in 618 | if (PyModule_AddIntMacro(m, I_PUSH)) return -1; | ^~ ./Include/modsupport.h:146:67: note: in definition of macro ‘PyModule_AddIntMacro’ 146 | #define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant(m, #c, c) | ^ /home/manjusaka/Documents/project/cpython/Modules/fcntlmodule.c:619:33: error: ‘I_POP’ undeclared (first use in this function) 619 | if (PyModule_AddIntMacro(m, I_POP)) return -1; | ^ ./Include/modsupport.h:146:67: note: in definition of macro ‘PyModule_AddIntMacro’ 146 | #define PyModule_AddIntMacro(m, c) PyModule_AddIntConstant(m, #c, c) | ^ /home/manjusaka/Documents/project/cpython/Modules/fcntlmodule.c:620:33: error: ‘I_LOOK’ undeclared (first use in this function); did you mean ‘F_LOCK’? 620 | if (PyModule_AddIntMacro(m, I_LOOK)) return -1; | ^~ I have figured out the reason because the stropts.h has been deprecated since the glic-2.30, but some of the distribution of Linux keep an empty file on the /usr/include, so the configure process will recognize stropts.h is existed and open HAVE_STROPTS_H flag. So should we add an extra content check in the configure process to avoid the empty file problem? -- components: Build messages: 372254 nosy: Manjusaka priority: normal severity: normal status: open title: Add some extra content check for some who has been deprecated by glibc type: compile error versions: Python 3.10, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41105> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40700] Make WSGIRequestHandler easier to be customized by the user
Manjusaka added the comment: ping~ -- ___ Python tracker <https://bugs.python.org/issue40700> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40065] py39: remove deprecation note for xml.etree.cElementTree
Manjusaka added the comment: I'm working on it. I will make a PR today. -- ___ Python tracker <https://bugs.python.org/issue40065> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40700] Make WSGIRequestHandler easier to be customized by the user
Change by Manjusaka : -- keywords: +patch pull_requests: +19548 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20262 ___ Python tracker <https://bugs.python.org/issue40700> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40700] Make WSGIRequestHandler easier to be customized by the user
New submission from Manjusaka : Hello everyone I think we can make WSGIRequestHandler in wsgiref easier to be customized by the user Here's the detail the WSGIRequestHandler in wsgiref.simple_server has some code like this class WSGIRequestHandler(BaseHTTPRequestHandler): def handle(self): """Handle a single HTTP request""" self.raw_requestline = self.rfile.readline(65537) if len(self.raw_requestline) > 65536: self.requestline = '' self.request_version = '' self.command = '' self.send_error(414) return if not self.parse_request(): # An error code has been sent, just exit return handler = ServerHandler( self.rfile, self.wfile, self.get_stderr(), self.get_environ(), multithread=False, ) handler.request_handler = self # backpointer for logging handler.run(self.server.get_app()) If people want just to replace the ServerHandler, they need to override all the handle method, I don't think this is a good way to use. I prefer do something like this class WSGIRequestHandler(BaseHTTPRequestHandler): server_version = "WSGIServer/" + __version__ server_handler = ServerHandler def handle(self): """Handle a single HTTP request""" self.raw_requestline = self.rfile.readline(65537) if len(self.raw_requestline) > 65536: self.requestline = '' self.request_version = '' self.command = '' self.send_error(414) return if not self.parse_request(): # An error code has been sent, just exit return handler = self.server_handler( self.rfile, self.wfile, self.get_stderr(), self.get_environ(), multithread=False, ) handler.request_handler = self # backpointer for logging handler.run(self.server.get_app()) Now if people just need simple code to replace the ServerHandler, like this class CustomWSGIRequestHandler(WSGIRequestHandler): server_handler = CustomeServerHandler what do you think, I'm glad to make a PR for this -- components: Library (Lib) messages: 369465 nosy: Manjusaka priority: normal severity: normal status: open title: Make WSGIRequestHandler easier to be customized by the user type: enhancement versions: Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue40700> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40122] The implementation and documentation of "dis.findlables" don't match
Change by Manjusaka : -- nosy: +Manjusaka, vstinner ___ Python tracker <https://bugs.python.org/issue40122> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40049] tarfile cannot extract from stdin
Manjusaka added the comment: Hello I can't reproduce this issue on my Laptop from 3.8.1 to 3.9.0a4 I think maybe it depends on the file you use would you mind to upload the file with the problem? -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue40049> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40065] py39: remove deprecation note for xml.etree.cElementTree
Manjusaka added the comment: I will clean this This issue looks like the same with https://bugs.python.org/issue40064 -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue40065> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38250] enum.Flag should be more set-like
Manjusaka added the comment: 1. not sure I gett the Point 2. not sure 3. absolutely yes -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue38250> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] On Linux, os.count() should read cgroup cpu.shares and cpu.cfs (CPU count inside docker container)
Manjusaka added the comment: Hello guys, I some ideas about this issue First, maybe we should add a new API named cpu_usable_count(). I think it's more meaningful than the os.sched_getaffinity(0) Second, more and more people use docker to run their app today. So people need an official way to get the environment info, not just cpu, but the memory, the network traffic limit. Because the docker is based on the CGroup in Linux, maybe we can add a cgroup lib as an official supported lib. but I'm not sure about this idea, because there are some problem. 1. the CGroup is only supported on Linux. I'm not sure that adding a platform-specific lib is a good idea 2. Many languages are not adding cgroup official yet. Maybe there are some languages are optimized for the cgroup (such as Java in JVM) -- nosy: +giampaolo.rodola ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] On Linux, os.count() should read cgroup cpu.shares and cpu.cfs (CPU count inside docker container)
Manjusaka added the comment: Actually, we already have some third party libs to support cgroup. But most of them get these questions 1. They are not std lib 2. They are just support cgroup1 But if we want to add a new std lib. Should we create a PEP? -- ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] On Linux, os.count() should read cgroup cpu.shares and cpu.cfs (CPU count inside docker container)
Manjusaka added the comment: I will make a PR in this week -- ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] On Linux, os.count() should read cgroup cpu.shares and cpu.cfs (CPU count inside docker container)
Manjusaka added the comment: Hello Mike, thanks for your code. I think it's a good way I think if cpu.quota and cpu.shares are -1, just return the original value in os.cpu_count() is OK -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39853] Segmentation fault with urllib.request.urlopen and threads
Manjusaka added the comment: Hello Victor I have tried on both MacOS and Ubuntu 18.04 from 3.8.2 to the newest code in master, and can't reproduce this problem macOS-10.15.4-x86_64-i386-64bit Python 3.9.0a4+ (heads/master:9a81ab107a, Mar 24 2020, 02:06:30) [Clang 11.0.3 (clang-1103.0.32.26)] Linux-4.15.0-1060-aws-x86_64-with-glibc2.27 Python 3.8.2 (default, Mar 23 2020, 19:21:16) [GCC 8.3.0] Linux-4.15.0-1060-aws-x86_64-with-glibc2.27 Python 3.9.0a4 (default, Mar 23 2020, 19:25:43) [GCC 8.3.0] I think it may be caused by the kernel version and the glibc version, I don't have enough evidence to prove it. I will try the Python 3.7.6 to the newest version in Ubuntu 19.10 with Kernel 5.3.0-29 and GCC 8.3.0 -- ___ Python tracker <https://bugs.python.org/issue39853> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39853] Segmentation fault with urllib.request.urlopen and threads
Manjusaka added the comment: use the same GCC 8.3.0 to recompile the Python 3.7.3 still no fault maybe we need the core dump to figure it out. -- ___ Python tracker <https://bugs.python.org/issue39853> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39853] Segmentation fault with urllib.request.urlopen and threads
Manjusaka added the comment: I have tried it on Python 3.7.3 Ubuntu 18.04 Linux-4.15.0-1060-aws-x86_64-with-debian-buster-sid Python 3.7.3 (default, Mar 23 2020, 18:15:26) [GCC 7.5.0] there is no segmentation fault would you mind sharing the core dump to help us find more detail about the crash? -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue39853> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34591] smtplib mixes RFC821 and RFC822 addresses
Manjusaka added the comment: > This is a problem because not all RFC822 addresses are valid RFC821 addresses. Do you mean that we would add a verification before we send the command? -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue34591> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39924] pathlib handles missing `os.link`, `os.symlink` and `os.readlink` inconsistently
Change by Manjusaka : -- keywords: +patch pull_requests: +18345 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18998 ___ Python tracker <https://bugs.python.org/issue39924> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39924] pathlib handles missing `os.link`, `os.symlink` and `os.readlink` inconsistently
Manjusaka added the comment: Fine, I get your means -- ___ Python tracker <https://bugs.python.org/issue39924> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39924] pathlib handles missing `os.link`, `os.symlink` and `os.readlink` inconsistently
Manjusaka added the comment: But when will os.readlink() be unavailable? -- ___ Python tracker <https://bugs.python.org/issue39924> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39924] pathlib handles missing `os.link`, `os.symlink` and `os.readlink` inconsistently
Manjusaka added the comment: I don't think rename 'link_to' to 'link' directly is a good idea. Because there are many third-party libs have used this name. Unless we can keep two names in this version, and remind people the 'link_to' function will be deprecated totally in a future version. But is there any way to make a function as deprecated? About 'os.readlink', we can hide this function in the platform that doesn't support readlink() just like `epoll' in mac or etc. -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue39924> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39806] different behavior between __ior__ and __or__ in dict made by PEP 584
Change by Manjusaka : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue39806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39806] different behavior between __ior__ and __or__ in dict made by PEP 584
Manjusaka added the comment: > Augmented assignment behaves identically to the update method called with a > single positional argument, so it also accepts anything implementing the > Mapping protocol (more specifically, anything with the keys and __getitem__ > methods) or iterables of key-value pairs. This is analogous to list += and > list.extend, which accept any iterable, not just lists. Continued from above: But the __or__ in implementation doesn't restrict the type of the input data. But it's almost the same with __ior__. I think we should keep the behavior as same as possible. some lenient or same restrictive -- ___ Python tracker <https://bugs.python.org/issue39806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39806] different behavior between __ior__ and __or__ in dict made by PEP 584
Manjusaka added the comment: In my opinion, make more lenient or not is OK, but we should guarantee the magic method should keep clean and right meaning For example, the __iadd__ in std data structure should be as same as the __add__ except it's an in-place operator. If it's necessary, I will make a PR to fix this -- nosy: -xtreak ___ Python tracker <https://bugs.python.org/issue39806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39806] different behavior between __ior__ and __or__ in dict made by PEP 584
New submission from Manjusaka :
Hello Guys:
I have tried Python 3.9.0a4, I have an issue: the __ior__ and the __or__ have
different behavior
For example:
x={}
y=[(1,2)]
x|=y is right and x=x|y will raise an exception.
I think it's should be better make the same between two magic method ?
--
components: C API
messages: 363045
nosy: Manjusaka
priority: normal
severity: normal
status: open
title: different behavior between __ior__ and __or__ in dict made by PEP 584
versions: Python 3.9
___
Python tracker
<https://bugs.python.org/issue39806>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38342] ImportError: cannot import name 'MetadataPathFinder' from 'importlib.metadata'
Manjusaka added the comment:
Hello Mariatta
I have tested the code below on 3.8.1 what's installed by pyenv on my Mac
from importlib.metadata import version, requires, files
version('requests')
it works correctly.
I think it depends on the tool what's used to install python
--
nosy: +Manjusaka
___
Python tracker
<https://bugs.python.org/issue38342>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31405] shutil.which doesn't find files without PATHEXT extension on Windows
Manjusaka added the comment:
Hello Anthony
would you mind to execute this command on your PC?
python -c "import os; print(os.environ.get("PATHEXT", "").split(os.pathsep))"
and show the result about this code?
--
nosy: +Manjusaka
___
Python tracker
<https://bugs.python.org/issue31405>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39408] Add support for SQLCipher
Manjusaka added the comment: To be serious, I don't think using SQLCipher is a good idea for CPython Cause, SQLCipher is always released by the source code, not the binary. That means we should compile and manage the binary on different platforms, sush as ffi on windows, Openssl on Windows. I think that will bring in some substantial compatibility problems. I think the ROI is not enough to make this change. -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue39408> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: Raymond, thanks for fixing many errors for my patch! -- ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38768] Support lldb enhancement in MacOS
New submission from Manjusaka : After MacOS 10.15.x, Apple has changed this system feature that will make more difficult for using GDB in MacOS. So is there any chance to support lldb enhancement such as py-list and etc.? -- components: macOS messages: 356372 nosy: Manjusaka, ned.deily, ronaldoussoren priority: normal severity: normal status: open title: Support lldb enhancement in MacOS versions: Python 3.9 ___ Python tracker <https://bugs.python.org/issue38768> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: Yes, you are right, we shouldn't consider about the unstandard using way. I will update my PR BTW, what're means for the "make_key" parameter? -- ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Change by Manjusaka : -- pull_requests: +16446 pull_request: https://github.com/python/cpython/pull/16916 ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment:
I have already make a new function like this
static PyObject *
lru_cache_cache_parameters(lru_cache_object *self)
{
PyObject *cache_parameters = PyDict_New();
PyDict_SetItemString(cache_parameters, "maxsize",
PyLong_FromSsize_t(self->maxsize));
PyDict_SetItemString(cache_parameters, "typed", self->typed == 0 ? Py_False
: Py_True);
return cache_parameters;
}
--
___
Python tracker
<https://bugs.python.org/issue38565>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: I think to modify in lru_cache should be good in normal circumstance But here's maybe some people modify the wrapped object that underlying in lru_cache So I prefer to add a new function in _functools.c? -- ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: I think add new function would be a better way I will make a new PR -- ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: I have already make a PR for this issue but here's a problem. add a new field to cache_info maybe cause some special problem for the third-party libs what're dependent the cache_info -- ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Change by Manjusaka : -- keywords: +patch pull_requests: +16445 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16915 ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38565] Expose the value passed of typed passed to functools.lru_cache
Manjusaka added the comment: I think it's a good idea to expose the full arguments that people use in lru_cache() -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue38565> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36792] zipfile.writestr causes a Python crash on Windows if the locale is set
Manjusaka added the comment: copy that I will reset my locale setting to figure it out -- ___ Python tracker <https://bugs.python.org/issue36792> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36792] zipfile.writestr causes a Python crash on Windows if the locale is set
Manjusaka added the comment: Hi Dominik Geldmacher May I get your system version? 1809 or 1903? I guess maybe it's microsoft error -- ___ Python tracker <https://bugs.python.org/issue36792> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36792] zipfile.writestr causes a Python crash on Windows if the locale is set
Manjusaka added the comment: Same environment. But I still can not reproduce this exception. I guess maybe it's about the local time or timezone problem. I will find a way to figure it out -- ___ Python tracker <https://bugs.python.org/issue36792> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36792] zipfile.writestr causes a Python crash on Windows if the locale is set
Manjusaka added the comment: Or would you share the Exception with us ? I guess it's caused by system setting -- ___ Python tracker <https://bugs.python.org/issue36792> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36792] zipfile.writestr causes a Python crash on Windows if the locale is set
Manjusaka added the comment: I can't reproduce this error on my system by using the same code. Could you share the system info with us? -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue36792> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36677] support visual studio multiprocess compile
Change by Manjusaka : -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36677> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36677] support visual studio multiprocess compile
New submission from Manjusaka : Support multiprocess compile when the developer uses the Visual studio on the Windows -- components: Windows messages: 340573 nosy: Manjusaka, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: support visual studio multiprocess compile versions: Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue36677> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36535] Windows build failure when use the code from the GitHub master branch
Change by Manjusaka : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36535> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36535] Windows build failure when use the code from the GitHub master branch
Manjusaka added the comment: Done,thx -- ___ Python tracker <https://bugs.python.org/issue36535> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36535] Windows build failure when use the code from the GitHub master branch
New submission from Manjusaka : I use Visual Studio 2017 to build the source code from the master branch. But it failed. The output message shows that I lose my ffi.h. I find that the developer had removed the libffi_module directory under cpython/modules/_ctypes since 32119e10b792ad7ee4e5f951a2d89ddbaf111cc5 I guess that maybe that's the problem why I get failure -- components: Windows messages: 339494 nosy: Manjusaka, paul.moore, steve.dower, tim.golden, zach.ware priority: normal severity: normal status: open title: Windows build failure when use the code from the GitHub master branch versions: Python 3.8 ___ Python tracker <https://bugs.python.org/issue36535> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] Way to detect CPU count inside docker container
Manjusaka added the comment: Yes, not only but also support get real memory limit. look at https://blogs.oracle.com/java-platform-group/java-se-support-for-docker-cpu-and-memory-limits -- ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] Way to detect CPU count inside docker container
Manjusaka added the comment: Hi Stéphane: I have checked the JVM implantation about container improvements. I confirm that maybe we need a new Libary for container environment. I don't think that combine it into the os module is a good idea. I will make a PR during this week. -- ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] Way to detect CPU count inside docker container
Manjusaka added the comment: Hi Stéphane Thanks a lot! In my opinion, I would like to make an independent library that name is cgroups. For ease of use and compatibility, I think it's better than combining code with the os module. Thanks for you working! Manjusaka -- ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36054] Way to detect CPU count inside docker container
Manjusaka added the comment: I think that I may work on a PR for this issue. Is there anybody has worked on it ？ -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue36054> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()
Manjusaka added the comment: I have already make a pull request on GitHub -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue28235> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()
Change by Manjusaka : -- pull_requests: +11929 ___ Python tracker <https://bugs.python.org/issue28235> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: ping -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Change by Manjusaka : -- pull_requests: -11140 ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Change by Manjusaka : -- pull_requests: -11141 ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Manjusaka added the comment: I have already work on a PR for it -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Change by Manjusaka : -- keywords: +patch, patch, patch pull_requests: +11140, 11141, 11142 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Change by Manjusaka : -- keywords: +patch, patch pull_requests: +11140, 11141 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35726] QueueHandler formating affects other handlers
Change by Manjusaka : -- keywords: +patch pull_requests: +11140 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35726> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30698] asyncio sslproto do not shutdown ssl layer cleanly
Manjusaka added the comment: Ping! Agree with Wei-Cheng. The leak still bothers me for times, and still bother for third-party like https://aiohttp.readthedocs.io/en/stable/client_reference.html#tcpconnector Yury, I think it's worth working on it. Using uvloop should not be a good idea for some people. -- nosy: +Manjusaka ___ Python tracker <https://bugs.python.org/issue30698> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: > `selectors` makes underlying implementations irrelavant to most users since > we can simply use `DefaultSelector` I agree with this. > If you know you want to add EPOLL_EXCLUSIVE, why not just use `select.epoll`? I don't think so. If I use the `select` directly, that means I have to give up all the features what `selectors` support such as binding a `data` to a fd, that also means I have to do some repeat work myself. I don't think it's a good idea. So, why not change this API when we can keep the compatibility? -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Change by Manjusaka : -- nosy: -asvetlov ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: Actually, in my implementation, it also supports POLL with the different event. I don't think to make selector be a public property is a good idea. It will break the whole system integrity. Please think about it, if people want to use epoll/poll with some special event, they must use it like this. > s = selectors.EpollSelector() > s.selector.register(fd,select.EPOLLIN | select.EPOLLEXCLUSIVE) > s.selector.modify(fd,select.EPOLLOU | select.EPOLLEXCLUSIVE) Here's a question, why we support the register? I think it will make people don't care about the detail. So, as you say, it's a little bit complicated, but it will help people don't care about the selector property detail, they just use the argument when they want to use it. I think it's worth it. -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: Vicor: > Moreover, we directly support any EPOLL constant exposed in the select > module. No need to change the API. I don't think so In class _PollLikeSelector ,here's register method def register(self, fileobj, events, data=None): key = super().register(fileobj, events, data) poller_events = 0 if events & EVENT_READ: poller_events |= self._EVENT_READ if events & EVENT_WRITE: poller_events |= self._EVENT_WRITE this code filter the event that people push in it. It only supports select.EPOLLIN and select.EPOLLOUT -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: OK, I will change my code -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: In my opinion selectors is an abstract for select, so I don't think allow people use select.* in selector is a good idea. like this > s.register(fd, EVENT_READ, extra_events=select.EPOLLEXCLUSIVE | > select.EPOLLONESHOT) Because the multiple epoll's params are supported in different Python version and Linux Kernel version. So, I think it's a good idea to support different epoll's params by keyword-only param in register method. It's also convenient to check the params -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Change by Manjusaka : -- keywords: +patch pull_requests: +10433 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: Hello rodola Here's detail: In the server, we use multiprocess to handle the request with share the same FD. OK, when a request comes, all the process wake up and try to accept the request but only one process will accept success and the others will raise an Exception if we use the epoll without EPOLLEXCLUSIVE. That means there will waste the performance. This effect is named thundering herd. But if we use epoll with EPOLLEXCLUSIVE, when the envents happen, only one process will wake and try to handle the event. So, I think it's necessary to support the EPOLLEXCLUSIVE in selectors.EpollSelector Actually, Python support EPOLLEXCLUSIVE official since 3.7. It's time to support it in selectors -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: "a keyword-only parameter" is good I'll take it done -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Manjusaka added the comment: I will work on a PR -- ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] enhhance for selector.EpollSelector
New submission from Manjusaka : Add a keyword argument for selector.EpollSelector with default value. This can help people use the EPOLLEXCLUSIVE since Python 3.7 and Linux Kernel 4.5 to avoid the herd effect like this def register(self, fileobj, events, data=None, exclusive=False): key = super().register(fileobj, events, data) epoll_events = 0 if events & EVENT_READ: epoll_events |= select.EPOLLIN if events & EVENT_WRITE: epoll_events |= select.EPOLLOUT try: if exclusive and hasattr(select, "EPOLLEXCLUSIVE"): epoll_events |= select.EPOLLEXCLUSIVE self._epoll.register(key.fd, epoll_events) except BaseException: super().unregister(fileobj) raise return key -- components: Library (Lib) messages: 331969 nosy: Manjusaka priority: normal severity: normal status: open title: enhhance for selector.EpollSelector type: enhancement versions: Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Change by Manjusaka : -- keywords: +patch pull_requests: +10398 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
New submission from Manjusaka : Since Python 3.7, Python adds a mask variable named EPOLLEXCLUSIVE for select.epoll. The mask variable is supported by the Linux Kernel since Kernel 4.5. So we can add a tip in this part of Python docs to notice the people the case. -- components: Library (Lib) messages: 331840 nosy: Manjusaka priority: normal severity: normal status: open title: Libary select docs enhance type: enhancement versions: Python 3.7 ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
Manjusaka added the comment: Finally, I must say when I first build the Python 3.7.0b5, I don't use Pyenv or others tools. As you say, It should be a PATH problem. I build success without no patch in a clean Mac. I think I will figure out what's wrong. But just as what I say, You can't ensure everyone has a clean PATH. Anyway, Thanks for your helping! -- ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
Manjusaka added the comment: it seems like what you say but I think that you can't ensure everyone has a clean path especially when people use some tools such as pyenv or others to build Python from source code, but not get the binary package directly. Anyway, it's just a personal idea. Thanks for what you do. -- ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
Manjusaka added the comment: The result in here https://gist.github.com/Zheaoli/86b04395748b998ad7d870a927a95aea -- ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
Manjusaka added the comment: Actually, I found some interesting problem. In Python 3.6.5 has declared the `extern pid_t forkpty(int *, char *, struct termios *, struct winsize *);` in here https://github.com/python/cpython/blob/3.6/Include/pyport.h#L532 and I add it into the Python 3.7.0b5's pyport.h, It builds success! -- ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
Manjusaka added the comment: Sure, I already set "xcode-select --install" in terminal Python 3.6.5 build success with a default setting when running ./configuration" command Xcode version is 9.3 System version 10.13.4 -- ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33756] Python 3.7.0b5 build error
New submission from Manjusaka : When I build 3.70.b5 in Mac , the compiler raise an error show that "./Modules/posixmodule.c:6018:11: error: implicit declaration of function 'forkpty' is invalid in C99 [-Werror,-Wimplicit-function-declaration] pid = forkpty(_fd, NULL, NULL, NULL);" the makefile was generated by './configuration" command without no argument. -- components: Build messages: 318555 nosy: Manjusaka priority: normal severity: normal status: open title: Python 3.7.0b5 build error type: compile error versions: Python 3.7 ___ Python tracker <https://bugs.python.org/issue33756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
