[issue31920] pygettext ignores directories as inputfile argument

[Oleg Krasnikov]

Oleg Krasnikov <a.insol...@gmail.com> added the comment:

Thanks for quite sensible notes Serhiy. I've fixed all that in recent commit 
and added a regression test. Still not sure about "testing conventions" here 
cause this is my first PR to python repository, so please let me know if 
something is wrong and I'll fix that.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31920>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31920] pygettext ignores directories as inputfile argument

[Oleg Krasnikov]

Change by Oleg Krasnikov <a.insol...@gmail.com>:


--
keywords: +patch
pull_requests: +4193
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31920>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31920] pygettext ignores directories as inputfile argument

[Oleg Krasnikov]

New submission from Oleg Krasnikov <a.insol...@gmail.com>:

This happens because pygettext's `getFilesForName` calls `os.walk` as if it was 
`os.path.walk`. But the `walk` function has changed signature when moved from 
`os.path` to `os`. So now `_visit_pyfiles` is passed to `walk` as `topdown` 
argument which is obviously wrong and therefore `_visit_pyfiles` is never 
called.

--
components: Demos and Tools
messages: 305406
nosy: Oleg Krasnikov
priority: normal
severity: normal
status: open
title: pygettext ignores directories as inputfile argument
type: behavior
versions: Python 3.4

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31920>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com