[issue45898] ctypes cfield.c defines duplicate ffi_type_* symbols
Change by Roman Yurchak : -- nosy: +Roman Yurchak ___ Python tracker <https://bugs.python.org/issue45898> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40280] Consider supporting emscripten/webassembly as a build target
Roman Yurchak added the comment: Thanks a lot for working on this! > _sys_shutdown is the syscall for shutdown(2) used by the socket module. Yes, the issue with Emscripten is that a number of system calls are either not implemented or implemented but not tested. See a list we are using in https://github.com/pyodide/pyodide/blob/main/cpython/pyconfig.undefs.h (though things might have improved since it was created). FYI, with Emscripten, the list of CPython unit tests that are currently skipped (as of Python 3.9.5) is in https://github.com/pyodide/pyodide/blob/main/src/tests/python_tests.txt some of those are due to browser VM limitations (e.g. virtual filestem by Emscripten that's not fully POSIX compliant, no processes, no sockets, async only via the browser event loop etc), others because we are not yet using threading since not all browsers support it, and some failures probably need more investigation. Also opened https://github.com/pyodide/pyodide/issues/2000 . Let us know if there is anything we can do help with this effort. -- ___ Python tracker <https://bugs.python.org/issue40280> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40280] Consider supporting emscripten/webassembly as a build target
Change by Roman Yurchak : -- nosy: +Roman Yurchak ___ Python tracker <https://bugs.python.org/issue40280> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set
Change by Roman Yurchak : -- type: -> compile error ___ Python tracker <https://bugs.python.org/issue41498> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue41498] Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set
New submission from Roman Yurchak : The `_Py_Sigset_Converter` function is conditionally defined in https://github.com/python/cpython/blob/777b611c8c5676b80898a429f71d28e59bddc49d/Modules/posixmodule.h#L27 if `ifdef HAVE_SIGSET_T` However this function is called unconditionally in https://github.com/python/cpython/blob/777b611c8c5676b80898a429f71d28e59bddc49d/Modules/clinic/signalmodule.c.h#L385 (there are 4 such occurrences), which leads to a compilation error when `HAVE_SIGSET_T` is not set. This is regression in 3.8+ as far as I can tell due to changes in https://github.com/python/cpython/pull/6720 I imagine the solution could be to always define this function but raise an exception if it is called when HAVE_SIGSET_T` is undefined, as done in the following patch: https://github.com/iodide-project/pyodide/blob/fc5495ffdb54a11fd588dc60ba6b8777f90c3724/cpython/patches/0006-fix-Py_Sigset_Converter.patch Would this be acceptable, or is there a better way of handling it? Thanks! -- messages: 374963 nosy: Roman Yurchak, pablogsal, serhiy.storchaka priority: normal severity: normal status: open title: Undefinied _Py_Sigset_Converter function when HAVE_SIGSET_T not set versions: Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41498> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40029] test_importlib.test_zip requires zlib but not marked
Change by Roman Yurchak : -- keywords: +patch nosy: +rth nosy_count: 2.0 -> 3.0 pull_requests: +18465 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19105 ___ Python tracker <https://bugs.python.org/issue40029> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35429] Incorrect use of raise NotImplemented
Roman Yurchak added the comment: Resolved in https://bugs.python.org/issue33023 -- resolution: -> duplicate ___ Python tracker <https://bugs.python.org/issue35429> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35430] Lib/argparse.py uses `is` for string comparison
Roman Yurchak added the comment: Thanks, Alexey and Serhiy! Looking at the code more closely I would agree. I guess changing the value of the suppress object to something else to avoid the warning, has a potential of breaking code that relies on the current functionality and is not worth it... -- ___ Python tracker <https://bugs.python.org/issue35430> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35430] Lib/argparse.py uses `is` for string comparison
Change by Roman Yurchak : -- keywords: +patch pull_requests: +10241 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35430> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35430] Lib/argparse.py uses `is` for string comparison
New submission from Roman Yurchak : Lib/argparse.py uses `is` for string comparison, ` 221:if self.heading is not SUPPRESS and self.heading is not None: 247:if text is not SUPPRESS and text is not None: 251:if usage is not SUPPRESS: 256:if action.help is not SUPPRESS: 290:if part and part is not SUPPRESS]) 679:if action.default is not SUPPRESS: 1130:if self.dest is not SUPPRESS: 1766:if action.dest is not SUPPRESS: 1768:if action.default is not SUPPRESS: 1851:if argument_values is not SUPPRESS: 2026: if action.help is not SUPPRESS] ` where `SUPPRESS = '==SUPPRESS=='`. Unless I'm missing something this can produce false negatives if the variable that we compare against is a slice from another string. Using equality is probably safer in any case. Detected with LGTM.com analysis. -- components: Library (Lib) messages: 331246 nosy: rth priority: normal severity: normal status: open title: Lib/argparse.py uses `is` for string comparison versions: Python 3.8 ___ Python tracker <https://bugs.python.org/issue35430> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35429] Incorrect use of raise NotImplemented
Change by Roman Yurchak : -- keywords: +patch pull_requests: +10237 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35429> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35429] Incorrect use of raise NotImplemented
New submission from Roman Yurchak :
In two places in stdlib, `raise NotImplemented` is used instead of `raise
NotImplementedError`. The former is not valid and produces,
```
>>> raise NotImplemented('message')
Traceback (most recent call last):
File "", line 1, in
TypeError: 'NotImplementedType' object is not callable
```
--
components: Library (Lib)
messages: 331244
nosy: rth
priority: normal
severity: normal
status: open
title: Incorrect use of raise NotImplemented
versions: Python 3.8
___
Python tracker
<https://bugs.python.org/issue35429>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
