[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Thanks a lot Victor for your numerous reviews and your help on this! Also thanks for all other who commented. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23630> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: A new (and hopefully last?) version of the patch, thanks again for the review Victor! -- Added file: http://bugs.python.org/file40356/multibind7.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23630> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Yet another version of the patch according to the last review. -- Added file: http://bugs.python.org/file40366/multibind8.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23630> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Here is a new patch without any dependency on netifaces. Thanks Victor for the great deal of help for all the mock() stuff! -- Added file: http://bugs.python.org/file40342/multibind6.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23630> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: About the function's signature to accept multiple hosts & ports, we could - accept host and port arguments being sequences and then we bind to all host:port combinations. Like if len(host) == N and len(port) == M, we bind to N*M sockets. or - accept host and port arguments being sequences and allow repetitions and bind to host:port couples from zip(host, port). I think the first is "clean", but the second allows more flexibility. Like for instance binding to IP1:port1 IP2:port2 but not IP1:port2 -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23630> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: A new patch with capitalization of first words of sentences + splitting lines which are too long (more PEP8 friendly). -- Added file: http://bugs.python.org/file40280/multibind4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: All right, here is the new patch then. -- Added file: http://bugs.python.org/file40275/multibind3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: All right, thanks. I fixed everything but the thing about getaddrinfo being Mock'ed. How am I supposed to handle the method being called with a Mock'ed getaddrinfo? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: About the missing capitalization, I omitted it because it's the argument's name. But I can resubmit with it being capitalized. I forgot to run flake8, sorry! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Ah yes, sorry about that. Here is a new patch. However, I worked on these sources: https://github.com/python/asyncio which now I understand was not the correct repository, but I added a tests_require=netifaces in the setup.py, where can I add this dependency in the CPython repository architecture? Thanks! -- Added file: http://bugs.python.org/file40271/multibind2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Here is a new patch, with modifications according to your review Victor. Thanks! -- Added file: http://bugs.python.org/file40270/multibind2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Changes by Yann Sionneau y...@m-labs.hk: Removed file: http://bugs.python.org/file40270/multibind2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: ping ? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Please let me know if you need anything for this patch to be integrated. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23630] support multiple hosts in create_server/start_server
Yann Sionneau added the comment: Here is a test related to Sebastien's patch. -- nosy: +ysionneau Added file: http://bugs.python.org/file38441/asyncio_multibind_test.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
