[issue37752] Redundant Py_CHARMASK called in some files
hai shi added the comment: typo error: delte->delete -- ___ Python tracker <https://bugs.python.org/issue37752> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37752] Redundant Py_CHARMASK called in some files
hai shi added the comment: Due to this macro documented in https://docs.python.org/3.9/c-api/intro.html#c.Py_CHARMASK and we don't know how much user use this marco, I don't think we need delte this function(deleting operation should be careful). -- ___ Python tracker <https://bugs.python.org/issue37752> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37718] 2to3 exception handling
hai shi added the comment: 1. the message property of PyBaseExceptionObject(Exception) have been cancelled. [1] https://github.com/python/cpython/blob/2.7/Include/pyerrors.h#L13 [2] https://github.com/python/cpython/blob/master/Include/cpython/pyerrors.h#L18 2. `except Exception, e` is a python2.x behavior, pls use `except Exception as e` in python3.x -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue37718> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37583] Got a 113 error when running the test_socket
hai shi added the comment: ping :) -- ___ Python tracker <https://bugs.python.org/issue37583> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27379] SocketType changed in Python 3
hai shi added the comment: ping -- ___ Python tracker <https://bugs.python.org/issue27379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37775] update doc of compileall
Change by hai shi : -- keywords: +patch pull_requests: +14883 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15148 ___ Python tracker <https://bugs.python.org/issue37775> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37775] update doc of compileall
New submission from hai shi : due to https://github.com/python/cpython/commit/a6b3ec5b6d4f6387820fccc570eea08b9615620d, we need update invalidation_mode's value from py_compile.PycInvalidationMode.TIMESTAMP to None in compile_xx function. -- assignee: docs@python components: Documentation messages: 349120 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: update doc of compileall versions: Python 3.9 ___ Python tracker <https://bugs.python.org/issue37775> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19692] Rename Py_SAFE_DOWNCAST
hai shi added the comment: It's a big problem, no ability to answer this question :( -- ___ Python tracker <https://bugs.python.org/issue19692> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37681] warning: ‘no_sanitize_thread’
Change by hai shi : -- keywords: +patch pull_requests: +14843 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15096 ___ Python tracker <https://bugs.python.org/issue37681> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37681] warning: ‘no_sanitize_thread’
hai shi added the comment: I checked no_sanitize_thread in some gcc manual of different version. And looks the no_sanitize_thread from gcc 5.1.0 [3](not 4.8) [1] https://gcc.gnu.org/onlinedocs/gcc-4.9.3/gcc/Function-Attributes.html#Function-Attributes [2] https://gcc.gnu.org/onlinedocs/gcc-4.9.4/gcc/Function-Attributes.html#Function-Attributes [3] https://gcc.gnu.org/onlinedocs/gcc-5.1.0/gcc/Function-Attributes.html#Function-Attributes [4] https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Function-Attributes.html#Function-Attributes Alexey have some descr of TSAN in https://bugs.python.org/issue35204(Looks `GCC introduced TSan together with ASan in 4.8` is wrong) -- ___ Python tracker <https://bugs.python.org/issue37681> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)
hai shi added the comment: Looks the PR is confused. Make sure: one PR on one dev branch. -- ___ Python tracker <https://bugs.python.org/issue37752> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37752] Redundant Py_CHARMASK called in normalizestring(codecs.c)
hai shi added the comment: Good catch ;), try to fix it, thanks. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue37752> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37751] In codecs, function 'normalizestring' should convert both spaces and hyphens to underscores.
hai shi added the comment: Hm, there is a bit misleading between desc(https://github.com/python/cpython/blob/master/Python/codecs.c#L53) and the code (https://github.com/python/cpython/blob/master/Python/codecs.c#L74). -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue37751> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37750] PyBuffer_FromContiguous not documented
Change by hai shi : -- keywords: +patch pull_requests: +14837 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15091 ___ Python tracker <https://bugs.python.org/issue37750> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37750] PyBuffer_FromContiguous not documented
New submission from hai shi : as the title said. -- ___ Python tracker <https://bugs.python.org/issue37750> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37750] PyBuffer_FromContiguous not documented
Change by hai shi : -- assignee: docs@python components: Documentation nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: PyBuffer_FromContiguous not documented ___ Python tracker <https://bugs.python.org/issue37750> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19692] Rename Py_SAFE_DOWNCAST
hai shi added the comment: Rename Py_SAFE_DOWNCAST in PR_15090. In the C API: Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END should be removed or keep it due to compatibility? In the stdlib: Looks that it's not changed is ok. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue19692> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19692] Rename Py_SAFE_DOWNCAST
Change by hai shi : -- keywords: +patch pull_requests: +14835 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15090 ___ Python tracker <https://bugs.python.org/issue19692> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34697] ctypes: Crash if manually-created CField instance is used
hai shi added the comment: ping -- ___ Python tracker <https://bugs.python.org/issue34697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11654] errors in atexit hooks don't change process exit code
hai shi added the comment: as antoine said in https://bugs.python.org/issue1257, this bug should be closed;) -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue11654> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37681] warning: ‘no_sanitize_thread’
hai shi added the comment: thanks, Ronald. Let me check the process by the upstairs refs. -- ___ Python tracker <https://bugs.python.org/issue37681> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37681] warning: ‘no_sanitize_thread’
hai shi added the comment: I want to build the cpython of master. My platform and compiler info: Linux version 3.10.0-957.1.3.el7.x86_64 (mockbu...@kbuilder.bsys.centos.org) (gcc version 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC) ) #1 SMP Thu Nov 29 14:49:43 UTC 2018 Looks not all platform get this info. -- ___ Python tracker <https://bugs.python.org/issue37681> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34101] PyBuffer_GetPointer() not documented
Change by hai shi : -- keywords: +patch pull_requests: +14760 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14994 ___ Python tracker <https://bugs.python.org/issue34101> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37698] Update doc of PyBuffer_ToContiguous
New submission from hai shi : Due to https://github.com/python/cpython/blob/master/Objects/memoryobject.c#L985, order could be 'A' in PyBuffer_ToContiguous() -- assignee: docs@python components: Documentation messages: 348585 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Update doc of PyBuffer_ToContiguous ___ Python tracker <https://bugs.python.org/issue37698> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37698] Update doc of PyBuffer_ToContiguous
Change by hai shi : -- keywords: +patch pull_requests: +14758 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14992 ___ Python tracker <https://bugs.python.org/issue37698> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33439] python-config.py should be part of the stdlib
hai shi added the comment: En, looks like just only makefile would call python-config.py. IMHO, if no out user call this script, looks it move to stdlib would be better. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue33439> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37689] Add Path.is_relative_to()
hai shi added the comment: Hi, Antoine, pls review this PR if you have free time. Looks is_relative_to only catch valueError is good enough. -- ___ Python tracker <https://bugs.python.org/issue37689> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37689] Add Path.is_relative_to()
Change by hai shi : -- keywords: +patch pull_requests: +14749 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14982 ___ Python tracker <https://bugs.python.org/issue37689> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37689] Add Path.is_relative_to()
hai shi added the comment: antoine, let me try it;) -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue37689> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37681] warning: ‘no_sanitize_thread’
New submission from hai shi : When I build cpython, I got this error: Objects/obmalloc.c:1414:1: warning: ‘no_sanitize_thread’ attribute directive ignored [-Wattributes] { ^ I removed the _Py_NO_SANITIZE_THREAD and build again, this warning dismissed. not sure ASAN、TSAN and MSAN have some inner relation? -- components: Build messages: 348441 nosy: shihai1991 priority: normal severity: normal status: open title: warning: ‘no_sanitize_thread’ ___ Python tracker <https://bugs.python.org/issue37681> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36692] Unexpected stderr output from test_sys_settrace
hai shi added the comment: It looks like setstrace function trigger this codeline: https://github.com/python/cpython/blob/master/Modules/_asynciomodule.c#L2618 Looks we can use set_exception_handler() to catch this error, but i am not sure it is worth catching this error through adding a extended exception hander. so, Nick, what's your thought? REF: https://github.com/python/cpython/blob/master/Lib/asyncio/base_events.py#L1627 -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue36692> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19113] duplicate test names in Lib/ctypes/test/test_functions.py
hai shi added the comment: en, in python 3.8.0a3, I got those other error info: $ /home/shihai/workspace/cpython/python test_functions.py ERROR:root:code for hash md5 was not found. Traceback (most recent call last): File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 244, in globals()[__func_name] = __get_hash(__func_name) File "/home/shihai/workspace/cpython/Lib/hashlib.py", line 113, in __get_builtin_constructor raise ValueError('unsupported hash type ' + name) ValueError: unsupported hash type md5 but in master branch, the test case is ok. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue19113> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34697] ctypes: Crash if manually-created CField instance is used
hai shi added the comment: I have try to cancel this PyCField_new function, but i am not sure I haven't break the code structure. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue34697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34697] ctypes: Crash if manually-created CField instance is used
Change by hai shi : -- keywords: +patch pull_requests: +14628 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14837 ___ Python tracker <https://bugs.python.org/issue34697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
hai shi added the comment: Thanks, copy that. -- ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
Change by hai shi : -- keywords: +patch pull_requests: +14592 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14796 ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
hai shi added the comment: Looks backend should be estimated before running unit tests. -- ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
New submission from hai shi : $ ./python -m unittest test.test_dtrace E == ERROR: setUpClass (test.test_dtrace.TraceTests) -- Traceback (most recent call last): File "/home/shihai/workspace/cpython/Lib/test/test_dtrace.py", line 110, in setUpClass self.backend.assert_usable() AttributeError: 'NoneType' object has no attribute 'assert_usable' -- Ran 0 tests in 0.008s FAILED (errors=1, skipped=4) -- components: Tests messages: 348029 nosy: shihai1991 priority: normal severity: normal status: open title: Improve test_dtrace.py ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29753] Ctypes Packing Bitfields Incorrectly - Linux
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue29753> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37583] Got a 113 error when running the test_socket
hai shi added the comment: sure, i copied the full output of test_socket. more failed test case looks like need add two property functions. -- Added file: https://bugs.python.org/file48480/test_socket_fail_info.txt ___ Python tracker <https://bugs.python.org/issue37583> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37590] Remove redundant docs of PyEval_EvalFrameEx
hai shi added the comment: Thanks, Steve -- ___ Python tracker <https://bugs.python.org/issue37590> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37590] Remove redundant docs of PyEval_EvalFrameEx
Change by hai shi : -- keywords: +patch pull_requests: +14560 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14765 ___ Python tracker <https://bugs.python.org/issue37590> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37590] Remove redundant docs of PyEval_EvalFrameEx
hai shi added the comment: sorry, the upstair's comment is wrong PyEval_EvalFrameEx have been updated. so remove redundant info:`It is literally 2000 lines long.` -- ___ Python tracker <https://bugs.python.org/issue37590> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37590] Remove redundant docs of PyEval_EvalFrameEx
New submission from hai shi : PyEval_EvalFrameEx have been updated. so remove redundant info in https://github.com/python/cpython/blob/master/Python/ceval.c#L733-L738 -- assignee: docs@python components: Documentation messages: 347874 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Remove redundant docs of PyEval_EvalFrameEx ___ Python tracker <https://bugs.python.org/issue37590> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37583] Got a 113 error when running the test_socket
hai shi added the comment: So I add this 113 error in `get_socket_conn_refused_errs` too ;) -- ___ Python tracker <https://bugs.python.org/issue37583> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37583] Got a 113 error when running the test_socket
Change by hai shi : -- keywords: +patch pull_requests: +14523 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14729 ___ Python tracker <https://bugs.python.org/issue37583> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37583] Got a 113 error when running the test_socket
New submission from hai shi : When I run test_socket.py, I got a error. Looks it's a problem of security group. My env: a vm of centos May be I need add `EHOSTUNREACH` in support.get_socket_conn_refused_errs()? == FAIL: test_create_connection (test.test_socket.NetworkConnectionNoServer) -- Traceback (most recent call last): File "/home/shihai/workspace/cpython/Lib/test/test_socket.py", line 4961, in test_create_connection self.assertIn(cm.exception.errno, expected_errnos) AssertionError: 113 not found in [111, 101, 99, 97] -- Ran 814 tests in 25.929s FAILED (failures=1, errors=117, skipped=197) -- components: Tests messages: 347786 nosy: shihai1991 priority: normal severity: normal status: open title: Got a 113 error when running the test_socket ___ Python tracker <https://bugs.python.org/issue37583> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37566] Remove redudant code in socket.py
Change by hai shi : -- keywords: +patch pull_requests: +14511 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14711 ___ Python tracker <https://bugs.python.org/issue37566> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37566] Remove redudant code in socket.py
New submission from hai shi : Looks like the _realsocket in socket.py is redudnat. But I am not sure somebody would use it or not. REF: https://github.com/python/cpython/blob/master/Lib/socket.py#L107 -- components: Library (Lib) messages: 347692 nosy: shihai1991 priority: normal severity: normal status: open title: Remove redudant code in socket.py ___ Python tracker <https://bugs.python.org/issue37566> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27379] SocketType changed in Python 3
hai shi added the comment: In order to keep back compatible, I would prefer to update SocketType ;) -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue27379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27379] SocketType changed in Python 3
Change by hai shi : -- keywords: +patch pull_requests: +14510 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14710 ___ Python tracker <https://bugs.python.org/issue27379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34697] ctypes: Crash if manually-created CField instance is used
Change by hai shi : -- nosy: -shihai1991 ___ Python tracker <https://bugs.python.org/issue34697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34697] ctypes: Crash if manually-created CField instance is used
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue34697> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37187] CField.size from the ctypes module does not behave as documented on bitfields
Change by hai shi : -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue37187> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27679] set_bitfields() unused in _ctypes_test
Change by hai shi : -- nosy: +shihai1991 versions: -Python 3.6 ___ Python tracker <https://bugs.python.org/issue27679> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27679] set_bitfields() unused in _ctypes_test
Change by hai shi : -- keywords: +patch pull_requests: +14459 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14648 ___ Python tracker <https://bugs.python.org/issue27679> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37187] CField.size from the ctypes module does not behave as documented on bitfields
Change by hai shi : -- keywords: +patch pull_requests: +14458 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14647 ___ Python tracker <https://bugs.python.org/issue37187> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
hai shi added the comment: or the value error replace type error in struct_init(). -- ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
Change by hai shi : -- keywords: +patch pull_requests: +14429 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14615 ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
New submission from hai shi : Python 3.9.0a0 (heads/master-dirty:80097e0, Jul 6 2019, 02:14:54) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from ctypes import * >>> class POINT(Structure): ... _fields_ = [("x", c_int), ... ("y", c_int)] ... >>> POINT(1, 2, 3) Traceback (most recent call last): File "", line 1, in TypeError: too many initializers and the init function in: https://github.com/python/cpython/blob/master/Modules/_ctypes/_ctypes.c#L4335 -- assignee: docs@python components: Documentation messages: 347419 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Fix a type error in ctypes.rst ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30090] Failed to build these modules: _ctypes
hai shi added the comment: In centos, `sudo yum install -y libffi libffi-devel` should worked -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue30090> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37508] A wrong return type in memory.rst
Change by hai shi : -- keywords: +patch pull_requests: +14419 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14604 ___ Python tracker <https://bugs.python.org/issue37508> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37508] A wrong return type in memory.rst
New submission from hai shi : the result should be a bytes object in #L70 in https://github.com/python/cpython/blob/master/Doc/c-api/memory.rst -- assignee: docs@python components: Documentation messages: 347356 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: A wrong return type in memory.rst ___ Python tracker <https://bugs.python.org/issue37508> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37411] testEnviron (test.test_wsgiref.HandlerTests) fails when environment variable X is set
Change by hai shi : -- pull_requests: +14383 pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker <https://bugs.python.org/issue37411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37411] testEnviron (test.test_wsgiref.HandlerTests) fails when environment variable X is set
Change by hai shi : -- pull_requests: +14375 pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker <https://bugs.python.org/issue37411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
Change by hai shi : -- keywords: +patch pull_requests: +14344 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14531 ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
New submission from hai shi : As title, Adding a unit test of unicode in test_unicode.py. -- components: Tests messages: 347059 nosy: shihai1991 priority: normal severity: normal status: open title: Adding a unit test of unicode in test_unicode.py ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37451] Remove redudant test code in _testcapimodule.c
Change by hai shi : -- keywords: +patch pull_requests: +14300 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14483 ___ Python tracker <https://bugs.python.org/issue37451> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37451] Remove redudant test code in _testcapimodule.c
New submission from hai shi : the code in https://github.com/python/cpython/blob/master/Objects/unicodeobject.c#L3163-L3165 looks redundant, due to https://github.com/python/cpython/blob/master/Objects/unicodeobject.c#L3163-L3165 -- messages: 346923 nosy: shihai1991 priority: normal severity: normal status: open title: Remove redudant test code in _testcapimodule.c ___ Python tracker <https://bugs.python.org/issue37451> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
Change by hai shi : -- keywords: +patch pull_requests: +14270 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37411] testEnviron (test.test_wsgiref.HandlerTests) fails when environment variable X is set
Change by hai shi : -- pull_requests: +14269 pull_request: https://github.com/python/cpython/pull/14453 ___ Python tracker <https://bugs.python.org/issue37411> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
New submission from hai shi : Due to https://github.com/python/cpython/blob/master/Python/errors.c#L845-L846, `PyObject* PyErr_SetImportErrorSubclass(PyObject *msg, PyObject *name, PyObject *path)` should be `PyObject* PyErr_SetImportErrorSubclass(PyObject *exception, PyObject *msg, PyObject *name, PyObject *path)` -- assignee: docs@python components: Documentation messages: 346836 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Fix a param error in exceptions.rst type: behavior ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37432] Fix a small param type in allocation.rst
Change by hai shi : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37432] Fix a small param type in allocation.rst
hai shi added the comment: Due to https://github.com/python/cpython/blob/master/Include/objimpl.h#L102, `void PyObject_Del(PyObject *op)` should be `void PyObject_Del(void *op)` -- ___ Python tracker <https://bugs.python.org/issue37432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37432] Fix a small param type in allocation.rst
Change by hai shi : -- keywords: +patch pull_requests: +14246 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14430 ___ Python tracker <https://bugs.python.org/issue37432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37432] Fix a small param type in allocation.rst
Change by hai shi : -- title: Fix a small param type allocation.rst -> Fix a small param type in allocation.rst ___ Python tracker <https://bugs.python.org/issue37432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37432] Fix a small param type allocation.rst
Change by hai shi : -- assignee: docs@python components: Documentation nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Fix a small param type allocation.rst type: behavior ___ Python tracker <https://bugs.python.org/issue37432> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37375] Fix a code style in dictobject.c
hai shi added the comment: Thanks, got it. -- ___ Python tracker <https://bugs.python.org/issue37375> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18299] Change script_helper to use universal_newlines=True in _assert_python
Change by hai shi : -- nosy: -shihai1991 ___ Python tracker <https://bugs.python.org/issue18299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37377] unicode error should raise a value error
hai shi added the comment: Got it, thank for your detailed explanation, steven. -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37377> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37377] unicode error should raise a value error
New submission from hai shi : >>> "\x1" File "", line 1 SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 0-2: truncated \xXX escape I think rasing the valueError would be exact.(pep223 agree this behavior: https://www.python.org/dev/peps/pep-0223/#bdfl-pronouncements). And I think the error type could be changed in: https://github.com/python/cpython/blob/master/Python/ast.c#L682 -- components: Interpreter Core messages: 346321 nosy: shihai1991 priority: normal severity: normal status: open title: unicode error should raise a value error type: behavior ___ Python tracker <https://bugs.python.org/issue37377> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37375] Fix a code style in dictobject.c
New submission from hai shi : # A small code style question: PyDictObject*mp should add a space:) PyDictObject *mp = (PyDictObject *)op -- ___ Python tracker <https://bugs.python.org/issue37375> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37375] Fix a code style in dictobject.c
Change by hai shi : -- keywords: +patch pull_requests: +14141 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14317 ___ Python tracker <https://bugs.python.org/issue37375> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37375] Fix a code style in dictobject.c
Change by hai shi : -- components: Interpreter Core nosy: shihai1991 priority: normal severity: normal status: open title: Fix a code style in dictobject.c ___ Python tracker <https://bugs.python.org/issue37375> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37342] A type error in typeobj.rst
Change by hai shi : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37342> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37342] A type error in typeobj.rst
Change by hai shi : -- keywords: +patch pull_requests: +14076 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14241 ___ Python tracker <https://bugs.python.org/issue37342> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37342] A type error in typeobj.rst
New submission from hai shi : nb_index's type is unaryfunc -- assignee: docs@python components: Documentation messages: 346071 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: A type error in typeobj.rst ___ Python tracker <https://bugs.python.org/issue37342> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37304] compiler need support in(de)crement operation or all of it should have syntax error.
hai shi added the comment: got it, Eric -- ___ Python tracker <https://bugs.python.org/issue37304> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37304] compiler need support in(de)crement operation or all of it should have syntax error.
hai shi added the comment: Thank for your suggestion,Steven. If python can not support post-increment and -decrement operators now, i think ++i should raise syntax error as i++. -- ___ Python tracker <https://bugs.python.org/issue37304> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37304] compiler need support in(de)crement operation or all of it should have syntax error.
New submission from hai shi : compiler need support unary operation of in(de)crement or all of it should have syntax error.I have found many user have confused about it(such as:https://stackoverflow.com/questions/2632677/python-integer-incrementing-with). Of course, it is a big change of grammar and it need core developer team to make decision. If core developer team support it, i will try my best to do it;) The behavior is: $ ./python Python 3.8.0a4+ (heads/master:e225beb, Jun 4 2019, 00:35:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> i = 1; >>> ++i 1 >>> i++ File "", line 1 i++ ^ SyntaxError: invalid syntax -- components: Interpreter Core messages: 345738 nosy: shihai1991 priority: normal severity: normal status: open title: compiler need support in(de)crement operation or all of it should have syntax error. type: behavior ___ Python tracker <https://bugs.python.org/issue37304> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37300] a Py_XINCREF in classobject.c are not necessary
New submission from hai shi : a Py_XINCREF in classobject.c are not necessary -- ___ Python tracker <https://bugs.python.org/issue37300> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37300] a Py_XINCREF in classobject.c are not necessary
Change by hai shi : -- keywords: +patch pull_requests: +13969 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14120 ___ Python tracker <https://bugs.python.org/issue37300> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37300] a Py_XINCREF in classobject.c are not necessary
Change by hai shi : -- components: Interpreter Core nosy: shihai1991 priority: normal severity: normal status: open title: a Py_XINCREF in classobject.c are not necessary type: enhancement ___ Python tracker <https://bugs.python.org/issue37300> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18299] Change script_helper to use universal_newlines=True in _assert_python
hai shi added the comment: spawn_python in script_helper is good enough, so this bug looks like cloud be closed. -- ___ Python tracker <https://bugs.python.org/issue18299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18299] Change script_helper to use universal_newlines=True in _assert_python
Change by hai shi : -- pull_requests: +13781 pull_request: https://github.com/python/cpython/pull/13908 ___ Python tracker <https://bugs.python.org/issue18299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18299] Change script_helper to use universal_newlines=True in _assert_python
Change by hai shi : -- keywords: +patch pull_requests: +13724 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/13847 ___ Python tracker <https://bugs.python.org/issue18299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18299] Change script_helper to use universal_newlines=True in _assert_python
hai shi added the comment: >it's a pain to extend the API (I don't want to use yet another __xxx custom >keyword) Adding __xxx in run_python_until_end function would increase the complexity but it looks like a unified function. -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue18299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33071] Document that PyPI no longer requires 'register'
hai shi added the comment: I think you are right, so i remain meaningful intro. Anyone else has an thought? -- versions: -Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue33071> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33071] Document that PyPI no longer requires 'register'
hai shi added the comment: hi, everyone. I am a freshman,so let me do it from easy issues:) -- nosy: +shihai1991 ___ Python tracker <https://bugs.python.org/issue33071> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33071] Document that PyPI no longer requires 'register'
Change by hai shi : -- pull_requests: +13491 stage: backport needed -> patch review pull_request: https://github.com/python/cpython/pull/13584 ___ Python tracker <https://bugs.python.org/issue33071> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com