Re: Using default a empty dictionary as a default value

[Peter Hansen]

C Gillespie wrote:
Dear All,
I ran my code through pylint to clean it up and one of the (many) errors it
through up was
Dangerous default value {} as argument
Bascially, I have:
class NewClass:
def __init__(self,  myDict={}):
for key, value in myDict:
print key, value
Obviously, this is not the way it should be done. Should I have a default
value of None for myDict and test for it? Or is there some other way?
If you *know* you will not be modifying the contents
of myDict, and you *know* you will not be modifying
the function in the future to do so, then it's
completely safe as written...
--
http://mail.python.org/mailman/listinfo/python-list

Re: Using default a empty dictionary as a default value

[SER.RI-TIC-Alexis Roda]

C Gillespie wrote:
Dear All,
I ran my code through pylint to clean it up and one of the (many) errors it
through up was
Dangerous default value {} as argument
Bascially, I have:
class NewClass:
def __init__(self,  myDict={}):
for key, value in myDict:
print key, value
Obviously, this is not the way it should be done. Should I have a default
value of None for myDict and test for it? Or is there some other way?
Take a look at:
http://www.python.org/doc/2.4/tut/node6.html#SECTION00671
look for "Important warning"
HTH
--
   
  (@ @)
oOO(_)OOo--
<>   Ojo por ojo y el mundo acabara ciego
/\ Alexis Roda - Universitat Rovira i Virgili - Reus, Tarragona (Spain)
---
--
http://mail.python.org/mailman/listinfo/python-list

Re: Using default a empty dictionary as a default value

[Diez B. Roggisch]

C Gillespie wrote:

> Dear All,
> I ran my code through pylint to clean it up and one of the (many) errors
> it through up was
> Dangerous default value {} as argument
> Bascially, I have:
> 
> class NewClass:
> def __init__(self,  myDict={}):
> for key, value in myDict:
> print key, value
> 
> Obviously, this is not the way it should be done. Should I have a default
> value of None for myDict and test for it? Or is there some other way?

Yes. That's the way to go.
-- 
Regards,

Diez B. Roggisch
-- 
http://mail.python.org/mailman/listinfo/python-list

Using default a empty dictionary as a default value

[C Gillespie]

Dear All,
I ran my code through pylint to clean it up and one of the (many) errors it
through up was
Dangerous default value {} as argument
Bascially, I have:

class NewClass:
def __init__(self,  myDict={}):
for key, value in myDict:
print key, value

Obviously, this is not the way it should be done. Should I have a default
value of None for myDict and test for it? Or is there some other way?

Thanks

Colin



-- 
http://mail.python.org/mailman/listinfo/python-list