[issue3778] python uninstaller leave registry entries

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> out of date
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Irit Katriel]

Change by Irit Katriel :


--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

leave

[flaskee via Python-list]

Sent with [ProtonMail](https://protonmail.com/) Secure Email.
-- 
https://mail.python.org/mailman/listinfo/python-list

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, Kevin! ✨  ✨

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Łukasz Langa]

Change by Łukasz Langa :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset f514addfbc637a42549ddc422b35b6caad2a4363 by Miss Islington (bot) 
in branch '3.10':
bpo-44514: Add doctest testcleanup for configparser and bz2 (GH-26909) 
(GH-27112)
https://github.com/python/cpython/commit/f514addfbc637a42549ddc422b35b6caad2a4363


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 105e6cd67cc793c971b3e83daa87d36516fcba28 by Miss Islington (bot) 
in branch '3.9':
bpo-44514: Add doctest testcleanup for configparser and bz2 (GH-26909) (#27111)
https://github.com/python/cpython/commit/105e6cd67cc793c971b3e83daa87d36516fcba28


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 3.0 -> 4.0
pull_requests: +25658
pull_request: https://github.com/python/cpython/pull/27111

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[miss-islington]

Change by miss-islington :


--
pull_requests: +25659
pull_request: https://github.com/python/cpython/pull/27112

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 48a5aa7f128caf5a46e4326c1fd285cd5fc8e59d by Kevin Follstad in 
branch 'main':
bpo-44514: Add doctest testcleanup for configparser and bz2 (#26909)
https://github.com/python/cpython/commit/48a5aa7f128caf5a46e4326c1fd285cd5fc8e59d


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Kevin Follstad]

Change by Kevin Follstad :


--
keywords: +patch
pull_requests: +25485
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26909

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44514] configparser.rst & bz2.rst leave temp files after 'make doctest'

[Kevin Follstad]

New submission from Kevin Follstad :

Both Docs/library/configparser.rst and Docs/library/bz2.rst create untracked 
temp files on the filesystem when 'make doctest' is run because testcleanup 
directives are absent in these files.

--
assignee: docs@python
components: Documentation
messages: 396541
nosy: docs@python, kfollstad
priority: normal
severity: normal
status: open
title: configparser.rst & bz2.rst leave temp files after 'make doctest'
type: behavior
versions: Python 3.10, Python 3.11, Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue44514>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38246] pathlib.resolve and .absolute leave trailing tilde in home expansion

[Andrea Bergonzo]

Change by Andrea Bergonzo :


--
nosy: +andybergon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38246] pathlib.resolve and .absolute leave trailing tilde in home expansion

[Eryk Sun]

Eryk Sun  added the comment:

Only Path.expanduser() special cases tilde as a POSIX shell would. Otherwise 
"~" is not a reserved filename character in POSIX. Path('~') is a file named 
"~" that's relative to the current working directory. By coincidence the 
working directory is the user's home directory in your example.

--
nosy: +eryksun
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38246] pathlib.resolve and .absolute leave trailing tilde in home expansion

[Infrasonics]

New submission from Infrasonics :

`Path('~').resolve()` gives `PosixPath('/home/youruser/~')`.
Same problem for `.absolute`, yet `.expanduser` works correctly.

--
components: Library (Lib)
messages: 352954
nosy: Infrasonics
priority: normal
severity: normal
status: open
title: pathlib.resolve and .absolute leave trailing tilde in home expansion
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 
<https://bugs.python.org/issue38246>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:


New changeset bcfbbd704646622e919c1306a91fba61d603483d by Victor Stinner in 
branch 'master':
bpo-36945: Add _PyPreConfig.configure_locale (GH-13368)
https://github.com/python/cpython/commit/bcfbbd704646622e919c1306a91fba61d603483d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[Steve Dower]

Steve Dower  added the comment:

> I suggest to move this discussion on the WIP PR of 4th version of my PEP

I prefer to keep it on the issue tracker where it doesn't disappear when merged 
and I get proper notifications. (I want to make the most of getting good 
notifications of new comments before they get taken away :( )

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:

I asked on Twitter: "If you embed Python in your application, would you prefer 
Python to leave your locale unchanged?"

Mai Giménez replied: "I would like to."
https://twitter.com/maidotgimenez/status/1129357352774393856

Steve Dower wrote:
"I think this should be opt-in, not opt-out."

I count at least two users who would like to get such option, so my idea wasn't 
stupid :-)

I updated my PR and I plan to merge it soon.

--

___
Python tracker 
<https://bugs.python.org/issue36945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:

> Nice, these will be helpful. Probably a good thing to try out with some 
> embedders too, to see whether they're intuitive enough.

I suggest to move this discussion on the WIP PR of 4th version of my PEP:
https://github.com/python/peps/pull/1056

I will reply you there :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[Steve Dower]

Steve Dower  added the comment:

> * customized Python interpreter: behaves as the "regular Python"

For this, why wouldn't we say "start by copying all the code in 
Programs/python.c"? Is there any reason why that file needs to only be one 
single call into Py_Main? Maybe there's some reason I'm not aware of...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[Steve Dower]

Steve Dower  added the comment:

> I have a very good news for you :-) Slowly but steadily, we converge on a 
> agreement ;-)

Yay! :)

> I added 2 functions …

Nice, these will be helpful. Probably a good thing to try out with some 
embedders too, to see whether they're intuitive enough.

(I promise I will get time to work on some code here soon, but right now I'm 
trying to get PEP 578 merged.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:

Steve:
> Imagine you're an existing application and you want to embed Python. Why 
> would you ever want it to suddenly change your global settings like this?

I have a very good news for you :-) Slowly but steadily, we converge on a 
agreement ;-)

The more time I spend on PEP 587, the more I think that the following use cases 
are too different and "incompatible":

* customized Python interpreter: behaves as the "regular Python"
* Embedded Python

I drafted "Isolate Python" in my PEP 587. With subtle options like 
configure_c_stdio, parse_argv and now configure_locale, it seems like we really 
need two *separated* these two configurations.

I implemented exactly that in PR 13388, I added 2 functions:

* _PyCoreConfig_InitPythonConfig(): provide a default configuration which 
parses command line arguments, enable UTF-8 Mode depending on the locale, read 
global configuration variables, read environment variables, etc.

* _PyCoreConfig_InitIsolateConfig(): isolated from the system, ignore command 
line arguments, ignore global configuration variables, leave the LC_CTYPE 
locale and C streams unchanged, etc.

I'm working on an update of my PEP to better describe that.

--

So I understand that this option is needed and you should prefer to turn it off 
by default in _PyCoreConfig_InitIsolateConfig.

--

___
Python tracker 
<https://bugs.python.org/issue36945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[Steve Dower]

Steve Dower  added the comment:

I think this should be opt-in, not opt-out.

Imagine you're an existing application and you want to embed Python. Why would 
you ever want it to suddenly change your global settings like this?

As a general rule, an embedded Python runtime should deal with all the settings 
it's been provided and not forcibly change *any* of them (though maybe the 
embedding application will discover bugs and have to update their entire 
application to deal with it - or switch to a language that isn't so demanding!).

For this specific case, it seems just as easy to opt-in by calling 
setlocale(LC_CTYPE, "") before initializing Python. We can recommend this in 
docs and do it ourselves in Py_Main, but I don't see why we'd add a specific 
option for configuring the user's C runtime.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:

> Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when 
> embedding Python

This parameter is similar the _PyCoreConfig.configure_c_stdio parameter that I 
just added. It allows to behave more as a "regular Python" or to better 
"isolate Python".

--

___
Python tracker 
<https://bugs.python.org/issue36945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

STINNER Victor  added the comment:

> I'm not sure if it's real issue in practice. Maybe users learnt how to 
> workaround this limitation.

I sent an email to capi-sig to get a feedback on this question :-)

https://mail.python.org/archives/list/capi-...@python.org/thread/KP2QNE4YITGJDZMZW5Y4EGIPZR2L6HRD/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +13278
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36945] Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged when embedding Python

[STINNER Victor]

New submission from STINNER Victor :

Py_Initiliaze() always call setlocale(LC_CTYPE, "") on all platforms to set the 
LC_CTYPE locale to the user preferred locale.

That's fine when Py_Main() is used: when Python is the only "owner" of a 
process.

I'm not sure that it's fine when Python is embedded into an application.

I propose to add _PyPreConfig.configure_locale: when set to 0, it leaves the 
LC_CTYPE locale unchanged. The caller is responsible to choose its favorite 
locale.

I'm not sure if it's real issue in practice. Maybe users learnt how to 
workaround this limitation.

By the way, I modified Python to always call setlocale(LC_CTYPE, "") on 
Windows, bpo-34485:

commit 177d921c8c03d30daa32994362023f777624b10d
Author: Victor Stinner 
Date:   Wed Aug 29 11:25:15 2018 +0200

bpo-34485, Windows: LC_CTYPE set to user preference (GH-8988)

On Windows, the LC_CTYPE is now set to the user preferred locale at
startup: _Py_SetLocaleFromEnv(LC_CTYPE) is now called during the
Python initialization. Previously, the LC_CTYPE locale was "C" at
startup, but changed when calling setlocale(LC_CTYPE, "") or
setlocale(LC_ALL, "").

pymain_read_conf() now also calls _Py_SetLocaleFromEnv(LC_CTYPE) to
behave as _Py_InitializeCore(). Moreover, it doesn't save/restore the
LC_ALL anymore.

On Windows, standard streams like sys.stdout now always use
surrogateescape error handler by default (ignore the locale).

This change caused a performance regression: bpo-35195 "[Windows] Python 3.7 
initializes LC_CTYPE locale at startup, causing performance issue on msvcrt 
isdigit()".

Attached PR implements proposed change.

--
components: Interpreter Core
messages: 342677
nosy: ncoghlan, steve.dower, twouters, vstinner
priority: normal
severity: normal
status: open
title: Add _PyPreConfig.configure_locale: allow to leave LC_CTYPE unchanged 
when embedding Python
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue36945>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Giampaolo Rodola']

Change by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[R. David Murray]

Change by R. David Murray :


--
resolution: duplicate -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[R. David Murray]

R. David Murray  added the comment:

Nick, what Jakub is saying is that 'with' hasn't even gotten involved yet: 
we're still executing the NamedTemporaryFile constructor, so the object hasn't 
been returned for 'with' to operate on yet.  In other words, 
NamedTemporaryFile.__init__ isn't safe against ctl-C when it calls _mkstemp, 
which is obvious by inspection since it isn't inside the try/except.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Nick Coghlan]

Nick Coghlan  added the comment:

It's still the same problem - the underlying issue is that the with statement 
machinery doesn't currently mask signals in the main thread while __enter__ and 
__exit__ are running, so __enter__ and __exit__ methods written in Python are 
also at risk of being interrupted at an inopportune point.

This means that even "with closing(open('filename')) as f: ..." is more at risk 
of leaving the file open until __del__ cleans it up than the version that calls 
open() directly.

So if this a concern that an application needs to worry about, then it 
currently needs to adopt a more complicated execution structure where:

1. The main thread launches a subthread that actually does all the work.
2. The main thread immediately drops into "active_thread.join()" (which can be 
interrupted by Ctrl-C)

Unfortunately, this scheme *doesn't* work for applications where the 
application itself needs to detect and handling signals other than Ctrl-C.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Jakub Wilk]

Jakub Wilk  added the comment:

I think issue29988 is unrelated, or at least not the whole story.

These are samples of tracebacks I see when the file is left behind:

  Traceback (most recent call last):
File "test-tmpfile.py", line 4, in 
  with tempfile.NamedTemporaryFile(dir='.'):
File "/opt/python/lib/python3.8/tempfile.py", line 548, in 
NamedTemporaryFile
  (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags, output_type)
File "/opt/python/lib/python3.8/tempfile.py", line 258, in _mkstemp_inner
  fd = _os.open(file, flags, 0o600)
  KeyboardInterrupt
  
  Traceback (most recent call last):
File "test-tmpfile.py", line 4, in 
  with tempfile.NamedTemporaryFile(dir='.'):
File "/opt/python/lib/python3.8/tempfile.py", line 548, in 
NamedTemporaryFile
  (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags, output_type)
File "/opt/python/lib/python3.8/tempfile.py", line 269, in _mkstemp_inner
  return (fd, _os.path.abspath(file))
File "/opt/python/lib/python3.8/posixpath.py", line 371, in abspath
  path = os.fspath(path)
  KeyboardInterrupt
  
  Traceback (most recent call last):
File "test-tmpfile.py", line 4, in 
  with tempfile.NamedTemporaryFile(dir='.'):
File "/opt/python/lib/python3.8/tempfile.py", line 548, in 
NamedTemporaryFile
  (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags, output_type)
File "/opt/python/lib/python3.8/tempfile.py", line 269, in _mkstemp_inner
  return (fd, _os.path.abspath(file))
File "/opt/python/lib/python3.8/posixpath.py", line 378, in abspath
  return normpath(path)
File "/opt/python/lib/python3.8/posixpath.py", line 355, in normpath
  if comp in (empty, dot):
  KeyboardInterrupt

In all cases the interrupt happened in the NamedTemporaryFile function,
so before __enter__/__exit__ would have chance to do its job.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Nick Coghlan]

Nick Coghlan  added the comment:

Aye, this is a specific case of the general issue noted in 
https://bugs.python.org/issue29988 (while it may be partially mitigated by 
https://bugs.python.org/issue32949, it isn't a guarantee)

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> with statements are not ensuring that __exit__ is called if 
__enter__ succeeds

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Nick, is this related to the bug where the "finally" portion of a context 
manager isn't guaranteed to be called?

--
nosy: +ncoghlan, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34157] NamedTemporaryFile can leave temporary files behind

[Jakub Wilk]

New submission from Jakub Wilk :

If you press Ctrl+C at the wrong moment, NamedTemporaryFile won't delete the
temporary file. To reproduce, you can try this script:

import tempfile
while True:
with tempfile.NamedTemporaryFile(dir='.'):
pass

I get a stray temporary file when I press Ctrl+C about 40% of the time.

--
components: Library (Lib)
messages: 321965
nosy: jwilk
priority: normal
severity: normal
status: open
title: NamedTemporaryFile can leave temporary files behind
type: behavior
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34157>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33666] os.errno gone absent without official leave (AWOL)

[STINNER Victor]

STINNER Victor  added the comment:

> If document disappearing of os.errno, we should document disappearing of all 
> other names in other modules in all versions.

Miro proposed to document the removal of os.errno since errno is a commonly 
used module, as the os module.

I don't think that the removal of other aliases are as important as that one.

By the way, os.errno has been removed by bpo-30152: PR 1269.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33666] os.errno gone absent without official leave (AWOL)

[STINNER Victor]

Change by STINNER Victor <vstin...@redhat.com>:


--
title: os.errno gone AWOL -> os.errno gone absent without official leave (AWOL)

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33666>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

Change by INADA Naoki :


--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

Change by INADA Naoki :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

Change by INADA Naoki :


--
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[miss-islington]

miss-islington  added the comment:


New changeset 9a90826c9b64183713ebe5a98ec82423d9cae3ee by Miss Islington (bot) 
in branch '3.6':
bpo-33199: Initialize ma_version_tag in PyDict_Copy (GH-6341)
https://github.com/python/cpython/commit/9a90826c9b64183713ebe5a98ec82423d9cae3ee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[miss-islington]

miss-islington  added the comment:


New changeset de755129a7a14cb3bee89aa256ca2e4a9a6605ce by Miss Islington (bot) 
in branch '3.7':
bpo-33199: Initialize ma_version_tag in PyDict_Copy (GH-6341)
https://github.com/python/cpython/commit/de755129a7a14cb3bee89aa256ca2e4a9a6605ce


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[miss-islington]

Change by miss-islington :


--
pull_requests: +6069

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[miss-islington]

Change by miss-islington :


--
pull_requests: +6068

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

INADA Naoki  added the comment:


New changeset d1c82c5cc7be0c21dddf86fd19c1702f6218459b by INADA Naoki in branch 
'master':
bpo-33199: Initialize ma_version_tag in PyDict_Copy (GH-6341)
https://github.com/python/cpython/commit/d1c82c5cc7be0c21dddf86fd19c1702f6218459b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

Change by INADA Naoki :


--
keywords: +patch
pull_requests: +6052
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[INADA Naoki]

Change by INADA Naoki :


--
versions:  -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[Antoine Pitrou]

Change by Antoine Pitrou :


--
nosy: +inada.naoki, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33199] PyDict_Copy() can leave 'ma_version_tag' uninitialized

[pdox]

New submission from pdox <p...@alum.mit.edu>:

PyDict_Copy leaves 'ma_version_tag' uninitialized when the dictionary being 
copied has a split table.

--
components: Interpreter Core
messages: 314768
nosy: pdox
priority: normal
severity: normal
status: open
title: PyDict_Copy() can leave 'ma_version_tag' uninitialized
type: behavior
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33199>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25577] os.path.dirname leave left quote and remove right one

[Zachary Ware]

Zachary Ware added the comment:

As far as os.path.dirname is concerned, you have a file named 'ciao.pdf"' in a 
directory called '"ciao/come/stai', which is what you're seeing. Since those 
are legal names, there's no way for os.path.dirname to know what you actually 
want. The solution is to handle the quotes yourself however you want.

--
nosy: +zach.ware
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25577] os.path.dirname leave left quote and remove right one

[Raffaele Mancuso]

New submission from Raffaele Mancuso:

Python 3.4.3 (default, Jun 29 2015, 12:16:01) 
[GCC 5.1.1 20150618 (Red Hat 5.1.1-4)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> dir = "\"ciao/come/stai/ciao.pdf\""
>>> dir
'"ciao/come/stai/ciao.pdf"'
>>> os.path.dirname(dir)
'"ciao/come/stai'

As you can see, dirname has removed the right quote, but not the left one.
The correct behaviour should be
'ciao/come/stai' (no quotes)
OR
'"ciao/come/stai"' (both quotes)
but never
'"ciao/come/stai' (only one quote)

This breaks other bash tools

--
components: Library (Lib)
messages: 254273
nosy: Raffaele Mancuso
priority: normal
severity: normal
status: open
title: os.path.dirname leave left quote and remove right one
versions: Python 3.4

___
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25577>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy:  -BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Re: When i leave a LineEdit widget and run slot

[Vincent Vande Vyvre]

Le 13/09/2013 02:33, Mohsen Pahlevanzadeh a écrit :

Dear all,

QtCore.QObject.connect(self.checkBox,
QtCore.SIGNAL(_fromUtf8(clicked(bool))), lambda:
self.interfaceCodesConstructor.setFilterList(self,name,self.lineEdit.text()))
I code pyqt, I have the following code:

///
QtCore.QObject.connect(self.checkBox,
QtCore.SIGNAL(_fromUtf8(clicked(bool))), lambda:
self.interfaceCodesConstructor.setFilterList(self,name,self.lineEdit.text()))
//

Abobe code causes When i click on checkbox, my function : setFilterList
will be run.

i need to run above function:
setFilterList(self,name,self.lineEdit.text()) When i leave a
LineEdit widget, But i don't know its signal.

My question is : What's its signal when you leave a widget such as
LineEdit?

Yours,
Mohsen



The signal editingFinished() is made for that.

http://pyqt.sourceforge.net/Docs/PyQt4/qlineedit.html#editingFinished

--
Vincent V.V.
Oqapy https://launchpad.net/oqapy . Qarte 
https://launchpad.net/qarte . PaQager https://launchpad.net/paqager

--
https://mail.python.org/mailman/listinfo/python-list

When i leave a LineEdit widget and run slot

[Mohsen Pahlevanzadeh]

Dear all,

QtCore.QObject.connect(self.checkBox,
QtCore.SIGNAL(_fromUtf8(clicked(bool))), lambda:
self.interfaceCodesConstructor.setFilterList(self,name,self.lineEdit.text()))
I code pyqt, I have the following code:

///
QtCore.QObject.connect(self.checkBox,
QtCore.SIGNAL(_fromUtf8(clicked(bool))), lambda:
self.interfaceCodesConstructor.setFilterList(self,name,self.lineEdit.text()))
//

Abobe code causes When i click on checkbox, my function : setFilterList
will be run.

i need to run above function:
setFilterList(self,name,self.lineEdit.text()) When i leave a
LineEdit widget, But i don't know its signal.

My question is : What's its signal when you leave a widget such as
LineEdit?

Yours,
Mohsen

-- 
https://mail.python.org/mailman/listinfo/python-list

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch which replace the open ... close idiom to the with open 
idiom in IDLE.

--
stage: commit review - patch review
Added file: http://bugs.python.org/file31144/idle_with_open.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch which replace the open ... close idiom to the with open 
idiom in IDLE.

--
Added file: http://bugs.python.org/file31145/idle_with_open.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Roundup Robot]

Roundup Robot added the comment:

New changeset e450e85e2075 by Terry Jan Reedy in branch '3.3':
Issue #18151: Replace remaining Idle 'open...close' pairs with 'with open'.
http://hg.python.org/cpython/rev/e450e85e2075

New changeset 7f6661a90d02 by Terry Jan Reedy in branch '2.7':
Issue #18151: Replace remaining Idle 'open...close' pairs with 'with open'.
http://hg.python.org/cpython/rev/7f6661a90d02

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Terry J. Reedy]

Terry J. Reedy added the comment:

Patch looked good, so I backported to 2.7 (attached, in case there are 
problems) and pushed.

--
assignee:  - terry.reedy
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed
Added file: http://bugs.python.org/file31158/idle_with_open-27.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Martin v . Löwis]

Martin v. Löwis added the comment:

Nobody has contributed a patch in five years, so it apparently is pretty hard.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3c0e8e910125 by Terry Jan Reedy in branch '2.7':
#18151, part 2: Silence debug build resource warning for each file opened by
http://hg.python.org/cpython/rev/3c0e8e910125

New changeset c541073173bb by Terry Jan Reedy in branch '3.3':
#18151, part 2: Silence debug build resource warning for each file opened by
http://hg.python.org/cpython/rev/c541073173bb

New changeset 1d67c0893719 by Terry Jan Reedy in branch 'default':
#18151 Merge from 3.3
http://hg.python.org/cpython/rev/1d67c0893719

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2fe64ce5da05 by Terry Jan Reedy in branch '3.3':
#18151, part 1: Backport idlelilb portion of Andrew Svetlov's 3.4 patch
http://hg.python.org/cpython/rev/2fe64ce5da05

New changeset 0be613638523 by Terry Jan Reedy in branch 'default':
#18151 null merge with 3.3.
http://hg.python.org/cpython/rev/0be613638523

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Terry J. Reedy]

New submission from Terry J. Reedy:

This issue is about uniformly updating the old idiom

try:
  f = open('file')
  use f)
  f.close()  # omitted at least in GrepDialog
except IOError as msg:
  ignore or display message

to the current idiom

try:
  with open('file') as f:
use f
except OSError as msg:  # still use IOError in 2.7
ignore or display message

#16715 changed 'IOError' to 'OSError' everywhere in Lib/* for 3.4 only.

I ran into this issue (again) because GrepDialog.Grepdialog.grep_it uses open 
without close. Consequently, with debug builds, 'Find in files' raises a 
ResourceWarning for each file opened. Because of the 3.4-only change, there 
will be a merge conflict.

To avoid this, now and in the future, I plan to backport the idlelib subset of 
the Svetlov's patch to 3.3 (it applied with only one fix).

Currently, all 3.x patches are being applied to both 3.3 and 3.4 and any 3.3 
patch with 'IOError' will have a merge conflict. Any 3.4 patch with 'OSError' 
will not apply to 3.3. There is no longer an issue with breaking 3.2 to 3.3 
merges. This change will break existing 3.3 patches with 'IOError', but they 
would break anyway on the merge.

--
components: IDLE
files: idle33.io2os.diff
keywords: patch
messages: 190718
nosy: Todd.Rovito, roger.serwy, terry.reedy
priority: normal
severity: normal
stage: commit review
status: open
title: Idlelib: update to with open ... except OSError  (in 2.7, leave 
IOError)
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4
Added file: http://bugs.python.org/file30485/idle33.io2os.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Terry J. Reedy]

Terry J. Reedy added the comment:

Here is the 'OS' version of the fix and update to grep_it. Change 'OS' to 'IO' 
on line 17 to apply to current 3.3, without the io2os patch.  Besides using 
'with', it iterates the files directly instead of iterating blocks of 
readlines. The two changes make the code simpler and cleaner. The changed 
summary looks better to me, besides avoiding the hit/hits problem.

As can be seen in the io2os patch, there are other opens to be updated in 
another patch.

OutputWindow.OutputWindow._file_line_helper has this one:
f = open(filename, r)
f.close()
which would become:
with open(filename, r): pass

This tests whether the filename extracted from a traceback or grep report is 
correct (can be opened). (Each of several patterns are tried until one works.) 
The opened file is discarded because the filename is returned to be passes to 
editwin's flist.open. I believe this could be replaced by an os.stat() call.

Backportint to 2.7 is the subject of #18152

--
keywords: +needs review
Added file: http://bugs.python.org/file30486/grep_it.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Please regenerate your patches without --git for review. Rietveld doesn't like 
git-style patches.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Terry J. Reedy]

Terry J. Reedy added the comment:

Serhiy: I don't care about patch style but I read somewhere that I 'should' set 
the hg options file to automatically produce git style diff. However, since the 
hg doc says that this setting does not affect pushes, I don't know why, and I 
cannot find where I read that. Is it obsolete? Are you suggesting that all 
patches should never be git style?

I turned git off and will leave it off until someone complains.

--
Added file: http://bugs.python.org/file30488/idle33.io2os.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Terry J. Reedy]

Changes by Terry J. Reedy tjre...@udel.edu:


Added file: http://bugs.python.org/file30489/grep_it.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18151] Idlelib: update to with open ... except OSError (in 2.7, leave IOError)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you. AFAIK you need git style diff only when moving/renaming files.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18151
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[anatoly techtonik]

anatoly techtonik added the comment:

What is the reason for not following the good practice? Is it so hard to fix?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Michael Foord]

Changes by Michael Foord mich...@voidspace.org.uk:


--
nosy:  -michael.foord

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Mark Lawrence]

Mark Lawrence added the comment:

I don't think this is worth the bother.  I've checked my registry and the only 
entry under HKLM\SOFTWARE\Python is PythonCore, under this are the following.

2.6
   Help
  Pythonwin Reference
 C:\Python26\Lib\site-packages\PyWin32.chm
   Modules
2.7
   Help
  Pythonwin Reference
 C:\Python27\Lib\site-packages\PyWin32.chm
   Modules
3.1
   Modules
3.2
   Modules
3.3
   Help
  Main Python Documentation
 C:\Python33\Doc\python331.chm
   Install Path
  Install Group
 Python 3.3
   Modules
   PythonPath
  C:\Python33\Lib;C:\Python33\DLLs

Only 3.3 is live on my machine.  Clearly the pythonwin keys aren't our 
responsibility.  It's hardly a lot of data anyway so why worry about it?  Yes 
I'm aware that it's good practice to clean up after yourself but in this case 
is it really worth the effort?

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Antoine Pitrou]

Antoine Pitrou added the comment:

Sorry for the delay. I am not sure I understand your concern here:

 If the user reads the exact amount of bytes the server sent, read() on  the 
 socket will never have a chance to return '' and inform the user
 about the connection termination.

Certainly read(), called once again, would return ''? That's how I understand 
your unit test anyway.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Eran Rundstein]

Eran Rundstein added the comment:

Hm, it's been a while and I'm no longer sure :(
You're right - since there is no length the user will have to call read() until 
he gets back ''. It's possible I forgot that assumption when speculating about 
this.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2186f7b99c28 by Antoine Pitrou in branch '2.7':
Issue #16298: In HTTPResponse.read(), close the socket when there is no 
Content-Length and the incoming stream is finished.
http://hg.python.org/cpython/rev/2186f7b99c28

New changeset b47d342c449b by Antoine Pitrou in branch '3.2':
Issue #16298: In HTTPResponse.read(), close the socket when there is no 
Content-Length and the incoming stream is finished.
http://hg.python.org/cpython/rev/b47d342c449b

New changeset 59358f991c00 by Antoine Pitrou in branch '3.3':
Issue #16298: In HTTPResponse.read(), close the socket when there is no 
Content-Length and the incoming stream is finished.
http://hg.python.org/cpython/rev/59358f991c00

New changeset 5d6c2c7bc5d4 by Antoine Pitrou in branch 'default':
Issue #16298: In HTTPResponse.read(), close the socket when there is no 
Content-Length and the incoming stream is finished.
http://hg.python.org/cpython/rev/5d6c2c7bc5d4

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Antoine Pitrou]

Antoine Pitrou added the comment:

Ok, the patch looked fine to me, so I've committed it to 2.7 and adapted it for 
3.x. Thank you!
By the way, it's probably easier to produce patches using Mercurial rather than 
using manual `diff`. You can have a look at the devguide for more information: 
http://docs.python.org/devguide/

--
resolution:  - fixed
stage: needs patch - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Eran Rundstein]

Eran Rundstein added the comment:

My pleasure.
I had no idea about the Mercurial patch, this is the first time I have 
submitted a Python bug report :)
I'll have a look.

Thanks for merging the fix!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Shivaram Lingamneni]

Changes by Shivaram Lingamneni sling...@cs.stanford.edu:


--
nosy: +slingamn

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Eran Rundstein]

Eran Rundstein added the comment:

Hello

I have attached a patch that includes a (slightly broken) fix and a test case. 
Note that there is currently an unresolved issue:
If the user reads the exact amount of bytes the server sent, read() on the 
socket will never have a chance to return '' and inform the user about the 
connection termination. This will also happen if the user reads more data than 
the server is sending. In that case, again, read() will not get called again so 
we will never know the socket is gone. One possible way to address this is 
perform the actual read() calls in a loop, attempting to read the exact amount 
the user specified. If we do this and the user attempts to read more bytes than 
the server sent, we will properly detect it. If, however, the user reads the 
exact length, then we still have a problem.

I am not sure what would be the correct way of solving this.

--
keywords: +patch
Added file: 
http://bugs.python.org/file27913/httplib-no-content-length-close-sock-fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Antoine Pitrou]

Antoine Pitrou added the comment:

 The patch is probably trivial - however I would still like some
 verification.
 Would it be correct to call self.close() when fp.read returns ''? In
 case self.length is not present, I don't see a way around this anyway.
 When it is present, and fp.read returns '', how should we go about
 that? We can either return less data, or raise an exception to
 indicate that the connection terminated prematurely.

It's probably better to return less data. No need to break user programs
when they download from a slightly misbehaved Web site.

The patch should include some kind of unit test, if possible. See
Lib/test/test_httplib.py.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Eran Rundstein]

Eran Rundstein added the comment:

The patch is probably trivial - however I would still like some verification.
Would it be correct to call self.close() when fp.read returns ''? In case 
self.length is not present, I don't see a way around this anyway. When it is 
present, and fp.read returns '', how should we go about that? We can either 
return less data, or raise an exception to indicate that the connection 
terminated prematurely.

Thanks

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Andrew Svetlov]

Andrew Svetlov added the comment:

Please publish patch for the issue.

--
nosy: +asvetlov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Eran Rundstein]

New submission from Eran Rundstein:

When calling HTTPResponse.read() on a response that is:
a. not chunked
b. contains no content-length header
the underlying socket (referenced by self.fp) will never get closed (through 
self.close())

The offending code is at the bottom of the read() function:
s = self.fp.read(amt)
if self.length is not None:
self.length -= len(s)
if not self.length:
self.close()
return s
As seen, if self.length is None, even when the server closes the connection 
(causing self.fp.read to return ''), the socket will not get closed.

btw, this may be the cause of Issue15633 (http://bugs.python.org/issue15633)

--
components: Library (Lib)
messages: 173505
nosy: eranrund
priority: normal
severity: normal
status: open
title: httplib.HTTPResponse.read could potentially leave the socket opened 
forever
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Piotr Dobrogost]

Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:


--
nosy: +piotr.dobrogost

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16298] httplib.HTTPResponse.read could potentially leave the socket opened forever

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +orsenthil, pitrou
stage:  - needs patch
versions: +Python 3.2, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16298
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Re: Your confirmation is required to leave the Python-list mailing list

[mhagbeng]

Le 05.06.2012 22:29, 
python-list-confirm+0ddf652b9a76d520bd9945a702f68cbf7a1d2...@python.org 
a écrit :

Mailing list removal confirmation notice for mailing list Python-list

We have received a request for the removal of your email address,
mhagb...@enib.fr from the python-list@python.org mailing list.  To
confirm that you want to be removed from this mailing list, simply
reply to this message, keeping the Subject: header intact.  Or visit
this web page:



http://mail.python.org/mailman/confirm/python-list/0ddf652b9a76d520bd9945a702f68cbf7a1d2cf0


Or include the following line -- and only the following line -- in a
message to python-list-requ...@python.org:

confirm 0ddf652b9a76d520bd9945a702f68cbf7a1d2cf0

Note that simply sending a `reply' to this message should work from
most mail readers, since that usually leaves the Subject: line in the
right form (additional Re: text in the Subject: is okay).

If you do not wish to be removed from this list, please simply
disregard this message.  If you think you are being maliciously
removed from the list, or have any other questions, send them to
python-list-ow...@python.org.


--
http://mail.python.org/mailman/listinfo/python-list

[issue14915] pysetup may leave a package in a half-installed state

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

IIUC checking trove classifiers / requires-python or something else before 
installing may be a good idea, but this bug is about something else: a project 
can be half-installed.  You could reproduce it with a Python 2 project with one 
file containing a syntax error (I think unittest2 is an example, see #10530).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14915
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14915] pysetup may leave a package in a half-installed state

[Alexis Metaireau]

Alexis Metaireau ale...@notmyidea.org added the comment:

Oh, a potential way to avoid this would be to check that the metadata 
have the python 3 trove classifier in it.

We could also add a way to force the installation even if the right 
classifier is not present with a special flag passed to the command 
line.

Does this sounds like an acceptable change to you?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14915
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14915] pysetup may leave a package in a half-installed state

[Nick Coghlan]

New submission from Nick Coghlan ncogh...@gmail.com:

Do make altinstall from trunk.

Try running pysetup3.3 install distutils2

This won't work properly, because distutils2 uses Python 2 syntax.

However, after running that command:

pysetup3.3 remove distutils2 complains that distutils2 is not installed, but 
import distutils2 works at the 3.3. command prompt

--
assignee: eric.araujo
components: Distutils2
messages: 161583
nosy: alexis, eric.araujo, ncoghlan, tarek
priority: high
severity: normal
status: open
title: pysetup may leave a package in a half-installed state
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14915
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14915] pysetup may leave a package in a half-installed state

[Tshepang Lekhonkhobe]

Changes by Tshepang Lekhonkhobe tshep...@gmail.com:


--
nosy: +tshepang

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14915
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Brian Curtin]

Changes by Brian Curtin cur...@acm.org:


--
nosy: +tebeka
versions:  -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

I think Installer has features to remove registry keys with no subkeys; we 
probably would need to declare that we create these keys, and then Installer 
might remove them automatically.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Michael Foord]

Michael Foord mich...@voidspace.org.uk added the comment:

Isn't there an issue around having multiple versions of Python installed? The 
top level folder should only be removed if the version of Python being 
uninstalled is the last installed Python. This means executing code on 
uninstall and doesn't seem worth the effort.  

If I'm correct in this then I would suggest closing as wontfix.

--
nosy: +michael.foord

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[anatoly techtonik]

anatoly techtonik techto...@gmail.com added the comment:

The top level should be removed only when it is empty after Python that is 
being uninstalled removed its own branch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[anatoly techtonik]

anatoly techtonik techto...@gmail.com added the comment:

There should be a function to remove key if empty.

BTW, what software is used to create (un)installer and where is Python code for 
it?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

See PC/_msi.c, Lib/msilib, and Tools/msi

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[anatoly techtonik]

anatoly techtonik techto...@gmail.com added the comment:

Confirmed 2.6.5 installer leaves HKLM\SOFTWARE\Python\PythonCore\2.6\Modules 
on install/uninstall without \2.6\ key.

I propose to mark it as 'low' priority.

--
nosy: +techtonik
versions: +Python 2.6, Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

I imagine this affects 3.1 and 3.2 as well, but I haven't added them to 
versions since that hasn't been confirmed.

--
keywords: +easy
nosy: +brian.curtin, loewis, r.david.murray
priority:  - low
stage:  - needs patch
type:  - behavior
versions:  -Python 2.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

Confirmed on 3.x.

--
versions: +Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3778
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com