[Python-modules-team] Bug#958669: "TypeError: can't concat str to bytes" in FileModifyCommand
Package: python3-fastimport
Version: 0.9.8-2
Severity: important
I tried to run "bzr fast-export" in lp:launchpad-buildd, and got the
following traceback:
11:31:38 Calculating the revisions to include ...
11:31:38 Starting export of 801 revisions ...
brz: ERROR: TypeError: can't concat str to bytes
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/breezy/commands.py", line 1016, in
exception_to_return_code
return the_callable(*args, **kwargs)
File "/usr/lib/python3/dist-packages/breezy/commands.py", line 1202, in
run_bzr
ret = run(*run_argv)
File "/usr/lib/python3/dist-packages/breezy/commands.py", line 759, in
run_argv_aliases
return self.run(**all_cmd_args)
File "/usr/lib/python3/dist-packages/breezy/commands.py", line 784, in run
return self._operation.run_simple(*args, **kwargs)
File "/usr/lib/python3/dist-packages/breezy/cleanup.py", line 136, in
run_simple
return _do_with_cleanups(
File "/usr/lib/python3/dist-packages/breezy/cleanup.py", line 166, in
_do_with_cleanups
result = func(*args, **kwargs)
File "/usr/lib/python3/dist-packages/breezy/plugins/fastimport/cmds.py", line
507, in run
return exporter.run()
File "/usr/lib/python3/dist-packages/breezy/plugins/fastimport/exporter.py",
line 253, in run
self.emit_commit(revid, self.ref)
File "/usr/lib/python3/dist-packages/breezy/plugins/fastimport/exporter.py",
line 372, in emit_commit
self.print_cmd(self._get_commit_command(ref, mark, revobj, file_cmds))
File "/usr/lib/python3/dist-packages/breezy/plugins/fastimport/exporter.py",
line 299, in print_cmd
self.outf.write(b"%s\n" % cmd)
File "/usr/lib/python3/dist-packages/fastimport/commands.py", line 189, in
__bytes__
return self.to_string(include_file_contents=True)
File "/usr/lib/python3/dist-packages/fastimport/commands.py", line 241, in
to_string
filecommands = b''.join([b'\n' + repr_bytes(c)
File "/usr/lib/python3/dist-packages/fastimport/commands.py", line 241, in
filecommands = b''.join([b'\n' + repr_bytes(c)
File "/usr/lib/python3/dist-packages/fastimport/helpers.py", line 120, in
repr_bytes
return bytes(obj)
File "/usr/lib/python3/dist-packages/fastimport/commands.py", line 367, in
__bytes__
return self.to_string(include_file_contents=True)
File "/usr/lib/python3/dist-packages/fastimport/commands.py", line 393, in
to_string
datastr = ('\ndata %d\n' % len(self.data)).encode('ascii') + self.data
TypeError: can't concat str to bytes
brz 3.0.2 on python 3.8.2 (Linux-5.4.0-21-generic-x86_64-with-glibc2.29)
arguments: ['/usr/bin/bzr', 'fast-export', '--export-marks=../git/marks']
plugins: bash_completion[3.0.2], changelog_merge[3.0.2],
commitfromnews[3.0.2], cvs[3.0.2], darcs[3.0.2], debian[3.0.0],
email[3.0.2], fastimport[3.0.2], launchpad[3.0.2], mtn[3.0.2],
netrc_credential_store[3.0.2], news_merge[3.0.2], po_merge[3.0.2],
propose[3.0.2], stats[3.0.2], upload[3.0.2], weave_fmt[3.0.2]
encoding: 'utf-8', fsenc: 'utf-8', lang: 'en_GB.UTF-8'
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https://bugs.launchpad.net/brz/+filebug
including this traceback and a description of the problem.
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.4.0-21-generic (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8),
LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: unable to detect
Versions of packages python3-fastimport depends on:
ii python3 3.8.2-3
python3-fastimport recommends no packages.
Versions of packages python3-fastimport suggests:
ii git [git-core] 1:2.26.2-1
-- no debconf information
--
Colin Watson [cjwat...@debian.org]
___
Python-modules-team mailing list
Python-modules-team@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#950038: Looks like a bug in httplib2 rather than on wsgi-intercept
Control: reassign -1 python-wsgi-intercept 1.8.1-2 Control: clone -1 -2 Control: reassign -2 python3-httplib2 0.14.0-1 Control: retitle -2 python3-httplib2 >= 1.13.0 breaks python3-wsgi-intercept << 1.9.0 Control: block -2 by -1 On Tue, Feb 11, 2020 at 11:43:03PM +0100, Andreas Beckmann wrote: > I have a little trouble getting what you mean here: > > On Mon, 10 Feb 2020 17:52:33 +0100 =?UTF-8?Q?H=c3=a5vard_Flaget_Aasen?= > wrote: > > Though they write that the change was indeed in the httplib2 package. > > * the change that introduced the bug > * the change that fixed the bug (is there an embedded copy of httplib2 > somewhere?) > * both ? wsgi-intercept reimplements a bit of httplib2's interface in order to intercept calls to it. Until version 1.9.0, the way it did so violated httplib2's reasonable expectations of its own interface, that is, that httplib2 could reasonably add more keyword arguments to its own classes' __init__ methods. This is a perfectly normal way to extend interfaces in Python, and it only broke because wsgi-intercept was making unwarranted assumptions. https://github.com/cdent/wsgi-intercept/commit/c4d44f5712e85d302db7e80e16156ca9c501bb6b (in part) fixes this by ignoring those extra keyword arguments for the purpose of interception, which indeed seems sensible since details of TLS versions aren't very relevant when you're writing tests that intercept network calls and redirect them to a WSGI application. So, I disagree with Thomas that this is principally a bug in httplib2, and I'm reassigning it back to wsgi-intercept. The main part of the fix should be to upgrade wsgi-intercept to 1.9.0 or newer. However, it would probably be appropriate for python3-httplib2 to declare a Breaks on python3-wsgi-intercept (<< 1.9.0) once a fixed version exists in the archive, so I'm cloning a part of this bug for that. -- Colin Watson [cjwat...@debian.org] ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] Comments regarding storm_0.22-2_multi.changes
On Wed, Dec 25, 2019 at 06:33:15PM +, Thorsten Alteholz wrote: > I marked the package for accept, but our hardworking trainees left a note: > > copyright years need updating to include (at least) 2014. Fixed in 0.22-3, thanks. -- Colin Watson [cjwat...@debian.org] ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#922259: python-libnacl: FTBFS (ValueError: byte must be in range(0, 256))
Control: forwarded -1 https://github.com/saltstack/libnacl/pull/115 On Wed, Apr 03, 2019 at 11:06:24PM +0200, Santiago Vila wrote: > > == > > ERROR: test_verify32 (unit.test_verify.TestVerify) > > -- > > Traceback (most recent call last): > > File > > "/<>/.pybuild/cpython3_3.7_libnacl/build/tests/unit/test_verify.py", > > line 30, in test_verify32 > > v32x[libnacl.randombytes_random() & 31] += 1 > > ValueError: byte must be in range(0, 256) > > Hi. This is still happening (randomly) on reproducible-builds. > > I could offer ssh access to a machine where this randomness is > reproducible, but I believe the randomness is intrisic to the > (wrongly designed) test and maybe it happens on any machine > as far as you try enough times. > > Can you execute test_verify32 in a loop and report if it fails > randomly or not for you? (Or tell me the way to do it). Indeed, it's easy to reproduce that way. I tracked this down and proposed a fix upstream: https://github.com/saltstack/libnacl/pull/115 Thanks, -- Colin Watson [cjwat...@debian.org] ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#936712: Temporarily reverted
Control: found -1 httmock/1.3.0-3 Control: block -1 by 937788 Control: affects 937788 src:httmock I've temporarily reverted the removal of python-httmock until #937788 is fixed. -- Colin Watson [cjwat...@debian.org] ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
