Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Dears, going through the list of commits in pymodbus upstream, I wonder if we should just package the latest version. Yes, I know, it is late in the freeze process, but e.g. official Python 3.11 support went in with release 3.1.0, not before. Most other changes are bug fixes or trivial to small changes. I don't see any huge, new features nor a redesign or similar dangerous changes. What do you think? Cheers ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Hi Joe, > Attached is a patch from the commit in pymodbus. As I said, it's a trivial. > Thanks, As Martin mentioned, could you fill a bug? Cheers, Emmanuel ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Hi Emmanuel, On 21/02/2023 13:53, Emmanuel Arias wrote: On Tue, Feb 21, 2023 at 08:59:47AM +, Joe Burmeister wrote: Hi Emmanuel, On 21/02/2023 06:00, Emmanuel Arias wrote: Hi On Tue, Feb 14, 2023 at 05:52:46PM +, Joe Burmeister wrote: Hi There is a silly bug I fixed in the pymodbus shipped for Testing, and I know Testing is coming up to frozen. https://github.com/pymodbus-dev/pymodbus/commit/e924e713ad96a420c9df60605ee49a0d9c451e2a Perhaps, Is there any chance to apply this patch? Sure. As you can see, it's really simple mistake and fix. I don't have the details of this package. But as you mentioned seems to be simple, but we are in the freezing period. I cc to the uploaders to take that decision. BTW, you can propose a patch, and take a look that is all ok with this bug fix in Debian. Attached is a patch from the commit in pymodbus. As I said, it's a trivial. Cheers, Emmanuel Cheers, Emmanuel Cheers, Joe Cheers, Joe From e924e713ad96a420c9df60605ee49a0d9c451e2a Mon Sep 17 00:00:00 2001 From: Joe Burmeister Date: Fri, 14 Oct 2022 15:23:18 +0100 Subject: [PATCH] Bugfix ModbusSerialServer setup so handler is called correctly. (#1113) Signed-off-by: Joe Burmeister --- pymodbus/server/async_io.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pymodbus/server/async_io.py b/pymodbus/server/async_io.py index bda7765..2ae1992 100755 --- a/pymodbus/server/async_io.py +++ b/pymodbus/server/async_io.py @@ -841,7 +841,7 @@ class ModbusSerialServer: # pylint: disable=too-many-instance-attributes try: self.transport, self.protocol = await create_serial_connection( asyncio.get_event_loop(), -self.handler(self), +lambda: self.handler(self), self.device, baudrate=self.baudrate, bytesize=self.bytesize, -- 2.39.1 OpenPGP_0xCC6911B1B94B954D.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Dears, On 2023-02-21 10:53, Emmanuel Arias wrote: > I don't have the details of this package. But as you mentioned seems to > be simple, but we are in the freezing period. > > I cc to the uploaders to take that decision. > > BTW, you can propose a patch, and take a look that is all ok with this > bug fix in Debian. IMHO, this is clearly a patch suitable for Debian 12. Please everybody in the Python team feel free to do a team upload! I can do it, too, but not before very late tonight. Is there a Debian bug number? If not, please submit one for reference! Thanks! ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
On Tue, Feb 21, 2023 at 08:59:47AM +, Joe Burmeister wrote: > Hi Emmanuel, > > On 21/02/2023 06:00, Emmanuel Arias wrote: > > Hi > > > > On Tue, Feb 14, 2023 at 05:52:46PM +, Joe Burmeister wrote: > > > Hi > > > > > > There is a silly bug I fixed in the pymodbus shipped for Testing, and I > > > know > > > Testing is coming up to frozen. > > > > > > https://github.com/pymodbus-dev/pymodbus/commit/e924e713ad96a420c9df60605ee49a0d9c451e2a > > Perhaps, Is there any chance to apply this patch? > > Sure. As you can see, it's really simple mistake and fix. I don't have the details of this package. But as you mentioned seems to be simple, but we are in the freezing period. I cc to the uploaders to take that decision. BTW, you can propose a patch, and take a look that is all ok with this bug fix in Debian. Cheers, Emmanuel > > > > Cheers, > > Emmanuel > > Cheers, > > Joe > > signature.asc Description: PGP signature ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Hi Emmanuel, On 21/02/2023 06:00, Emmanuel Arias wrote: Hi On Tue, Feb 14, 2023 at 05:52:46PM +, Joe Burmeister wrote: Hi There is a silly bug I fixed in the pymodbus shipped for Testing, and I know Testing is coming up to frozen. https://github.com/pymodbus-dev/pymodbus/commit/e924e713ad96a420c9df60605ee49a0d9c451e2a Perhaps, Is there any chance to apply this patch? Sure. As you can see, it's really simple mistake and fix. Cheers, Emmanuel Cheers, Joe OpenPGP_0xCC6911B1B94B954D.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
Re: [Python-modules-team] python3-pymodbus 3.0.0-6
Hi On Tue, Feb 14, 2023 at 05:52:46PM +, Joe Burmeister wrote: > Hi > > There is a silly bug I fixed in the pymodbus shipped for Testing, and I know > Testing is coming up to frozen. > > https://github.com/pymodbus-dev/pymodbus/commit/e924e713ad96a420c9df60605ee49a0d9c451e2a Perhaps, Is there any chance to apply this patch? > > The up shot of this bug is that using pymodbus for a server over serial > doesn't work. > > Any chance a slightly newer version could go into the freeze? > > Cheers, > > Joe Cheers, Emmanuel signature.asc Description: PGP signature ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] python3-pymodbus 3.0.0-6
Hi There is a silly bug I fixed in the pymodbus shipped for Testing, and I know Testing is coming up to frozen. https://github.com/pymodbus-dev/pymodbus/commit/e924e713ad96a420c9df60605ee49a0d9c451e2a The up shot of this bug is that using pymodbus for a server over serial doesn't work. Any chance a slightly newer version could go into the freeze? Cheers, Joe OpenPGP_0xCC6911B1B94B954D.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Python-modules-team mailing list Python-modules-team@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team
