[Python-modules-team] Bug#636719: python-scrapy: provide ipython 0.11 compatibility

2011-08-17 Thread Ignace Mouzannar
Hello Julian,

Thank you for reporting this issue and providing the patch to correct it.

On Fri, Aug 5, 2011 at 11:41, Julian Taylor
jtaylor.deb...@googlemail.com wrote:
 The patch applied upstream in
 https://github.com/insophia/scrapy/commit/3191a0856003e8298d9d4b74aec56ffb5ed38432
 is not correct.
 I forwarded this patch:

I will be uploading a new release of the package including your patch.

Also, it looks like your patch has been applied upstream [1].

Cheers,
 Ignace M

[1] 
https://github.com/insophia/scrapy/commit/09af0866c7aae482628df144ecc50f38b9606586#scrapy/utils/console.py



___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team


[Python-modules-team] Bug#636719: python-scrapy: provide ipython 0.11 compatibility

2011-08-17 Thread Ignace Mouzannar
On Wed, Aug 17, 2011 at 22:02, Ignace Mouzannar mouzan...@gmail.com wrote:
 I will be uploading a new release of the package including your patch.

 Also, it looks like your patch has been applied upstream [1].

An new version has been released upstream including your patch [2].

I am currently working on packaging it.

Cheers,
 Ignace M

 [1] 
 https://github.com/insophia/scrapy/commit/09af0866c7aae482628df144ecc50f38b9606586#scrapy/utils/console.py
[2] http://pypi.python.org/pypi/Scrapy



___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team


[Python-modules-team] Bug#636719: python-scrapy: provide ipython 0.11 compatibility

2011-08-05 Thread Julian Taylor
Package: python-scrapy
Version: 0.12.0.2542-1
Severity: normal
Tags: patch
User: jtaylor.deb...@googlemail.com
Usertags: ipython-0.11

IPython 0.11 has been released last week [0,1]. It is currently
available in debian experimental.

In order to upgrade IPython in unstable your package needs to be updated
to deal with the new api and configuration system.
Some hints for migrating applications are available here:
http://wiki.ipython.org/Cookbook/Updating_code_that_uses_IPython_for_0.11

The documentation for the new version can be found here:
http://ipython.org/ipython-doc/rel-0.11/index.html

The patch applied upstream in
https://github.com/insophia/scrapy/commit/3191a0856003e8298d9d4b74aec56ffb5ed38432
is not correct.
I forwarded this patch:
Index: console.py
===
--- console.py  2011-08-05 17:32:47.877221950 +0200
+++ console.py  2011-08-05 17:38:08.567221910 +0200
@@ -11,8 +11,11 @@
 if noipython:
 raise ImportError
 import IPython
-shell = IPython.Shell.IPShellEmbed(argv=[], user_ns=namespace)
-shell()
+try:
+IPython.embed(user_ns=namespace)
+except AttributeError:
+shell = IPython.Shell.IPShellEmbed(argv=[], user_ns=namespace)
+shell()
 except ImportError:
 import code
 try: # readline module is only available on unix systems

[0] http://mail.scipy.org/pipermail/ipython-dev/2011-July/008041.html
[1] http://ipython.org/ipython-doc/rel-0.11/whatsnew/version0.11.html








signature.asc
Description: OpenPGP digital signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team