Your message dated Sat, 16 May 2015 17:51:27 +0000
with message-id <e1ytgfd-0003ty...@franck.debian.org>
and subject line Bug#774509: fixed in python-qt4 4.11.3+dfsg-2
has caused the Debian Bug report #774509,
regarding python-qt4: remove timestamps in generated files to enable
reproducible building
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
774509: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774509
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: python-qt4
Version: 4.11.2+dfsg-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps toolchain
Hi,
the uic python module and the pyrcc tool are currently embedding
timestamps into the comments of generated files.
This results in packages that can't be built reproducibly, because
the timestamp will be a different one on each build (see [1]).
The attached patch removes the timestamp writing in those tools,
as this is no useful information anyway.
Regards,
Reiner
[1]:
https://reproducible.debian.net/userContent/issues/timestamps_in_source_generated_by_pyqt4_ui_issue.html
diff --git a/debian/changelog b/debian/changelog
index 2df5e40..43e2fde 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+python-qt4 (4.11.2+dfsg-1.0~reproducible1) UNRELEASED; urgency=low
+
+ * Added patch which removes embedding of timestamps in generated
+ files, to enable reproducible builds in packages build-depending
+ on python-qt4.
+
+ -- Reiner Herrmann <rei...@reiner-h.de> Sat, 03 Jan 2015 16:57:18 +0100
+
python-qt4 (4.11.2+dfsg-1) unstable; urgency=medium
* New upstream bugfix release.
diff --git a/debian/patches/remove_timestamps.diff b/debian/patches/remove_timestamps.diff
new file mode 100644
index 0000000..c60a51d
--- /dev/null
+++ b/debian/patches/remove_timestamps.diff
@@ -0,0 +1,59 @@
+Description: prevent embedding of timestamps in files generated by rcc and uic
+ Timestamps in generated files will make packages using those tools no longer
+ build reproducibly, because the files will differ in each build.
+ As those timestamps are no useful information, they can be left out.
+Author: Reiner Herrmann <rei...@reiner-h.de>
+
+Index: python-qt4-4.11.2+dfsg/pyrcc/rcc.cpp
+===================================================================
+--- python-qt4-4.11.2+dfsg.orig/pyrcc/rcc.cpp
++++ python-qt4-4.11.2+dfsg/pyrcc/rcc.cpp
+@@ -24,7 +24,6 @@
+ #include <qfile.h>
+ #include <qfileinfo.h>
+ #include <qlocale.h>
+-#include <qdatetime.h>
+ #include <qtextstream.h>
+ #include <qbytearray.h>
+ #include <qhash.h>
+@@ -407,8 +406,7 @@ RCCResourceLibrary::writeHeader(FILE *ou
+ fprintf(out, "# -*- coding: utf-8 -*-\n\n");
+ fprintf(out, "# Resource object code\n");
+ fprintf(out, "#\n");
+- fprintf(out, "# Created: %s\n", QDateTime::currentDateTime().toString().toUtf8().constData());
+- fprintf(out, "# by: The Resource Compiler for PyQt (Qt v%s)\n", QT_VERSION_STR);
++ fprintf(out, "# Created by: The Resource Compiler for PyQt (Qt v%s)\n", QT_VERSION_STR);
+ fprintf(out, "#\n");
+ fprintf(out, "# WARNING! All changes made in this file will be lost!\n");
+ fprintf(out, "\n");
+Index: python-qt4-4.11.2+dfsg/pyuic/uic/__init__.py
+===================================================================
+--- python-qt4-4.11.2+dfsg.orig/pyuic/uic/__init__.py
++++ python-qt4-4.11.2+dfsg/pyuic/uic/__init__.py
+@@ -47,8 +47,7 @@ _header = """# -*- coding: utf-8 -*-
+
+ # Form implementation generated from reading ui file '%s'
+ #
+-# Created: %s
+-# by: PyQt4 UI code generator %s
++# Created by: PyQt4 UI code generator %s
+ #
+ # WARNING! All changes made in this file will be lost!
+
+@@ -160,7 +159,6 @@ def compileUi(uifile, pyfile, execute=Fa
+ module is foo_rc.
+ """
+
+- from time import ctime
+ from PyQt4.QtCore import PYQT_VERSION_STR
+
+ try:
+@@ -170,7 +168,7 @@ def compileUi(uifile, pyfile, execute=Fa
+
+ indenter.indentwidth = indent
+
+- pyfile.write(_header % (uifname, ctime(), PYQT_VERSION_STR))
++ pyfile.write(_header % (uifname, PYQT_VERSION_STR))
+
+ winfo = compiler.UICompiler().compileUi(uifile, pyfile, from_imports, resource_suffix)
+
diff --git a/debian/patches/series b/debian/patches/series
index 30a5420..a89a1d2 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
debian_configure_changes.diff
qreal_float_support.diff
config_flags.diff
+remove_timestamps.diff
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: python-qt4
Source-Version: 4.11.3+dfsg-2
We believe that the bug you reported is fixed in the latest version of
python-qt4, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 774...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dmitry Shachnev <mity...@debian.org> (supplier of updated python-qt4 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 14 May 2015 15:18:25 +0300
Source: python-qt4
Binary: python-qt4 python3-pyqt4 python-qt4-dbg python3-pyqt4-dbg
python-qt4-phonon python3-pyqt4.phonon python-qt4-phonon-dbg
python3-pyqt4.phonon-dbg python-qt4-dbus python-qt4-dbus-dbg
python3-dbus.mainloop.qt python3-dbus.mainloop.qt-dbg python-qt4-gl
python-qt4-gl-dbg python3-pyqt4.qtopengl python3-pyqt4.qtopengl-dbg
python-qt4-sql python3-pyqt4.qtsql python-qt4-sql-dbg python3-pyqt4.qtsql-dbg
python-qt4-dev python-qt4-doc pyqt4-dev-tools
Architecture: source all
Version: 4.11.3+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team
<python-modules-team@lists.alioth.debian.org>
Changed-By: Dmitry Shachnev <mity...@debian.org>
Description:
pyqt4-dev-tools - Development tools for PyQt4
python-qt4 - Python bindings for Qt4
python-qt4-dbg - Python bindings for Qt4 (debug extensions)
python-qt4-dbus - D-Bus Support for PyQt4
python-qt4-dbus-dbg - D-Bus Support for PyQt4 (debug extensions)
python-qt4-dev - Development files for PyQt4
python-qt4-doc - Documentation and examples for PyQt4
python-qt4-gl - Python bindings for Qt4's OpenGL module
python-qt4-gl-dbg - Python bindings for Qt4's OpenGL module (debug extension)
python-qt4-phonon - Python bindings for Phonon
python-qt4-phonon-dbg - Python bindings for Phonon (debug extensions)
python-qt4-sql - Python bindings for PyQt4's SQL module
python-qt4-sql-dbg - Python bindings for PyQt4's SQL module (debug extension)
python3-dbus.mainloop.qt - D-Bus Support for PyQt4 with Python 3
python3-dbus.mainloop.qt-dbg - D-Bus Support for PyQt4 (debug extensions for
Python 3)
python3-pyqt4 - Python3 bindings for Qt4
python3-pyqt4-dbg - Python3 bindings for Qt4 (debug extensions)
python3-pyqt4.phonon - Python3 bindings for Phonon
python3-pyqt4.phonon-dbg - Python3 bindings for Phonon (debug extensions)
python3-pyqt4.qtopengl - Python 3 bindings for Qt4's OpenGL module
python3-pyqt4.qtopengl-dbg - Python 3 bindings for Qt4's OpenGL module (debug
extension)
python3-pyqt4.qtsql - Python3 bindings for PyQt4's SQL module
python3-pyqt4.qtsql-dbg - Python3 bindings for PyQt4's SQL module (debug
extension)
Closes: 774509
Changes:
python-qt4 (4.11.3+dfsg-2) unstable; urgency=medium
.
[ Reiner Herrmann ]
* Added patch which removes embedding of timestamps in generated
files, to enable reproducible builds in packages build-depending
on python-qt4 (closes: #774509).
.
[ Dmitry Shachnev ]
* Bump Standards-Version to 3.9.6, no changes needed.
* Upload to unstable.
Checksums-Sha1:
89843154d75198ed34a1b36680c44fd2fbe5b4e8 4237 python-qt4_4.11.3+dfsg-2.dsc
95706bb7bff6fdae819e8b773727989e42e24fbd 22060
python-qt4_4.11.3+dfsg-2.debian.tar.xz
272644f6b5aaec7997bc48b662a1a0820cea0b11 267214
python-qt4-dev_4.11.3+dfsg-2_all.deb
ed0b1173d2155ffd819350351c9c034fad5b2cb4 8059550
python-qt4-doc_4.11.3+dfsg-2_all.deb
Checksums-Sha256:
83ae2527d9896ce385ce73d54885c1fc60fbbbb549b9cdfa88575f7b7465c562 4237
python-qt4_4.11.3+dfsg-2.dsc
7ab95cff12984a225d9898248bd036f68fbac4f17fa29dd4971fd40d8369e113 22060
python-qt4_4.11.3+dfsg-2.debian.tar.xz
f85feb1032d3c43032c43980cc912e44777ec1de0bb0723c08450cd9a368e214 267214
python-qt4-dev_4.11.3+dfsg-2_all.deb
563610597ad2846e1e9fdc849e060338e895f4e91367873c412bdafdc9a0040b 8059550
python-qt4-doc_4.11.3+dfsg-2_all.deb
Files:
8b480890f28e7cea5ab6a3d6415f953d 4237 python optional
python-qt4_4.11.3+dfsg-2.dsc
8e63439105204e3c5a10450beeac7b00 22060 python optional
python-qt4_4.11.3+dfsg-2.debian.tar.xz
76540ca7fb9f61f7fa2be0ff1d7b18ea 267214 python optional
python-qt4-dev_4.11.3+dfsg-2_all.deb
b5ed3dc4c5d58ecc32d0aa4d8d71275d 8059550 doc optional
python-qt4-doc_4.11.3+dfsg-2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVV3/JAAoJENb+cQNj+F3TXCoP/2u5KKEVNi4dxVWbsQVyKa4H
CsJhvt8e5MndX/VXRK69zh7a915gVL/ysXWtg2+WBKWGuSDEStn/oPx9+s7njV3U
mzpJwYAOTs1/W4XVoSOVS4guiqJr7pMgp5XtdopvDkbk87zH/uDO6Tw9luB+SdOL
vg8qGVFmL5q+Rv88E5V80p0JWuGf+Y2LB4PhFBGAC4fL8MXpP2SlA8t2KH7xgY9W
/gn7my+az77Xyrpcu48KKHh+YxrBj0AGhCsJsZv2DJ7k8cL+ZAo87FYi3q61sdIA
rPLeNyzCQ+tgKlrG3rQ3k+Yogn3pumiB+4fVCsJELBoWDapIiyf1slBzS2PxwzDV
yHSPnlO5mVkouXW6dyKjOG0I638NMejHsJsUlSch5QQScgzBveYSMExnPZpsOZpZ
leHkF+ClnNloBNwayyjkIPnMT4KyvxHuBqUvY7tBsX7d//G0nRFafZOEaUmvSao4
izG+mrBsAksXIGO33X2G2KWyWrjw3Y79cxNdV2PTjh5EYUloxmEjr57UZVkSAF3t
Z+acrlK4srZuhve5G6Ga8Vdr5eRTOoNpAm/UO5QIx9t1NFASWEwC1d/Mi6I2zzIu
fuU78ZQg+wCjFBXyK6AEC1zxF7TIXovGdscS/ZOv/Ptgbfi5YV8JNANcT9qgNpFR
tgLJ1PVJP+VqfGkXZvKU
=ZH62
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
