[Python-modules-team] Bug#870888: breaks awscli 1.11.121-1
On Sat, Aug 26, 2017 at 03:33:03AM -0300, Nicolás Alvarez wrote: >... > But if that botocore code is indeed wrong, then comes the question of > why this ever worked before, and why the change in requests made it > fail. This was fixed in awscli (#874367)[1], so a Breaks on older awscli versions is the most that could be done here. > Nicolás cu Adrian [1] I haven't looked at how it was fixed -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ___ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#870888: breaks awscli 1.11.121-1
This might be a botocore bug. botocore/awsrequest.py has this code: class AWSHTTPConnection(HTTPConnection): def __init__(self, *args, **kwargs): HTTPConnection.__init__(self, *args, **kwargs) # [snip] # [snip more overridden methods...] class AWSHTTPSConnection(VerifiedHTTPSConnection): pass # Now we need to set the methods we overrode from AWSHTTPConnection # onto AWSHTTPSConnection. This is just a shortcut to avoid # copy/pasting the same code into AWSHTTPSConnection. for name, function in AWSHTTPConnection.__dict__.items(): if inspect.isfunction(function): setattr(AWSHTTPSConnection, name, function) This seems incorrect, because AWSHTTPSConnection will get an __init__ method that calls HTTPConnection.__init__ instead of VerifiedHTTPSConnection.__init__, and the latter is where ssl_context gets set. But if that botocore code is indeed wrong, then comes the question of why this ever worked before, and why the change in requests made it fail. -- Nicolás ___ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#870888: breaks awscli 1.11.121-1
I tried bisecting the upstream code directly from git, and got down to the range of commits where upstream removed bundled libraries: With requests 282b01a7c9, awscli works (v2.15.1, right before deleting the 'packages' directory) With requests 47f170bb35, awscli fails (pre-v2.16.0, right after fixing the last "from .packages.urllib3.foo import Bar") The in-between revisions don't work (ImportError: No module named 'requests.packages.urllib3.exceptions'), because the 'packages' directory was already deleted but import statements still pointed to it. Note that upstream's 47f170bb35 uses the system urllib3, but fails with both python3-urllib3 1.19.1-1 and 1.21.1-1. I guess this is bad news for trying to figure out what causes the problem... -- Nicolás ___ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#870888: breaks awscli 1.11.121-1
Hello Jamie, On Sunday, August 6, 2017 1:06:22 AM CEST Jamie Heilman wrote: > Package: python3-requests > Version: 2.18.1-1 > Severity: important > > With this version installed (and python3-urllib3 1.21.1-1), aws cli > just spits out: > > 'AWSHTTPSConnection' object has no attribute 'ssl_context' > > downgrading to 2.12.4-1 restores normal functionality. I haven't > looked to see if awscli is playing dirty pool and fiddling with things > that were never part of a guaranteed API, if that's the case, reassign > as necessary. Thanks for the report. Can you share more details? I don't use AWS for personal projects and I forgot to test it at work. Thanks, -- Daniele Tricoli 'eriol' https://mornie.org signature.asc Description: This is a digitally signed message part. ___ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
[Python-modules-team] Bug#870888: breaks awscli 1.11.121-1
Package: python3-requests Version: 2.18.1-1 Severity: important With this version installed (and python3-urllib3 1.21.1-1), aws cli just spits out: 'AWSHTTPSConnection' object has no attribute 'ssl_context' downgrading to 2.12.4-1 restores normal functionality. I haven't looked to see if awscli is playing dirty pool and fiddling with things that were never part of a guaranteed API, if that's the case, reassign as necessary. ___ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
