[Pywikipedia-bugs] [Maniphest] [Commented On] T109213: cosmetic_Changes replaces {{PAGENAME}} in with "API"

2015-12-13 Thread JAnD 
JAnD added a comment.

In https://phabricator.wikimedia.org/T109213#1872310, @Aklapper wrote:

> Can someone reply to the last comment? Are there any news / progress to 
> share? 
>  Is the current priority correct 
> 
>  (does not seem so)? 
>  Thanks!


"Severity" high, so caled "priority unknown"


TASK DETAIL
  https://phabricator.wikimedia.org/T109213

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JAnD
Cc: Legoktm, XZise, Mpaa, jayvdb, Danny_B, pywikibot-bugs-list, JAnD, Aklapper



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T109213: cosmetic_Changes replaces {{PAGENAME}} in with "API"

2015-12-13 Thread jayvdb 
jayvdb added a comment.

Note this also occurs in v 2.0, so a fix needs to be backported.


TASK DETAIL
  https://phabricator.wikimedia.org/T109213

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Legoktm, XZise, Mpaa, jayvdb, Danny_B, pywikibot-bugs-list, 
JAnD, Aklapper



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T121326: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty

2015-12-13 Thread jayvdb 
jayvdb edited the task description.
jayvdb set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T121326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: Aklapper, StudiesWorld, pywikibot-bugs-list, Tgr, mobrovac, jeremyb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121326: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty

2015-12-13 Thread jayvdb 
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.

Another option is to install using `python setup.py install`

But given that trusty is our default platform it makes sense to do something to 
make it easy. To avoid markers a `requirements` needs to target only Python 2 
or 3, and the filename needs to include the version to avoid it being misused. 
I think Python 3 is the better choice.


TASK DETAIL
  https://phabricator.wikimedia.org/T121326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Tgr, mobrovac, jeremyb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T104864: [breaking change] Page.namespace() gives inconsistent result

2015-12-13 Thread Sn1per 
Sn1per added a subscriber: Sn1per.

TASK DETAIL
  https://phabricator.wikimedia.org/T104864

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb, Sn1per
Cc: Sn1per, gerritbot, XZise, jayvdb, Aklapper, Xqt, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T109213: cosmetic_Changes replaces {{PAGENAME}} in with "API"

2015-12-13 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T109213

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Legoktm, XZise, Mpaa, jayvdb, Danny_B, pywikibot-bugs-list, 
JAnD, Aklapper



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T109213: cosmetic_Changes replaces {{PAGENAME}} in with "API"

2015-12-13 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 258782 had a related patch set uploaded (by John Vandenberg):
Do not expand text by default in getCategoryLinks

https://gerrit.wikimedia.org/r/258782


TASK DETAIL
  https://phabricator.wikimedia.org/T109213

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Legoktm, XZise, Mpaa, jayvdb, Danny_B, pywikibot-bugs-list, 
JAnD, Aklapper



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb created this task.
jayvdb added a subscriber: jayvdb.
jayvdb added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, StudiesWorld, Aklapper.

TASK DESCRIPTION
  pep257 has introduced D403 "First word of first line [of docstring] should be 
properly capitalized"
  https://github.com/GreenSteam/pep257/pull/165
  
  The #pywikibot-core codebase has many failures of this new rule.  To be ready 
for the next release of pep257, we need to address the following (and report 
bugs #upstream):
  (for brevity, I have trimmed the DEPRECATED: entries)
  ```
  $ pep257 -s --select=D403 .
  ./pywikibot/logentries.py:87 in public method `title`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  
  ./pywikibot/logentries.py:258 in public method `page`:
  D403: First word of the first line should be properly capitalized 
('Filepage', not 'FilePage')
  
 258: def page(self):
 259: """
 260: FilePage on which action was performed.
 261: 
 262: Note: title may be missing in data dict e.g. by oversight 
action to
 263:   hide the title. In that case a KeyError exception will 
raise
 264: 
  ...
  
  ./pywikibot/family.py:947 in public method `iwkeys`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:954 in public method `get_known_families`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:1012 in public method `category_redirects`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:1017 in public method `get_cr_templates`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:1021 in public method `disambig`:
  D403: First word of the first line should be properly capitalized 
('"return', not '"Return')
  
1021: def disambig(self, code, fallback='_default'):
1022: Return list of disambiguation templates."""
1023: if code in self.disambiguationTemplates:
1024: return self.disambiguationTemplates[code]
1025: elif fallback:
1026: return self.disambiguationTemplates[fallback]
1027: else:
  ...
  
  ./pywikibot/family.py:1122 in public method `nicepath`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:1136 in public method `nice_get_address`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/family.py:1266 in public method `versionnumber`:
  D403: First word of the first line should be properly capitalized 
('Deprecated,', not 'DEPRECATED,')
  ./pywikibot/family.py:1339 in public method `server_time`:
  D403: First word of the first line should be properly capitalized 
('Deprecated,', not 'DEPRECATED,')
  ./pywikibot/bot.py:960 in public function `handleArgs`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:991 in public method `getNamespaceIndex`:
  D403: First word of the first line should be properly capitalized 
('Deprecated:', not 'DEPRECATED:')
  ./pywikibot/site.py:1083 in public method `linkto`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1216 in public method `urlEncode`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1223 in public method `getUrl`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1242 in public method `postForm`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1247 in public method `postData`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1253 in public method `checkCharset`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1258 in public method `cookies`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1263 in public method `updateCookies`:
  D403: First word of the first line should be properly capitalized 
('Deprecated.', not 'DEPRECATED.')
  ./pywikibot/site.py:1268 in public method `solveCaptcha`:

[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation

2015-12-13 Thread gerritbot 
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.

Change 258896 had a related patch set uploaded (by John Vandenberg):
Fix docstring using quod-quote

https://gerrit.wikimedia.org/r/258896


TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T121365: pep257 D403 capitalisation

2015-12-13 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation

2015-12-13 Thread gerritbot 
gerritbot added a comment.

Change 258896 merged by jenkins-bot:
Fix docstring using quad-quote

https://gerrit.wikimedia.org/r/258896


TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb moved this task to Reported Upstream on the Upstream workboard.

TASK DETAIL
  https://phabricator.wikimedia.org/T121365

WORKBOARD
  https://phabricator.wikimedia.org/project/board/153/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, 
Krenair



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb added a project: Upstream.
jayvdb added a comment.

I've raised:
https://github.com/GreenSteam/pep257/issues/166 for "quotation mark at start or 
end of docstring"
https://github.com/GreenSteam/pep257/issues/167 for "D403 has a very simplistic 
definition of word"


TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, 
Krenair



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb edited the task description.
jayvdb set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb edited the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T121366: deprecation decorators should add deprecation information to docstrings

2015-12-13 Thread jayvdb 
jayvdb created this task.
jayvdb added subscribers: Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list.
jayvdb added projects: pywikibot-core, Pywikibot-documentation.
Herald added a project: Documentation.

TASK DESCRIPTION
  T121365 shows many instances where the docstring has 'DEPRECATED' explicitly 
added to the docstring.
  
  There will be other cases where a method is decorated with `@deprecated` but 
the docstring was not updated to mention it is deprecated, or there is no 
docstring at all.
  
  All the existing literal `DEPRECATED` in docstrings should be removed, and 
the `deprecated` decorator should add/alter the function's docstring to 
describe the deprecation for documentation.
  
  This task doesnt need to solve T121365; it could simply replicate the 
existing problem by prefixing the docstrings with 'DEPRECATED:' .
  There are alternatives which would pass the new pep257 rule, such as 
appending `(DEPRECATED).` to the end of the first line of the docstring.

TASK DETAIL
  https://phabricator.wikimedia.org/T121366

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: pywikibot-bugs-list, jayvdb, StudiesWorld, Aklapper, Spage



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb added a comment.

IMO the errors rejecting 'Create/Edit' and '(Un)protect' feel like an 
"over-reach" bug in pep257.  It feels like they are not allowing the first word 
to be .. interesting.  But to be fair, pep257 is partly intended to simplify 
docstrings , and thus help ESL-people to understand the documentation, so a 
simplistic definition of 'sentence' is not a bad thing.

Most of the others can be 'fixed' by starting the docstring with "Return ...", 
and will not cause a line length problem.  I personally find 'Return' at start 
of docstrings to be superfluous, but it probably helps ESL-people, and it 
solves the pep257 problem.


TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121366: deprecation decorators should add deprecation information to docstrings

2015-12-13 Thread jayvdb 
jayvdb added a comment.

As decorators are fairly 'advanced Python', and are complex to 
build/modify/test, this would be a good 
https://phabricator.wikimedia.org/tag/google-code-in-2015/ project for someone 
wanting to increase their Python skills.


TASK DETAIL
  https://phabricator.wikimedia.org/T121366

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: pywikibot-bugs-list, jayvdb, StudiesWorld, Aklapper, Spage



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T121365: pep257 D403 capitalisation

2015-12-13 Thread jayvdb 
jayvdb removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T121365

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T86074: ItemPage.editEntity does not support 'async'

2015-12-13 Thread Liuxinyu970226 
Liuxinyu970226 set Security to None.

TASK DETAIL
  https://phabricator.wikimedia.org/T86074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: vadi, Liuxinyu970226
Cc: gerritbot, StudiesWorld, Liuxinyu970226, m4tx, Aklapper, 
pywikibot-bugs-list, Ricordisamoa



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121326: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty

2015-12-13 Thread jayvdb 
jayvdb added a comment.

Any Python lower than 2.7.9 iirc is insecure, and will require overriding 
system provided packages, or a virtualenv.


TASK DETAIL
  https://phabricator.wikimedia.org/T121326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Tgr, mobrovac, jeremyb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T121326: Pywikibot's requirements.txt needs pip 6+ which is not present on Ubuntu Trusty

2015-12-13 Thread Tgr 
Tgr added a comment.

The default Python on Trusty is currently 2.7.6 - people would have to remember 
to type `python3` and hashbangs would not work either. That's not a huge deal 
but all else being equal I would prefer targeting the default version.


TASK DETAIL
  https://phabricator.wikimedia.org/T121326

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Tgr, mobrovac, jeremyb



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs