[Pywikipedia-bugs] [Maniphest] [Reopened] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Pasleim
Pasleim reopened this task as "Open".Pasleim added a comment.
This patch causes that PropertyPage.exists() throws an error.TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, PasleimCc: Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Magul
Magul added a comment.
@Pasleim are we talking about something like this?

>>> import pywikibot
>>> s = pywikibot.Site('en', 'wikipedia')
>>> r = s.data_repository()
>>> p = pywikibot.PropertyPage(r, 'P38')
>>> p.exists()
Traceback (most recent call last):
  File "", line 1, in 
  File "pywikibot/page.py", line 3457, in exists
self.get(get_redirect=True)
  File "pywikibot/page.py", line 4263, in get
'PropertyPage.get only implements "force".')
NotImplementedError: PropertyPage.get only implements "force".TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T148121: [CGI template easy task] Find and fix syntax errors in translated messages

2016-11-18 Thread Nemo_bis
Nemo_bis added a comment.
do we have checkers for that? (and where can I find a list of existing checkers?)

In the translatewiki repository. It's certainly possible that wikipedia-ios folks are using some non-standard methods outside translatewiki.net, I don't know why they have those bash scripts.TASK DETAILhttps://phabricator.wikimedia.org/T148121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Nemo_bisCc: Xqt, pywikibot-bugs-list, Psychoslave, Nikerabbit, Nemo_bis, jayvdb, Aklapper, Taquo, catalandres, D3r1ck01, MuhammadShuaib, Gryllida, Josve05a, Shizhao, Arrbee, KartikMistry, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T110856: Convert all scripts to TWN i18n

2016-11-18 Thread Magul
Magul moved this task from Backlog to Next release (2.0 RC4) on the Pywikibot-core board.Magul triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T110856WORKBOARDhttps://phabricator.wikimedia.org/project/board/87/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: XZise, Xqt, Ricordisamoa, Avicennasis, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Raised Priority] T110856: Convert all scripts to TWN i18n

2016-11-18 Thread Magul
Magul raised the priority of this task from "Low" to "Needs Triage".
TASK DETAILhttps://phabricator.wikimedia.org/T110856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: XZise, Xqt, Ricordisamoa, Avicennasis, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T151018: Cannot load item page. upperBound KeyError

2016-11-18 Thread Aklapper
Aklapper added a project: Pywikibot-core.Aklapper added a comment.Herald added a subscriber: pywikibot-bugs-list.
Hi @ChongDae, thanks for taking the time to report this!

Is this an issue in Pywikibot, or which project should be associated to this task?TASK DETAILhttps://phabricator.wikimedia.org/T151018EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: pywikibot-bugs-list, ChongDae, Aklapper, Magul, MayS, Mdupont, JJMC89, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Multichill
Multichill added a comment.
FYI, on my not yet updated 6b8c01d, g7574, 2016/11/10, 09:32:07, n/a :

mdammers@bingo:~/pywikibot$ python
Python 2.7.6 (default, Jun 22 2015, 17:58:13) 
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pywikibot
>>> s = pywikibot.Site('en', 'wikipedia')
>>> r = s.data_repository()
>>> p = pywikibot.PropertyPage(r, 'P38')
>>> p.exists()
True
>>>

Maybe go back to my plan A?:

if not hasattr(self, '_content'):
try:
self.get()
return True
 except pywikibot.IsRedirectPage
 return True
except pywikibot.NoPage:
return False
return 'lastrevid' in self._content

Yes, this will also return True if the redirect is to a deleted page, but that's quite an extreme edge case and if you follow a redirect you should do your checks again anyway for the target.

We should probably add tests to " TestPropertyPage" to test exists().TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MultichillCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Magul
Magul added a comment.
@Multichill or maybe we should accept get_redirect in PropertyPage.get and just ignore it there (see: 1)?TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread gerritbot
gerritbot added a comment.
Change 322253 had a related patch set uploaded (by Dalba):
WikibasePage.exists: Don't call self.get(get_redirect=True) for PropertyPage

https://gerrit.wikimedia.org/r/322253TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Retitled] T124192: compat selflink.py freezes trying saving an edit

2016-11-18 Thread XXN
XXN changed the title from "compact selflink.py freezes trying saving an edit" to "compat selflink.py freezes trying saving an edit".XXN edited the task description. (Show Details)
EDIT DETAILSI have to use compact selflink.py because core's one doesn't support -xml option. Anyway (even using -page) it freezes trying saving any edit. Here's the traceback after a keyboard interrupt:...TASK DETAILhttps://phabricator.wikimedia.org/T124192EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XXNCc: jayvdb, Aklapper, StudiesWorld, Vituzzu, pywikibot-bugs-list, Anshoe___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Created] T151092: Change in quantities broke pywikibot

2016-11-18 Thread Multichill
Multichill created this task.Multichill added projects: Pywikibot-Wikidata, Wikidata.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION@daniel broke Pywikibot in T115269 . After some digging I found https://lists.wikimedia.org/pipermail/wikidata-tech/2016-November/001050.html

I'm not happy at all about upstream breaking pywikibot yet again.

Working on Q19160832
Traceback (most recent call last):
  File "pwb.py", line 255, in 
if not main():
  File "pwb.py", line 249, in main
run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 121, in run_python_file
main_mod.__dict__)
  File "/home/mdammers/code/toollabs/bot/wikidata/painting_add_creator.py", line 320, in 
main()
  File "/home/mdammers/code/toollabs/bot/wikidata/painting_add_creator.py", line 317, in main
paintingBot.run()
  File "/home/mdammers/code/toollabs/bot/wikidata/painting_add_creator.py", line 156, in run
creatorItem = self.getCreator(creator)
  File "/home/mdammers/code/toollabs/bot/wikidata/painting_add_creator.py", line 214, in getCreator
if (creatoritem.get().get('labels').get('en') and creatoritem.get().get('labels').get('en').lower() == creator.lower()) or (creatoritem.get().get('aliases').get('en') and creator in creatoritem.get().get('aliases').get('en')):
  File "/home/mdammers/pywikibot/pywikibot/page.py", line 3923, in get
data = "" self).get(force, *args, **kwargs)
  File "/home/mdammers/pywikibot/pywikibot/page.py", line 3538, in get
c = Claim.fromJSON(self.repo, claim)
  File "/home/mdammers/pywikibot/pywikibot/page.py", line 4339, in fromJSON
claim.type, lambda value, site: value)(value, site)
  File "/home/mdammers/pywikibot/pywikibot/page.py", line 4282, in 
'quantity': lambda value, site: pywikibot.WbQuantity.fromWikibase(value),
  File "/home/mdammers/pywikibot/pywikibot/__init__.py", line 675, in fromWikibase
upperBound = cls._todecimal(wb['upperBound'])
KeyError: u'upperBound'

CRITICAL: Closing network session.TASK DETAILhttps://phabricator.wikimedia.org/T151092EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: hoo, Ladsgroup, Lydia_Pintscher, Aklapper, Multichill, pywikibot-bugs-list, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Wesalius, Mbch331___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T151092: Change in quantities broke pywikibot

2016-11-18 Thread Multichill
Multichill triaged this task as "Unbreak Now!" priority.Herald added subscribers: Jay8g, Luke081515, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T151092EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: TerraCodes, Luke081515, Jay8g, hoo, Ladsgroup, Lydia_Pintscher, Aklapper, Multichill, pywikibot-bugs-list, daniel, D3r1ck01, Izno, Wikidata-bugs, aude, Ricordisamoa, Wesalius, Mbch331___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T151092: Change in quantities broke pywikibot

2016-11-18 Thread aude
aude added a comment.
upperBound and lowerBound are now optional

(see https://lists.wikimedia.org/pipermail/wikidata/2016-November/009921.html)TASK DETAILhttps://phabricator.wikimedia.org/T151092EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: audeCc: aude, TerraCodes, Luke081515, Jay8g, hoo, Ladsgroup, Lydia_Pintscher, Aklapper, Multichill, pywikibot-bugs-list, daniel, D3r1ck01, Izno, Wikidata-bugs, Ricordisamoa, Wesalius, Mbch331___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T101524: Many parts of compat will break when used on Wikimedia servers on July 1, 2015

2016-11-18 Thread Xqt
Xqt added a parent task: T99365: [RFC] Compat deprecation.Herald added subscribers: Jay8g, TerraCodes.
TASK DETAILhttps://phabricator.wikimedia.org/T101524EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: TerraCodes, Jay8g, XZise, gerritbot, Xqt, Steinsplitter, Sn1per, Ladsgroup, Sitic, Ricordisamoa, pywikibot-bugs-list, jayvdb, Aklapper, Lewizho99, Maathavan, Samtar, Johan, Luke081515, Anshoe, fbstj, TheDJ, Krenair, greg___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T101214: Decommission compat

2016-11-18 Thread Xqt
Xqt added a parent task: T99365: [RFC] Compat deprecation.
TASK DETAILhttps://phabricator.wikimedia.org/T101214EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Matanya, Liuxinyu970226, Mpaa, Ricordisamoa, JAnD, XZise, Xqt, Legoktm, valhallasw, Ladsgroup, pywikibot-bugs-list, Multichill, jayvdb, Aklapper, Magul, MayS, Mdupont, JJMC89, Samtar, Johan, Luke081515, Anshoe, Dalba, fbstj, Masti, Alchimista, TheDJ, Rxy, Jay8g, Krenair, greg___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Edited] T101214: Decommission compat

2016-11-18 Thread Xqt
Xqt edited the task description. (Show Details)
EDIT DETAILS...4. ~~request that 'Bot approval' processes and teams reject compat bots~~
5. T99373 - #Analytics monitoring and reporting on compat bots running on Wikimedia sites...7. ~~Move all compat documentation to https://www.mediawiki.org/wiki/Manual:Pywikibot/Compat , add it to https://www.mediawiki.org/wiki/Template:Pywikibot,~~
9. hold a #pywikibot-general cleanup day to triage all bugs in that tag into either/both compat/core, and then delete that tag. (and then repeat step 2)
8. ~~release Pywikibot 2.0~~
10. at Wikimania July 2015 (https://wikimania2015.wikimedia.org/) , mass close all tasks that are #pywikibot-compat only
11. ~~Block bots using Pywikipedia in user-agent~~
12. Celebrate.TASK DETAILhttps://phabricator.wikimedia.org/T101214EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Matanya, Liuxinyu970226, Mpaa, Ricordisamoa, JAnD, XZise, Xqt, Legoktm, valhallasw, Ladsgroup, pywikibot-bugs-list, Multichill, jayvdb, Aklapper, Magul, MayS, Mdupont, JJMC89, Samtar, Johan, Luke081515, Anshoe, Dalba, fbstj, Masti, Alchimista, TheDJ, Rxy, Jay8g, Krenair, greg___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T95074: compat emits NameError in user-config.py when it contains values appropriate for core

2016-11-18 Thread Xqt
Xqt added a parent task: T99365: [RFC] Compat deprecation.
TASK DETAILhttps://phabricator.wikimedia.org/T95074EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Xqt, pywikibot-bugs-list, jayvdb, Aklapper, Anshoe___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T57282: weblinkchecker.LinkChecker throws IndexError: tuple index out of range

2016-11-18 Thread Xqt
Xqt removed a project: Pywikibot-compat.Xqt added a comment.
Decommission of compat branch.TASK DETAILhttps://phabricator.wikimedia.org/T57282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: StudiesWorld, jayvdb, Aklapper, Xqt, Legoktm, Ricordisamoa, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T102315: pywikibot support for https-only

2016-11-18 Thread Xqt
Xqt removed a project: Pywikibot-compat.Xqt added a comment.
Compat decommissionTASK DETAILhttps://phabricator.wikimedia.org/T102315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Xqt, Andrew, StudiesWorld, Ricordisamoa, XZise, BBlack, Nemo_bis, Tony_Tan_98, Aklapper, jayvdb, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T57301: redirect pages not properly followed.

2016-11-18 Thread Xqt
Xqt added a parent task: T99365: [RFC] Compat deprecation.
TASK DETAILhttps://phabricator.wikimedia.org/T57301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Legoktm, pywikibot-bugs-list, Anshoe, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Declined] T57301: redirect pages not properly followed.

2016-11-18 Thread Xqt
Xqt closed this task as "Declined".Xqt added a comment.
Compat decommission.TASK DETAILhttps://phabricator.wikimedia.org/T57301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Xqt, Legoktm, pywikibot-bugs-list, Anshoe___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs