date:20161127

[Pywikipedia-bugs] [Maniphest] [Commented On] T134640: site_tests.py fails for TestUserContribsWithoutUser with TimeoutError

2016-11-27 Thread Dalba

Dalba added a comment.
@Magul Well, I think it would be better if we increased the timeouts as low as necessary. Especially that in multi-threaded environments these timeouts make the application completely unresponsive. When there is actually a problem with the connection somewhere an early timeout could be a bless. Users could actually depend on these timeouts, trying to catch and skip them or just using the built-in retry mechanism. Increasing the timeouts could greatly increase the overall retry times. An early timeout when there is actually no more hope can be a blessing...

On the other hand I'm not sure that increasing the timeout will resolve the problem here. I tried to reproduce the issue (many times) and only a few of my attempts where successful. All of which ended up with a 503 error instead of finishing the request:

WARNING: Http response status 503
WARNING: Non-JSON response received from server wikipedia:en; the server may be down.
Set uclimit = ['2']
WARNING: Waiting 5 seconds before retrying.
WARNING: Http response status 503
WARNING: Non-JSON response received from server wikipedia:en; the server may be down.
Set uclimit = ['1']
 246.508s 
Error
Traceback (most recent call last):
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 1987, in submit
result = json.loads(rawdata)
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\__init__.py", line 319, in loads
return _default_decoder.decode(s)
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\programming\python\wiki\pywikibot-core\tests\site_tests.py", line 1493, in test_user_prefix_range
total=5):
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2753, in __iter__
self.data = self.request.submit()
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2005, in submit
self.wait()
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2197, in wait
raise TimeoutError("Maximum retries attempted without success.")
pywikibot.data.api.TimeoutError: Maximum retries attempted without success.

WARNING: Http response status 503
WARNING: Non-JSON response received from server wikipedia:en; the server may be down.
Set uclimit = ['2']
WARNING: Waiting 5 seconds before retrying.
 190.370s 
Process finished with exit code 0

(It seems that some caching mechanism is involved and you can only get these errors in the first attempt, then you'll have to wait a while, otherwise all subsequent retries will end up passing without error.)

tests: max_retries reduced from 25 to 1
WARNING: Http response status 503
WARNING: Non-JSON response received from server wikipedia:en; the server may be down.
Set uclimit = ['2']
WARNING: Waiting 5 seconds before retrying.
WARNING: Http response status 503
WARNING: Non-JSON response received from server wikipedia:en; the server may be down.
Set uclimit = ['1']
 250.990s 
Error
Traceback (most recent call last):
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 1987, in submit
result = json.loads(rawdata)
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\__init__.py", line 319, in loads
return _default_decoder.decode(s)
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Users\a\AppData\Local\Programs\Python\Python35\lib\json\decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\programming\python\wiki\pywikibot-core\tests\site_tests.py", line 1516, in test_user_prefix_reverse
reverse=True, total=5):
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2753, in __iter__
self.data = self.request.submit()
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2005, in submit
self.wait()
  File "G:\programming\python\wiki\pywikibot-core\pywikibot\data\api.py", line 2197, in wait
raise TimeoutError("Maximum retries attempted without success.")
pywikibot.data.api.TimeoutError: Maximum retries attempted without success.


Process finished with exit code 0

(The timeout was set to 300 seconds in both cases)TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T148121: [CGI template easy task] Find and fix syntax errors in translated messages

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.
Imported as https://codein.withgoogle.com/tasks/5695759668215808/TASK DETAILhttps://phabricator.wikimedia.org/T148121WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Xqt, pywikibot-bugs-list, Psychoslave, Nikerabbit, Nemo_bis, jayvdb, Aklapper, Taquo, catalandres, D3r1ck01, MuhammadShuaib, Gryllida, Josve05a, Shizhao, Arrbee, KartikMistry, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Unassigned] T132158: Page title too long pages errors with nondescriptive message "has neither 'pageid' nor 'missing' attribute"

2016-11-27 Thread Magul

Magul removed Magul as the assignee of this task.
TASK DETAILhttps://phabricator.wikimedia.org/T132158EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Magul, gerritbot, Mpaa, Xqt, jayvdb, Aklapper, Senapa, pywikibot-bugs-list, zhuyifei1999, MayS, Mdupont, JJMC89, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Closed] T132158: Page title too long pages errors with nondescriptive message "has neither 'pageid' nor 'missing' attribute"

2016-11-27 Thread Magul

Magul closed this task as "Resolved".Magul claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T132158EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: gerritbot, Mpaa, Xqt, jayvdb, Aklapper, Senapa, pywikibot-bugs-list, zhuyifei1999, Magul, MayS, Mdupont, JJMC89, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T114574: Create an alias "mul" for -lang: syntax in pywikibot

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.
Imported as https://codein.withgoogle.com/tasks/5727455453118464/TASK DETAILhttps://phabricator.wikimedia.org/T114574WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: TerraCodes, valhallasw, darthbhyrava, XZise, Mpaa, jayvdb, Aklapper, pywikibot-bugs-list, Magul, MayS, Mdupont, JJMC89, D3r1ck01, MuhammadShuaib, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T70797: script_wui hardcoded to use User:DrTrigon

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.

In T70797#2758117, @DrTrigon wrote:
I will mentor this in #GCI2016


@DrTrigon: Could you please reply to the mentor registration email you received, and register? :) If you missed it, please drop me an email. Thanks!

Imported as https://codein.withgoogle.com/tasks/6219155388760064/TASK DETAILhttps://phabricator.wikimedia.org/T70797WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, AklapperCc: Aklapper, DrTrigon, TerraCodes, gerritbot, Sitic, jayvdb, Ricordisamoa, pywikibot-bugs-list, Ramalepe, Liugev6, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, D3r1ck01, MuhammadShuaib, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T90149: LDAP based login is broken in pywikibot because lgdomain is not set

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.
Imported as https://codein.withgoogle.com/tasks/5099661157203968/TASK DETAILhttps://phabricator.wikimedia.org/T90149WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: David.august, AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, Magul, MayS, Mdupont, JJMC89, D3r1ck01, MuhammadShuaib, Dalba, droid, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T130805: Create some tests for pywikibot.diff.PatchManager

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.
Imported as https://codein.withgoogle.com/tasks/5757373792649216/TASK DETAILhttps://phabricator.wikimedia.org/T130805WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb, Magul, MayS, Mdupont, JJMC89, D3r1ck01, MuhammadShuaib, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T130805: Create some tests for pywikibot.diff.PatchManager

2016-11-27 Thread Aklapper

Aklapper changed the title from "pywikibot.diff.PatchManager has no tests" to "Create some tests for pywikibot.diff.PatchManager".
TASK DETAILhttps://phabricator.wikimedia.org/T130805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: Vennela0212, TerraCodes, Aklapper, pywikibot-bugs-list, Mpaa, jayvdb, Magul, MayS, Mdupont, JJMC89, D3r1ck01, MuhammadShuaib, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T124005: Create tests for fake user agent

2016-11-27 Thread Aklapper

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Aklapper added a comment.
Imported as https://codein.withgoogle.com/tasks/5710305380270080/TASK DETAILhttps://phabricator.wikimedia.org/T124005WORKBOARDhttps://phabricator.wikimedia.org/project/board/2304/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AklapperCc: TerraCodes, darthbhyrava, Aklapper, pywikibot-bugs-list, jayvdb, Nemo_bis, MtDu, gerritbot, Magul, MayS, Mdupont, JJMC89, D3r1ck01, MuhammadShuaib, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T92856: Assertion failure testing namespace restriction

2016-11-27 Thread Magul

Magul added subscribers: Xqt, XXN, Dalba, valhallasw.Magul added a comment.
The reason that (I believe) cause failing tests here (and in few other tasks) is, that these tests aren't unittests. The work on live Mediawiki instances and they assume that there will be no change during test.

As You can see in my previous comment it sometimes happend that change is made and it is failing.

I was trying to build here bullet proof solution. The solution mock BasePage.init method and decorate it logic with 2 lines that were responsible for getting last rev id for every page that was created during test and if it failed it would check if any page that was created during test changed. The problem here is that time required to run one such test was increased by at least one order of magnitude. Previously test take 3-4 seconds to pass and after implementing bullet-proof solution it was going for few minutes and haven't end.

So the question is what level of fragility is enough for us? I'm tending right now into:

choping long tests that cuse problems to smaller ones

on failure reruning test (that it will take 10 failures before test fails completely).

What do You think about it?

@Dalba @Xqt @jayvdb @valhallasw @XZise @XXNTASK DETAILhttps://phabricator.wikimedia.org/T92856EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: valhallasw, Dalba, XXN, Xqt, Magul, gerritbot, jayvdb, pywikibot-bugs-list, Aklapper, XZise, MayS, Mdupont, JJMC89, GPHemsley, Darkdadaah, Masti, Alchimista, Rxy, Krenair___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T151733: Compat deprecation message broke compat

2016-11-27 Thread Masti

Masti changed the title from "Compat deprecation message broke comat" to "Compat deprecation message broke compat".
TASK DETAILhttps://phabricator.wikimedia.org/T151733EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MastiCc: Aklapper, Masti, pywikibot-bugs-list, Anshoe___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T151733: Compat deprecation message broke comat

2016-11-27 Thread Masti

Masti created this task.Masti added a project: Pywikibot-compat.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONwarning message in throttle.py introduced in https://gerrit.wikimedia.org/r/322502 crasshes with
EOFError: EOF when reading a line

example:

Press  to continue.



Traceback (most recent call last):

File "basicvotes.py", line 29, in 
  import wikipedia as pywikibot
File "/usr/home/masti/pw/compat/wikipedia.py", line 10466, in 
  get_throttle = Throttle()
File "/usr/home/masti/pw/compat/pywikibot/throttle.py", line 66, in __init__
  self.checkMultiplicity()
File "/usr/home/masti/pw/compat/pywikibot/throttle.py", line 140, in checkMultiplicity
  self._show_warning()
File "/usr/home/masti/pw/compat/pywikibot/throttle.py", line 89, in _show_warning
  \03{default}""")
File "/usr/home/masti/pw/compat/wikipedia.py", line 10329, in input
  data = "" password)
File "/usr/home/masti/pw/compat/userinterfaces/terminal_interface_base.py", line 142, in input
  text = self._raw_input()
File "/usr/home/masti/pw/compat/userinterfaces/terminal_interface_base.py", line 120, in _raw_input
  return raw_input()

EOFError: EOF when reading a lineTASK DETAILhttps://phabricator.wikimedia.org/T151733EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MastiCc: Aklapper, Masti, pywikibot-bugs-list, Anshoe, jayvdb___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T134640: site_tests.py fails for TestUserContribsWithoutUser with TimeoutError

2016-11-27 Thread Magul

Magul added a comment.
I have just pushed update to my patch that will change default timeout to 1 minute instead of 5 (and fixing commit message typo).

@Dalba I'm not certain what kind of advantage we will get, if we will distinguish read timeout and connect timeout.

@Xqt I get Your hesitation about increasing default timeout, but we should think about it as an abstract value, that we are willing to wait. I know that lot of bots doesn't do heavy requests but they will not be affected by this change, and if will, inecrease of default timeout value is the the least of their problems. 
.TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: MtDu, Lokal_Profil, Dalba, gerritbot, valhallasw, XZise, Aklapper, jayvdb, Zppix, Xqt, pywikibot-bugs-list, Ramalepe, Liugev6, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

45 matches

Mail list logo