[Pywikipedia-bugs] [Maniphest] [Updated] T160355: site_detect_tests fails with AttributeError in constructor of MWSite

2017-04-19 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T160355EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, valhallasw, Dalba, Aklapper, XZise, Xqt, pywikibot-bugs-list, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T160355: site_detect_tests fails with AttributeError in constructor of MWSite

2017-04-19 Thread gerritbot
gerritbot added a comment.
Change 349156 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] site_detect.py: Check the response in _parse_post_117 for server errors

https://gerrit.wikimedia.org/r/349156TASK DETAILhttps://phabricator.wikimedia.org/T160355EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, valhallasw, Dalba, Aklapper, XZise, Xqt, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T160355: site_detect_tests fails with AttributeError in constructor of MWSite

2017-04-19 Thread Dalba
Dalba added a comment.
private_wiki is not set because _parse_post_117 method is getting a server error status from the server and ignores it. We should check for server errors inside _parse_post_117, just the way we do in MWSite.__init__.TASK DETAILhttps://phabricator.wikimedia.org/T160355EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: valhallasw, Dalba, Aklapper, XZise, Xqt, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T132849: Fail gracefully on invalid user name

2017-04-19 Thread Framawiki
Framawiki triaged this task as "Low" priority.
TASK DETAILhttps://phabricator.wikimedia.org/T132849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: APerson, Aklapper, pywikibot-bugs-list, Mdupont, Magul, Tbscho, MayS, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Claimed] T123020: Add support for `ns` (namespace) parameter in `Page.move`

2017-04-19 Thread Framawiki
Framawiki claimed this task.Framawiki added a comment.
I'll try to look at this.TASK DETAILhttps://phabricator.wikimedia.org/T123020EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, jayvdb, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T113193: Detect toollabs environment in pywikibot.version

2017-04-19 Thread Framawiki
Framawiki added a comment.
It can be useful too to indicate if the script is running on an executer host or on the bastion.TASK DETAILhttps://phabricator.wikimedia.org/T113193EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, Aklapper, pywikibot-bugs-list, jayvdb, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Triaged] T110411: login.py doesnt recognise * in config.usernames

2017-04-19 Thread Framawiki
Framawiki triaged this task as "High" priority.Framawiki added a comment.
It can really be practical.TASK DETAILhttps://phabricator.wikimedia.org/T110411EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, Dalba, Aklapper, jayvdb, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Edited] T75534: missing language in family causes exception in Page.langlinks

2017-04-19 Thread Framawiki
Framawiki edited the task description. (Show Details)
EDIT DETAILSOn en.wowwiki:
```
ERROR: testLinks (tests.page_tests.TestPageObject)...UnknownSite: Language nn does not exist in family wowwiki
```
--...TASK DETAILhttps://phabricator.wikimedia.org/T75534EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: jayvdb, pywikibot-bugs-list, XZise, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Claimed] T132849: Fail gracefully on invalid user name

2017-04-19 Thread Framawiki
Framawiki claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T132849EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: APerson, Aklapper, pywikibot-bugs-list, Mdupont, Magul, Tbscho, MayS, JJMC89, Avicennasis, Sn1per, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T163349: makecat.py fails under python 3: TypeError: can't concat bytes to str

2017-04-19 Thread Dalba
Dalba added a project: Pywikibot-core.
TASK DETAILhttps://phabricator.wikimedia.org/T163349EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T163349: makecat.py fails under python 3: TypeError: can't concat bytes to str

2017-04-19 Thread Dalba
Dalba added a parent task: T60053: Pywikibot Python 3 compatibility (tracking).
TASK DETAILhttps://phabricator.wikimedia.org/T163349EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T60053: Pywikibot Python 3 compatibility (tracking)

2017-04-19 Thread Dalba
Dalba added a subtask: T163349: makecat.py fails under python 3: TypeError: can't concat bytes to str.
TASK DETAILhttps://phabricator.wikimedia.org/T60053EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, Xqt, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs-list, Ladsgroup, XZise, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Created] T163349: makecat.py fails under python 3: TypeError: can't concat bytes to str

2017-04-19 Thread Dalba
Dalba created this task.Dalba added a project: Pywikibot-Other-scripts.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION$ python3 pwb.py makecat TEST -lang:en -family:wikipedia
Traceback (most recent call last):
  File "pwb.py", line 263, in 
if not main():
  File "pwb.py", line 257, in main
run_python_file(filename, [filename] + args, argvu, file_package)
  File "pwb.py", line 121, in run_python_file
main_mod.__dict__)
  File "./scripts/makecat.py", line 224, in 
'category', workingcatname.encode('ascii', 'xmlcharrefreplace') + '_exclude.txt')
TypeError: can't concat bytes to str

CRITICAL: Closing network session.TASK DETAILhttps://phabricator.wikimedia.org/T163349EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2017-04-19 Thread gerritbot
gerritbot added a comment.
Change 312721 abandoned by Xqt:
pywikibot.Page.put: checking the changes before saving

Reason:
per T122715

https://gerrit.wikimedia.org/r/312721TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, gerritbotCc: AbdealiJK, Xqt, gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, DatGuy, Abbe98, Avicennasis, MuhammadShuaib, Sn1per, jayvdb, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T161726: Support new geo-shape datatype in Pywikibot

2017-04-19 Thread Lokal_Profil
Lokal_Profil added a comment.
For now the url is hardcoded in the family file. Once T162561: Expose geoShapeStorageFrontendUrl through siteinfo is resolved we should instead get to it through the api.TASK DETAILhttps://phabricator.wikimedia.org/T161726EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lokal_ProfilCc: gerritbot, Aklapper, pywikibot-bugs-list, Lokal_Profil, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

2017-04-19 Thread gerritbot
gerritbot added a comment.
Change 348942 merged by jenkins-bot:
[pywikibot/core@master] Remove version variable from the modules of the test package

https://gerrit.wikimedia.org/r/348942TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Ricordisamoa, gerritbot, Legoktm, Ladsgroup, Xqt, XZise, valhallasw, pywikibot-bugs-list, jayvdb, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T151145: Make Travis (and Appveyor) pass again

2017-04-19 Thread Xqt
Xqt added a comment.
Thanks a lot folks!TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, XqtCc: Xqt, Dalba, Sn1per, jayvdb, Aklapper, Magul, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T151145: Make Travis (and Appveyor) pass again

2017-04-19 Thread Magul
Magul added a comment.
We have still few issues in Appveyor and should revalidate all open subtasks here (as they propably should be closed), but that looks like real milestone for this project. We should treat right now any Travis failure as blocker (at least till we move to Wikimedia CI) and try to make all tests properly mocked.TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Xqt, Dalba, Sn1per, jayvdb, Aklapper, Magul, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T151145: Make Travis (and Appveyor) pass again

2017-04-19 Thread Dalba
Dalba added a subscriber: Xqt.Dalba added a comment.
@Magul, It is! I don't know when was the last time that a build pass successfully! :)

Of-course there are still some tests that sporadically fail that we should focus on.

Thanks to everyone involved, especially you and @Xqt!TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, DalbaCc: Xqt, Dalba, Sn1per, jayvdb, Aklapper, Magul, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T151145: Make Travis (and Appveyor) pass again

2017-04-19 Thread Magul
Magul added a subscriber: Dalba.Magul added a comment.
@Dalba that's huge! https://travis-ci.org/wikimedia/pywikibot-core/builds/223520844

chapeau bas!TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MagulCc: Dalba, Sn1per, jayvdb, Aklapper, Magul, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

2017-04-19 Thread gerritbot
gerritbot added a comment.
Change 348942 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] Remove version variable from the modules of the test package

https://gerrit.wikimedia.org/r/348942TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Ricordisamoa, gerritbot, Legoktm, Ladsgroup, Xqt, XZise, valhallasw, pywikibot-bugs-list, jayvdb, Aklapper, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Updated] T87409: pep8 E402 vs __version__ and others

2017-04-19 Thread gerritbot
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dalba, Ricordisamoa, gerritbot, Legoktm, Ladsgroup, Xqt, XZise, valhallasw, pywikibot-bugs-list, jayvdb, Aklapper, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Commented On] T87409: pep8 E402 vs __version__ and others

2017-04-19 Thread Dalba
Dalba added a comment.

In T87409#2189435, @Xqt wrote:
imho this could be removed or it should be replaced by a more informative value.


+1.

There are only a few scripts that actually use __version__ :


bot.py:
handle_args prints out module versions in verbose mode

version.py:
A few functions, e.g. getfileversion, obviously depend on __version__.

compat2core.py:
Might require a minor update to remove __version__ from converted scripts.



TASK DETAILhttps://phabricator.wikimedia.org/T87409EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dalba, Ricordisamoa, gerritbot, Legoktm, Ladsgroup, Xqt, XZise, valhallasw, pywikibot-bugs-list, jayvdb, Aklapper, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Closed] T160268: test_arabeyes is failing with assertion error

2017-04-19 Thread Dalba
Dalba closed this task as "Resolved".Dalba added a comment.
I'm going to mark this task as resolved. Please feel free to reopen or create a new task/RFC if required.TASK DETAILhttps://phabricator.wikimedia.org/T160268EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Magul, Lokal_Profil, gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Unblock] T151145: Make Travis (and Appveyor) pass again

2017-04-19 Thread Dalba
Dalba closed subtask T160268: test_arabeyes is failing with assertion error as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T151145EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, DalbaCc: Sn1per, jayvdb, Aklapper, Magul, pywikibot-bugs-list, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs


[Pywikipedia-bugs] [Maniphest] [Closed] T163293: jenkins-bot verification is failing with AttributeError: 'module' object has no attribute 'PEP257Checker'

2017-04-19 Thread Dalba
Dalba closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T163293EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs