date:20170830

Mpaa added a comment.
Attempting a fix ... maybe it is too late at night :-)TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: Edit counter gives wrong result in replace.py

2017-08-30 Thread Dvorapa

Dvorapa added a comment.

In T147178#3568298, @Mpaa wrote:
Using _flush(True) probably just gives some time to be able to join the thread before the main dies ...


This seems to be a right directionTASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: Edit counter gives wrong result in replace.py

2017-08-30 Thread Dvorapa

Dvorapa added a comment.
@Framawiki Personally I don't think this should be disabled. Better approximate count than nothing. And this bug is noticeable only when a really low count of pages was edited. For hundreds of pages or more one extra or one missing is not a big deal.

@matej_suchanek @Mpaa Apart from what has been already mentioned (mainly T151727), there are some other possibilities, how to deal with this issue. First of all maybe something like this: 0 pages changed, 1 pages still in progress?? I would prefer this solution and it seems to me as #easy one. Another option could be to pass n pages changed summary on the second thread (and return that output after all jobs of second thread are done after callback is out somehow, but I don't really know how this could work here). Or just make first thread wait for async callback, but this approach is not really async at all.

In T147178#3567967, @matej_suchanek wrote:
The funniest fact at the end: this script has sync/async saving swapped, compared to other standard bots. In other words, with -always ([a]) it saves synchronously, in manual mode ([y]) asynchronously.

@matej_suchanek Maybe the funniest, but completely logical. When reviewing one page after another using y or n options, user doesn't want to wait for script to process and save a page. User just wants to see diff and make a decision, see another diff and make another decision, process/save stuff should run in the background (second thread) and not waste user's time. In always mode user usually doesn't care, when script saves the page, it can be synced or asynced, whatever (but better synced in order to have a clean and readable terminal/log output.TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: Edit counter gives wrong result in replace.py

Mpaa added a comment.

In T147178#3568041, @Mpaa wrote:
If you change stopme() to use _flush(True) instead of _flush(False), it works.
 Maybe it can help to understand?


False track ...TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T174615: Arwiki noreferences.py

gerritbot added a comment.
Change 374896 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] noreferences.py: arwiki config

https://gerrit.wikimedia.org/r/374896TASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Framawiki, gerritbotCc: gerritbot, Framawiki, Aklapper, alanajjar, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T174615: Arwiki noreferences.py

Framawiki added a comment.
I've edited the summary message on translatewikiTASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, Framawiki, Aklapper, alanajjar, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T174615: Arwiki noreferences.py

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Framawiki, gerritbotCc: gerritbot, Framawiki, Aklapper, alanajjar, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Claimed] T174615: Arwiki noreferences.py

Framawiki claimed this task.Framawiki added a comment.
@alanajjar is a trusted user, I'll do this change.TASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, Aklapper, alanajjar, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T147178: Edit counter gives wrong result in replace.py

Framawiki removed a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T147178: Edit counter gives wrong result in replace.py

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Lordiis, Adik2382, Jrbranaa, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: Edit counter gives wrong result in replace.py

gerritbot added a comment.
Change 374894 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] replace.py: Temporary comment unessential wrong count output

https://gerrit.wikimedia.org/r/374894TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: Edit counter gives wrong result in replace.py

Framawiki added a comment.
As this bug is still alive a year later, and it only concerns an output that is not essential, I'll submit a patch to temporary disable it.TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Retitled] T147178: Edit counter gives wrong result in replace.py

Framawiki renamed this task from "replace.py gives a wrong edit result" to "Edit counter gives wrong result in replace.py".
TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T147178: replace.py gives a wrong edit result

Mpaa added a comment.
AFAIK, there is only one _putthread, where all _async requests are sent. Am I wrong?

If you change stopme() to use _flush(True) instead of _flush(False), it works.
Maybe it can help to understand?TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc: matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T147178: replace.py gives a wrong edit result

2017-08-30 Thread matej_suchanek

matej_suchanek added a comment.
(a)sync_callback is executed after a response from the wiki is received. When the last page from the generator is being treated, an asynchronous save action will launch a second thread, which handles the response. However, the main thread continues running and immediately exits the script (with printing the final message), before the second thread is finished.

T151727 & T171713 are two ways how to improve this.

The funniest fact at the end: this script has sync/async saving swapped, compared to other standard bots. In other words, with -always ([a]) it saves synchronously, in manual mode ([y]) asynchronously.TASK DETAILhttps://phabricator.wikimedia.org/T147178EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Edited] T174615: Arwiki noreferences.py

2017-08-30 Thread alanajjar

alanajjar updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONHello, can any one help to change (in [[https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/scripts/noreferences.py|this script]])


```...TASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alanajjarCc: Aklapper, alanajjar, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T174615: Arwiki noreferences.py

2017-08-30 Thread alanajjar

alanajjar created this task.alanajjar added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONHello, can any one help to change

'ar': ['Reflist', 'مراجع', 'ثبت المراجع', 'ثبت_المراجع',
   'بداية المراجع', 'نهاية المراجع'],

to be

'ar': ['Reflist', 'مراجع', 'ثبت المراجع', 'ثبت_المراجع',
   'بداية المراجع', 'نهاية المراجع', 'المراجع'],

and can please change the bot summary from (بوت: إضافة وسم  مفقود) 
to (بوت: إضافة {{قا|مراجع}} مفقود لمقالة [[ويكيبيديا:مراجع|بمراجع]]).

ThanksTASK DETAILhttps://phabricator.wikimedia.org/T174615EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: alanajjarCc: Aklapper, alanajjar, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Updated] T147178: replace.py gives a wrong edit result