[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
Shreyasminocha added a comment. @Xyt To clarify, I haven't implemented the second approach. We have two options—the regex-based approach I illustrated or an index-based approach (looping over the characters in the string, looking for an open parenthesis and trimming everything after that or a more advanced version of the same to handle edge cases such as nested parens, unmatched parens, multiple parens).TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ShreyasminochaCc: D3r1ck01, Liuxinyu970226, revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
Xqt added a comment. @D3r1ck01 @Xqt and others: Do you prefer a regex or an index approach here ? The second looks cleaner to me. Sorry, I don’t have it. Could you show me the different approach? What about implementing this as a param like withoutDisambiguation in page.title() method? That would allow to easily reuse it elsewhere. Sounds good but there is a general problem with it which isn’t taken into account: There may be real titles which has these bracket tail included. Therefore sth. without_brackets would be more neutral but doesn’t solve that underlying problem I also think that this param use can be directly added in create_item_for_page() , and in this case scripts/newitem.py would not be modified. Agree Best xqtTASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Shreyasminocha, XqtCc: D3r1ck01, Liuxinyu970226, revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository
D3r1ck01 added a comment. @Framawiki, will start creating corresponding GCI tasks for this and will tag us as mentors during the weekend. Thanks :)TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T207836: Fix W504 issues across files in the Pywikibot repository
D3r1ck01 updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION/scripts/listpages.py:161:17: W504 line break after binary operator ./scripts/welcome.py:800:31: W504 line break after binary operator ./scripts/nowcommons.py:278:25: W504 line break after binary operator...TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: D3r1ck01Cc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
D3r1ck01 added a comment. @Framawiki, if it's per this, https://gerrit.wikimedia.org/r/c/pywikibot/core/+/470627, then I'll say regex solutions become really confusing if they're trying to solve a complex problem hence making it difficult for one to understand a code base if we have many of them. Regex are good for solving parsing problems and somewhat fast as well but indexing seems generally easier to understand no matter how complex the problem is compared to regex and fast too. But in this case that we're just checking for brackets (pretty straight forward), it's a pretty simpler problem and I think any solution here (regex or indexing) can work well and will not cause so much trouble. But honestly, for future proofing of code and scalability, I'll go for the index approach but let's hear what others have to say :)TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Shreyasminocha, D3r1ck01Cc: D3r1ck01, Liuxinyu970226, revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T207836: Fix W504 issues across files in the Pywikibot repository
Framawiki added a comment. Will mentor too.TASK DETAILhttps://phabricator.wikimedia.org/T207836EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: Framawiki, gerritbot, Aklapper, pywikibot-bugs-list, D3r1ck01, Dvorapa, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample
gerritbot added a comment. Change 470550 merged by jenkins-bot: [pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0] https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T200399: Make Pywikibot remove disambiguation bracket in labels to created new items for articles in Wikidata
Framawiki added a subscriber: D3r1ck01.Framawiki added a comment. @D3r1ck01 @Xqt and others: Do you prefer a regex or an index approach here ? The second looks cleaner to me. What about implementing this as a param like withoutDisambiguation in page.title() method? That would allow to easily reuse it elsewhere. I also think that this param use can be directly added in create_item_for_page() , and in this case scripts/newitem.py would not be modified.TASK DETAILhttps://phabricator.wikimedia.org/T200399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Shreyasminocha, FramawikiCc: D3r1ck01, Liuxinyu970226, revi, jayvdb, JAnD, Framawiki, matej_suchanek, Xqt, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample
Multichill added a comment. In T208292#4705393, @Xqt wrote: Hm, this script never worked. Do we need it ;) It worked, but someone broke it. Tons of things have changed in the library part, but I don't think impact on the scripts that are using it is noticed enough.TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MultichillCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T208303: test_Coordinate_get_globe_item_different_repo is failing
Dalba closed this task as "Resolved".Dalba assigned this task to matej_suchanek.Dalba added a comment. Thanks, Matěj!TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, DalbaCc: matej_suchanek, Lokal_Profil, Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T208303: test_Coordinate_get_globe_item_different_repo is failing
matej_suchanek added a comment. There was an error on test.wikidata: https://test.wikidata.org/w/index.php?title=Q123=314870#P10. I restored the earliest revision of the item.TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: matej_suchanek, Lokal_Profil, Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Reassigned] T163661: site.messages() gives not the right state
Xqt reassigned this task from Xqt to matej_suchanek. TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanek, XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T163661: site.messages() gives not the right state
Xqt closed this task as "Resolved".Xqt claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Triaged] T208303: test_Coordinate_get_globe_item_different_repo is failing
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: matej_suchanek, Lokal_Profil, Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T208303: test_Coordinate_get_globe_item_different_repo is failing
Dalba added a project: Pywikibot-Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T208303EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T208303: test_Coordinate_get_globe_item_different_repo is failing
Dalba created this task.Dalba added projects: Pywikibot, Pywikibot-tests.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot/jobs/448209151 __ TestWikibaseCoordinateNonDry.test_Coordinate_get_globe_item_different_repo __ self =def test_Coordinate_get_globe_item_different_repo(self): """Test getting globe item in different repo from Coordinate.""" repo = self.get_repo() test_repo = pywikibot.Site('test', 'wikidata') q = pywikibot.Coordinate( site=repo, lat=12.0, lon=13.0, precision=0, globe_item='http://test.wikidata.org/entity/Q123') > self.assertEqual(q.get_globe_item(test_repo), ItemPage(test_repo, 'Q123')) tests/wikibase_tests.py:265: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ pywikibot/__init__.py:464: in get_globe_item return ItemPage.from_entity_uri(repo, self.entity, lazy_load) pywikibot/page.py:4433: in from_entity_uri if not lazy_load and not item.exists(): pywikibot/page.py:3859: in exists self.get(get_redirect=True) pywikibot/page.py:4449: in get data = super(ItemPage, self).get(force, *args, **kwargs) pywikibot/page.py:3949: in get c = Claim.fromJSON(self.repo, claim) pywikibot/page.py:4886: in fromJSON claim.type, lambda value, site: value)(value, site) pywikibot/page.py:4817: in FilePage(pywikibot.Site('commons', 'commons'), value), # T90492 pywikibot/tools/__init__.py:1740: in wrapper return obj(*__args, **__kw) pywikibot/page.py:2423: in __init__ super(FilePage, self).__init__(source, title, 6) pywikibot/tools/__init__.py:1740: in wrapper return obj(*__args, **__kw) pywikibot/page.py:2272: in __init__ super(Page, self).__init__(source, title, ns) pywikibot/page.py:196: in __init__ self._link = Link(title, source=source, default_namespace=ns) pywikibot/tools/__init__.py:1740: in wrapper return obj(*__args, **__kw) pywikibot/page.py:5518: in __init__ self._text = url2unicode(self._text, encodings=encodings) pywikibot/tools/__init__.py:1740: in wrapper return obj(*__args, **__kw) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ title = {'altitude': None, 'globe': 'http://www.wikidata.org/entity/Q2', 'latitude': 48.9861, 'longitude': -113.622, ...} encodings = ['utf-8', 'utf-8'] @deprecated_args(site2=None, site='encodings') def url2unicode(title, encodings='utf-8'): """ Convert URL-encoded text to unicode using several encoding. Uses the first encoding that doesn't cause an error. @param title: URL-encoded character data to convert @type title: str @param encodings: Encodings to attempt to use during conversion. @type encodings: str, list or Site @rtype: unicode @raise UnicodeError: Could not convert using any encoding. """ if isinstance(encodings, basestring): encodings = [encodings] elif isinstance(encodings, pywikibot.site.BaseSite): # create a list of all possible encodings for both hint sites site = encodings encodings = [site.encoding()] + list(site.encodings()) first_exception = None for enc in encodings: try: > t = title.encode(enc) E AttributeError: 'dict' object has no attribute 'encode' pywikibot/page.py:6108: AttributeError -- Captured log call --- logging.py 109 VERBOSE Found 1 wikidata:test processes running, including this one. __ TestWbQuantityNonDry.test_WbQuantity_get_unit_item_different_repo ___ self = def test_WbQuantity_get_unit_item_different_repo(self): """Test getting unit item in different repo from WbQuantity.""" repo = self.get_repo() test_repo = pywikibot.Site('test', 'wikidata') q = pywikibot.WbQuantity(amount=1234, error=1, site=repo, unit='http://test.wikidata.org/entity/Q123') > self.assertEqual(q.get_unit_item(test_repo), ItemPage(test_repo, 'Q123')) tests/wikibase_tests.py:615: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ pywikibot/__init__.py:847: in get_unit_item self._unit = ItemPage.from_entity_uri(repo, self._unit, lazy_load) pywikibot/page.py:4433: in from_entity_uri if not lazy_load and not item.exists(): pywikibot/page.py:3859: in exists self.get(get_redirect=True) pywikibot/page.py:4449: in get data = super(ItemPage, self).get(force, *args, **kwargs) pywikibot/page.py:3949: in get
[Pywikipedia-bugs] [Maniphest] [Commented On] T163661: site.messages() gives not the right state
gerritbot added a comment. Change 469930 merged by jenkins-bot: [pywikibot/core@master] [Bugfix] Check appropriate key in Site.messages https://gerrit.wikimedia.org/r/469930TASK DETAILhttps://phabricator.wikimedia.org/T163661EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T207579: imagecopy_tests failing with IndexError
Xqt removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Wenyi, AndyTan, Zylc, 1978Gage2001, Chicocvenancio, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, srodlund, mys_721tx, Gryllida, jayvdb, Masti, scfc, Alchimista, Mbch331, Rxy, Krenair, chasemp, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample
Xqt added a comment. Hm, this script never worked. Do we need it ;)TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Triaged] T208292: imagecopy fails for a given sample
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T208292: imagecopy fails for a given sample
gerritbot added a comment. Change 470550 had a related patch set uploaded (by Xqt; owner: Xqt): [pywikibot/core@master] [deprecated] Use latest_file_info.user instead of getLatestUploader()[0] https://gerrit.wikimedia.org/r/470550TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T208292: imagecopy fails for a given sample
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, pywikibot-bugs-list, Multichill, Xqt, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError
gerritbot added a comment. Change 469049 merged by jenkins-bot: [pywikibot/core@master] [test] Temporary accept imagecopy_tests.py failing https://gerrit.wikimedia.org/r/469049TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, srodlund, mys_721tx, Gryllida, jayvdb, Masti, scfc, Alchimista, Mbch331, Rxy, Krenair, chasemp___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError
Dvorapa added a comment. @Xqt I thought Magnus will be faster (he was for the first problem), the test disabling patch would be useless for one day, but now I think we can disable the tests until Magnus will have the time to fix the tool properly.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, srodlund, mys_721tx, Gryllida, jayvdb, Masti, scfc, Alchimista, Mbch331, Rxy, Krenair, chasemp___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T208292: imagecopy fails for a given sample
Xqt created this task.Xqt added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONThere is a sample for this script given in the doc but it fails: C:\pwb\GIT\core>pwb.py imagecopy -newimages:100 Retrieving 49 pages from wikipedia:de. WARNING: .\scripts\imagecopy.py:536: DeprecationWarning: pywikibot.page.FilePage .getLatestUploader is deprecated for 3 years and 11 months; use FilePage.latest_ file_info.user instead. username = imagepage.getLatestUploader()[0] Traceback (most recent call last): File "C:\pwb\GIT\core\pwb.py", line 257, in if not main(): File "C:\pwb\GIT\core\pwb.py", line 250, in main run_python_file(filename, [filename] + args, argvu, file_package) File "C:\pwb\GIT\core\pwb.py", line 119, in run_python_file main_mod.__dict__) File ".\scripts\imagecopy.py", line 594, in main() File ".\scripts\imagecopy.py", line 555, in main imagepage.templates()).getnewname() File ".\scripts\imagecopy.py", line 403, in __init__ super(TkdialogIC, self).__init__() TypeError: __init__() missing 3 required positional arguments: 'photo_descriptio n', 'photo', and 'filename' CRITICAL: Closing network session. C:\pwb\GIT\core>TASK DETAILhttps://phabricator.wikimedia.org/T208292EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T207579: imagecopy_tests failing with IndexError
Xqt added a comment. @Dvorapa: why shouldn't we disable thoses tests temporarily with that patch committed in https://gerrit.wikimedia.org/r/469049? The problem is noted here and it seems not easy to solve. All further travis and appveyor tests are failing now and there is no focus to other tests when they are failing currently. And last but not least I planned to upload the next release to pypi the next days but I always wait for some successfull tests.TASK DETAILhttps://phabricator.wikimedia.org/T207579EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Dvorapa, gerritbot, Magnus, D3r1ck01, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, srodlund, mys_721tx, Gryllida, jayvdb, Masti, scfc, Alchimista, Mbch331, Rxy, Krenair, chasemp___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
