[Pywikipedia-bugs] [Maniphest] [Updated] T184115: Pywikibot: Add missing docstring params

[Framawiki]

Framawiki added a project: Google-Code-in-2018.Framawiki added a comment.
Filled for 2018 as https://codein.withgoogle.com/tasks/5761442767699968/, will mentor with whoever wants it.TASK DETAILhttps://phabricator.wikimedia.org/T184115EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: D3r1ck01, Aklapper, pywikibot-bugs-list, MtDu, Framawiki, jayvdb, Wenyi, Kieubinhtb, Wonnral, Asad_Ali_Palijo, Cpaulf30, Bright1055, Lahi, Toppole69, Ivana_Isadora, Mine0901, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, Tbscho, MayS, Beeyan, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, srodlund, SimmeD, mys_721tx, Dinoguy1000, Dalba, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T200234: Create edit groups when running Wikidata-related scripts

[Pintoch]

Pintoch added a comment.
@Criscod yes that would be a great idea.TASK DETAILhttps://phabricator.wikimedia.org/T200234EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PintochCc: Criscod, Pintoch, jayvdb, Framawiki, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T200234: Create edit groups when running Wikidata-related scripts

[Criscod]

Criscod added a comment.
Would it be possible to ask the user of the tool to enter a one line natural language text describing the edit group? That would help others understand what the edit group did when looking here: https://tools.wmflabs.org/editgroups/TASK DETAILhttps://phabricator.wikimedia.org/T200234EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CriscodCc: Criscod, Pintoch, jayvdb, Framawiki, Aklapper, pywikibot-bugs-list, Bugreporter, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Ricordisamoa, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Created] T208484: TestIsbnWikibaseBot.test_isbn_format is failing with TypeError

[Dalba]

Dalba created this task.Dalba added projects: Pywikibot, Pywikibot-tests, Pywikibot-Wikidata.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONhttps://travis-ci.org/wikimedia/pywikibot/jobs/449178336#L3750

 ERROR at setup of TestIsbnWikibaseBot.test_isbn_format 
cls = 
@classmethod
def setUpClass(cls):
"""Set up test class."""
super(TestIsbnWikibaseBot, cls).setUpClass()

# Check if the unit test item page and the property both exist
item_ns = cls.get_repo().item_namespace
for page in cls.get_site().search('IsbnWikibaseBotUnitTest'
  total=1, namespaces=item_ns):
cls.test_page_qid = page.title()
item_page = ItemPage(cls.get_repo(), page.title())
>   for pid, claims in item_page.get()['claims'].items():
tests/isbn_tests.py:253: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pywikibot/page.py:4449: in get
data = super(ItemPage, self).get(force, *args, **kwargs)
pywikibot/page.py:3949: in get
c = Claim.fromJSON(self.repo, claim)
pywikibot/page.py:4886: in fromJSON
claim.type, lambda value, site: value)(value, site)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
value = '097522980x', site = DataSite("test", "wikidata")
'wikibase-item': lambda value, site:
>   ItemPage(site, 'Q' + str(value['numeric-id']))
'wikibase-property': lambda value, site:
PropertyPage(site, 'P' + str(value['numeric-id']))
'commonsMedia': lambda value, site:
FilePage(pywikibot.Site('commons', 'commons'), value),  # T90492
'globe-coordinate': pywikibot.Coordinate.fromWikibase
'geo-shape': pywikibot.WbGeoShape.fromWikibase
'tabular-data': pywikibot.WbTabularData.fromWikibase
'time': pywikibot.WbTime.fromWikibase
'quantity': pywikibot.WbQuantity.fromWikibase
'monolingualtext': lambda value, site:
pywikibot.WbMonolingualText.fromWikibase(value)
}
E   TypeError: string indices must be integers
pywikibot/page.py:4813: TypeError
-- Captured log setup --
logging.py 109 VERBOSE  Found 1 wikidata:test processes running, including this one.
_ ERROR at setup of TestIsbnWikibaseBot.test_isbn_to13 _
cls = 
@classmethod
def setUpClass(cls):
"""Set up test class."""
super(TestIsbnWikibaseBot, cls).setUpClass()

# Check if the unit test item page and the property both exist
item_ns = cls.get_repo().item_namespace
for page in cls.get_site().search('IsbnWikibaseBotUnitTest'
  total=1, namespaces=item_ns):
cls.test_page_qid = page.title()
item_page = ItemPage(cls.get_repo(), page.title())
>   for pid, claims in item_page.get()['claims'].items():
tests/isbn_tests.py:253: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pywikibot/page.py:4449: in get
data = super(ItemPage, self).get(force, *args, **kwargs)
pywikibot/page.py:3949: in get
c = Claim.fromJSON(self.repo, claim)
pywikibot/page.py:4886: in fromJSON
claim.type, lambda value, site: value)(value, site)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
value = '097522980x', site = DataSite("test", "wikidata")
'wikibase-item': lambda value, site:
>   ItemPage(site, 'Q' + str(value['numeric-id']))
'wikibase-property': lambda value, site:
PropertyPage(site, 'P' + str(value['numeric-id']))
'commonsMedia': lambda value, site:
FilePage(pywikibot.Site('commons', 'commons'), value),  # T90492
'globe-coordinate': pywikibot.Coordinate.fromWikibase
'geo-shape': pywikibot.WbGeoShape.fromWikibase
'tabular-data': pywikibot.WbTabularData.fromWikibase
'time': pywikibot.WbTime.fromWikibase
'quantity': pywikibot.WbQuantity.fromWikibase
'monolingualtext': lambda value, site:
pywikibot.WbMonolingualText.fromWikibase(value)
}
E   TypeError: string indices must be integers
pywikibot/page.py:4813: TypeErrorTASK DETAILhttps://phabricator.wikimedia.org/T208484EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs