[Pywikipedia-bugs] [Maniphest] [Commented On] T122763: unsupported operand type for generator and set
gerritbot added a comment. Change 423701 merged by jenkins-bot: [pywikibot/core@master] [bugfix] ensure "modules" parameter of ParamInfo._fetch is a set https://gerrit.wikimedia.org/r/423701TASK DETAILhttps://phabricator.wikimedia.org/T122763EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: Framawiki, gerritbot, XZise, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: Convert english template titles to localised ones with cosmetic_changes.py
Dvorapa added a comment. In T212704#484, @Xqt wrote: I thought it would make complete sense to add this into fixing_redirects.py. But I realized, that for conversion between latin and non-latin script, cosmetic_changes.py is much more apropriate. I suggest to add this feature to the fixing_redirects and import it in cosmetic_changes for some chosen wikis. I propose the other way in that sense: fixing_redirect.py is just a script but cc is the library part. Oh yes, sure.TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: Framawiki, gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: Convert english template titles to localised ones with cosmetic_changes.py
Xqt added a comment. I thought it would make complete sense to add this into fixing_redirects.py. But I realized, that for conversion between latin and non-latin script, cosmetic_changes.py is much more apropriate. I suggest to add this feature to the fixing_redirects and import it in cosmetic_changes for some chosen wikis. I propose the other way in that sense: fixing_redirect.py is just a script but cc is the library part.TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Framawiki, gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unassigned] T212741: classes derived from object should always call super in Initializer
Xqt removed Xqt as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T212741EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Framawiki, Aklapper, pywikibot-bugs-list, Xqt, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unassigned] T212740: Insufficient polymorphism implementation of specialbots EditReplacement class
Xqt removed Xqt as the assignee of this task. TASK DETAILhttps://phabricator.wikimedia.org/T212740EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Framawiki, Zoranzoki21, Magul, Aklapper, Xqt, pywikibot-bugs-list, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T132138: Perform full test suite using Wikimedia CI
hashar edited projects, added Continuous-Integration-Config; removed Continuous-Integration-Infrastructure. TASK DETAILhttps://phabricator.wikimedia.org/T132138EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, hasharCc: Framawiki, Ricordisamoa, jayvdb, Aklapper, JanZerebecki, pywikibot-bugs-list, Sadisticturd, Wenyi, A.S.Kochergin, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy, hashar, thcipriani, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T212704: Convert english template titles to localised ones with cosmetic_changes.py
Framawiki renamed this task from "[Feature] Feature request in cosmetic_changes.py" to "Convert english template titles to localised ones with cosmetic_changes.py". TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: FramawikiCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: [Feature] Feature request in cosmetic_changes.py
Dvorapa added a comment. In T212704#4847591, @MuhammadShuaib wrote: And one more cosmetic change can be added. If an article starts with such words that match ecactly with current article title, cc will add ''' around them to make them bold. This feature exists in AWB. Like this edit on Urdu wiki where title and starting words are same: https://ur.wikipedia.org/wiki/Special:Diff/3742808 Seems easy to doTASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: [Feature] Feature request in cosmetic_changes.py
Dvorapa added a comment. In T212704#4847561, @MuhammadShuaib wrote: In T212704#4847560, @Xqt wrote: Other languages' pages are connected on wikidata https://www.wikidata.org/wiki/Q13380729 Great. Then we can have a solution for all sites. Why should this become a solution of cc and not of template.py or fixing_redirects.py? You knows better, but I think that fixing_redirects.py is meant to fix broken redirects. Isnt it? I thought it would make complete sense to add this into fixing_redirects.py. But I realized, that for conversion between latin and non-latin script, cosmetic_changes.py is much more apropriate. I suggest to add this feature to the fixing redirects and import it to cosmetic_changes for some chosen wikis.TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T212741: classes derived from object should always call super in Initializer
Xqt created this task.Xqt added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONIf a class is derived from multiple instances, the initializer must alway call ist super initializer even the class is derived from object. Otherwise the MRO chain is broken:
>>> class foo(object):
def __init__(self):
print('foo')
>>> class bar(object):
def __init__(self):
print('bar')
>>> class baz(foo, bar):
def __init__(self):
print('baz')
super(baz, self).__init__()
>>> x = baz()
baz
foo
bar initializer isn't called here whereas the following works as expected:
>>> class foo(object):
def __init__(self):
print('foo')
super(foo, self).__init__()
>>> class bar(object):
def __init__(self):
print('bar')
super(bar, self).__init__()
>>> class baz(foo, bar):
def __init__(self):
print('baz')
super(baz, self).__init__()
>>> x = baz()
baz
foo
barTASK DETAILhttps://phabricator.wikimedia.org/T212741EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, pywikibot-bugs-list, Xqt, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Triaged] T212741: classes derived from object should always call super in Initializer
Xqt triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T212741EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Aklapper, pywikibot-bugs-list, Xqt, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T212740: Insufficient polymorphism implementation of specialbots EditReplacement class
Xqt triaged this task as "High" priority.Xqt claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T212740EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, Magul, Aklapper, Xqt, pywikibot-bugs-list, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T212740: Insufficient polymorphism implementation of specialbots EditReplacement class
Xqt created this task.Xqt added a project: Pywikibot.Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONbot_choice.Option is derived by subclasses which sometimes overwrites stop properties and gives always False for example. But specialbots.EditReplacement is derived from ChoiceException and UnhandledAnswer which sets a stop attribute. ChoiceException is derived from StandardOption and Exception. StandardOption is derived from Option and has a stop property which has to be set by a setter property. Otherwise it will fail. UnhandledAnswer is an Exception which also sets a stop attribute. See https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/321576/ Sample: >>> import pwb, pywikibot as py >>> from pywikibot.specialbots import EditReplacement >>> raise EditReplacement Traceback (most recent call last): File "pywikibot\specialbots.py", line 495, in __init__ self.stop = True AttributeError: can't set attribute >>>TASK DETAILhttps://phabricator.wikimedia.org/T212740EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: Zoranzoki21, Magul, Aklapper, Xqt, pywikibot-bugs-list, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T212704: [Feature] Feature request in cosmetic_changes.py
MuhammadShuaib updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONThose wikipedias who import templates from English wikipedia, generally create redirects of english title to local one. But many times original english names of template are being used in pages. Is it possible to add feature in cosmetic_changes.py to convert thisese english namtitles to localised ones? Hope this feature is useful for many wikipedias. ...TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MuhammadShuaibCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: [Feature] Feature request in cosmetic_changes.py
MuhammadShuaib added a comment. And one more cosmetic change can be added. If an article starts with such words that match ecactly with current article title, cc will add ''' around them to make it bold. This feature exists in AWB. Like this edit on Urdu wiki where title and starting words are same: https://ur.wikipedia.org/wiki/Special:Diff/3742808TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MuhammadShuaibCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212723: Exception - No username
Xqt added a comment. I can reproduce it with the following traceback: C:\pwb\GIT\core>pwb.py touch -page:user:xqt/Test family and mylang are not set. Defaulting to family='test' and mylang='test'. Traceback (most recent call last): File "C:\pwb\GIT\core\pywikibot\login.py", line 112, in __init__ self.username = self.username or family_usernames['*'] KeyError: '*' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\pwb\GIT\core\pwb.py", line 257, in if not main(): File "C:\pwb\GIT\core\pwb.py", line 250, in main run_python_file(filename, [filename] + args, argvu, file_package) File "C:\pwb\GIT\core\pwb.py", line 119, in run_python_file main_mod.__dict__) File ".\scripts\touch.py", line 133, in main() File ".\scripts\touch.py", line 124, in main pywikibot.Site().login() File "C:\pwb\GIT\core\pywikibot\site.py", line 2123, in login site=self, sysop=sysop, user=self._username[sysop]) File "C:\pwb\GIT\core\pywikibot\tools\__init__.py", line 1737, in wrapper return obj(*__args, **__kw) File "C:\pwb\GIT\core\pywikibot\login.py", line 120, in __init__ 'wiki_code': self.site.code}) pywikibot.exceptions.NoUsername: ERROR: Username for test:test is undefined. If you have an account for that site, please add a line to user-config.py: usernames['test']['test'] = 'myUsername' CRITICAL: Exiting due to uncaught exception C:\pwb\GIT\core> Seems an pywikibot environment variable 'PYWIKIBOT_NO_USER_CONFIG' or 'PYWIKIBOT2_NO_USER_CONFIG' is set. @Wesalius: could you please provide the whole traceback including the command line or use touch.py like me: pwb.py touch -page:user:Wesalius. Please also check the Environment variables either via command line or using python idle or better via pwb shell: pwb.py shell >>> from os import environ >>> sorted(environ.keys()) ['ALLUSERSPROFILE', 'APPDATA', 'ASL.LOG', 'AUTINSTLOG', 'COMMONPROGRAMFILES', ... 'PROGRAMW6432', 'PROMPT', 'PSMODULEPATH', 'PUBLIC', 'PYWIKIBOT_DIR_PWB', 'S7TMP', 'SESSIONNAME', ... 'USERPROFILE', 'WINDIR', 'WINDOWS_TRACING_FLAGS', 'WINDOWS_TRACING_LOGFILE']TASK DETAILhttps://phabricator.wikimedia.org/T212723EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: zhuyifei1999, Dvorapa, Xqt, Zoranzoki21, Aklapper, Wesalius, pywikibot-bugs-list, Wenyi, Mahveotm, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: [Feature] Feature request in cosmetic_changes.py
MuhammadShuaib added a comment. In T212704#4847560, @Xqt wrote: Other languages' pages are connected on wikidata https://www.wikidata.org/wiki/Q13380729 Great. Then we can have a solution for all sites. Why should this become a solution of cc and not of template.py or fixing_redirects.py? You knows better, but I think that fixing_redirects.py is meant to fix broken redirects. Isnt it?TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MuhammadShuaibCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T212704: [Feature] Feature request in cosmetic_changes.py
Xqt added a comment. Other languages' pages are connected on wikidata https://www.wikidata.org/wiki/Q13380729 Great. Then we can have a solution for all sites. Why should this become a solution of cc and not of template.py or fixing_redirects.py?TASK DETAILhttps://phabricator.wikimedia.org/T212704EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Dvorapa, Xqt, Aklapper, MuhammadShuaib, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
