[Pywikipedia-bugs] [Maniphest] [Commented On] T136074: pytest_attrib in dev-requirements.txt doesnt install, breaking Travis and Appveyor CI
AbdealiJK added a comment. Is this still an issue? I thought the latest version fixed it according to the github commentsTASK DETAILhttps://phabricator.wikimedia.org/T136074EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T90149: LDAP based login is broken in pywikibot because lgdomain is not set
AbdealiJK added a comment. why in API.py? Can't it be done in the login.py like how it was done in compact?TASK DETAILhttps://phabricator.wikimedia.org/T90149EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, TerraCodes, Riddlesj, darthbhyrava, jayvdb, XZise, pywikibot-bugs-list, Aklapper, Multichill, MayS, Mdupont, JJMC89, MuhammadShuaib, droid, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)
AbdealiJK added a comment. @Vyeshwant123 Sorry about that! I'd recommend you go ahead and find another bug to solve :)TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, AbdealiJKCc: AbdealiJK, Xqt, gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T146580: Pywikibot Script image.py Site warnings
AbdealiJK removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T146580EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Mpaa, gerritbot, Aklapper, TerraCodes, pywikibot-bugs-list, AbdealiJK, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Subscribers] T146580: Pywikibot Script image.py Site warnings
AbdealiJK added a subscriber: Mpaa.AbdealiJK added a comment. @Mpaa while I understand that you could solve this task in less than a minute, it would be useful to leave these #easy tasks for people who would like to begin contributing to pywikibot. Especially something like this low priority, easy task. Otherwise it's difficult to get someone initiated to pywikibot bug solving. And they can learn git, gerrit, and the Wikimedia basics with these.TASK DETAILhttps://phabricator.wikimedia.org/T146580EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Mpaa, gerritbot, Aklapper, TerraCodes, pywikibot-bugs-list, AbdealiJK, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T1315: Release 2.0
AbdealiJK added a comment. Can the critical bug fixes be mentioned by adding them as subtasks ? This would give more clarity to find things and also to see how close we are to the next releaseTASK DETAILhttps://phabricator.wikimedia.org/T1315EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, AbdealiJKCc: AbdealiJK, StudiesWorld, Aklapper, Ricordisamoa, Xqt, jayvdb, pywikibot-bugs-list, XZise, MayS, Mdupont, JJMC89, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T145642: image.py fails on image removals at Meta
AbdealiJK closed this task as "Resolved".AbdealiJK added a comment. Agree, that's a bit irritating, but as it's warnings it is not fatal. I've created the task T146580 which will look into removing those warnings for image.py Closing this task.TASK DETAILhttps://phabricator.wikimedia.org/T145642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Ladsgroup, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T146580: Pywikibot Script image.py Site warnings
AbdealiJK created this task.AbdealiJK added projects: Easy, Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, TerraCodes, Aklapper. TASK DESCRIPTIONIt is confusing for users when the pywikibot.Bot gives warnings about self._site not being set. Currently in image.py it gives: >pwb.py image "Senior picture.jpg" WARNING: Bot.site was not set before being retrieved. WARNING: Using the default site: meta:meta Retrieving 1 pages from meta:meta. WARNING: Bot.site was not set before being retrieved. WARNING: Using the default site: meta:meta This can be simplified by just setting self.site in the constructor of the Bot class being used by image.py Marking as #easy, as it's simple to do and would be beneficial for new contributors.TASK DETAILhttps://phabricator.wikimedia.org/T146580EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, TerraCodes, pywikibot-bugs-list, AbdealiJK, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T75196: category.py more - add "-noredirect" option
AbdealiJK added a comment. Adding more context: The category.py has an option to move category pages from one title to another (rename) and so on. When the page is moved, the old page normally has a category redirect template added which helps in identifying where the category has moved for users who are used to the old category name. The -noredirect is useful for users with admin rights who can delete the category directly rather than adding the category redirect template.TASK DETAILhttps://phabricator.wikimedia.org/T75196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, TerraCodes, Steenth, pywikibot-bugs-list, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T64261: Throw specific error instead of generic APIError if claim target is deleted
AbdealiJK added projects: TestMe, Easy.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T64261EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, AbdealiJKCc: TerraCodes, jayvdb, pywikibot-bugs-list, MayS, Mdupont, JJMC89, MuhammadShuaib, Luke081515, Ricordisamoa, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T61080: isCategoryRedirect is very slow
AbdealiJK added a comment. Marking as easy. What essentially needs to be done is change the self.templatesWithParams() to self.templates() because we don't want the parameters which contain the target of the redirect. The appropritate functionality will have to be moved to getCategoryRedirectTarget as that's where the parameter (the redirect target) is needed. This makes the function faster because we lazily find the target only when needed.TASK DETAILhttps://phabricator.wikimedia.org/T61080EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, TerraCodes, jayvdb, Ricordisamoa, pywikibot-bugs-list, Multichill, Ladsgroup, MayS, Mdupont, JJMC89, MuhammadShuaib, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T61080: isCategoryRedirect is very slow
AbdealiJK added a project: Easy.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T61080EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: TerraCodes, jayvdb, Ricordisamoa, pywikibot-bugs-list, Multichill, Ladsgroup, MayS, Mdupont, JJMC89, MuhammadShuaib, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85271: document pywikibot.error and pywikibot.exception
AbdealiJK added a comment. By "document" what do you mean ? Where should this be documented ? What sort of information additionally should be added ?TASK DETAILhttps://phabricator.wikimedia.org/T85271EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, jayvdb, valhallasw, Aklapper, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista, Jay8g, Spage___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T75137: Wikia family nicepath is incorrect, but is functional
AbdealiJK added a comment. The codebase says that the function nicepath() is deprecated, and it is not being used by any of the scripts as of now in the scripts/. The only function using this in core is nice_get_address() ... which is also deprecated. Are nicepath() and nice_get_address() still needed ? Doesn't seem like anything is using it. If it's still needed and only an exception list is requried then we can tag this with #easyTASK DETAILhttps://phabricator.wikimedia.org/T75137EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, Aklapper, Grunny, jayvdb, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T75196: category.py more - add "-noredirect" option
AbdealiJK added a project: Easy.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T75196EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: TerraCodes, Steenth, pywikibot-bugs-list, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T137612: PageGenerator generating same page multiple times
AbdealiJK added a comment. The only solution to this, as I see it would be to save all the items in a set() and check if the page has already been generated.TASK DETAILhttps://phabricator.wikimedia.org/T137612EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, MayS, Mdupont, JJMC89, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T138692: Redirect error messages don't specify the pages
AbdealiJK added a comment. Works for me too, unable to reproduce this. What version of pywikibot/python is this in ?TASK DETAILhttps://phabricator.wikimedia.org/T138692EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, Mpaa, Aklapper, Zppix, pywikibot-bugs-list, APerson, MayS, Mdupont, JJMC89, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T144694: Port -first from compat to solve_disambiguation.py
AbdealiJK added a project: Easy.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T144694EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: TerraCodes, valhallasw, Aklapper, pywikibot-bugs-list, binbot, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Dalba, droid, Alchimista, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T145642: image.py fails on image removals at Meta
AbdealiJK added a comment. @MarcoAurelio can you check if you get this with the latest pywikibot code ? There is a commit on https://gerrit.wikimedia.org/r/#/c/282195/ which should have solved it.TASK DETAILhttps://phabricator.wikimedia.org/T145642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T145642: image.py fails on image removals at Meta
AbdealiJK claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T145642EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, jayvdb, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T145853: unusedfiles.py: if an image is already tagged, don't tag it again
AbdealiJK added a project: Easy.Herald added a subscriber: TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, MuhammadShuaib, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T85656: Pywikibot to detect and correctly handle edits that trigger abusefilter rules
AbdealiJK edited the task description. (Show Details) EDIT DETAILS...Co-mentor: <>@AbdealiJK Microtask: T56551, T103284, T103736...TASK DETAILhttps://phabricator.wikimedia.org/T85656EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: AbdealiJK, Shubhpatel108, Riddlesj, Billghost, darthbhyrava, Sumit, 01tonythomas, XZise, Multichill, Xqt, Mpaa, jayvdb, Aklapper, pywikibot-bugs-list, MayS, EdelyGomes, Sek2016, Enandwani, riyafa, AniaMag, PuriDilip, Pahadiahimanshu, Manrajsinghgrover, Mdupont, JJMC89, Samtar, Luke081515, Gryllida, Mvolz, Alchimista, Se4598, Jackmcbarn, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T66838: Port catimages.py to core
AbdealiJK closed subtask T129611: [GSoC 2016 Proposal] Port catimages.py to pywikibot-core as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T66838EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Vlkyrie, Sumit, DrTrigon, AbdealiJK, StudiesWorld, Shrutika719, Avicennasis, Aklapper, Xqt, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs-list, MelodyKramer, Pahadiahimanshu, Manrajsinghgrover, Lethexie, droid, Jay8g, matej_suchanek___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T129611: [GSoC 2016 Proposal] Port catimages.py to pywikibot-core
AbdealiJK closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T129611EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, Rillke, Sumit, 01tonythomas, Josve05a, Aklapper, pywikibot-bugs-list, AbdealiJK, jayvdb, DrTrigon, Lethexie, Mdupont, JJMC89, droid, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T129368: Usages of unittest.expectedFailure should be solved
AbdealiJK closed subtask T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T129368EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Mpaa, gerritbot, valhallasw, jayvdb, Aklapper, Xqt, pywikibot-bugs-list, Mdupont, JJMC89___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods
AbdealiJK closed this task as "Resolved".AbdealiJK added a comment. This has been merged into the stable pytest 3.0 Closing the taskTASK DETAILhttps://phabricator.wikimedia.org/T135594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont, JJMC89, Jay8g, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T129611: [GSoC 2016 Proposal] Port catimages.py to pywikibot-core
AbdealiJK closed subtask T133762: [GSoC requirement] Weekly Reports for Port catimages.py to pywikibot-core as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T129611EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, Rillke, Sumit, 01tonythomas, Josve05a, Aklapper, pywikibot-bugs-list, AbdealiJK, jayvdb, DrTrigon, Lethexie, Mdupont, JJMC89, droid, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T143491: Endterm evaluation for "Port catimages.py to pywikibot-core"
AbdealiJK edited the task description. (Show Details) EDIT DETAILSGSoC 2016 program enters into its final week soon. All interns should have discussed with their mentors by now on how to submit their work for evaluation as per - https://developers.google.com/open-source/gsoc/help/work-product The final GSoC report can be found at - https://commons.wikimedia.org/wiki/User:AbdealiJK/file-metadata/GSoC2016 **Copying from the above link:**...TASK DETAILhttps://phabricator.wikimedia.org/T143491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: DrTrigon, jayvdb, AbdealiJK, pywikibot-bugs-list, Aklapper, Josve05a, 01tonythomas, Rillke, zhuyifei1999, Sumit, Lethexie, Mdupont, JJMC89, droid, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T141194: Meeting 14 - Fri 29 July 2016 - 12:30 UTC
AbdealiJK closed this task as "Resolved".AbdealiJK claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T141194EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, pywikibot-bugs-list, jayvdb, AbdealiJK, DrTrigon, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T141235: Filter based on datetime
AbdealiJK closed this task as "Resolved".AbdealiJK claimed this task.AbdealiJK added a comment. @Mpaa that did work for a resolution for 1 day. For my purpose, 1Day is sufficient so I'm closing this task for the time being. If someone needs a smaller resolution it can be reopened.TASK DETAILhttps://phabricator.wikimedia.org/T141235EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Mpaa, Aklapper, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T141235: Filter based on datetime
AbdealiJK created this task.AbdealiJK added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONIt would be nice to provide a filter or generator which can generate all newly uploaded files between two datetimes given by the user. This helps in making time slotted bot runs. My exact usecase is that I have a image analyzer which runs on commons and I wanted to find accuracy and other statistics for each day of the week for all the new files uploaded in that day. Extending this, it would also be nice to have a filter/generator which provides all modified files in a time period and so on.TASK DETAILhttps://phabricator.wikimedia.org/T141235EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Aklapper, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T138582: Meeting 10 - Fri 1 July 2016 - 12:30 UTC
AbdealiJK added a comment. @jayvdb From my understanding, OSX wheel are there. Here is a travis build with OSX, Py35: https://travis-ci.org/python-pillow/pillow-wheels/jobs/141359557 Jobs 9 through 12 in the build https://travis-ci.org/python-pillow/pillow-wheels/builds/141359545 are for OSX. The osx builds are also there in the .travis.yml - https://github.com/python-pillow/pillow-wheels/pull/36/files#diff-354f30a63fb0907d4ad57269548329e3R56TASK DETAILhttps://phabricator.wikimedia.org/T138582EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: pywikibot-bugs-list, jayvdb, Aklapper, AbdealiJK, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T139144: Making a pypi package pywikibot-scripts for officially supported scripts
AbdealiJK created this task.AbdealiJK added a project: Pywikibot-core.Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTIONCurrently to run any of the scripts, the user needs to clone the git repo. This is not a very nice method for python projects, as pip is the defacto for installing python packages. It would be nice to make a pywikibot-scripts pypi packages which installs all pywikibot scripts. This way, for a user to install and run pywikibot's official scripts, all they'd have to do is: $ pip install pywikibot-scripts $ pwb
[Pywikipedia-bugs] [Maniphest] [Edited] T139143: Make a pywikibot entry point for scripts
AbdealiJK edited the task description. (Show Details) EDIT DETAILS...This way, other users can simply make a `pywikibot-` package on pypi and it can be linked to `pwb` as a plugin with entry points. other users can simply make a `pywikibot-` package on pypi and it can be linked to `pwb` as a plugin with entry points. Hence, it gives pywikibot the ability to make "plugins" which are run using a unified interface. Check out how pytest does it to get a better idea: https://pytest.org/latest/writing_plugins.htmlTASK DETAILhttps://phabricator.wikimedia.org/T139143EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: DrTrigon, jayvdb, pywikibot-bugs-list, Aklapper, Zppix, AbdealiJK, Mdupont, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T139141: Using pywikibot as a library
AbdealiJK created this task.AbdealiJK added projects: Pywikibot-core, Pywikibot-catimages.Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTIONI want to make a script and host it on pypi. To do this, I was thinking the user would need to do something like: $ pip install my_script_name $ my_script_name -cat:SomeCategory -limit:10 Now, I can add pywikibot as a install_requires and pip will install it for me. But there is no nice way for me to create the user-config.py file. I get an error that it's not found, and asking me to run pwb or make a PYWIKIBOT2_DIR - but a user who isn't used to pywikibot will get confused. I was thinking it may be a good idea to make generate_user_files.py into an console entry_point so that the error message is simplified to "Run $ generate_pywikibot_user_files to create a user-config".TASK DETAILhttps://phabricator.wikimedia.org/T139141EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: DrTrigon, Aklapper, jayvdb, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. The simplest way to install openCV would be sudo apt-get install python-opencv. I'm still working on making dependency handling slightly better, along with https://github.com/AbdealiJK/file-metadata/issues/46 The utilities.py:88 issue happens when the zxing and dlib data is downloading. So, after the first time it gets downloaded, it won't occur anymore. I have fixed it in my local repo (I was revamping related code, and I happened to notice this too)TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DrTrigon, AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T138121: Meeting 9 - Fri 24 June 2016 - 12:30 UTC
AbdealiJK added a comment. @DrTrigon Yes, matplotlib does not currently give suggestions. I've created https://github.com/matplotlib/matplotlib/pull/6575 for itTASK DETAILhttps://phabricator.wikimedia.org/T138121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon you can find the code for that at https://github.com/AbdealiJK/file-metadata/blob/95cc2abb3506608266b1faf0da0722433ad6b03b/tests/bulk.py Note that it has some extra args: -logname - The logname to write to. Used as -logname:Some_Name which tells it to write to User:/logs/Some_Name. -dryrun - Print the log rather than writing to the userspace. needs to be used as -dryrun:1 PS: I have not tested this script rigorously, no unittests, it's not "supported", etc. etc. Use at own risk.TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DrTrigon, AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T138582: Meeting 10 - Fri 1 July 2016 - 12:30 UTC
AbdealiJK moved this task from Backlog to GSoC Meetings on the Pywikibot-catimages board. TASK DETAILhttps://phabricator.wikimedia.org/T138582WORKBOARDhttps://phabricator.wikimedia.org/project/board/755/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: pywikibot-bugs-list, jayvdb, Aklapper, AbdealiJK, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T138121: Meeting 9 - Fri 24 June 2016 - 12:30 UTC
AbdealiJK added a comment. Regarding Project Plan, second 50%, again: I think it would be worth it to spend some time revamping how the installation of dependencies happens (again). I've gotten some inspiration from matplotlib, which has a generic SetupPackages class. This makes things quite streamlined and easy to understand. It has a class (inherited from SetupPackage) for every dependency. I think this makes a lot more sense and makes it easier to manage, This can remove the download() issues we have and can download everything with appropriate messages during pip install itself. (Which makes sense because installation/downloads shouldn't happen when running, it should happen when installing)TASK DETAILhttps://phabricator.wikimedia.org/T138121EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T138302: Midterm evaluation for "Port catimages.py to pywikibot-core"
AbdealiJK moved this task from Backlog to GSoC on the Pywikibot-catimages board. TASK DETAILhttps://phabricator.wikimedia.org/T138302WORKBOARDhttps://phabricator.wikimedia.org/project/board/755/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DrTrigon, AbdealiJKCc: Zppix, DrTrigon, jayvdb, AbdealiJK, pywikibot-bugs-list, Aklapper, Josve05a, Rillke, zhuyifei1999, Sumit, 01tonythomas, Lethexie, Mdupont, droid, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Actually I haven't updated the requirements.txt on the pypi version or in master yet. Not sure what the issue was, but it seems like pip resolved it.TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Ouch, sorry. just read the error message properly. It seems the Pillow version is really old ? (It doesn't seem to have a warning called DecompressionBombWarning). This was added in Pillow 2.5.0 according to release notes, I'll adding a minimum version in the requirements.txt. Also, Note that the latest version of file-metadata in git will not be compatible with the file_metadata_bot.py as analyze_barcode() has been removed in favour of the two new functions analyze_barcode_zxing() and analyze_barcode_zbar()TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Yeah, I think the pywikibot thing is a bit confusing too. I assumed pywikibot veterans would be trying that. I'd like @jayvdb 's opinion on how a script not inside /pywikibot/scripts is supposed to use pywikibot. Is there an example project I could look at ? (Currently import pywikibot assumes a user-config.py exists ... and is created by the user) The error in ImageFile is documented at https://github.com/AbdealiJK/file-metadata/issues/33 and fixed with a better warning message in master (Not fixed on v0.1.0 which is in pypi though)TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Ah. I just realized that in your case, the reason the wheel is not being used is because you have a really old version of pip which does not support wheels. pip install -U pip can be used to upgrade pip. But again, I'd recommend it be done inside a virtualenv ... (Otherwise apt-get's python-pip may cause confusion)TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon There is no special step involved for installing with wheels. pip install generally prefers using wheels if a wheel is found that is suitable for your system. If a wheel suitable for your system is not found, it compiles it from source. For example, on Travis, it uses the scikit wheel (.whl file) from pypi - Line 632 on the build 138811509 The specific wheel it uses on travis is scikit_image-0.12.3-cp27-cp27mu-manylinux1_x86_64.whl. Which means (Got this information from https://github.com/pypa/manylinux): cp27 means CPython 2.7 m in cp27mu means that pymalloc is available u in cp27mu means the python was compiled with UCS4 unicodes x86_64 - 64bit (or arch 64 or x64) computers only TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon wheels are like pre-compiled versions of a python package. As file-metadata does not need any compilation, it isnt very needed for our package. But our dependencies that have C code (skimage, numpy, scipy, dlib, matplotlib, wand) should normally have wheels to make it easy to install. I've modified the instructions at the readme page quite a bit. https://commons.wikimedia.org/wiki/User:AbdealiJK/file-metadata I hope this reduces confusion.TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon The numpy issue, I think the error message is quite clear. This error would not happen most of the time, because scikit-image does have wheels for most systems, and hence will not have to be compiled every time. Hence, I think it's better not to include it in the installation step, as the error message is clear + it should not happen majority of the time.TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Issue 1: Hm. So, the first issue is surprising. pypi normally does not guarantee the order of installation of packages. So, if pkgA needs pkgB for compilation, this can be a problem. Could you tell me which package gave an error about numpy not installed so I can investigate further ? Issue 2: This is the issue we noticed earlier about cython from the system being preinstalled, hence making the cython from pypi confused. The solution to this was to (1) make a virtualenv OR (2) uninstall the cython system package Could you add the issue 2 as a note to the wiki page at https://commons.wikimedia.org/wiki/User:AbdealiJK/file-metadata ? Or possibly a new section "Installation FAQ" or so ?TASK DETAILhttps://phabricator.wikimedia.org/T136985EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: zhuyifei1999, jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T138119: Use user-maintained bot run mode to gain stats and learn
AbdealiJK added a comment. This is an interesting question, and the major issue I see here is that the user's computer will hang if we do use it. So, the best method may be to have something like what a lot of softwares do: "Would you like to send usage statistics to the owner to make the software better" And then in the next release use the information to create a training set which is more comprehensive. Note that a lot of times a larger training set can make the learning agent worse. Basically depends on where you wan the hyper plane to be drawn, etc. So, the training set *needs* to be well curated.TASK DETAILhttps://phabricator.wikimedia.org/T138119EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T66838: Port catimages.py to core
AbdealiJK closed blocking task T131141: Add catimages dependencies to Travis CI Ubuntu precise whitelist as "Resolved".TASK DETAILhttps://phabricator.wikimedia.org/T66838EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: Vlkyrie, Sumit, DrTrigon, AbdealiJK, StudiesWorld, Shrutika719, Avicennasis, Aklapper, Xqt, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs-list, Pahadiahimanshu, Manrajsinghgrover, Lethexie, droid, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T137612: PageGenerator generating same page multiple times
AbdealiJK added a comment.Also, I am doing a not page.isRedirectPage() so redirects should not be affecting it. I believe this is because the file exists in more than 1 sub category of the original category given in -catr. The files related to Thalie Envolée have: Ogg sound files -> Ogg files by language -> Ogg sound files of spoken French -> Thalie Envolée -> File:Thalie Envolée - Charles Baudelaire - La beauté.oga Ogg sound files -> Ogg files by language -> Ogg sound files of spoken French -> Thalie Envolée -> Thalie Envolée - Opus 1 -> File:Thalie Envolée - Charles Baudelaire - La beauté.oga Ogg sound files -> Ogg sound files of audiobooks -> Thalie Envolée -> File:Thalie Envolée - Charles Baudelaire - La beauté.oga Ogg sound files -> Ogg sound files of audiobooks -> Thalie Envolée -> Thalie Envolée - Opus 1 -> File:Thalie Envolée - Charles Baudelaire - La beauté.oga TASK DETAILhttps://phabricator.wikimedia.org/T137612EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T137612: PageGenerator generating same page multiple times
AbdealiJK added a project: Pywikibot-core.Herald added a subscriber: pywikibot-bugs-list.TASK DETAILhttps://phabricator.wikimedia.org/T137612EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AbdealiJKCc: pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon You don't need to test the ffmpeg nor pywikibot. Travis does those to ensure that the tools are being handled correctly.. They are alternatives (i.e. **if** You don't have libav installed but ffmpeg is installed, ffmpeg is used). I think I'll try adding more features, etc before we do another testing run :D That was really tiring ! TASK DETAIL https://phabricator.wikimedia.org/T136985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. > Result / Conclusions: > > - 1 failed: something wrong with the color average for green.png, see below (https://phabricator.wikimedia.org/T136985#2360554) > - libmagickwand-dev missing: the command to install was correctly stated in the error message -> cool, thanks! made me happy! Yep, I have made an issue https://github.com/dahlia/wand/issues/293 to fail at setup.py itself. > - python-bs4 missing: no command was mentioned (made me unhappy ;) This is interesting, nothing needs bs4 as far as I know. Will test. > - colormath missing: needs to be done by pip during install (has to be added to `requirements.txt`, right?) This is weird. file-metadata has `pycolorname` in the requirements.txt and `pycolorname` has `colormath` in it's requirements. So, this should have been installed. Will check. TASK DETAIL https://phabricator.wikimedia.org/T136985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. Wow, I'm happy that nearly all the tests passed ! I recall having this exact same issue yesterday morning and I remember fixing it too. I think the dev999... version had that issue, and can be ignored for now. By the way, the skipped tests are probably because of these reasons: - bulk_tests.py will be skipped because you dont have pywikibot installed, not do you have a user-config set. This is by default, because otherwise you would be downloading 100,000 images ^^ - Your system probably won't have both LibAv and FFMPEG, because of that, one of those tests will get skipped. - Your system will not have python-magic from Ubuntu. Hence, that test will be skipped too (It will use the python-magic from pypi) You can get more info about skipped tests by adding the `-r s` arg to pytest. TASK DETAIL https://phabricator.wikimedia.org/T136985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T137011: pywikibot: Find alternative files in different formats
AbdealiJK created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION Some images on commons.wikimedia have converted the file format to other formats. For example the SVG file https://commons.wikimedia.org/wiki/File:Codabar-example.svg has png formats available (https://upload.wikimedia.org/wikipedia/commons/thumb/3/3e/Codabar-example.svg/705px-Codabar-example.svg.png) I can get the url of the SVG file using `page.fileUrl()`, but there doesnt seem to be a method to get the URL of the png files. TASK DETAIL https://phabricator.wikimedia.org/T137011 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, jayvdb, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T137009: pywikibot title - Add options when asLink=True
AbdealiJK created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION Currently, I can use `page.title()` with the kwarg `asLink=True` to create a link. Example: >>> page=pywikibot.FilePage(site, 'File:Codabar-example.svg') >>> page.title(asLink=True) u'[[File:Codabar-example.svg]]' In commons, I want to make a link to a page, but specify some additional options, like the size of the image: https://www.mediawiki.org/wiki/Help:Images#Size_and_frame I can't seem to find any way of getting the link to use for that. TASK DETAIL https://phabricator.wikimedia.org/T137009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136985: file-metadata testing log
AbdealiJK added a comment. @DrTrigon Yeah, it's all in bulk_test - I tried making a "real" bot script yesterday, but after the meeting yesterday, we decided that the functionality was not needed right now, so abandoned it. I thought I'd implement it when it's needed, as dead code which isn't being used right now, just complicates things (And requires refactoring when things change in file-metadata). TASK DETAIL https://phabricator.wikimedia.org/T136985 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, AbdealiJK, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T136074: pytest_attrib in dev-requirements.txt doesnt install, breaking Travis and Appveyor CI
AbdealiJK added a comment. This should now be fixed upstream. Here is the pywikibot-core travis build where it works https://travis-ci.org/AbdealiJK/pywikibot-core/builds/132529623 I've tested it on pytest-attrib's appveyor - https://ci.appveyor.com/project/AbdealiJK/pytest-attrib/build/1.0.22 TASK DETAIL https://phabricator.wikimedia.org/T136074 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Mdupont, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T136066: pywikibot-core support for conda
AbdealiJK created this task. Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper. TASK DESCRIPTION `conda` is becoming a popular package management system and it would be really good to support it. The nice thing about conda is that is supports not just python (although it was created for python initially. Conda makes it much easier to setup a complete pywikibot infrastructure because it sets up the virtualenv, packages, and so on completely. (One tool to set up everything) Some examples: - If my script depends on vlfeat, and the user is using pip, I'd have to ask the user to install it manually, but in conda I just use the package https://anaconda.org/menpo/vlfeat - If my script depends on a C package which has python bindings using boost.python, I'd have to ask the user to install boost.python (And installing it in a virtualenv needs either --with-system-packages or needs to be compiled from source). In such cases, pip is frustrating, but conda just has https://anaconda.org/meznom/boost-python - Similar stories for gobject-introspection based modules like pyexiv2, gtk, rsvg and even modules like OpenCV, etc which use cmake/autoconf for their compiling needs because they're not only python centric. Note: This came up because I've been struggling to setup a travis environment with the packages `dlib` (Which needs Boost) and `opencv` for https://phabricator.wikimedia.org/tag/pywikibot-catimages/ It seems conda already integrates with pypi and fetches packages from there, pywikibot is already there (https://anaconda.org/pypi/pywikibot) so to "support" conda I think we'd just need to give options to install other (non pip) dependencies like graphviz, etc too and add a travis build to ensure it works ? TASK DETAIL https://phabricator.wikimedia.org/T136066 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T131141: Add catimages dependencies to Travis CI Ubuntu precise whitelist
AbdealiJK added a comment. I've created a travis.yml file that has a bunch of dependencies that are in catimages or that we may need in catimages. I've not added some packages like `bob` and `jseg` because I hope to replace them with other packages. I found vlfeat was the major package that we would need which is not there. I found libfaac-dev and other codec packages were not there either, so i made apt-package-whitelist issues for them. - libgpac-dev - https://github.com/travis-ci/apt-package-whitelist/issues/3036 - libfaac-dev - https://github.com/travis-ci/apt-package-whitelist/issues/3035 - libvlfeat-dev - https://github.com/travis-ci/apt-package-whitelist/issues/3034 Also, `dlib` (Which I want to use instead of bob) doesn't seem to import correctly in travis (Although it gets installed correctly). I've raised an appropriate issue - https://github.com/davisking/dlib/issues/120 And `exiftool` binary seems to be missing (although it gets installed) - https://github.com/travis-ci/travis-ci/issues/6093 TASK DETAIL https://phabricator.wikimedia.org/T131141 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T131141: Add catimages dependencies to Travis CI Ubuntu precise whitelist
AbdealiJK added a comment. I had not added to any report as I was just playing around while making a list of dependencies (and I didn't document it.) I'll begin documenting and close this issue. TASK DETAIL https://phabricator.wikimedia.org/T131141 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T134232: ToolLabs git clone is really slow
AbdealiJK closed this task as "Resolved". AbdealiJK claimed this task. AbdealiJK added a comment. I've added the suggestion mentioned by @bd808 on the wiki - https://wikitech.wikimedia.org/w/index.php?title=Help%3ATool_Labs=revision=551995=493235 I'm closing this as it's the expected working and not a bug per se. TASK DETAIL https://phabricator.wikimedia.org/T134232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: bd808, zhuyifei1999, Luke081515, jayvdb, pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, Mdupont, yuvipanda, Gryllida, scfc, coren, valhallasw, chasemp ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T134232: ToolLabs git clone is really slow
AbdealiJK added a comment. @bd808 That is awesome ! It would be useful to add this to the Gotchas section - https://wikitech.wikimedia.org/wiki/Help:Tool_Labs#Gotchas TASK DETAIL https://phabricator.wikimedia.org/T134232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: bd808, zhuyifei1999, Luke081515, jayvdb, pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, Mdupont, yuvipanda, Gryllida, scfc, coren, valhallasw, chasemp ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T131141: Add catimages dependencies to Travis CI Ubuntu precise whitelist
AbdealiJK added a comment. I went through the dependencies once 2 weeks ago. I found that nearly everything I wanted was already there in travis I also created a few issues at apt-package-whitelist <https://github.com/travis-ci/apt-package-whitelist/issues?q=is%3Aissue+author%3AAbdealiJK+is%3Aclosed> about some packages to add and that got added. There are some python packages that are not there in the whitelist, but this was mainly because there exists no ubuntu package for those. My experience with the travis list is that either it gets added within 2-3 days or it doesn't get added even for a year. TASK DETAIL https://phabricator.wikimedia.org/T131141 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T135230: Pywikibot-catimages: Meeting 4 - Fri 20 May 2016 - 11:30 UTC
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T135230 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: pywikibot-bugs-list, jayvdb, Aklapper, AbdealiJK, DrTrigon, Zppix, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods
AbdealiJK moved this task from Backlog to Upstream on the Pywikibot-tests board. TASK DETAIL https://phabricator.wikimedia.org/T135594 WORKBOARD https://phabricator.wikimedia.org/project/board/107/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135701: Travis apt addon not working for matrix: include:
AbdealiJK added a comment. Possibly a comment for a new Phab task: I think there is an underlying issue about the fact that when pytest skips tests, travis doesn't fail. There was an issue on pytest about this a while back which I had given up on which I have reinitiated conversation about: https://github.com/pytest-dev/pytest/issues/1364 Based on that discussion: if we're using pytest, one possible method would be to override the unittest.skipIf decorators in the `tests/__init__.py` where we already do try/catch for unittest2 to add a pytest fixture which is later handled in conftest. This was we can specify which tests (or how many tests) should skip in each CI job using an env variable or in the tox.ini TASK DETAIL https://phabricator.wikimedia.org/T135701 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, gerritbot, Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Lewizho99, Maathavan, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135659: py.test doesnt support selecting tests using test object attributes
AbdealiJK added a comment. I ran the tests using pytest-attrib as mentioned in the gerrit comments, and found the number of tests being run on the nosetests and pytest were different, where the pytest builds always found more tests than the nose one. PyTest build - https://travis-ci.org/AbdealiJK/pywikibot-core/builds/131373171 Nose build - https://travis-ci.org/AbdealiJK/pywikibot-core/builds/131404927 To be able to compare which tests were being not collected, I used the `nose-ignore-docstring` plugin to give the name of the function rather than the docstring. I wrote the script http://pastebin.com/FnMQThYK which uses regex to find all the tests that were collected and run in the pytest and nose travis logs. When doing this, I found a lot of tests which inherit from `DefaultSiteTestCase` but were not being run by the SITE_ONLY=1 jobs in nose. This seems like a bug in nose, as the `language` and `code` attributes are set correctly, and only some of the subclasses of `DefaultSiteTestCase` are not collected, a lot of them are collected correctly. Examples of subclasses of `DefaultSiteTestCase` which are collected by pytest but not by nose: - pagegenerators_tests:TestDayPageGenerator - pagegenerators_tests:LiveRCPageGeneratorTestCase - pagegenerators_tests:PageGeneratorIntersectTestCase - pagegenerators_tests:TestDequePreloadingGenerator - pagegenerators_tests:TestFactoryGenerator - pagegenerators_tests:TestLogeventsFactoryGenerator - patrolbot_tests:TestPatrolBot Other than this, there were also some tests that were collected by nosetest, but not by pytest: - site_tests:TestPagePreloading - script_tests:TestScriptSimulate (This is only skipped in Job 18, but is found correctly in other jobs) - site_tests:TestSiteGenerators.test_allpages_langlinks_enabled I've created appropriate issues at https://github.com/AbdealiJK/pytest-attrib/issues/2 and https://github.com/AbdealiJK/pytest-attrib/issues/1 TASK DETAIL https://phabricator.wikimedia.org/T135659 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: gerritbot, AbdealiJK, Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Lewizho99, Maathavan, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods
AbdealiJK moved this task from Reported Upstream to Patch merged upstream on the Upstream board. TASK DETAIL https://phabricator.wikimedia.org/T135594 WORKBOARD https://phabricator.wikimedia.org/project/board/153/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods
AbdealiJK claimed this task. AbdealiJK added a comment. This has been merged upstream. They mentioned that they would be doing a release in a week or so. PR is at: https://github.com/pytest-dev/pytest/pull/1561 TASK DETAIL https://phabricator.wikimedia.org/T135594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135659: py.test doesnt support selecting tests using test object attributes
AbdealiJK added a comment. I was hoping someone could review that and then I'd make the pip package for pytest-attrib. I guess I'll make a beta pypi package and use that in the pywikibot travis and make another release as needed if there are issues. TASK DETAIL https://phabricator.wikimedia.org/T135659 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135659: py.test doesnt support selecting tests using test object attributes
AbdealiJK added a comment. I've made https://github.com/AbdealiJK/pytest-attrib which should be good for at least out use case. You can review it there and make issues at https://github.com/AbdealiJK/pytest-attrib/issues TASK DETAIL https://phabricator.wikimedia.org/T135659 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135659: py.test doesnt support selecting tests using test object attributes
AbdealiJK added a comment. pytest does have an equivalent `pytest.mark`, but it seems to be a little limited. It can only be used by doing: - It can be used with the decorator `pytest.mark.NAME` - It can be used by declaring the `pytestmark` attribute like `pytestmark = [pytest.mark.NAME1, pytest.mark.NAME2]` Hence, it can't detect custom defined attributes, and uses the special "pytestmark" keyword to do this. It'd be neat to make a plugin. TASK DETAIL https://phabricator.wikimedia.org/T135659 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, Aklapper, Zppix, jayvdb, pywikibot-bugs-list, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135594: pytest doesnt respect __test__ = False on script_tests metaclass
AbdealiJK added a comment. Yeah, You're right. It should not even be collected. I also made this simpler testcase to test this out: import unittest def test_abc(): pass def test_abc_not_run(): pass test_abc_not_run.__test__ = False class ClassTest(unittest.TestCase): def test_class_abc(self): pass class NotRunClassTest(unittest.TestCase): __test__ = False def test_class_abc_not_run(self): pass class ClassMeta(type): def __new__(cls, name, bases, dct): for name in ['abc', 'abc_not_run']: test_name = 'test_metaclass_' + name dct[test_name] = lambda self: None dct[test_name].__name__ = test_name dct['test_metaclass_abc_not_run'].__test__ = False return super(ClassMeta, cls).__new__(cls, name, bases, dct) class ClassMetaTest(unittest.TestCase): __metaclass__ = ClassMeta And I used the conftest: def pytest_runtest_setup(item): print print '__test__ for', item, "is", getattr(item._obj, '__test__', None) Results got: $ py.test --capture=no -vvv platform linux2 -- Python 2.7.6, pytest-2.9.1, py-1.4.31, pluggy-0.3.1 -- /home/ajk/Documents/wiki/venv/bin/python #REMOVED CONTENT# collected 4 items test_abc.py::ClassMetaTest::test_metaclass_abc __test__ for is None PASSED test_abc.py::ClassMetaTest::test_metaclass_abc_not_run __test__ for is False PASSED test_abc.py::test_abc __test__ for is None PASSED test_abc.py::ClassTest::test_class_abc __test__ for is None PASSED = 4 passed in 2.37 seconds = TASK DETAIL https://phabricator.wikimedia.org/T135594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135594: pytest doesnt respect __test__ = False on script_tests metaclass
AbdealiJK added a comment. I don't think the problem is the `__test__`. According to the code in script_tests `unrunnable_script_list` has two files that set `__test__` - version and script_wui. Without `dct[test_name] = unittest.expectedFailure(dct[test_name])`, script_wui sis kipped because of xfail: $ python -m pytest -vvv -k "TestScriptHelp and test_script_wui or TestScriptHelp and test_version" # REMOVED CONTENT # collected 2146 items tests/script_tests.py::TestScriptHelp::test_script_wui <- ../../../../../usr/lib/python2.7/unittest/case.py xfail tests/script_tests.py::TestScriptHelp::test_version FAILED TASK DETAIL https://phabricator.wikimedia.org/T135594 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, jayvdb, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T102860: Flickrripper: support flickrapi 2.x
AbdealiJK added a comment. Would it be a good idea to ask UploadWizard to allow some users permission to upload in bulk, similar to how users need to get permission to run a bot ? Possibly they could use the same bot account to allot permission ? TASK DETAIL https://phabricator.wikimedia.org/T102860 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Josve05a, Zppix, AbdealiJK, Avicennasis, Platonides, jayvdb, XXN, Aklapper, ToAruShiroiNeko, valhallasw, pywikibot-bugs-list, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T134336: flake8-py3 fails for unknown reason
AbdealiJK closed blocking task T134341: Create tests for diff.html_comparator as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T134336 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: gerritbot, Mpaa, AbdealiJK, hashar, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, Lewizho99, Mdupont, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T134341: Create tests for diff.html_comparator
AbdealiJK closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T134341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: gerritbot, Aklapper, Zppix, pywikibot-bugs-list, jayvdb, Lewizho99, Mdupont, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T115428: imageharvest and panoramiopicker uses BeautifulSoup version 3 instead of bs4
AbdealiJK added a comment.
@darthbhyrava I notice that you have created a new gerrit Change
<https://gerrit.wikimedia.org/r/#/c/288871/> with a different Change-Id. This
is not normally recommended, and it's better to create a new PatchSet in the
previous gerrit change. Read more ...
<https://www.mediawiki.org/wiki/Gerrit/Tutorial#Prepare_to_work_with_Gerrit>
**Regarding `StringIO`** - `StringIO` or `io.BytesIO` needs to be used in py2
and `io.StringIO` should be used in py3. Check `tests/ui_tests.py:89`
<https://phabricator.wikimedia.org/diffusion/PWBC/browse/refs%252Fchanges%252F91%252F286791%252F5/tests/ui_tests.py;3c8c5eae24a147a5149be75c305bf7b9649a2830$89>:
$ git grep StringIO
pywikibot/compat/query.py:res_dummy = io.StringIO()
pywikibot/data/wikistats.py:from io import BytesIO, StringIO
pywikibot/data/wikistats.py:f = StringIO(data.decode('utf8'))
scripts/panoramiopicker.py:import StringIO
scripts/panoramiopicker.py:Download the photo and store it in a
StrinIO.StringIO object.
scripts/panoramiopicker.py:return StringIO.StringIO(imageFile)
scripts/script_wui.py:from io import StringIO
scripts/script_wui.py:buffer = StringIO()
tests/ui_tests.py:"""Handler for a StringIO or BytesIO instance able to
patch itself."""
tests/ui_tests.py:Create a new stream with a StringIO or BytesIO
instance.
tests/ui_tests.py:self._stream = io.StringIO() if not PY2 else
io.BytesIO()
tests/ui_tests.py:self.stream = io.StringIO()
**script_deps** - I do not think this is needed anymore, rather you need to
use the `@requires_module('bs4')` decorator in your tests. But I'll let @jayvdb
or others confirm this as i am not sure.
TASK DETAIL
https://phabricator.wikimedia.org/T115428
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: darthbhyrava, AbdealiJK
Cc: TerraCodes, gerritbot, AbdealiJK, darthbhyrava, StudiesWorld, XZise,
Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Lewizho99, Mdupont,
Maathavan
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T135302: wikidataquery_tests.TestApiSlowFunctions.testQueryApiGetter fails for python 3.4
AbdealiJK added a comment. As mentioned in https://github.com/kennethreitz/requests/issues/2510 this is an error of a ReadTimeout rather than the TypeError. Hence, this is probably non-deterministic because of a slow internet connection or a network timeout ? TASK DETAIL https://phabricator.wikimedia.org/T135302 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, jayvdb, Aklapper, Zppix, pywikibot-bugs-list, Xqt, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Merged] T134720: Pywikibot: -random gives TypeError
AbdealiJK merged a task: T134838: pywikibot: -random Not generating a default of 10 pages. TASK DETAIL https://phabricator.wikimedia.org/T134720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, gerritbot, Mpaa, Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Lewizho99, Mdupont, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T134838: pywikibot: -random Not generating a default of 10 pages
AbdealiJK added a comment. This seems to happen because the kwarg uses: gen = RandomPageGenerator(total=intNone(value), site=self.site, namespaces=namespaces) and the default value of 10 is given in the function like: def RandomPageGenerator(total=10, site=None, namespaces=None): Hence, the value of `total` is set to None if it is not given. It should actually be set to 10. TASK DETAIL https://phabricator.wikimedia.org/T134838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T134720: Pywikibot: -random gives TypeError
AbdealiJK claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T134720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T134720: Pywikibot: -random gives TypeError
AbdealiJK created this task.
Herald added subscribers: pywikibot-bugs-list, Zppix, Aklapper.
TASK DESCRIPTION
I made a very simple script which simply prints the URL of a file. It throws
a typeerror when the PageGenerator is being created.
#!/usr/bin/python
# -*- coding: utf-8 -*-
from __future__ import absolute_import, unicode_literals
import os
import pywikibot
from pywikibot import pagegenerators
def download(page):
url = os.path.split(page.fileUrl())
print(url)
def main(*args):
generator = None
local_args = pywikibot.handle_args(args)
site = pywikibot.Site('commons', 'commons')
genFactory = pagegenerators.GeneratorFactory(site)
for arg in local_args:
genFactory.handleArg(arg)
generator = genFactory.getCombinedGenerator(gen=generator)
if not generator:
pywikibot.bot.suggest_help(missing_generator=True)
else:
pregenerator = pagegenerators.PreloadingGenerator(generator)
site.login()
for page in pregenerator:
if page.exists() and not page.isRedirectPage():
download(page)
pywikibot.output("")
if __name__ == "__main__":
main()
This gives a TypeError when I try to use the RandomPageGenerator
$ python ../pywikibot-core/pwb.py download.py -namespaces:File -random:3
Traceback (most recent call last):
File "../pywikibot-core/pwb.py", line 256, in
if not main():
File "../pywikibot-core/pwb.py", line 250, in main
run_python_file(filename, [filename] + args, argvu, file_package)
File "../pywikibot-core/pwb.py", line 121, in run_python_file
main_mod.__dict__)
File "download.py", line 37, in
main()
File "download.py", line 23, in main
genFactory.handleArg(arg)
File
"/home/ajk/Documents/wiki/pywikibot-core/pywikibot/pagegenerators.py", line
688, in handleArg
namespace=namespaces)
File
"/home/ajk/Documents/wiki/pywikibot-core/pywikibot/tools/__init__.py", line
1414, in wrapper
return obj(*__args, **__kw)
TypeError: RandomPageGenerator() got an unexpected keyword argument
'namespace'
CRITICAL: Closing network session.
TASK DETAIL
https://phabricator.wikimedia.org/T134720
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: AbdealiJK
Cc: Aklapper, Zppix, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T66838: Port catimages.py to core
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T66838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Vlkyrie, Sumit, DrTrigon, AbdealiJK, StudiesWorld, Shrutika719, Avicennasis, Aklapper, Xqt, jayvdb, valhallasw, Ricordisamoa, pywikibot-bugs-list, Pahadiahimanshu, Manrajsinghgrover, Lethexie, droid, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T134656: Pywikibot-catimages: Meeting 3 - Fri 13 May 2016 - 12:30 UTC
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T134656 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, jayvdb, Aklapper, pywikibot-bugs-list, DrTrigon, Zppix, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T134121: Pywikibot-catimages: Meeting 2 - 7 May 2016 - 12:30 UTC
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T134121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DrTrigon, AbdealiJK Cc: pywikibot-bugs-list, jayvdb, AbdealiJK, DrTrigon, Aklapper, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T134121: Pywikibot-catimages: Meeting 2 - 7 May 2016 - 12:30 UTC
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T134121 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DrTrigon, AbdealiJK Cc: pywikibot-bugs-list, jayvdb, AbdealiJK, DrTrigon, Aklapper, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T134172: Python 3 fails with UnicodeDecodeError
AbdealiJK moved this task from Backlog to Upstream on the Pywikibot-tests board. TASK DETAIL https://phabricator.wikimedia.org/T134172 WORKBOARD https://phabricator.wikimedia.org/project/board/107/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, Mpaa, Urbanecm, TerraCodes, Luke081515, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T132122: Enable isort for pywikibot import rules
AbdealiJK added a comment. Why not simply add appropriate comments in those lines to ignore isort's results there ? Like `# noqa` etc. ? TASK DETAIL https://phabricator.wikimedia.org/T132122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, pywikibot-bugs-list, Aklapper, jayvdb, Mdupont, Jay8g, Krenair, Spage ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T78520: strange link test error: ValueError: need more than 0 values to unpack
AbdealiJK added a comment. Has this happened anytime since this last happened ? I tried going to `"pywikibot/comms/threadedhttp.py", line 255` and there was no such line ! The whole code has been revamped since, and I was wondering if there's an updated error message TASK DETAIL https://phabricator.wikimedia.org/T78520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, jayvdb, Aklapper, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T134336: flake8-py3 fails for unknown reason
AbdealiJK added a comment. Oops, just uploaded a patch set for https://phabricator.wikimedia.org/T134337 Should I change the commit message to use this task ? TASK DETAIL https://phabricator.wikimedia.org/T134336 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: AbdealiJK, hashar, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, Mdupont ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T134337: Use of invalid variable for ImportErrors
AbdealiJK changed the title from "Use on invalid variable for ImportErrors" to "Use of invalid variable for ImportErrors". AbdealiJK added a project: pywikibot-core. Herald added a subscriber: pywikibot-bugs-list. TASK DETAIL https://phabricator.wikimedia.org/T134337 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: pywikibot-bugs-list, Aklapper, AbdealiJK, Zppix, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T129971: nosetests: Not detecting pyenv libraries
AbdealiJK added a comment. Seems like there was an issue where when I ran `nosetests` it was actually using the system's python, because pyenv was linking `nosetests` to system python instead of giving an error that it was not installed in pyenv. This apparently happens if the pyenv shims are not updated (This can be rehashed manually or is done automatically when a new shell is opened). Closing, as it is not a pywikibot issue. TASK DETAIL https://phabricator.wikimedia.org/T129971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: Aklapper, pywikibot-bugs-list, AbdealiJK, Mdupont, jayvdb ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T129965: proofreadpage_tests: TestIndexPageMappingsRedlinks fails if bs4 not installed
AbdealiJK closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T129965 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: jayvdb, gerritbot, Aklapper, pywikibot-bugs-list, AbdealiJK, Lewizho99, Mdupont, Maathavan, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T123092: mandatory dependency on bz2
AbdealiJK closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T123092 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: gerritbot, AbdealiJK, valhallasw, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Lewizho99, Mdupont, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Changed Project Column] T134121: Pywikibot-catimages: Meeting 2 - 7 May 2016 - 12:30 UTC
AbdealiJK moved this task from Backlog to GSoC Meetings on the pywikibot-catimages board. TASK DETAIL https://phabricator.wikimedia.org/T134121 WORKBOARD https://phabricator.wikimedia.org/project/board/755/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AbdealiJK Cc: pywikibot-bugs-list, jayvdb, AbdealiJK, DrTrigon, Aklapper, Lethexie, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T133763: Pywikibot-catimages: Meeting 1 - 1 May 2016 - 13:00 UTC
AbdealiJK edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T133763 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DrTrigon, AbdealiJK Cc: pywikibot-bugs-list, DrTrigon, jayvdb, Aklapper, AbdealiJK, Jay8g ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
