[Pywikipedia-bugs] [Maniphest] [Created] T176147: Introduce a userscripts directory
Huji created this task.Huji added a project: Pywikibot-Other-scripts.Herald added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTIONCurrently, if you create a new script for pywikibot, you have to put it in the scripts directory which is a directory watched by git, so that makes your git status busy. Alternatively, they can put their scripts in a directory and add it to their user_script_paths array in the config file but if that directory is inside the bot directory it still is going to make the git working directory unclean. Instead, we should create a directory called userscripst and add all files in it (except for __init__.py) to .gitignore. That way, users can place their scripts in that directory and keep their git working copy clean at all times.TASK DETAILhttps://phabricator.wikimedia.org/T176147EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Aklapper, Huji, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T176147: Introduce a userscripts directory
Huji claimed this task.Huji moved this task from Backlog to New scripts/requests on the Pywikibot-Other-scripts board.Huji triaged this task as "Lowest" priority. TASK DETAILhttps://phabricator.wikimedia.org/T176147WORKBOARDhttps://phabricator.wikimedia.org/project/board/103/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: gerritbot, Aklapper, Huji, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T229288: Add allowusertalk to the userblock options in pywikibot
Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Currently the `site.userblock()` function does not have a parameter for `allowusertalk`; consequently, all blocks made using pywikibot result in blocking the user from editing their talk page as well (because the default value for this option is true). The API has supported the `allowusertalk` option for many years; it is time for pywikibot to also support it. TASK DETAIL https://phabricator.wikimedia.org/T229288 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Huji, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T229293: invalid CSRF token error shown after each block
Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION I am using a bot to block open proxies; the bot works without any problem (blocks are successfully done) but after each block I see this warning on terminal: `WARNING: API error badtoken: Invalid CSRF token` The bot's code can be seen here <https://github.com/PersianWikipedia/fawikibot/blob/d68e71edc230ac1917d54bead3b9b52f5fbd59bc/HujiBot/findproxy.py>. Note that it uses a version of Site.py which already has the patch for T229288 <https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/526278/> implemented (so please don't be surprised with the extra paramter for `userblock()` function; the warning occurs without it too). TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T229293: invalid CSRF token error shown after each block
Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown after each block
Huji added a comment. I did more examinations of this. My bot will issue several blocks each time I run it. The first block never causes the warning to show up; all subsequent blocks will. I will try to investigate more, but thought sharing it here could help others who may also be investigating this. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown after each block
Huji added a comment. That is my best guess. Here is an excerpt of the relevant portions of the output of my bot in one of its recent runs: ... Checking 5.113.58.172 Checking 38.91.100.235 Logging in to wikipedia:fa as HujiBot WARNING: API warning (login): Main-account login via "action=login" is deprecated and may stop working without warning. To continue login with "action=login", see [[Special:BotPasswords]]. To safely continue using main-account login, see "action=clientlogin". WARNING: API warning (main): Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application. WARNING: API error badtoken: Invalid CSRF token. Sleeping for 4.8 seconds, 2019-08-14 00:05:33 Checking 185.176.57.25 ... 38.91.100.235 was the fifth IP it blocked in that run. You can see that the CSRF warning is shown right around when the block is done. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T229293: invalid CSRF token error shown with each block
Huji renamed this task from "invalid CSRF token error shown after each block" to "invalid CSRF token error shown with each block". TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. Sure, I will give OAuth a try. But first, I need someone to add my bot to the "confirmed" group on Meta <https://meta.wikimedia.org/wiki/Meta:Requests_for_help_from_a_sysop_or_bureaucrat#Make_HujiBot_a_confirmed_user>. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment.
Alright, I tried OAuth and when I was creating the consumer on meta, I made
sure to check "Block and unblock users". However, when the bot gets to the
point that it tries to block an IP I get this error message:
...
Checking 109.169.72.36
Traceback (most recent call last):
File "pwb.py", line 297, in
if not main():
File "pwb.py", line 292, in main
run_python_file(filename, [filename] + args, argvu, file_package)
File "pwb.py", line 96, in run_python_file
main_mod.__dict__)
File "./scripts/userscripts/findproxy.py", line 236, in
robot.find_proxies()
File "./scripts/userscripts/findproxy.py", line 209, in find_proxies
anononly=False, allowusertalk=True)
File "/home/huji/bot/pywikibot/site.py", line 1320, in callee
self.login(True)
File "/home/huji/bot/pywikibot/site.py", line 2069, in login
raise NoUsername('No sysop is permitted with OAuth')
pywikibot.exceptions.NoUsername: No sysop is permitted with OAuth
Looking at Site.py
<https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/site.py$2067-2070>
it seems like the code actually disallows using OAuth for sysop accounts. (It
seems this is because OAuth does not tie the bot to a username? but that
doesn't make sense)
Anyway, unless I am doing something overtly wrong, OAuth is not going to be
the answer here. Let me see if I can get BotPasswords to work.
TASK DETAIL
https://phabricator.wikimedia.org/T229293
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712,
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. With BotPasswords, the CSRF error is not shown. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T142303: Two-account workflow is not available with OAuth
Huji added a comment. I am not fluent in MW API, so let me ask this: is there a way to ask the API "who am i"? Or "which groups am I a part of"? Because if so, then all Pywikibot has to do is when OAuth is used it should check to make sure it is indeed authenticated using a sysop account before trying each sysop action. TASK DETAIL https://phabricator.wikimedia.org/T142303 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, pywikibot-bugs-list, Masti, Alkamid, Anomie, MarcoAurelio, Aklapper, Tgr, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T229293: invalid CSRF token error shown with each block
Huji added a comment.
In T229293#5419215 <https://phabricator.wikimedia.org/T229293#5419215>,
@Dalba wrote:
> I wonder why you're being prompted for typing your password again, maybe
your `user-config.py`/`password_file` is not configured properly?
> I have the following lines in mine:
> user-config.py:
>
> usernames['*']['*'] = 'Dalba'
> sysopnames['*']['*'] = 'Dalba'
> password_file = 'user-password.py'
Mine is like this:
usernames['wikipedia']['fa'] = 'HujiBot'
sysopnames['wikipedia']['fa'] = 'HujiBot'
password_file = "/home/huji/bot/user-password.py"
> user-password.py:
>
> ('wpbeta', 'Dalba', BotPassword('Dalba', ''))
Mine is like this:
(HujiBot', BotPassword('HujiBot', 'REDACTED'))
In T229293#5420921 <https://phabricator.wikimedia.org/T229293#5420921>,
@Dvorapa wrote:
>> I wonder why you're being prompted for typing your password again, maybe
your `user-config.py`/`password_file` is not configured properly?
>
> You should delete pywikibot.lwp file or better download/clone Pywikibot
freshly to the new folder
I deleted the file (which essentially clears the cookies for pywikibot). But
when I re-ran the bot I still run into the same issue (of it asking me to log
in again). This is based on a fresh copy of Pywikibot as of 8b35e732403fb7
<https://phabricator.wikimedia.org/rPWBC8b35e732403fb7b3a415f2053b0a41f690d4ca7a>
TASK DETAIL
https://phabricator.wikimedia.org/T229293
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor,
DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment.
@Dalba I just ran this simplified bot on fawiki and ran into the same issue
(of it asking me to login again):
import pywikibot
from pywikibot import Site
proxies = ('198.16.74.205', '204.14.73.69', '185.217.117.2')
class FindProxyBot():
def __init__(self):
self.site = Site('fa', 'wikipedia')
self.target = 'ویکیپدیا:گزارش دیتابیس/کشف پروکسی'
self.summary = 'روزآمدسازی نتایج (وظیفه ۲۲)'
self.blocksummary = '{{پروکسی باز}}'
def find_proxies(self):
for ip in proxies:
pywikibot.output('Checking %s' % ip)
target = pywikibot.User(self.site, ip)
if target.isBlocked():
pywikibot.output('Unblocking %s' % ip)
self.site.unblockuser(target)
pywikibot.output('Blocking %s' % ip)
self.site.blockuser(
target, '1 year', self.blocksummary,
anononly=False, allowusertalk=True)
robot = FindProxyBot()
robot.find_proxies()
TASK DETAIL
https://phabricator.wikimedia.org/T229293
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor,
DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. No. Only one instance, run in solitude. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment.
Correct. Here is how I have it now:
('fa', 'wikipedia', 'HujiBot', BotPassword('HujiBot', 'REDACTED'))
I verified that `login.py` can be run with this configuration without any
issues. I have also updated the bot script so that it explicitly says when it
is trying to block an IP. When I ran my bot again. It did one block
successfully but asked for my password when attempting a second block. Here are
the logs:
...
Checking 5.210.61.111
Checking 136.244.84.19
Blocking 136.244.84.19
Logging in to wikipedia:fa as HujiBot@HujiBot
Checking 89.198.39.196
Checking 83.123.81.153
Checking 5.209.53.251
Checking 5.235.14.22
Checking 31.56.92.175
Checking 31.56.98.144
Checking 31.2.244.214
Checking 5.127.70.237
Checking 5.117.132.109
Checking 86.55.175.176
Checking 5.122.72.65
Checking 83.123.54.83
Checking 85.93.89.107
Blocking 85.93.89.107
Logging in to wikipedia:fa as HujiBot@HujiBot
ERROR: Login failed (Aborted).
Password for user HujiBot@HujiBot on wikipedia:fa (no characters will be
shown):
TASK DETAIL
https://phabricator.wikimedia.org/T229293
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor,
DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis,
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. First of all, I found out something really interesting: when I run the bot against test.wikipedia.org it works without any issues. When I run it against fa.wikipedia.org I get that Login Failed error followed by the script asking for my password. This made me remember that on fawiki we do not assign admin bots to the "sysop" group; instead, we assign them to the "botadmin" group. I added my bot to the "sysop" group as well and re-run it, and it did not show any error messages. So whatever is the issue has to do with the "botadmin" group (or more specifically, with the differences between its rights and that of the "sysop" group). Comparing the rights of the two groups, the only thing that stood out was that "sysop" has the "noratelimit" right but "botadmin" does not. But my bot is both in the "botadmin" and the "bot" group and the latter has the "noratelimit" right. To further make sure this is *not* the cause of the problem, I modified the script so that it would wait 20 seconds before each blocking and it still showed the Login Failed error. With that knowledge, I also did what you asked me, @Dalba, and here is the output: Cannot log in when using MediaWiki\Session\BotPasswordSessionProvider sessions. HujiBot@HujiBot REDACTED The value of the REDACTED is the same as my BotPasswords key, obviously. I am not sure how to interpret that error message. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T229293: invalid CSRF token error shown with each block
Huji added a project: MediaWiki-User-management. Huji added a comment. This can potentially be a MediaWiki bug (such as a hardcoded "sysop" value somewhere in the API code), so I am going to add a MW tag as well. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, Wong128hk, mys_721tx, Dinoguy1000, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. And here is a comparison of the rights of the "sysop" group to those my bot holds by being in both "bot" and "botdamin" groups: | right | sysop | bot or botadmin | | - | | | | abusefilter-log | X | | | abusefilter-log-detail| X | | | abusefilter-log-private | X | | | abusefilter-modify| X | | | abusefilter-modify-restricted | X | | | abusefilter-revert| X | | | abusefilter-view | X | | | abusefilter-view-private | X | | | apihighlimits | X | X | | autoconfirmed | X | X | | autopatrol| X | X | | autoreview| X | | | block | X | X | | blockemail| X | | | bot | | X | | browsearchive | X | | | createaccount | X | | | delete| X | X | | deletechangetags | X | | | deletedhistory| X | | | deletedtext | X | | | deletelogentry| X | | | deleterevision| X | | | editcontentmodel | X | | | editinterface | X | | | editprotected | X | X | | editsemiprotected | X | X | | editsitejson | X | | | edituserjson | X | | | extendedconfirmed | X | X | | flow-delete | X | | | flow-edit-post| X | | | flow-lock | X | | | globalblock-whitelist | X | | | import| X | | | ipblock-exempt| X | X | | managechangetags | X | | | markbotedits | X | | | massmessage | X | | | mergehistory | X | X | | move | X | | | move-categorypages| X | X | | move-rootuserpages| X | | | move-subpages | X | | | movefile | X | | | movestable| X | | | nominornewtalk| | X | | noratelimit | X | X | | nuke | X | | | oathauth-enable | X | X | | oathauth-view-log | X | | | override-antispoof| X | | | patrol| X | | | protect | X | X | | reupload | X | | | reupload-shared | X | | | review| X | | | rollback | X | | | skipcaptcha | X | X | | stablesettings| X | | | suppressredirect | X | X | | tboverride| X | | | titleblacklistlog | X | | | transcode-reset | X | | | transcode-status | X | | | undelete | X | X | | unwatchedpages| X | | | upload| X | | | urlshortener-create-url | X | | | validate | X | | | writeapi | | X | TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJ
[Pywikipedia-bugs] [Maniphest] [Claimed] T229293: invalid CSRF token error shown with each block
Huji removed a project: MediaWiki-User-management. Huji claimed this task. Huji added a comment. I think I found the problem. Removing the MW tag, because this is indeed a Pywikibot bug. And my guess was on point: hard coded "sysop" values are the cause. You can find them here <https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/site.py$5910> and here <https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/pywikibot/site.py$5968>. Essentially, Pywikibot is being presumptuous that *only* sysops can block. This is wrong, and instead of checking the user group, the rights should be checked. I will submit a patch shortly, which fixes my problem and also avoids other similar problems in the future. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Wong128hk, Dinoguy1000 ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. I just confirmed that the patch above fixes the issue both using the traditional username and password based user configuration, as well as using the BotPasswords configuration. The OAuth approach does not work, but that is not due to the issue discussed in this task, so I will open a separate task for it. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. In T229293#5430073 <https://phabricator.wikimedia.org/T229293#5430073>, @JJMC89 wrote: > In T229293#5430001 <https://phabricator.wikimedia.org/T229293#5430001>, @Huji wrote: > >> First of all, I found out something really interesting: when I run the bot against test.wikipedia.org it works without any issues. When I run it against fa.wikipedia.org I get that Login Failed error followed by the script asking for my password. >> This made me remember that on fawiki we do not assign admin bots to the "sysop" group; instead, we assign them to the "botadmin" group. I added my bot to the "sysop" group as well and re-run it, and it did not show any error messages. So whatever is the issue has to do with the "botadmin" group (or more specifically, with the differences between its rights and that of the "sysop" group). >> >>> ! In T229293#5430002 <https://phabricator.wikimedia.org/T229293#5430002>, @Huji wrote: >> >> This can potentially be a MediaWiki bug (such as a hardcoded "sysop" value somewhere in the API code), so I am going to add a MW tag as well. > > I think this is pywikibot's @must_be <https://github.com/wikimedia/pywikibot/blob/5efeb820c15b75b797129e445faf77ee246e1105/pywikibot/site.py#L1298> decorator attempting to log the bot in as a sysop, which your bot couldn't do without being in the sysop group. > T71283: dualism between user and sysop needs to be overtaken <https://phabricator.wikimedia.org/T71283> Did not mean to ignore you here. The patch I submitted will do away with checking membership in the "sysop" group. Group membership is essentially irrelevant. Rights matter, groups don't. Now that we can check a user's rights, we should have a much easier time doing away with the user/sysop dualism. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T71283: dualism between user and sysop needs to be overtaken
Huji added a comment. I am considering to take this over after T229293 <https://phabricator.wikimedia.org/T229293> is fixed. Besides site.py is there any other place where we allow dualism? TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, Huji Cc: Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T229293: invalid CSRF token error shown with each block
Huji added a comment. @Ciencia_Al_Poder I agree with you in essence. All of these checks are a side effect of the fact that we have historically allowed a user to run *one* bot script with a configuration that includes *more than one* user account (one normal account, one sysop account). This is archaic, and if it was up to me, I would immediately drop it. And I am not alone in that point of view; see T71283#1040612 <https://phabricator.wikimedia.org/T71283#1040612> But until we solve that throughout the code, I would like to at least solve this very specific case through a minimal change in the patch I posted above. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Ciencia_Al_Poder, JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T189126: Cannot delete more than one page with delete.py
Huji added a comment. @MarcoAurelio it would be nice if you could test and confirm that my patch (r531589) can fix this issue TASK DETAIL https://phabricator.wikimedia.org/T189126 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Liuxinyu970226, Dalba, Framawiki, Aklapper, MarcoAurelio, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T229293: invalid CSRF token error shown with each block
Huji closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: zhuyifei1999, Ciencia_Al_Poder, JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T189126: Cannot delete more than one page with delete.py
Huji closed this task as "Resolved". Huji claimed this task. Huji added a comment. I am assuming r531589 fixed this. Reopen if otherwise. TASK DETAIL https://phabricator.wikimedia.org/T189126 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Liuxinyu970226, Dalba, Framawiki, Aklapper, MarcoAurelio, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T229364: CSRF token issues (tracking)
Huji closed subtask T229293: invalid CSRF token error shown with each block as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T229364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Aklapper, pywikibot-bugs-list, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T122705: delete.py asks for password on *every* deletion
Huji closed this task as "Resolved". Huji claimed this task. Huji added a comment. I am assuming r531589 fixed this. Reopen if otherwise. TASK DETAIL https://phabricator.wikimedia.org/T122705 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, kolbert, Framawiki, zhuyifei1999, Zoranzoki21, Xqt, valhallasw, Mpaa, Magul, MarcoAurelio, Aklapper, StudiesWorld, Ciencia_Al_Poder, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T119335: as_group='sysop' not working properly
Huji closed this task as "Resolved". Huji claimed this task. Huji added a comment. I am assuming r531589 fixed this. Reopen if otherwise. TASK DETAIL https://phabricator.wikimedia.org/T119335 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Lokal_Profil, Masti, Aklapper, StudiesWorld, Alkamid, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T75545: Support Portuguese wiki flag 'eliminator'
Huji closed this task as "Resolved". Huji claimed this task. Huji added a comment. I am assuming r531589 fixed this. Reopen if otherwise. TASK DETAIL https://phabricator.wikimedia.org/T75545 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Xqt, zhuyifei1999, Aklapper, Sn1per, Ricordisamoa, gerritbot, jayvdb, pywikibot-bugs-list, Danilo, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T196880: List parameters in option list, not in blockquote
Huji added a comment. Awaiting upstream. TASK DETAIL https://phabricator.wikimedia.org/T196880 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Aklapper, Xqt, pywikibot-bugs-list, Dvorapa, Urstrulykkr, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T231219: [pep8] section is deprecated. Use [pycodestyle].
Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION That is the warning you get if you try `pycodestyle` with any of the scripts. The solution is to update the tox.ini file TASK DETAIL https://phabricator.wikimedia.org/T231219 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Huji, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T85328: PEP-8 compliance
Huji added a comment. @Xqt from what I can see, the only issue pycodestyle finds with our current scripts is lack of compliance with E731 <https://phabricator.wikimedia.org/E731> (do not assign a lambda expression, use a def) which happens with only the following: - pywikibot/site.py - scripts/flickrripper.py - scripts/interwiki.py How about we refactor those three (I think I can do that) and add pycodestyle to the CI jobs for pywikibot so that it is enforced prospectively? TASK DETAIL https://phabricator.wikimedia.org/T85328 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Magul, Huji, Ricordisamoa, Xqt, jayvdb, Aklapper, pywikibot-bugs-list, XZise, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85328: PEP-8 compliance
Huji added a comment. Once https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/532473/ is merged, we are all clear (given the exclusions we have specified in tox.ini of course) and we can close this task. CI already takes care of the rest. TASK DETAIL https://phabricator.wikimedia.org/T85328 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Magul, Huji, Ricordisamoa, Xqt, jayvdb, Aklapper, pywikibot-bugs-list, XZise, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T231263: Pywikibot cannot delete pages despite the user having sufficient rights
Huji claimed this task. Huji triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T231263 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: zhuyifei1999, Dalba, Xqt, Huji, Aklapper, pywikibot-bugs-list, JJMC89, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T71283: dualism between user and sysop needs to be overtaken
Huji added a subtask: T229293: invalid CSRF token error shown with each block. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, Huji Cc: Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T229293: invalid CSRF token error shown with each block
Huji added a parent task: T71283: dualism between user and sysop needs to be overtaken. TASK DETAIL https://phabricator.wikimedia.org/T229293 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: zhuyifei1999, Ciencia_Al_Poder, JJMC89, Dvorapa, Dalba, Framawiki, Aklapper, Huji, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T71283: dualism between user and sysop needs to be overtaken
Huji added a comment. In T71283#5433037 <https://phabricator.wikimedia.org/T71283#5433037>, @zhuyifei1999 wrote: > config2.py needs to emit a warning that sysopnames don't work anymore (if we decide to just break it) The patch I just submitted will mark `sysopnames` as deprecated. The next step is to go through the code an eliminate all dependencies on `sysopnames`. I can find it in the following places: - pywikibot/config2.py - pywikibot/__init__.py - pywikibot/login.py - scripts/flickrripper.py - scripts/imagetransfer.py - scripts/login.py - scripts/version.py - scripts/watchlist.py - tests/aspects.py Next, we should eliminate all places were the "sysop" status of an account is checked (because we should check the user's rights, not the group memberships). Here is a potential list of places too look at: - pywikibot/config2.py - pywikibot/flow.py - pywikibot/__init__.py - pywikibot/login.py - pywikibot/page.py - pywikibot/site.py - pywikibot/xmlreader.py - scripts/blockpageschecker.py - scripts/flickrripper.py - scripts/followlive.py - scripts/i18n/redirect/qqq.json - scripts/imagecopy.py - scripts/imagetransfer.py - scripts/login.py - scripts/nowcommons.py - scripts/protect.py - scripts/redirect.py - scripts/replicate_wiki.py - scripts/userscripts/stats.py - scripts/userscripts/weekly.py - scripts/version.py - scripts/watchlist.py - scripts/welcome.py - tests/aspects.py - tests/deletionbot_tests.py - tests/dry_api_tests.py - tests/dry_site_tests.py - tests/edit_failure_tests.py - tests/edit_tests.py - tests/flow_edit_tests.py - tests/oauth_tests.py - tests/page_tests.py - tests/protectbot_tests.py - tests/README.rst - tests/redirect_bot_tests.py - tests/replacebot_tests.py - tests/site_tests.py - tests/utils.py - tests/wikibase_tests.py At this point, all that would be left to be done is to devise a strategy for those who need to use different accounts on different wikis (or different accounts for different parts of the same script). The latter is such a rare use case, that I don't think we should prioritize working on it for now. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, Huji Cc: Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T71283: dualism between user and sysop needs to be overtaken
Huji added a comment. Correct. What I was trying to say was that we should not spend clarifying how to do that (updating documentation, etc) right away. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb, Huji Cc: Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unassigned] T71283: dualism between user and sysop needs to be overtaken
Huji removed jayvdb as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T142303: Two-account workflow is not available with OAuth
Huji added a comment. In T142303#5443329 <https://phabricator.wikimedia.org/T142303#5443329>, @Anomie wrote: > In T142303#5419491 <https://phabricator.wikimedia.org/T142303#5419491>, @Huji wrote: > >> I am not fluent in MW API, so let me ask this: is there a way to ask the API "who am i"? Or "which groups am I a part of"? > > https://www.mediawiki.org/w/api.php?action=query&meta=userinfo&uiprop=groups Fabulous! TASK DETAIL https://phabricator.wikimedia.org/T142303 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Huji, pywikibot-bugs-list, Masti, Alkamid, Anomie, MarcoAurelio, Aklapper, Tgr, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T142303: Two-account workflow is not available with OAuth
Huji added a project: User-Huji. TASK DETAIL https://phabricator.wikimedia.org/T142303 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Huji, pywikibot-bugs-list, Masti, Alkamid, Anomie, MarcoAurelio, Aklapper, Tgr, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T228961: -limit option does not work for checkimages.py any longer
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T228961 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Aklapper, Xqt, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T231263: Pywikibot cannot delete pages despite the user having sufficient rights
Huji added a comment. In T231263#5449401 <https://phabricator.wikimedia.org/T231263#5449401>, @JJMC89 wrote: > rPWBC5811a544278e: Check a user's rights rather than group memberships <https://phabricator.wikimedia.org/rPWBC5811a544278e644e2a330052f0fabc990010253f> did not resolve the issue. > Now, with or without `sysopnames` in `user-config.py` nothing happens when `Page.delete()` (or `Site.deletepage()`) is used. > > Pywikibot: [https] r-pywikibot-core.git (5811a54, g1, 2019/08/27, 08:48:32, OUTDATED) That is because the decorator `must_be()` should return a function, but we accidentally made it return True! In all fairness, this was the very first time I had dealt with a decorator in Python. The patch above will fix it (I verified on test.wikipedia.org) TASK DETAIL https://phabricator.wikimedia.org/T231263 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: zhuyifei1999, Dalba, Xqt, Huji, Aklapper, pywikibot-bugs-list, JJMC89, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T231263: Pywikibot cannot delete pages despite the user having sufficient rights
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T231263 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: zhuyifei1999, Dalba, Xqt, Huji, Aklapper, pywikibot-bugs-list, JJMC89, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T71283: dualism between user and sysop needs to be overtaken
Huji added a comment. I officially announced the deprecation in https://lists.wikimedia.org/pipermail/pywikibot/2019-September/009955.html TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Urbanecm, Dvorapa, Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T220262: Enable create_categories.py for other sites
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T220262 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, Viztor, DannyS712, Wenyi, Kieubinhtb, Mh-3110, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, JakeTheDeveloper, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, D3r1ck01, Altostratus, Avicennasis, MuhammadShuaib, Tmalhotra, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. @revi: Can you please provide an excerpt of the code you are using (or if it is the vanilla `delete.py`, how you are calling it)? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Aklapper, pywikibot-bugs-list, revi, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T233608: cannot use delete.py despite being admin on a wiki
Huji claimed this task. Huji added a comment. Got it. I can confirm that I can replicate it. My suspicion is that the `-user` parameter is causing it somehow. Investigating. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. I was wrong about the cause, but now I know the cause. Here is the line of code that causes it to happen: https://github.com/wikimedia/pywikibot/blob/master/pywikibot/page.py#L1922 The logic `if 'delete' in self.site.userinfo['rights']:` fails because `self.site.userinfo['rights']` is a list of unicode strings (e.g. `[ ..., u'delete', ...]`) and as far as python 2.x is concerned, `'delete' !== u'delete'`. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T75370: deletedrevs deprecated
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T75370 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Anomie, IoannisKydonis, AndyTechGuy, Dufferzafar, Aklapper, jayvdb, pywikibot-bugs-list, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Pchelolo, mys_721tx, mobrovac, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. I have one more thought. Let me try that (may take me a day or two). TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T71283: dualism between user and sysop needs to be overtaken
Huji added a subtask: T233577: sysopnames are still required for tests. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Urbanecm, Dvorapa, Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T233577: sysopnames are still required for tests
Huji added a parent task: T71283: dualism between user and sysop needs to be overtaken. TASK DETAIL https://phabricator.wikimedia.org/T233577 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Huji, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. @revi can you share with us the relevant portions of your user-config.py (after redacting passwords and such) please? I want to know how you are using `usernames[]` to define your main bot account, any additional bot accounts, and the passwords for them, so I can replicate your setup as closely as possible. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. I modified my config to use BotPaswords just like you, and then I forced my bot to log out (`python3 pwb.py login -logout`) and log back in. Then I ran the script; both with and without the `-user` argument, it would give me the "Can't delete" message, meaning that it forgot who it was logged in as. This issue did not occur, however, if I was using a password-based configuration as opposed to one based on BotPasswords). And it happens with or without the `-user` argument. I am investigating it more, but just to be sure, can you also give it a try with a password-based configuration and confirm that things work that way? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. @revi in addition to my request above, can you also checkout the 3rd version of that patch set and confirm that it works? @Xqt I am surprised that when using BotPasswords, session information is lost. The patch above is not a solution; we need to figure out the root cause and fix that. Any thoughts? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. Great. I will investigate more to see why BotPasswords doesn't retain the session info, but if it takes too long, we can merge the patch as is (it won't cause an extra login if session info is retained). TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T104716: The clean_sandbox.py script should call a page that is in Wikipedia namespace, not one from user namespace
Huji created this task.
Huji added a subscriber: Huji.
Huji added a project: pywikibot-core.
Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION
Currently, clean_sandbox.py script uses {{subst:User:Amirobot/sandbox}} to
clean the sandbox. I am moving that page from User:Amirobot/sandbox to
Wikipedia:ربات/sandbox because it really doesn't belong in user namespace. I
have already copied the content over; all that is left to do is to update the
code so it uses {{subs:Wikipedia:ربات/sandbox}} instead. I will submit the
patch myself in a bit.
TASK DETAIL
https://phabricator.wikimedia.org/T104716
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Aklapper, Huji, pywikibot-bugs-list, jayvdb, Malyacko, P.Copp
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T145633: Deadlock can be caused by raising SpamfilterError in site.editpage()
Huji removed a parent task: T145477: Ballot type and voting system should be separated. TASK DETAILhttps://phabricator.wikimedia.org/T145633EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, HujiCc: Xqt, gerritbot, jayvdb, valhallasw, Aklapper, pywikibot-bugs-list, zhuyifei1999, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T145633: Deadlock can be caused by raising SpamfilterError in site.editpage()
Huji added a parent task: T145477: Ballot type and voting system should be separated. TASK DETAILhttps://phabricator.wikimedia.org/T145633EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zhuyifei1999, HujiCc: Xqt, gerritbot, jayvdb, valhallasw, Aklapper, pywikibot-bugs-list, zhuyifei1999, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T137805: API action=login is deprecated
Huji added a subscriber: Anomie.Huji added a comment. @MaxBioHazard I am not sure. It was marked as "deprecated" in response to T110276 in rMW54d58ef50665 and I think @Anomie might be able to answer your question best.TASK DETAILhttps://phabricator.wikimedia.org/T137805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Anomie, MaxBioHazard, Huji, Glavkos, Vladis13, MZMcBride, DrTrigon, Udo_T, Aschroet, MarcoAurelio, Jogo.obb, valhallasw, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T154309: getCategoryLinks should not fail when an invalid category title is extracted
Huji created this task.Huji added projects: Pywikibot-category.py, Pywikibot-textlib.py.Herald added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTIONToday I noticed that when category.py tries to move this template from one category to another, it failed with a nasty InvalidTitle error message. My investigations showed it occurs because the template's Doc page currently contains this wikicode:
[[رده:فیلمهای زبان {{#invoke:string|replace|{{{زبان}}}|%[%[([^%[%]]*) [%(]?زبان[%)]?{{!}}[^%[%]]*%]%]|%1|plain=false}}]]
To make it easier to understand for our LTR-language speaking developers, that is akin to:
[[Category:movies in {{#invoke:string|replace|{{{language}}}|%[%[([^%[%]]*) [%(]?language[%)]?{{!}}[^%[%]]*%]%]|%1|plain=false}}]]
Where the output would be something like [[Category:movies in English]]. But this confuses textlib.getCategoryLinks when it tries to check for a category with that name (basically, it looks for a category whose name starts with Category:movies in {{ and { is an invalid character in page titles, hence an InvalidTitle error is resulted).
The real issue is that getCategoryLinks() does not use try .. except when trying to fetch the categories.TASK DETAILhttps://phabricator.wikimedia.org/T154309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Aklapper, pywikibot-bugs-list, Huji___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Retitled] T154309: getCategoryLinks should catch invalid category title exceptions
Huji changed the title from "getCategoryLinks should not fail when an invalid category title is extracted" to "getCategoryLinks should catch invalid category title exceptions". TASK DETAILhttps://phabricator.wikimedia.org/T154309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Aklapper, pywikibot-bugs-list, Huji___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Triaged] T154309: getCategoryLinks should catch invalid category title exceptions
Huji triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T154309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: gerritbot, Aklapper, pywikibot-bugs-list, Huji, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T154309: getCategoryLinks should catch invalid category title exceptions
Huji edited the task description. (Show Details)
EDIT DETAILS...The real issue is that `getCategoryLinks()` does not use `try .. except` when trying to fetch the categories. So anytime a `[[Category:...]]` link is created on-the-fly (using templates or modules), an invalid title (i.e. one that contains `{`) will pass through causing an exception and failing the entire code.TASK DETAILhttps://phabricator.wikimedia.org/T154309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: gerritbot, Aklapper, pywikibot-bugs-list, Huji, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85328: PEP-8 compliance
Huji added a comment. Question for the team: I check PEP8 compliance using http://pep8online.com/ and one of the rules it enforces is that the file must end with a newline (i.e. one blank line at the very end is required). I cannot find that recommendation on python.org's PEP8 documentation but it is mentioned on online forums so I guess it is/was part of PEP8. Our scripts in pywikibot do not comply with this. Should we consider complying?TASK DETAILhttps://phabricator.wikimedia.org/T85328EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, HujiCc: Huji, Ricordisamoa, Xqt, jayvdb, Aklapper, pywikibot-bugs-list, XZise, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85328: PEP-8 compliance
Huji added a comment. @Magul I also agree that we shouldn't do like one big commit that only consists of adding blank lines to the end of files. But perhaps to ensure that this change actually does happen over time, can we modify our test scripts on Jenkins to enforce this rule? This way, every time someone submits a patch for a file that does not end with a blank line, they will receive a -1 from Jenkins, and they will fix it. And once that goes into effect, the next person wouldn't get the warning. Over time, as all files are modified, they all become compliant. On that note, do we even run a full PEP8 test on all patches? From what I see, currently four test scripts are run on every patch, called pywikibot-core-tox-jessie, pywikibot-core-tox-nose-jessie, pywikibot-core-tox-nose34-jessie and pywikibot-core-tox-doc-jessie. Of these, the last three don't seem to do any PEP8 related checks. The first one does something called PEP8-naming, and I haven't looked into it but I guess it only enforces rules regarding function names and variable names and class names and such. If my assessment is correct, should we expand our tests to include the full PEP8 specifications?TASK DETAILhttps://phabricator.wikimedia.org/T85328EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, HujiCc: Magul, Huji, Ricordisamoa, Xqt, jayvdb, Aklapper, pywikibot-bugs-list, XZise, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T137805: API action=login is deprecated
Huji removed projects: Pywikibot-General, Pywikibot-core. TASK DETAILhttps://phabricator.wikimedia.org/T137805EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: Hasenlaeufer, Masti, XXN, Jnanaranjan_sahu, Anomie, MaxBioHazard, Huji, Glavkos, Vladis13, MZMcBride, DrTrigon, Udo_T, Aschroet, MarcoAurelio, Jogo.obb, valhallasw, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T85328: PEP-8 compliance
Huji added a comment. @Magul I am not familiar with Wikimedia CI so I am afraid I cannot help. What I can tell you for sure is that we do not check PEP8 compliance right now; I checked a number of our existing scripts and they failed for reasons like having lines longer than 80 characters, having import commands not at the top of the file, etc.TASK DETAILhttps://phabricator.wikimedia.org/T85328EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdb, HujiCc: Magul, Huji, Ricordisamoa, Xqt, jayvdb, Aklapper, pywikibot-bugs-list, XZise, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Dalba, Masti, Alchimista, Rxy___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T154309: getCategoryLinks should catch invalid category title exceptions
Huji closed this task as "Resolved".Huji removed a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T154309EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HujiCc: gerritbot, Aklapper, pywikibot-bugs-list, Huji___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. @xqt: I think we should merge https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/538724/ for now to get the code into a working state at least. I know the #technical-debt <https://phabricator.wikimedia.org/tag/technical-debt/> will remain, but I cannot afford a revamp of our login infrastructure for BotPasswords until at least December. TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: jhsoby, Dvorapa, Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T239436: Add a generator based on an online list of pages
Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION Many a time, I use a query (often using #quarry <https://phabricator.wikimedia.org/tag/quarry/>) to identify a list of pages that need to be processed by Pywikibot. I have to then save that list to a page on wiki and then point the bot to that page using the `-links:` parameter. This extra step of saving the list to wiki is wasteful. I suggest adding another generator, perhaps called `-url:`, which allows passing a URL that would return a CSV with column consisting of page titles. For instance, I could use `-url:https://quarry.wmflabs.org/run/123456/output/0/csv` to get the list directly from Quarry. Any webservice can also be used in the same way. @Xqt do you have thoughts on this or recommendations about what the command line argument should be called? TASK DETAIL https://phabricator.wikimedia.org/T239436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Huji, Xqt, AndreasTraut, Zkhalido, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T239436: Add a generator based on an online list of pages
Huji added a comment. Yes, essentially we want a counterpart to `-file:` which, instead of needing a file on the disk, can work with a file online given its URL. TASK DETAIL https://phabricator.wikimedia.org/T239436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Huji, Xqt, AndreasTraut, Zkhalido, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T241879: Can't remove broken redirects without "sysopnames" defined
Huji added a parent task: T71283: dualism between user and sysop needs to be overtaken. TASK DETAIL https://phabricator.wikimedia.org/T241879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Aklapper, Railfail536, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Wong128hk, mys_721tx, Xqt, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T71283: dualism between user and sysop needs to be overtaken
Huji added a subtask: T241879: Can't remove broken redirects without "sysopnames" defined. TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Stanglavine, Urbanecm, Dvorapa, Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T241879: Can't remove broken redirects without "sysopnames" defined
Huji closed this task as "Resolved". Huji claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T241879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Aklapper, Railfail536, pywikibot-bugs-list, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, Wong128hk, mys_721tx, Xqt, jayvdb, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T71283: dualism between user and sysop needs to be overtaken
Huji closed subtask T241879: Can't remove broken redirects without "sysopnames" defined as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T71283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Stanglavine, Urbanecm, Dvorapa, Huji, Dalba, zhuyifei1999, Sn1per, Aklapper, Ciencia_Al_Poder, gerritbot, XZise, jayvdb, Ricordisamoa, pywikibot-bugs-list, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T241879: Can't remove broken redirects without "sysopnames" defined
Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T241879 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Aklapper, Railfail536, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Wong128hk, mys_721tx, Xqt, jayvdb, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T225631: test_template of l10n.TestValidTemplate fails for several sites
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T225631 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T225413: A lot of tests fails after badges for sitelinks where implemented
Huji closed subtask T225631: test_template of l10n.TestValidTemplate fails for several sites as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T225413 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Lokal_Profil, Xqt, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T225781: l10n_test.TestValidTemplate always tests archivebot-archiveheader package
Huji closed this task as "Resolved". Huji removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T225781 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Huji Cc: Aklapper, Xqt, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T243794: AttributeError: 'Family' object has no attribute '_userinfo' when using Pywikibot
Huji added a comment. I think `has_right()` should first check that `logged_in()` returns `true` and only then return `right.lower() in self._userinfo['rights']` TASK DETAIL https://phabricator.wikimedia.org/T243794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Xqt, Huji, Aklapper, Zoranzoki21, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T225591: Make Travis and Appveyor pass again
Huji closed subtask T137805: API action=login is deprecated as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T225591 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: D3r1ck01, Mpaa, Framawiki, Dvorapa, Dalba, Aklapper, pywikibot-bugs-list, Xqt, Zkhalido, Viztor, Wenyi, Kotchchanipa, Adrian1985, Abo00tamr, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T137805: API action=login is deprecated
Huji closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T137805 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Dvorapa, Huji Cc: zhuyifei1999, XZise, Paucabot, Zoranzoki21, Pablo-WMDE, Prod, Framawiki, Dvorapa, protonotarios, Hasenlaeufer, Masti, XXN, Jnanaranjan_sahu, Anomie, MBH, Huji, Glavkos, Vladis13, MZMcBride, DrTrigon, Aschroet, MarcoAurelio, Jogo.obb, valhallasw, jayvdb, Aklapper, Zppix, Xqt, pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Unblock] T178061: Reduce (API) warning clutter in login.py after clean installation
Huji closed subtask T137805: API action=login is deprecated as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T178061 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Dvorapa, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T233608: cannot use delete.py despite being admin on a wiki
Huji added a comment. @revi so with the latest version, is it still happening or not? TASK DETAIL https://phabricator.wikimedia.org/T233608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Chicocvenancio, Ruthven, jhsoby, Dvorapa, Framawiki, Mpaa, Xqt, Huji, Aklapper, pywikibot-bugs-list, revi, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Closed] T100965: automatic login to private wiki raises APIError on the second failed login
Huji closed this task as "Invalid". Huji added a comment. Judging by the associated patch, this was related to the "sysopnames" feature of bot logins, which we have since deprecated and removed (see T71283 <https://phabricator.wikimedia.org/T71283>). I am going to mark it as Invalid given how much the code has moved forward since this task was created. Can always be reopened if the issue still matters. TASK DETAIL https://phabricator.wikimedia.org/T100965 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, gerritbot, XZise, Aklapper, jayvdb, pywikibot-bugs-list, JohnsonLee01, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T234147: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old"
Huji added a comment. I have been getting this occasionally too. It does not occur every time (indeed, it happens rarely) so I am guessing there is a condition race going on somewhere in the code. TASK DETAIL https://phabricator.wikimedia.org/T234147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Dvorapa, Xqt, Aklapper, Zoranzoki21, pywikibot-bugs-list, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T234147: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old"
Huji added a comment.
In further investigation: it happens only when I use pywikibot to query an
item on Wikidata that has a sitelink for `be_x_old`, such as Q4048908
<https://www.wikidata.org/wiki/Q4048908#sitelinks-wikipedia>. I am not sure why
wikidata shows those sitelinks as `be_x_old` when the link itself goes to a
page like `be-tarask.wikipedia.or/wiki/foobar` but in any case, I don't think
fixing it upstream in Wikidata would be a realistic answer here. So my proposal
is: when we run into `be_x_old` in a Wikidata query, we should gracefully
ignore that and not show the warning above.
@Xqt what do you think?
-
Here is a piece of code that gives me the error every time:
page = pywikibot.Page(pywikibot.Site('en', 'wikipedia'), 'Category:Hidden
categories')
item = pywikibot.ItemPage.fromPage(page)
TASK DETAIL
https://phabricator.wikimedia.org/T234147
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Huji
Cc: Huji, Dvorapa, Xqt, Aklapper, Zoranzoki21, pywikibot-bugs-list,
JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89,
Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T234147: UserWarning: Site wikipedia:be-tarask instantiated using different code "be-x-old"
Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T234147 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Huji, Dvorapa, Xqt, Aklapper, Zoranzoki21, pywikibot-bugs-list, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts
Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Created] T253873: pycodestyles does not work inside scripts/userscripts
Huji created this task. Huji added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. TASK DESCRIPTION If you save a PEP8-uncompliant bot script in `./scripts/userscripts` and run `pycodestyles` on it, you will not get any warnings back. But if you copy that file elsewhere and run `pycodestyle` there, you will get warnings. Reproduction steps -- Save this file both in `/tmp` and in `./scripts/userscripts`: name=sample.py #!/usr/bin/python3 # -*- coding: utf-8 -*- Note that last line in the file contains white-spaces, which is a violation of PEP8. Here is the output of `pycodestyles`, first in the `./scripts/userscripts/` directory and next in `/tmp`: ➜ userscripts git:(master) pycodestyle T.py ➜ userscripts git:(master) ➜ userscripts git:(master) cd /tmp ➜ /tmp pycodestyle T.py T.py:3:1: W293 blank line contains whitespace T.py:3:1: W391 blank line at end of file ➜ /tmp TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts
Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Edited] T253873: pycodestyles does not work inside scripts/userscripts
Huji updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts
Huji added a comment. Two questions: 1. How is it that tox.in (which is define in the root of the bot) is being observed when I run pycodestyles in a subdirectory? 2. While we can decide which parts of bywikibot code should or should not be excluded from pycodestyles, we cannot choose that for user scripts. Why don't we leave it to the user to decide? TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T253873: pycodestyles does not work inside scripts/userscripts
Huji added a comment. In other words, I can add a blank `tox.ini` file in `./scripts/userscripts` and that fixes the issue above. However, I think the default should be the other way around: those users who *don't* want this directory to be considered by pycodestyles should add a `tox.ini` in their `userscripts` directory that reads: `exclude = *` TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Dijkstra, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Updated] T253873: pycodestyles does not work inside scripts/userscripts
Huji added a comment. @Dvorapa I think you added this back in c1eb7709af0b <https://phabricator.wikimedia.org/rPWBCc1eb7709af0bef39972760b8bc9065796861a366> mainly to make it easier for pywikibot developers (like you and me) to run tests. If so, then the correct way was for you to add a `tox.ini` in your installations with an exclusion rule. I, for one, want my `userscripts` to also be checked by the linter :) TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Claimed] T253873: pycodestyles does not work inside scripts/userscripts
Huji triaged this task as "Medium" priority. Huji claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T253873 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Huji Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, Huji, JohnsonLee01, Blissjay007, Dijkstra, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
