[Pywikipedia-bugs] [Maniphest] [Changed Status] T211492: Update Arabic (ar) for fixes.py

2018-12-23 Thread Meno25 
Meno25 changed the task status from "Stalled" to "Open".Meno25 added a comment.

In T211492#4842520, @Meno25 wrote:

In T211492#4842505, @Xqt wrote:
Sure. I am going to try using  \s and see if it will work. Let's mark this as stalled for now.

I made another proposal here. Could you check it?


Sure. Just please give me some time to test it as I am busy right now with other stuff in real life.


And @Xqt  saves the day!

I ran the new code as suggested by Xqt on all the featured and  good articles and featured lists on arwiki (a total of 568+593+159=1320 pages) and all is OK.

I uploaded a new patch to Gerrit https://gerrit.wikimedia.org/r/#/c/481284/
based on the earlier patch https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/481256/
Please add the new patch (but note that I am new to Gerrit, so, please review the patch carefully before adding it).
Thank you.TASK DETAILhttps://phabricator.wikimedia.org/T211492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Meno25Cc: Dvorapa, Zoranzoki21, gerritbot, Framawiki, Xqt, OsamaK, Aklapper, alanajjar, pywikibot-bugs-list, Meno25, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, binbot, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Changed Status] T211492: Update Arabic (ar) for fixes.py

2018-12-23 Thread Meno25 
Meno25 changed the task status from "Open" to "Stalled".Meno25 added a comment.

In T211492#4810128, @Xqt wrote:
@Meno25: could you tag some samples where the current implementation fails. I think the path made by @OsamaK was intended to ensure to replace single words but not word fragments.

Could you check whether \s solves this instead of that \b?


Sure. I am going to try using  \s and see if it will work. Let's mark this as stalled for now.TASK DETAILhttps://phabricator.wikimedia.org/T211492EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Meno25Cc: Dvorapa, Zoranzoki21, gerritbot, Framawiki, Xqt, OsamaK, Aklapper, alanajjar, pywikibot-bugs-list, Meno25, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Mahveotm, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, binbot, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs