[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
jayvdb added a comment. After T119790 was resolved, flake8-docstrings 1.0 was released using pydocstyle which included D403, and all related lint problems have been fixed.TASK DETAILhttps://phabricator.wikimedia.org/T121365EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jayvdbCc: Negative24, Kat233hryn, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Mdupont, JJMC89, Jay8g, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 303371 merged by jenkins-bot: Fix docstring capitalization in return types and behavior https://gerrit.wikimedia.org/r/303371TASK DETAILhttps://phabricator.wikimedia.org/T121365EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Negative24, Kat233hryn, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Mdupont, Jay8g, Krenair___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 264475 merged by jenkins-bot: Fix docstring capitalization in return types and behavior https://gerrit.wikimedia.org/r/264475 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Negative24, Kat233hryn, Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 264475 had a related patch set uploaded (by Negative24): Fix docstring capitalization in return types and behavior https://gerrit.wikimedia.org/r/264475 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Kat233hryn, Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
jayvdb added a comment. In https://phabricator.wikimedia.org/T121365#1922602, @Nemo_bis wrote: > In https://phabricator.wikimedia.org/T121365#1877480, @jayvdb wrote: > > > Very beginner task, with two instances; each instance is to fix 10 of the > > 23 non-deprecation errors: > > https://codein.withgoogle.com/dashboard/tasks/5630923064213504/ > > > Thanks. A beginner task is often focused on one aspect of becoming a > productive GCI participant, in this case gerrit. This task also requires > learning about PEP and, if I understand correctly, build pep257 from source. I have removed the expectation to build pep257 from source, and test their changes via pep257 package. > So far there were no claims; maybe make it a non-beginner task, or reduce the > amount of code involved? The task typically requires changing one word in non-code for each of the identified errors. It is a beginner task, not requiring any understanding of the PEP or Python to fix. So, I've changed it from fixing 10 -> 5 errors in the hope of making it more appealing to beginners. TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 263174 had a related patch set uploaded (by Mehtab98): Fix case of some first words https://gerrit.wikimedia.org/r/263174 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 263174 merged by jenkins-bot: Fix case of some first words https://gerrit.wikimedia.org/r/263174 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
Nemo_bis added a subscriber: Nemo_bis. Nemo_bis added a comment. In https://phabricator.wikimedia.org/T121365#1877480, @jayvdb wrote: > Very beginner task, with two instances; each instance is to fix 10 of the 23 > non-deprecation errors: > https://codein.withgoogle.com/dashboard/tasks/5630923064213504/ Thanks. A beginner task is often focused on one aspect of becoming a productive GCI participant, in this case gerrit. This task also requires learning about PEP and, if I understand correctly, build pep257 from source. So far there were no claims; maybe make it a non-beginner task, or reduce the amount of code involved? TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nemo_bis Cc: Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 258896 had a related patch set uploaded (by John Vandenberg): Fix docstring using quod-quote https://gerrit.wikimedia.org/r/258896 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
gerritbot added a comment. Change 258896 merged by jenkins-bot: Fix docstring using quad-quote https://gerrit.wikimedia.org/r/258896 TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
[Pywikipedia-bugs] [Maniphest] [Commented On] T121365: pep257 D403 capitalisation
jayvdb added a comment. IMO the errors rejecting 'Create/Edit' and '(Un)protect' feel like an "over-reach" bug in pep257. It feels like they are not allowing the first word to be .. interesting. But to be fair, pep257 is partly intended to simplify docstrings , and thus help ESL-people to understand the documentation, so a simplistic definition of 'sentence' is not a bad thing. Most of the others can be 'fixed' by starting the docstring with "Return ...", and will not cause a line length problem. I personally find 'Return' at start of docstrings to be superfluous, but it probably helps ESL-people, and it solves the pep257 problem. TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list ___ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
