[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2017-04-19 Thread gerritbot 
gerritbot added a comment.
Change 312721 abandoned by Xqt:
pywikibot.Page.put: checking the changes before saving

Reason:
per T122715

https://gerrit.wikimedia.org/r/312721TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, gerritbotCc: AbdealiJK, Xqt, gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, DatGuy, Abbe98, Avicennasis, MuhammadShuaib, Sn1per, jayvdb, Masti, Alchimista, Rxy, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2016-09-29 Thread AbdealiJK 
AbdealiJK added a comment.
@Vyeshwant123 Sorry about that!
I'd recommend you go ahead and find another bug to solve :)TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, AbdealiJKCc: AbdealiJK, Xqt, gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Alchimista, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2016-09-27 Thread Xqt 
Xqt added a comment.
Some notes of my pov


as Ricordisamoa mentioned this would be a breaking change and unables null-edits
we would have a different behaviour for put() put_async() and save() but we should avoid this
user messages should be avoided in library parts except they are exceptions
put() and put_async() are more deprecated methods; save() should used instead
we have putting methods inside bot classes. If at all I guess this test should made inside put_current or userPut and have an additional option.
TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, XqtCc: Xqt, gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Alchimista, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2016-09-25 Thread gerritbot 
gerritbot added a comment.
Change 312721 had a related patch set uploaded (by Vyeshwanth):
pywikibot.Page.put: checking the changes before saving

https://gerrit.wikimedia.org/r/312721TASK DETAILhttps://phabricator.wikimedia.org/T122715EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vyeshwanth123, gerritbotCc: gerritbot, TerraCodes, darthbhyrava, Shreyastawre, Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba, MayS, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Alchimista, Jay8g___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2016-01-01 Thread Ricordisamoa 
Ricordisamoa added a comment.

BasePage.purge() 

 with `forcerecursivelinkupdate` should be preferred but some users may still 
be using `BasePage.put()` for the purpose. Although I'm not dismissing the 
proposed change at first glance, I don't think the framework should get in its 
users' way.


TASK DETAIL
  https://phabricator.wikimedia.org/T122715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ricordisamoa
Cc: Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2015-12-31 Thread Dalba 
Dalba added a comment.

Oh, good point!
Even in that case, `forcerecursivelinkupdate` 
 seems a better 
choice to me, but maybe it's not worth it anymore. Should I mark this task as 
declined?


TASK DETAIL
  https://phabricator.wikimedia.org/T122715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T122715: Check if the page content has changed before trying to save it (in Page.put)

2015-12-31 Thread Ricordisamoa 
Ricordisamoa added a subscriber: Ricordisamoa.
Ricordisamoa added a comment.

This is a breaking change. Some users may send intentionally null edits to 
refresh server caches.


TASK DETAIL
  https://phabricator.wikimedia.org/T122715

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ricordisamoa
Cc: Ricordisamoa, Aklapper, StudiesWorld, pywikibot-bugs-list, Dalba



___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs