[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-10 Thread gerritbot 
gerritbot added a comment.


  Change 587841 abandoned by Dvorapa:
  [bugfix] Fix WindowsError caused by internal command-line command
  
  Reason:
  In favor of https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /587708/
  
  https://gerrit.wikimedia.org/r/587841

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, 
Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, 
Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-10 Thread gerritbot 
gerritbot added a comment.


  Change 587708 **merged** by jenkins-bot:
  [pywikibot/core@master] [bugfix] Fix FileNotFoundError within editor.edit()
  
  https://gerrit.wikimedia.org/r/587708

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, 
Zkhalido, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, 
Meekrab2012, joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-09 Thread gerritbot 
gerritbot added a comment.


  Change 587841 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
  [pywikibot/core@master] [bugfix] Fix WindowsError caused by internal 
command-line command
  
  https://gerrit.wikimedia.org/r/587841

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Oblanco79, Alter-paule, Beast1978, Un1tY, Zkhalido, 
Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, 
joker88john, Viztor, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Af420, Darkminds3113, 
Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, 
WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Altostratus, Avicennasis, 
mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-09 Thread gerritbot 
gerritbot added a comment.


  Change 587708 had a related patch set uploaded (by Xqt; owner: Xqt):
  [pywikibot/core@master] [tests] Ignore FileNotFoundError for Windows within 
editor.edit()
  
  https://gerrit.wikimedia.org/r/587708

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-09 Thread Xqt 
Xqt added a comment.


  Probably it has to do with https://bugs.python.org/issue22107
  A solution might be to use
  
try:
subprocess.call(cmd)
except FileNotFoundError:
pywikibot.exception()
  
  within pywikibot.editor lines 104++ because for the -simulate test the 
edit/editor does not care. We also could have a return statement at the first 
line of Editor.edit() method to have the test passing.

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-09 Thread Dvorapa 
Dvorapa added a comment.


  Can't we disable automatic removal and let Pywikibot remove it once not 
needed?

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-09 Thread Xqt 
Xqt added a comment.


  Seems the temp file is removed after closing. But keeping them open leads to 
a "Permission error: the file is already used by another process" or sth like 
that.

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-04-07 Thread Dvorapa 
Dvorapa added a comment.


Page to edit: Traceback (most recent call last):
  File "C:\\projects\\pywikibot-g4xqx\\pwb.py", line 390, in 
if not main():
  File "C:\\projects\\pywikibot-g4xqx\\pwb.py", line 385, in main
file_package)
  File "C:\\projects\\pywikibot-g4xqx\\pwb.py", line 101, in run_python_file
main_mod.__dict__)
  File ".\\scripts\\editarticle.py", line 129, in 
main()
  File ".\\scripts\\editarticle.py", line 125, in main
app.run()
  File ".\\scripts\\editarticle.py", line 100, in run
new = text_editor.edit(old)
  File "C:\\projects\\pywikibot-g4xqx\\pywikibot\\editor.py", line 104, in 
edit
subprocess.call(self._command(tempFilename, text, jumpIndex))
  File "c:\\python27\\Lib\\subprocess.py", line 172, in call
return Popen(*popenargs, **kwargs).wait()
  File "c:\\python27\\Lib\\subprocess.py", line 394, in __init__
errread, errwrite)
  File "c:\\python27\\Lib\\subprocess.py", line 644, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
CRITICAL: Exiting due to uncaught exception 

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-03-23 Thread Dvorapa 
Dvorapa added a comment.


  Do you have a link?

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: Dvorapa, DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, 
pywikibot-bugs-list, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Altostratus, Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T128453: script_tests fails for editarticle in windows environment

2020-03-23 Thread Xqt 
Xqt added a comment.


  I had it again. I guess there is a problem with the temporary file because it 
was failing with the `self._command(tempFilename, text, jumpIndex)` call

TASK DETAIL
  https://phabricator.wikimedia.org/T128453

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: DrTrigon, Aklapper, jayvdb, StudiesWorld, Xqt, pywikibot-bugs-list, 
Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs