[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-12-07 Thread gerritbot 
gerritbot added a comment.
Change 313309 abandoned by Mpaa:
unusedfiles.py: do not tag image if already tagged

https://gerrit.wikimedia.org/r/313309TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-29 Thread Xqt 
Xqt added a comment.
It starts to get complicated

everyone can do it if it is simple ;-)TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-29 Thread Mpaa 
Mpaa added a comment.
OK, so different parameters to be added for different templates/sites?
It starts to get complicated.TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-29 Thread Xqt 
Xqt added a comment.
looks like Timestamp.strftime('%d %B %Y')TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-29 Thread MarcoAurelio 
MarcoAurelio added a comment.

In T145853#2676162, @Xqt wrote:
I think it is insufficient to check for the template only. Looking at the file page I found an additional but still undocumented parameter for the template. I guess the bot script should be changed to tag this new parameter too.


My local PWB copy is already modified to tag with that new parameter.


In T145853#2676168, @Xqt wrote:
@MarcoAurelio could you please explain the  new parameter(s) you have added.
 https://meta.wikimedia.org/w/index.php?title=Template:Orphan_file="">


It allows categorizing by date to allow better maintenance with a subst:#time.TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-28 Thread Xqt 
Xqt added a comment.
@MarcoAurelio could you please explain the  new parameter(s) you have added.
https://meta.wikimedia.org/w/index.php?title=Template:Orphan_file="">TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-28 Thread Xqt 
Xqt added a comment.
I think it is insufficient to check for the template only. Looking at the file page I found an additional but still undocumented parameter for the template. I guess the bot script should be changed to tag this new parameter too.TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-28 Thread gerritbot 
gerritbot added a comment.
Change 313309 had a related patch set uploaded (by Mpaa):
unusedfiles.py: do not tag image if already tagged

https://gerrit.wikimedia.org/r/313309TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-25 Thread Mpaa 
Mpaa added a comment.
@Anoopchandu18, the template is searched "as is" in text.

if self.template_image in image.text

Maybe better to construct a template page from 'self.template_image' and check if it is in image.templates()?TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MpaaCc: Mpaa, Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-25 Thread MarcoAurelio 
MarcoAurelio added a comment.

In T145853#2665351, @Anoopchandu18 wrote:
MarcoAurelio  : In unusedfiles.py   there is code to check this. Can you elaborate more on this?


I'm afraid I don't know how to explain further. Please see https://meta.wikimedia.org/w/index.php?title=File:Head_logo.jpg=""> for the issue (just one random file chosen, although they're more).

I've changed the template in my local repo, so it's not the same as in rPWBC, but it should still work.TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarcoAurelioCc: Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-25 Thread Anoopchandu18 
Anoopchandu18 added a comment.
MarcoAurelio  : In unusedfiles.py   there is code to check this. Can you elaborate more on this?TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anoopchandu18Cc: Anoopchandu18, MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145853: unusedfiles.py: if an image is already tagged, don't tag it again

2016-09-24 Thread MuhammadShuaib 
MuhammadShuaib added a comment.
Similarly, lonelypages.py also do.TASK DETAILhttps://phabricator.wikimedia.org/T145853EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MuhammadShuaibCc: MuhammadShuaib, TerraCodes, valhallasw, jayvdb, Xqt, Aklapper, MarcoAurelio, pywikibot-bugs-list, MayS, Mdupont, JJMC89, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs