[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2024-05-06 Thread gerritbot 
gerritbot added a comment.


  Change #322253 **merged** by jenkins-bot:
  
  [pywikibot/core@master] WikibasePage.exists: Add tests for 
PropertyPage.exists.
  
  https://gerrit.wikimedia.org/r/322253

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2024-05-06 Thread gerritbot 
gerritbot added a comment.


  Change #322253 **restored** by Xqt:
  
  [pywikibot/core@master] WikibasePage.exists: Don't call 
PropertyPage.get(get_redirect=True)
  
  https://gerrit.wikimedia.org/r/322253

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2024-05-05 Thread gerritbot 
gerritbot added a comment.


  Change #322253 **abandoned** by Xqt:
  
  [pywikibot/core@master] WikibasePage.exists: Don't call 
PropertyPage.get(get_redirect=True)
  
  Reason:
  
  prefer the other patch to continue
  
  https://gerrit.wikimedia.org/r/322253

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, PotsdamLamb, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, 
Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, 
joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Tbscho, KimKelting, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, 
Dvorapa, Altostratus, Neuronton, Avicennasis, mys_721tx, Ricordisamoa, Masti, 
Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2024-05-05 Thread gerritbot 
gerritbot added a comment.


  Change #322385 **restored** by Xqt:
  
  [pywikibot/core@master] Remove unnecessary NotImplementedErrors
  
  https://gerrit.wikimedia.org/r/322385

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, 
Viztor, Wenyi, Tbscho, KimKelting, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2024-05-05 Thread gerritbot 
gerritbot added a comment.


  Change #322385 **abandoned** by Xqt:
  
  [pywikibot/core@master] Remove unnecessary NotImplementedErrors
  
  Reason:
  
  Already done somewhere
  
  https://gerrit.wikimedia.org/r/322385

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, mevo, 
PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, 
Viztor, Wenyi, Tbscho, KimKelting, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2023-04-08 Thread RPI2026F1 
RPI2026F1 added a comment.


  Ahh my bad, I didn't notice this difference.

TASK DETAIL
  https://phabricator.wikimedia.org/T145971

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: RPI2026F1
Cc: RPI2026F1, matej_suchanek, Legoktm, Dalba, jayvdb, Magul, Pasleim, 
gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, 
PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Dvorapa, Altostratus, 
Avicennasis, mys_721tx, Ricordisamoa, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread gerritbot 
gerritbot added a comment.
Change 322253 had a related patch set uploaded (by Dalba):
WikibasePage.exists: Don't call self.get(get_redirect=True) for PropertyPage

https://gerrit.wikimedia.org/r/322253TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Magul 
Magul added a comment.
@Multichill or maybe we should accept get_redirect in PropertyPage.get and just ignore it there (see: 1)?TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-18 Thread Magul 
Magul added a comment.
@Pasleim are we talking about something like this?

>>> import pywikibot
>>> s = pywikibot.Site('en', 'wikipedia')
>>> r = s.data_repository()
>>> p = pywikibot.PropertyPage(r, 'P38')
>>> p.exists()
Traceback (most recent call last):
  File "", line 1, in 
  File "pywikibot/page.py", line 3457, in exists
self.get(get_redirect=True)
  File "pywikibot/page.py", line 4263, in get
'PropertyPage.get only implements "force".')
NotImplementedError: PropertyPage.get only implements "force".TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MagulCc: Magul, Pasleim, gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-11-17 Thread gerritbot 
gerritbot added a comment.
Change 311337 merged by jenkins-bot:
[bugfix] ItemPage.exists() should return True for redirects

https://gerrit.wikimedia.org/r/311337TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, Magul, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Wesalius, Dalba, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-09-20 Thread Xqt 
Xqt added a comment.
Yes because get() is successful.TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-09-20 Thread Multichill 
Multichill added a comment.

In T145971#2646615, @Xqt wrote:
Do you have a test sample?


Judging from your patchset, you found one. If an item exists, but redirects to a deleted item, than it should probably still give true for exists(), right?TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, MultichillCc: gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, MuhammadShuaib, jayvdb, Ricordisamoa, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage

2016-09-18 Thread gerritbot 
gerritbot added a comment.
Change 311337 had a related patch set uploaded (by Xqt):
[bugfix] ItemPage.exists() should return True for redirects

https://gerrit.wikimedia.org/r/311337TASK DETAILhttps://phabricator.wikimedia.org/T145971EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Xqt, Aklapper, TerraCodes, pywikibot-bugs-list, Multichill, MayS, Esc3300, Mdupont, JJMC89, MuhammadShuaib, jayvdb, Ricordisamoa, Alchimista___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs