[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-09-25 Thread Dalba 
Dalba added a comment.
Here is an idea (although I don't know how much it can help):
When a commit only affects a script, there is no need to run the all tests, just the related test module for that script, the other parts have already been tested in previous commits. This should work because the pywikibot directory modules do not depend on scripts.TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DalbaCc: Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-09-26 Thread gerritbot 
gerritbot added a comment.
Change 462912 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Run L10N tests only once for each patch

https://gerrit.wikimedia.org/r/462912TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-09-26 Thread Xqt 
Xqt added a comment.
I've no glue whether that configuration matrix in .travis.yml inside i18n repository ever runs.TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-10-09 Thread Dvorapa 
Dvorapa added a comment.
The whole haqndling with disabled_test_modules is a bit weird:

Line 151	disabled_test_modules = [
	'tests',  # tests of the tests package
	'l10n',
	]

OK, these will be disabled

Line 155if not i18n.messages_available():
	disabled_test_modules.append('l10n')

Isn't this already in the list?

Line 187if 'PYWIKIBOT_TEST_MODULES' in os.environ:
	disabled_test_modules = set(test_modules) - set(_enabled_test_modules)

Now we overwrite it even before we use it?TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: DvorapaCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-10-09 Thread Xqt 
Xqt added a comment.
The test could be done in i18n repository but it seems no tests are done there but the bot verify with +2 together with CR+2TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: XqtCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-11-17 Thread gerritbot 
gerritbot added a comment.
Change 462912 merged by jenkins-bot:
[pywikibot/core@master] [tests] Run L10N tests on Travis only once for each patch

https://gerrit.wikimedia.org/r/462912TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

2018-11-18 Thread gerritbot 
gerritbot added a comment.
Change 474543 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Re-enable l10n_tests

https://gerrit.wikimedia.org/r/474543TASK DETAILhttps://phabricator.wikimedia.org/T191632EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Xqt, gerritbotCc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs