[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  https://github.com/xqt/pwb/runs/4761389285?check_suite_focus=true
  
==
ERROR: test_clear_cookies (tests.site_tests.TestClearCookies)
Test cookies are cleared (T224712).
--
Traceback (most recent call last):
  File "/home/runner/work/pwb/pwb/tests/site_tests.py", line 3633, in 
test_clear_cookies
site.logout()
  File "/home/runner/work/pwb/pwb/pywikibot/site/_apisite.py", line 430, in 
logout
uirequest.submit()
  File "/home/runner/work/pwb/pwb/pywikibot/data/api.py", line 1868, in 
submit
raise pywikibot.exceptions.APIError(**result['error'])
pywikibot.exceptions.APIError: missingparam: The "token" parameter must be 
set.
[help: See https://zh.wikisource.org/w/api.php for API usage. Subscribe to 
the mediawiki-api-announce mailing list at 
https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/;
 for notice of API deprecations and breaking changes.]

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  Tests are failing now due to this 
https://travis-ci.com/github/wikimedia/pywikibot/jobs/521442547

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
___
pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org
To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  In T222508#5225702 , @Xqt 
wrote:
  
  > In T222508#5225437 , 
@Dalba wrote:
  >
  >> Wouldn't it be better to mark the test with a `user = True` attribute 
instead of `skipIf(os.environ.get('APPVEYOR', ...`?
  >
  > Is this recognized for APPVEYOR tests?
  
  Credentials added to AppVeyor, but Appveyor failing to load settings 
currently. Anyway, we can enable tests once #upstream 
 issue solved or workarounded

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, 
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  In T222508#5168363 , 
@Framawiki wrote:
  
  > The later patch also intents to skip test on AppVeyor.
  > I'm not sure how to deal with the `pywikibot.data.api.APIError: Failed: You 
have made too many recent login attempts. Please wait 5 minutes before trying 
again.` present on Travis.
  
  Solved yesterday by appending to 'Throttle' response

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, 
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  In T222508#5158894 , 
@Dvorapa wrote:
  
  > Since the very first patch it also fails on AppVeyor with the following 
error:
  >
  >   ==
  >   ERROR: test_login_logout (tests.site_tests.TestLoginLogout)
  >   Validate login and logout methods by toggling the state.
  >   --
  >   Traceback (most recent call last):
  > File "c:\projects\pywikibot-g4xqx\tests\site_tests.py", line 3717, in 
test_login_logout
  >   site.login()
  > File "c:\projects\pywikibot-g4xqx\pywikibot\site.py", line 2101, in 
login
  >   if login_manager.login(retry=True, autocreate=autocreate):
  > File "c:\projects\pywikibot-g4xqx\pywikibot\login.py", line 306, in 
login
  >   self.check_user_exists()
  > File "c:\projects\pywikibot-g4xqx\pywikibot\login.py", line 155, in 
check_user_exists
  >   % (main_username, self.site))
  >   NoUsername: Username 'None' does not exist on wikipedia:en
  >   --
  >
  >> ! In T222508#5159234 , 
@Xqt wrote:
  >
  > Seems there is no password found to login
  
  Means passed badtoken APIError

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Zkhalido, 
Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, Avicennasis, 
mys_721tx, jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  In T222508#5225437 , 
@Dalba wrote:
  
  > Wouldn't it be better to mark the test with a `user = True` attribute 
instead of `skipIf(os.environ.get('APPVEYOR', ...`?
  
  
  Is this recognized for APPVEYOR tests?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, 
DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dalba]

Dalba added a comment.


  In T222508#5179922 , 
@gerritbot wrote:
  
  > Change 508893 **merged** by jenkins-bot:
  >  [pywikibot/core@master] [bugfix] clear tokens on logout()
  >
  > https://gerrit.wikimedia.org/r/508893
  
  
  Wouldn't it be better to be marked with a `user = True` attribute instead of 
`skipIf(os.environ.get('APPVEYOR', ...`?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dalba
Cc: Dalba, Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, 
DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, 
jayvdb, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  In T222508#5215339 , @Xqt 
wrote:
  
  > In T222508#5215288 , 
@Dvorapa wrote:
  >
  > > musicbrainz issue solved
  >
  >
  > What was the problem here?
  
  
  My stupidity: I created the account on musicbrainz, not musicbrainz wiki :D

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  In T222508#5215288 , 
@Dvorapa wrote:
  
  > musicbrainz issue solved
  
  
  What was the problem here?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  musicbrainz issue solved, only the timeout is the issue now (happens only 
sometimes)

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  In T222508#5212114 , 
@Dvorapa wrote:
  
  > What else should be set to make it work? OAuth? Some preferences?
  
  
  I've no glue. Deactivation tests where login is needed then.

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  The username and general password do match. What else should be set to make 
it work? OAuth? Some preferences?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  In T222508#5212037 , 
@Framawiki wrote:
  
  > In T222508#5186431 , 
@Dvorapa wrote:
  >
  > > - en:musicbrainz - test account created, but still failing (weird)
  >
  >
  > For en:musicbrainz I see 
 
`pywikibot.data.api.APIError: Failed: Incorrect username or password entered. 
Please try again.` and it is full of
  >
  >   Logging in to musicbrainz:en as Pywikibot-test
  >   ERROR: Login failed (Failed).
  >
  
  
  Probably travis username/password settings does not match the musicbrainz 
test account?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Framawiki]

Framawiki added a comment.


  In T222508#5186431 , 
@Dvorapa wrote:
  
  > - en:musicbrainz - test account created, but still failing (weird)
  
  
  For en:musicbrainz I see 
 
`pywikibot.data.api.APIError: Failed: Incorrect username or password entered. 
Please try again.` and it is full of
  
Logging in to musicbrainz:en as Pywikibot-test
ERROR: Login failed (Failed).

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  Okay, Appveyor tests skipped, en:wsbeta test account created. Last fails:
  
  - en:musicbrainz - test account created, but still failing (weird)
  - zh:wikisource on Python 3.4: still timeouts

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, E.S.A-Sheild, 
joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 510520 **merged** by jenkins-bot:
  [pywikibot/core@master] Skip TestLoginLogout if it is running on Appveyor
  
  https://gerrit.wikimedia.org/r/510520

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, E.S.A-Sheild, 
joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 510520 had a related patch set uploaded (by Xqt; owner: Xqt):
  [pywikibot/core@master] Skip TestLoginLogout unless it is running on Travis
  
  https://gerrit.wikimedia.org/r/510520

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, E.S.A-Sheild, 
joker88john, Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508893 **merged** by jenkins-bot:
  [pywikibot/core@master] [bugfix] clear tokens on logout()
  
  https://gerrit.wikimedia.org/r/508893

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  Apart from the wsbeta and musicbrainz on Travis there sometimes occur 
infinite loops:
  
  https://travis-ci.org/wikimedia/pywikibot/jobs/530930561
  https://travis-ci.org/wikimedia/pywikibot/jobs/530930559

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508893 had a related patch set uploaded (by Framawiki; owner: 
Framawiki):
  [pywikibot/core@master] [bugfix] clear tokens on logout()
  
  https://gerrit.wikimedia.org/r/508893

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, 
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, 
Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Framawiki]

Framawiki added a comment.


  The later patch also intents to skip test on AppVeyor.
  I'm not sure how to deal with the `pywikibot.data.api.APIError: Failed: You 
have made too many recent login attempts. Please wait 5 minutes before trying 
again.` present on Travis.

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  Perhaps this should be skipped on AppVeyor as we have no chance to add 
password/env variable in AppVeyor config?

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  Seems there is no password found to login

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Dvorapa]

Dvorapa added a comment.


  Since the very first patch it also fails on AppVeyor with the following error:
  
==
ERROR: test_login_logout (tests.site_tests.TestLoginLogout)
Validate login and logout methods by toggling the state.
--
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\tests\site_tests.py", line 3717, in 
test_login_logout
site.login()
  File "c:\projects\pywikibot-g4xqx\pywikibot\site.py", line 2101, in login
if login_manager.login(retry=True, autocreate=autocreate):
  File "c:\projects\pywikibot-g4xqx\pywikibot\login.py", line 306, in login
self.check_user_exists()
  File "c:\projects\pywikibot-g4xqx\pywikibot\login.py", line 155, in 
check_user_exists
% (main_username, self.site))
NoUsername: Username 'None' does not exist on wikipedia:en
--

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Dvorapa
Cc: Dvorapa, Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, 
Viztor, DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


  There are two remaining issues for wsbeta and musicbrainz: 
https://travis-ci.org/wikimedia/pywikibot/builds/528404683

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508111 **merged** by jenkins-bot:
  [pywikibot/core@master] [TEST] fix test_login_logout, OAuth case
  
  https://gerrit.wikimedia.org/r/508111

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508111 had a related patch set uploaded (by Framawiki; owner: 
Framawiki):
  [pywikibot/core@master] [TEST] fix test_login_logout, OAuth case
  
  https://gerrit.wikimedia.org/r/508111

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508094 **merged** by jenkins-bot:
  [pywikibot/core@master] [TEST] fix test_login_logout
  
  https://gerrit.wikimedia.org/r/508094

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508094 had a related patch set uploaded (by Framawiki; owner: 
Framawiki):
  [pywikibot/core@master] [TEST] fix test_login_logout
  
  https://gerrit.wikimedia.org/r/508094

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[Xqt]

Xqt added a comment.


=== FAILURES 
===
__ TestLoginLogout.test_login_logout 
___

self = 

def test_login_logout(self):
"""Validate login and logout methods by toggling the state."""
site = self.get_site()
loginstatus = pywikibot.site.LoginStatus

self.assertFalse(site.logged_in())

site.login()
self.assertTrue(site.logged_in())
>   self.assertGreaterEqual(site._loginstatus, loginstatus.AS_USER)
E   AssertionError: -2 not greater than or equal to 0

tests/site_tests.py:3719: AssertionError

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, Xqt
Cc: Xqt, Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, 
DannyS712, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
Tbscho, MayS, WSH1906, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, 
mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508072 **merged** by jenkins-bot:
  [pywikibot/core@master] [bugfix] add CSRF token in sitelogout() api call
  
  https://gerrit.wikimedia.org/r/508072

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Aklapper, pywikibot-bugs-list, Framawiki, joker88john, Viztor, DannyS712, 
CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, 
Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, WSH1906, 
Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, 
Masti, Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

[Pywikipedia-bugs] [Maniphest] [Commented On] T222508: action=logout needs CSRF token, since API breaking change

[gerritbot]

gerritbot added a comment.


  Change 508072 had a related patch set uploaded (by Framawiki; owner: 
Framawiki):
  [pywikibot/core@master] [bugfix] add CSRF token in sitelogout() api call
  
  https://gerrit.wikimedia.org/r/508072

TASK DETAIL
  https://phabricator.wikimedia.org/T222508

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki, gerritbot
Cc: Aklapper, pywikibot-bugs-list, Framawiki, Viztor, DannyS712, Wenyi, Tbscho, 
MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, 
Alchimista, Rxy
___
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs